209815 2020-03-31 09:48:21 -0700 [macOS] Add additional IPC permission needed by Security.framework 2020-03-31 10:40:45 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan oldest_to_newest 1636061 0 bfulgham 2020-03-31 09:48:21 -0700 WebKit's Network sandbox needs the ipc-posix-shm-write-create permission to properly interact with the 'com.apple.AppleDatabaseChanged' name. 1636062 1 bfulgham 2020-03-31 09:48:34 -0700 <rdar://problem/60892378> 1636063 2 395052 bfulgham 2020-03-31 09:50:15 -0700 Created attachment 395052 Patch 1636067 3 395052 pvollan 2020-03-31 09:53:38 -0700 Comment on attachment 395052 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395052&action=review R=me. > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:359 > -(allow ipc-posix-shm-read* ipc-posix-shm-write-data > +(allow ipc-posix-shm-read* ipc-posix-shm-write-create ipc-posix-shm-write-data > (ipc-posix-name "com.apple.AppleDatabaseChanged")) Does older macOS versions still need ipc-posix-shm-write-data? 1636085 4 395052 bfulgham 2020-03-31 10:13:19 -0700 Comment on attachment 395052 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395052&action=review >> Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:359 >> (ipc-posix-name "com.apple.AppleDatabaseChanged")) > > Does older macOS versions still need ipc-posix-shm-write-data? Yes -- this is entirely about needing to add *-create, not about taking anything else away. It's possible we could have left the old rule for pre-10.15 systems, but I don't think the extra complexity in the sandbox is worth it. 1636120 5 ews-feeder 2020-03-31 10:40:44 -0700 Committed r259300: <https://trac.webkit.org/changeset/259300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395052. 395052 2020-03-31 09:50:15 -0700 2020-03-31 10:40:44 -0700 Patch bug-209815-20200331095014.patch text/plain 1673 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5Mjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDljMDQ2ZjhjYTFlMDVhYWVm YmJlMWMxZjk2NTVhYzU5NGJjY2EzYzkuLmEwOTc2MDBhMWZlMDEwOThhYTQyMWM2MWVhMmViYzc1 Mzc2ZTU2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMzEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBBZGQgYWRkaXRp b25hbCBJUEMgcGVybWlzc2lvbiBuZWVkZWQgYnkgU2VjdXJpdHkuZnJhbWV3b3JrCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk4MTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYwODkyMzc4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIHBlcm1pc3Npb24gbmVlZGVkIGZvciByZWNl bnQgbWFjT1MgcmVsZWFzZXMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFw cGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbjoKKwogMjAyMC0wMy0zMSAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogKHIyNTkyMzYp IFsgaU9TIGFuZCBDYXRhbGluYSB3azIgRGVidWcgXSBBU1NFUlRJT04gRkFJTEVEOiBtX2RlYnVn TG9nZ2luZ0VuYWJsZWQgaW4gV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OmRl YnVnQnJvYWRjYXN0Q29uc29sZU1lc3NhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4gYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQ cm9jZXNzLnNiLmluCmluZGV4IDg4ZTc4YjE5Zjk0Y2ZiZjU2ZjdiODI5YTlmMTBkMzcyMDg5OTY5 NTIuLmE1NDU4MjAxMDk5YTZiNjgzYTlmNGFjY2YzM2JlMzRhNTI5MzMzODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29y a1Byb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29t LmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgpAQCAtMzU1LDcgKzM1NSw3IEBACiAg ICAgICAgKGhvbWUtcmVnZXggKHN0cmluZy1hcHBlbmQgIi9MaWJyYXJ5L1ByZWZlcmVuY2VzL0J5 SG9zdC9jb21cLmFwcGxlXC5pc3RcLmRzXC5hcHBsZWNvbm5lY3QyXC5wcm9kdWN0aW9uXC4iICh1 dWlkLXJlZ2V4LXN0cmluZykgIlwucGxpc3QkIikpCiApCiAKLShhbGxvdyBpcGMtcG9zaXgtc2ht LXJlYWQqIGlwYy1wb3NpeC1zaG0td3JpdGUtZGF0YQorKGFsbG93IGlwYy1wb3NpeC1zaG0tcmVh ZCogaXBjLXBvc2l4LXNobS13cml0ZS1jcmVhdGUgaXBjLXBvc2l4LXNobS13cml0ZS1kYXRhCiAg ICAgICAgKGlwYy1wb3NpeC1uYW1lICJjb20uYXBwbGUuQXBwbGVEYXRhYmFzZUNoYW5nZWQiKSkK IAogKHN5c3RlbS1uZXR3b3JrKQo=