209759 2020-03-30 12:35:40 -0700 REGRESSION (r259211): ASSERT(window) in applicationType() under shouldUseForegroundPriorityForClientNavigation() 2020-03-30 16:42:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209748 https://bugs.webkit.org/show_bug.cgi?id=207341 InRadar P2 Normal --- 209748 1 thorton cdumez achristensen cdumez darin ggaren thorton webkit-bug-importer oldest_to_newest 1635653 0 thorton 2020-03-30 12:35:40 -0700 #1 0x00000001003ee42b in WTFCrashWithInfo(int, char const*, char const*, int) #2 0x0000000100c5dbed in WebKit::applicationType(UIWindow*) #3 0x0000000101129a41 in WebKit::PageClientImpl::isApplicationVisible() #4 0x00000001011abfe6 in WebKit::WebPageProxy::shouldUseForegroundPriorityForClientNavigation() const #5 0x0000000100fb52f5 in WebKit::WebPageProxy::loadRequest(WebCore::ResourceRequest&&, WebCore::ShouldOpenExternalURLsPolicy, API::Object*) #6 0x0000000100cdcc2d in -[WKWebView loadRequest:] shouldUseForegroundPriorityForClientNavigation() calls isApplicationVisible() when a view is unparented, but isApplicationVisible() depends on having a window to determine the type of application. 1635789 1 394976 cdumez 2020-03-30 15:53:51 -0700 Created attachment 394976 Patch 1635843 2 ews-feeder 2020-03-30 16:41:43 -0700 Committed r259242: <https://trac.webkit.org/changeset/259242> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394976. 1635844 3 webkit-bug-importer 2020-03-30 16:42:16 -0700 <rdar://problem/61079983> 394976 2020-03-30 15:53:51 -0700 2020-03-30 16:41:44 -0700 Patch bug-209759-20200330155350.patch text/plain 6897 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU2YWFkZDdlMWM1YjUzZDg0 OWJmMWU1NDRkNDZmN2RiODQyNzA0NWQuLjIyOThiZDAxZGNjNjZiYjRiOTk2MTJkYTdiMWE5NDA0 OTI3ODJkYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDMtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU5MjExKTog QVNTRVJUKHdpbmRvdykgaW4gYXBwbGljYXRpb25UeXBlKCkgdW5kZXIgc2hvdWxkVXNlRm9yZWdy b3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk3NTkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdG8gbm90IGNhbGwgYXBwbGljYXRp b25UeXBlKCkgd2l0aCBhIG51bGwgd2luZG93LiBUaGlzIHBhdGNoIG1haW50YWlucyBwcmV2aW91 cyBiZWhhdmlvcgorICAgICAgICBpbiByZWxlYXNlIGJ1aWxkcy4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6Omxv YWRSZXF1ZXN0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpsb2FkRmlsZSk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bG9hZERhdGEpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJ bXBsSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6aXNBcHBsaWNhdGlv blZpc2libGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnNob3VsZEZvcmNlRm9yZWdyb3VuZFByaW9y aXR5Rm9yQ2xpZW50TmF2aWdhdGlvbiBjb25zdCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6c2hvdWxkVXNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbiBjb25z dCk6IERlbGV0ZWQuCisKIDIwMjAtMDMtMzAgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6cmVnaXN0ZXJG aWxlQmxvYlVSTCBzaG91bGQgdmFsaWRhdGUgaXRzIHBhcmFtZXRlcnMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGE5OWVhODIwOTk4OWQ5NDk4OWRhODFjMmFj MzhiYmZjMWI4NDY3ZTUuLmE1MzAxZjE0ODJiZmU1Y2E5NmE3YjZkNWEwMDgzOTc0ZTY3ZTA5OGMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMTI5Myw3ICsx MjkzLDcgQEAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gV2ViUGFnZVByb3h5Ojpsb2FkUmVxdWVz dChSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0LCBTaG8KIAogICAgIGF1dG8gbmF2aWdhdGlvbiA9 IG1fbmF2aWdhdGlvblN0YXRlLT5jcmVhdGVMb2FkUmVxdWVzdE5hdmlnYXRpb24oUmVzb3VyY2VS ZXF1ZXN0KHJlcXVlc3QpLCBtX2JhY2tGb3J3YXJkTGlzdC0+Y3VycmVudEl0ZW0oKSk7CiAKLSAg ICBpZiAoc2hvdWxkVXNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpKQor ICAgIGlmIChzaG91bGRGb3JjZUZvcmVncm91bmRQcmlvcml0eUZvckNsaWVudE5hdmlnYXRpb24o KSkKICAgICAgICAgbmF2aWdhdGlvbi0+c2V0Rm9yZWdyb3VuZEFjdGl2aXR5KHByb2Nlc3MoKS50 aHJvdHRsZXIoKS5mb3JlZ3JvdW5kQWN0aXZpdHkoIkNsaWVudCBuYXZpZ2F0aW9uIl9zKS5tb3Zl VG9VbmlxdWVQdHIoKSk7CiAKICAgICBsb2FkUmVxdWVzdFdpdGhOYXZpZ2F0aW9uU2hhcmVkKG1f cHJvY2Vzcy5jb3B5UmVmKCksIG1fd2ViUGFnZUlELCBuYXZpZ2F0aW9uLmdldCgpLCBXVEZNb3Zl KHJlcXVlc3QpLCBzaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5LCB1c2VyRGF0YSwgU2hvdWxk VHJlYXRBc0NvbnRpbnVpbmdMb2FkOjpObywgaXNOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbigp LCBoYXNOYXZpZ2F0ZWRBd2F5RnJvbUFwcEJvdW5kRG9tYWluKCkpOwpAQCAtMTM3Miw3ICsxMzcy LDcgQEAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gV2ViUGFnZVByb3h5Ojpsb2FkRmlsZShjb25z dCBTdHJpbmcmIGZpbGVVUkxTdHJpbmcsIGNvbnMKIAogICAgIGF1dG8gbmF2aWdhdGlvbiA9IG1f bmF2aWdhdGlvblN0YXRlLT5jcmVhdGVMb2FkUmVxdWVzdE5hdmlnYXRpb24oUmVzb3VyY2VSZXF1 ZXN0KGZpbGVVUkwpLCBtX2JhY2tGb3J3YXJkTGlzdC0+Y3VycmVudEl0ZW0oKSk7CiAKLSAgICBp ZiAoc2hvdWxkVXNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpKQorICAg IGlmIChzaG91bGRGb3JjZUZvcmVncm91bmRQcmlvcml0eUZvckNsaWVudE5hdmlnYXRpb24oKSkK ICAgICAgICAgbmF2aWdhdGlvbi0+c2V0Rm9yZWdyb3VuZEFjdGl2aXR5KHByb2Nlc3MoKS50aHJv dHRsZXIoKS5mb3JlZ3JvdW5kQWN0aXZpdHkoIkNsaWVudCBuYXZpZ2F0aW9uIl9zKS5tb3ZlVG9V bmlxdWVQdHIoKSk7CiAKICAgICBhdXRvIHRyYW5zYWN0aW9uID0gbV9wYWdlTG9hZFN0YXRlLnRy YW5zYWN0aW9uKCk7CkBAIC0xNDE1LDcgKzE0MTUsNyBAQCBSZWZQdHI8QVBJOjpOYXZpZ2F0aW9u PiBXZWJQYWdlUHJveHk6OmxvYWREYXRhKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgZGF0YSwg YwogCiAgICAgYXV0byBuYXZpZ2F0aW9uID0gbV9uYXZpZ2F0aW9uU3RhdGUtPmNyZWF0ZUxvYWRE YXRhTmF2aWdhdGlvbihtYWtlVW5pcXVlPEFQSTo6U3Vic3RpdHV0ZURhdGE+KGRhdGEudmVjdG9y KCksIE1JTUVUeXBlLCBlbmNvZGluZywgYmFzZVVSTCwgdXNlckRhdGEpKTsKIAotICAgIGlmIChz aG91bGRVc2VGb3JlZ3JvdW5kUHJpb3JpdHlGb3JDbGllbnROYXZpZ2F0aW9uKCkpCisgICAgaWYg KHNob3VsZEZvcmNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpKQogICAg ICAgICBuYXZpZ2F0aW9uLT5zZXRGb3JlZ3JvdW5kQWN0aXZpdHkocHJvY2VzcygpLnRocm90dGxl cigpLmZvcmVncm91bmRBY3Rpdml0eSgiQ2xpZW50IG5hdmlnYXRpb24iX3MpLm1vdmVUb1VuaXF1 ZVB0cigpKTsKIAogICAgIGxvYWREYXRhV2l0aE5hdmlnYXRpb25TaGFyZWQobV9wcm9jZXNzLmNv cHlSZWYoKSwgbV93ZWJQYWdlSUQsIG5hdmlnYXRpb24sIGRhdGEsIE1JTUVUeXBlLCBlbmNvZGlu ZywgYmFzZVVSTCwgdXNlckRhdGEsIFNob3VsZFRyZWF0QXNDb250aW51aW5nTG9hZDo6Tm8sIGlz TmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4oKSwgaGFzTmF2aWdhdGVkQXdheUZyb21BcHBCb3Vu ZERvbWFpbigpLCBXVEY6Om51bGxvcHQsIHNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kpOwpA QCAtMTAwMTQsNyArMTAwMTQsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0U2hvdWxkRmlyZVJl c2l6ZUV2ZW50cyhib29sIHNob3VsZEZpcmVSZXNpemVFdmVudHMpCiB9CiAKICNpZiAhUExBVEZP Uk0oSU9TX0ZBTUlMWSkKLWJvb2wgV2ViUGFnZVByb3h5OjpzaG91bGRVc2VGb3JlZ3JvdW5kUHJp b3JpdHlGb3JDbGllbnROYXZpZ2F0aW9uKCkgY29uc3QKK2Jvb2wgV2ViUGFnZVByb3h5OjpzaG91 bGRGb3JjZUZvcmVncm91bmRQcmlvcml0eUZvckNsaWVudE5hdmlnYXRpb24oKSBjb25zdAogewog ICAgIHJldHVybiBmYWxzZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgK aW5kZXggZTYxYjdmNDJkOTBhMTZjMmQ4NTVkZTIxY2U5YzJkNTRmZDkyYjJhMy4uZDQ0MDQyZjll OGU3MzRjOTNlZjUyYzBlMmM2NGY4ZmZjY2E3Zjg3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKQEAgLTE3MzIsNyArMTczMiw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBu b3RpZnlQcm9jZXNzUG9vbFRvUHJld2FybSgpOwogICAgIGJvb2wgc2hvdWxkVXNlQmFja0Zvcndh cmRDYWNoZSgpIGNvbnN0OwogCi0gICAgYm9vbCBzaG91bGRVc2VGb3JlZ3JvdW5kUHJpb3JpdHlG b3JDbGllbnROYXZpZ2F0aW9uKCkgY29uc3Q7CisgICAgYm9vbCBzaG91bGRGb3JjZUZvcmVncm91 bmRQcmlvcml0eUZvckNsaWVudE5hdmlnYXRpb24oKSBjb25zdDsKIAogICAgIFJlZlB0cjxBUEk6 Ok5hdmlnYXRpb24+IGdvVG9CYWNrRm9yd2FyZEl0ZW0oV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYs IFdlYkNvcmU6OkZyYW1lTG9hZFR5cGUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0KaW5kZXggZjMyMGY4MDgyMDUyMmUyZjhlYmE2MDgz MzUyMTAwMThlNGIzYTU4MS4uYWU3MDZlOTYxZTc2Mjg5NzUxYmQ4ZGJlNGU3YzgzMGUzMjY3NjM0 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBs SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElP Uy5tbQpAQCAtMTUxLDE0ICsxNTEsMTEgQEAgYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3Vmlz aWJsZSgpCiAKIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzQXBwbGljYXRpb25WaXNpYmxlKCkKIHsK LSAgICBzd2l0Y2ggKGFwcGxpY2F0aW9uVHlwZShbbV93ZWJWaWV3IHdpbmRvd10pKSB7Ci0gICAg Y2FzZSBBcHBsaWNhdGlvblR5cGU6OkFwcGxpY2F0aW9uOgorICAgIGF1dG8qIHdpbmRvdyA9IFtt X3dlYlZpZXcgd2luZG93XTsKKyAgICBpZiAoIXdpbmRvdyB8fCBhcHBsaWNhdGlvblR5cGUod2lu ZG93KSA9PSBBcHBsaWNhdGlvblR5cGU6OkFwcGxpY2F0aW9uKQogICAgICAgICByZXR1cm4gW1tV SUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxpY2F0aW9uXSBhcHBsaWNhdGlvblN0YXRlXSAhPSBVSUFw cGxpY2F0aW9uU3RhdGVCYWNrZ3JvdW5kOwotICAgIGNhc2UgQXBwbGljYXRpb25UeXBlOjpWaWV3 U2VydmljZToKLSAgICBjYXNlIEFwcGxpY2F0aW9uVHlwZTo6RXh0ZW5zaW9uOgotICAgICAgICBi cmVhazsKLSAgICB9CiAKKyAgICAvLyBDb21wbGV4IGNvZGUgcGF0aCBmb3IgZXh0ZW5zaW9ucyBh bmQgdmlldyBzZXJ2aWNlcy4KICAgICBVSVZpZXdDb250cm9sbGVyICpzZXJ2aWNlVmlld0NvbnRy b2xsZXIgPSBuaWw7CiAgICAgZm9yIChVSVZpZXcgKnZpZXcgPSBtX3dlYlZpZXcuZ2V0KCkuZ2V0 KCk7IHZpZXc7IHZpZXcgPSB2aWV3LnN1cGVydmlldykgewogICAgICAgICBVSVZpZXdDb250cm9s bGVyICp2aWV3Q29udHJvbGxlciA9IFtVSVZpZXdDb250cm9sbGVyIHZpZXdDb250cm9sbGVyRm9y Vmlldzp2aWV3XTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XZWJQ YWdlUHJveHlJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5 SU9TLm1tCmluZGV4IGY0OTQ1YmNiOTYzNWUxZGUxODhlODYzZjY1NTRiYTg0ZjUyMzQxYjUuLjI1 NTc3NDU2Y2Q4MzNjNDc0NjEwNzE3ZTAzOTBiZDYwZjM4Yjc1NzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQpAQCAtMTUxOSwxMyArMTUxOSwx NiBAQCBXZWJDb250ZW50TW9kZSBXZWJQYWdlUHJveHk6OmVmZmVjdGl2ZUNvbnRlbnRNb2RlQWZ0 ZXJBZGp1c3RpbmdQb2xpY2llcyhBUEk6OldlYgogICAgIHJldHVybiBXZWJDb250ZW50TW9kZTo6 RGVza3RvcDsKIH0KIAotYm9vbCBXZWJQYWdlUHJveHk6OnNob3VsZFVzZUZvcmVncm91bmRQcmlv cml0eUZvckNsaWVudE5hdmlnYXRpb24oKSBjb25zdAorYm9vbCBXZWJQYWdlUHJveHk6OnNob3Vs ZEZvcmNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpIGNvbnN0CiB7CiAg ICAgLy8gVGhlIGNsaWVudCBtYXkgcmVxdWVzdCB0aGF0IHdlIGRvIGNsaWVudCBuYXZpZ2F0aW9u cyBhdCBmb3JlZ3JvdW5kIHByaW9yaXR5LCBldmVuIGlmIHRoZQogICAgIC8vIHZpZXcgaXMgbm90 IHZpc2libGUsIGFzIGxvbmcgYXMgdGhlIGFwcGxpY2F0aW9uIGlzIGZvcmVncm91bmQuCiAgICAg aWYgKCFjb25maWd1cmF0aW9uKCkuY2xpZW50TmF2aWdhdGlvbnNSdW5BdEZvcmVncm91bmRQcmlv cml0eSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICAvLyBUaGlzIHNldHRpbmcgb25s eSBhcHBsaWVzIHRvIGJhY2tncm91bmQgdmlld3MuIFRoZXJlIGlzIG5vIG5lZWQgdG8gZm9yY2Ug Zm9yZWdyb3VuZAorICAgIC8vIHByaW9yaXR5IGZvciBmb3JlZ3JvdW5kIHZpZXdzIHNpbmNlIHRo ZXkgZ2V0IGZvcmVncm91bmQgcHJpb3JpdHkgYnkgdmlydHVlIG9mIGJlaW5nCisgICAgLy8gdmlz aWJsZS4KICAgICBpZiAoaXNWaWV3VmlzaWJsZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK