209714 2020-03-28 20:20:47 -0700 ScrollLatchingState should use WeakPtr<Element> 2020-03-30 20:36:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo darin ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1635301 0 simon.fraser 2020-03-28 20:20:47 -0700 ScrollLatchingState should use WeakPtr<Element> 1635302 1 394856 simon.fraser 2020-03-28 20:21:33 -0700 Created attachment 394856 Patch 1635319 2 394856 darin 2020-03-29 01:13:02 -0700 Comment on attachment 394856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394856&action=review > Source/WebCore/page/scrolling/ScrollLatchingState.h:48 > + void setWheelEventElement(Element*); Does this need to accept null? Could it take a references instead of a pointer? > Source/WebCore/page/scrolling/ScrollLatchingState.h:57 > + void setPreviousWheelScrolledElement(Element*); Ditto. > Source/WebCore/page/scrolling/ScrollLatchingState.h:61 > + Ditto. 1635932 3 simon.fraser 2020-03-30 20:35:57 -0700 https://trac.webkit.org/changeset/259278/webkit 1635933 4 webkit-bug-importer 2020-03-30 20:36:15 -0700 <rdar://problem/61087846> 394856 2020-03-28 20:21:33 -0700 2020-03-29 01:13:02 -0700 Patch bug-209714-20200328202132.patch text/plain 7123 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFlNDkwOWMwODhhZGI4 OTU0NTk0MjYyYWI0MWI4MWIyYmUxYzQ0Yi4uZTgyYWI2ZWQxOGI2ZjNmYTBjMzZkMTQ4ZGViNzU3 ZjE0M2E3YTM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAzLTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNjcm9sbExhdGNo aW5nU3RhdGUgc2hvdWxkIHVzZSBXZWFrUHRyPEVsZW1lbnQ+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk3MTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTY3JvbGxMYXRjaGluZ1N0YXRlIHNob3VsZG4n dCBhZmZlY3QgZWxlbWVudCBsaWZldGltZXMuIENoYW5nZSBpdCB0byB1c2UgV2Vha1B0ciBpbnN0 ZWFkCisgICAgICAgIG9mIFJlZlB0cjw+LgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpkZWZhdWx0V2hlZWxFdmVudEhh bmRsZXIpOgorICAgICAgICAqIHBhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbToKKyAgICAgICAg KFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cGxhdGZvcm1QcmVwYXJlRm9yV2hlZWxFdmVudHMpOgor ICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbExhdGNoaW5nU3RhdGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U2Nyb2xsTGF0Y2hpbmdTdGF0ZTo6c2V0V2hlZWxFdmVudEVsZW1lbnQpOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsTGF0Y2hpbmdTdGF0ZTo6c2V0UHJldmlvdXNXaGVlbFNj cm9sbGVkRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxMYXRjaGluZ1N0YXRlOjpz ZXRTY3JvbGxhYmxlQ29udGFpbmVyKToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxM YXRjaGluZ1N0YXRlLmg6CisKIDIwMjAtMDMtMjggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgU2Nyb2xsTGF0Y2hpbmcgbG9nIGNoYW5uZWwg YW5kIGltcHJvdmUgc29tZSBsb2dnaW5nIGZ1bmN0aW9uYWxpdHkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcAppbmRleCAwYjBkM2ExOTBmMjg3MmY0Yjk5ZTMxNzQ2MmMzOTAyYjVmZWRi MTQxLi4yMjA3MjZhNmVjNDIxMmUzM2VjMTFlMWM4Y2ZmZjQyNjM4YmZlZTczIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yOTE3LDE2ICsyOTE3LDE1IEBAIHZvaWQgRXZl bnRIYW5kbGVyOjpkZWZhdWx0V2hlZWxFdmVudEhhbmRsZXIoTm9kZSogc3RhcnROb2RlLCBXaGVl bEV2ZW50JiB3aGVlbEV2CiAgICAgICAgIGZpbHRlcmVkUGxhdGZvcm1EZWx0YS5zZXRIZWlnaHQo cGxhdGZvcm1XaGVlbEV2ZW50LT5kZWx0YVkoKSk7CiAgICAgfQogCisgICAgUmVmUHRyPEVsZW1l bnQ+IHN0b3BFbGVtZW50OwogI2lmIEVOQUJMRShXSEVFTF9FVkVOVF9MQVRDSElORykKICAgICBT Y3JvbGxMYXRjaGluZ1N0YXRlKiBsYXRjaGVkU3RhdGUgPSBtX2ZyYW1lLnBhZ2UoKSA/IG1fZnJh bWUucGFnZSgpLT5sYXRjaGluZ1N0YXRlKCkgOiBudWxscHRyOwotICAgIFJlZlB0cjxFbGVtZW50 PiBzdG9wRWxlbWVudCA9IGxhdGNoZWRTdGF0ZSA/IGxhdGNoZWRTdGF0ZS0+cHJldmlvdXNXaGVl bFNjcm9sbGVkRWxlbWVudCgpIDogbnVsbHB0cjsKKyAgICBzdG9wRWxlbWVudCA9IGxhdGNoZWRT dGF0ZSA/IGxhdGNoZWRTdGF0ZS0+cHJldmlvdXNXaGVlbFNjcm9sbGVkRWxlbWVudCgpIDogbnVs bHB0cjsKIAogICAgIGlmIChtX2ZyYW1lLnBhZ2UoKSAmJiBtX2ZyYW1lLnBhZ2UoKS0+d2hlZWxF dmVudERlbHRhRmlsdGVyKCktPmlzRmlsdGVyaW5nRGVsdGFzKCkpIHsKICAgICAgICAgZmlsdGVy ZWRQbGF0Zm9ybURlbHRhID0gbV9mcmFtZS5wYWdlKCktPndoZWVsRXZlbnREZWx0YUZpbHRlcigp LT5maWx0ZXJlZERlbHRhKCk7CiAgICAgICAgIGZpbHRlcmVkVmVsb2NpdHkgPSBtX2ZyYW1lLnBh Z2UoKS0+d2hlZWxFdmVudERlbHRhRmlsdGVyKCktPmZpbHRlcmVkVmVsb2NpdHkoKTsKICAgICB9 Ci0jZWxzZQotICAgIFJlZlB0cjxFbGVtZW50PiBzdG9wRWxlbWVudDsKICNlbmRpZgogCiAgICAg aWYgKGhhbmRsZVdoZWVsRXZlbnRJbkFwcHJvcHJpYXRlRW5jbG9zaW5nQm94KHN0YXJ0Tm9kZSwg d2hlZWxFdmVudCwgc3RvcEVsZW1lbnQsIGZpbHRlcmVkUGxhdGZvcm1EZWx0YSwgZmlsdGVyZWRW ZWxvY2l0eSkpCkBAIC0yOTM0LDcgKzI5MzMsNyBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVs dFdoZWVsRXZlbnRIYW5kbGVyKE5vZGUqIHN0YXJ0Tm9kZSwgV2hlZWxFdmVudCYgd2hlZWxFdgog CiAjaWYgRU5BQkxFKFdIRUVMX0VWRU5UX0xBVENISU5HKQogICAgIGlmIChsYXRjaGVkU3RhdGUg JiYgIWxhdGNoZWRTdGF0ZS0+d2hlZWxFdmVudEVsZW1lbnQoKSkKLSAgICAgICAgbGF0Y2hlZFN0 YXRlLT5zZXRQcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50KFdURk1vdmUoc3RvcEVsZW1lbnQp KTsKKyAgICAgICAgbGF0Y2hlZFN0YXRlLT5zZXRQcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50 KHN0b3BFbGVtZW50LmdldCgpKTsKICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL21h Yy9FdmVudEhhbmRsZXJNYWMubW0KaW5kZXggMzRiYmQ4YWZmYTI5ZDkxYWM3ZjAwNDliMjg3OWE2 ZGJiZGQ5NDIwMi4uNWE4OTU0OGQyMmNmYjk5YmQ1Yzc3MTdiZTllNjgzNDdlYzI1NTVlMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQpAQCAtOTg0LDcgKzk4 NCw3IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpwbGF0Zm9ybVByZXBhcmVGb3JXaGVlbEV2ZW50cyhj b25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmIHdoZWVsCiAgICAgICAgICAgICAgICAgbGF0Y2hpbmdT dGF0ZS5zZXRTdGFydGVkR2VzdHVyZUF0U2Nyb2xsTGltaXQoZmFsc2UpOwogICAgICAgICAgICAg ICAgIGxhdGNoaW5nU3RhdGUuc2V0V2hlZWxFdmVudEVsZW1lbnQod2hlZWxFdmVudFRhcmdldC5n ZXQoKSk7CiAgICAgICAgICAgICAgICAgbGF0Y2hpbmdTdGF0ZS5zZXRGcmFtZSgmbV9mcmFtZSk7 Ci0gICAgICAgICAgICAgICAgbGF0Y2hpbmdTdGF0ZS5zZXRTY3JvbGxhYmxlQ29udGFpbmVyKHNj cm9sbGFibGVDb250YWluZXIuY29weVJlZigpKTsKKyAgICAgICAgICAgICAgICBsYXRjaGluZ1N0 YXRlLnNldFNjcm9sbGFibGVDb250YWluZXIoc2Nyb2xsYWJsZUNvbnRhaW5lci5nZXQoKSk7CiAg ICAgICAgICAgICAgICAgbGF0Y2hpbmdTdGF0ZS5zZXRXaWRnZXRJc0xhdGNoZWQocmVzdWx0Lmlz T3ZlcldpZGdldCgpKTsKICAgICAgICAgICAgICAgICBwYWdlLT5wdXNoTmV3TGF0Y2hpbmdTdGF0 ZShXVEZNb3ZlKGxhdGNoaW5nU3RhdGUpKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvU2Nyb2xsTGF0Y2hpbmdTdGF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxMYXRjaGluZ1N0YXRlLmNwcAppbmRleCAwYzFhMjQ1MTc1YmQ0 MmNmMWFhNzlhMWFjMmEwNWQxMWRhYTEyYzMxLi4xYzhjYjU2NTY0MjFiMDU3MDEwMWZhZmUyMTBk ZjliOTQ0MGY3NGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxMYXRjaGluZ1N0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxMYXRjaGluZ1N0YXRlLmNwcApAQCAtNDQsOSArNDQsOSBAQCB2b2lkIFNjcm9sbExh dGNoaW5nU3RhdGU6OmNsZWFyKCkKICAgICBtX3ByZXZpb3VzV2hlZWxTY3JvbGxlZEVsZW1lbnQg PSBudWxscHRyOwogfQogCi12b2lkIFNjcm9sbExhdGNoaW5nU3RhdGU6OnNldFdoZWVsRXZlbnRF bGVtZW50KFJlZlB0cjxFbGVtZW50PiYmIGVsZW1lbnQpCit2b2lkIFNjcm9sbExhdGNoaW5nU3Rh dGU6OnNldFdoZWVsRXZlbnRFbGVtZW50KEVsZW1lbnQqIGVsZW1lbnQpCiB7Ci0gICAgbV93aGVl bEV2ZW50RWxlbWVudCA9IFdURk1vdmUoZWxlbWVudCk7CisgICAgbV93aGVlbEV2ZW50RWxlbWVu dCA9IG1ha2VXZWFrUHRyKGVsZW1lbnQpOwogfQogCiB2b2lkIFNjcm9sbExhdGNoaW5nU3RhdGU6 OnNldFdpZGdldElzTGF0Y2hlZChib29sIGlzT3ZlcldpZGdldCkKQEAgLTU0LDE0ICs1NCwxNCBA QCB2b2lkIFNjcm9sbExhdGNoaW5nU3RhdGU6OnNldFdpZGdldElzTGF0Y2hlZChib29sIGlzT3Zl cldpZGdldCkKICAgICBtX3dpZGdldElzTGF0Y2hlZCA9IGlzT3ZlcldpZGdldDsKIH0KIAotdm9p ZCBTY3JvbGxMYXRjaGluZ1N0YXRlOjpzZXRQcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50KFJl ZlB0cjxFbGVtZW50PiYmIGVsZW1lbnQpCit2b2lkIFNjcm9sbExhdGNoaW5nU3RhdGU6OnNldFBy ZXZpb3VzV2hlZWxTY3JvbGxlZEVsZW1lbnQoRWxlbWVudCogZWxlbWVudCkKIHsKLSAgICBtX3By ZXZpb3VzV2hlZWxTY3JvbGxlZEVsZW1lbnQgPSBXVEZNb3ZlKGVsZW1lbnQpOworICAgIG1fcHJl dmlvdXNXaGVlbFNjcm9sbGVkRWxlbWVudCA9IG1ha2VXZWFrUHRyKGVsZW1lbnQpOwogfQogCi12 b2lkIFNjcm9sbExhdGNoaW5nU3RhdGU6OnNldFNjcm9sbGFibGVDb250YWluZXIoUmVmUHRyPENv bnRhaW5lck5vZGU+JiYgY29udGFpbmVyKQordm9pZCBTY3JvbGxMYXRjaGluZ1N0YXRlOjpzZXRT Y3JvbGxhYmxlQ29udGFpbmVyKENvbnRhaW5lck5vZGUqIGNvbnRhaW5lcikKIHsKLSAgICBtX3Nj cm9sbGFibGVDb250YWluZXIgPSBXVEZNb3ZlKGNvbnRhaW5lcik7CisgICAgbV9zY3JvbGxhYmxl Q29udGFpbmVyID0gbWFrZVdlYWtQdHIoY29udGFpbmVyKTsKIH0KIAogVGV4dFN0cmVhbSYgb3Bl cmF0b3I8PChUZXh0U3RyZWFtJiB0cywgY29uc3QgU2Nyb2xsTGF0Y2hpbmdTdGF0ZSYgc3RhdGUp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxMYXRjaGlu Z1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxMYXRjaGluZ1N0 YXRlLmgKaW5kZXggZjY5Yzg0ZWU4YTJmMTE3ZjViNDJmYzFiNzlmZjY3NTk3OWFkY2EzNS4uZjk0 YzNjYjEyZWUyMmM4MTg3NjhmYjYzYzJlYjJhYjc5MmM5OTZjNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsTGF0Y2hpbmdTdGF0ZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbExhdGNoaW5nU3RhdGUuaApAQCAtMjUsNyAr MjUsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAotI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KKyNpbmNs dWRlIDx3dGYvV2Vha1B0ci5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIGNsYXNzIFRleHRTdHJlYW07 CkBAIC00NSw3ICs0NSw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsZWFyKCk7CiAKICAgICBFbGVt ZW50KiB3aGVlbEV2ZW50RWxlbWVudCgpIGNvbnN0IHsgcmV0dXJuIG1fd2hlZWxFdmVudEVsZW1l bnQuZ2V0KCk7IH0KLSAgICB2b2lkIHNldFdoZWVsRXZlbnRFbGVtZW50KFJlZlB0cjxFbGVtZW50 PiYmKTsKKyAgICB2b2lkIHNldFdoZWVsRXZlbnRFbGVtZW50KEVsZW1lbnQqKTsKKwogICAgIEZy YW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fZnJhbWU7IH0KICAgICB2b2lkIHNldEZyYW1l KEZyYW1lKiBmcmFtZSkgeyBtX2ZyYW1lID0gZnJhbWU7IH0KIApAQCAtNTMsMTcgKzU0LDE4IEBA IHB1YmxpYzoKICAgICB2b2lkIHNldFdpZGdldElzTGF0Y2hlZChib29sIGlzT3ZlcldpZGdldCk7 CiAKICAgICBFbGVtZW50KiBwcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50KCkgY29uc3QgeyBy ZXR1cm4gbV9wcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50LmdldCgpOyB9Ci0gICAgdm9pZCBz ZXRQcmV2aW91c1doZWVsU2Nyb2xsZWRFbGVtZW50KFJlZlB0cjxFbGVtZW50PiYmKTsKKyAgICB2 b2lkIHNldFByZXZpb3VzV2hlZWxTY3JvbGxlZEVsZW1lbnQoRWxlbWVudCopOwogICAgIAogICAg IENvbnRhaW5lck5vZGUqIHNjcm9sbGFibGVDb250YWluZXIoKSBjb25zdCB7IHJldHVybiBtX3Nj cm9sbGFibGVDb250YWluZXIuZ2V0KCk7IH0KLSAgICB2b2lkIHNldFNjcm9sbGFibGVDb250YWlu ZXIoUmVmUHRyPENvbnRhaW5lck5vZGU+JiYpOworICAgIHZvaWQgc2V0U2Nyb2xsYWJsZUNvbnRh aW5lcihDb250YWluZXJOb2RlKik7CisKICAgICBib29sIHN0YXJ0ZWRHZXN0dXJlQXRTY3JvbGxM aW1pdCgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhcnRlZEdlc3R1cmVBdFNjcm9sbExpbWl0OyB9CiAg ICAgdm9pZCBzZXRTdGFydGVkR2VzdHVyZUF0U2Nyb2xsTGltaXQoYm9vbCBzdGFydGVkQXRMaW1p dCkgeyBtX3N0YXJ0ZWRHZXN0dXJlQXRTY3JvbGxMaW1pdCA9IHN0YXJ0ZWRBdExpbWl0OyB9CiAK IHByaXZhdGU6Ci0gICAgUmVmUHRyPEVsZW1lbnQ+IG1fd2hlZWxFdmVudEVsZW1lbnQ7Ci0gICAg UmVmUHRyPEVsZW1lbnQ+IG1fcHJldmlvdXNXaGVlbFNjcm9sbGVkRWxlbWVudDsKLSAgICBSZWZQ dHI8Q29udGFpbmVyTm9kZT4gbV9zY3JvbGxhYmxlQ29udGFpbmVyOworICAgIFdlYWtQdHI8RWxl bWVudD4gbV93aGVlbEV2ZW50RWxlbWVudDsKKyAgICBXZWFrUHRyPEVsZW1lbnQ+IG1fcHJldmlv dXNXaGVlbFNjcm9sbGVkRWxlbWVudDsKKyAgICBXZWFrUHRyPENvbnRhaW5lck5vZGU+IG1fc2Ny b2xsYWJsZUNvbnRhaW5lcjsKIAogICAgIEZyYW1lKiBtX2ZyYW1lIHsgbnVsbHB0ciB9OwogCg==