209703 2020-03-28 09:28:22 -0700 [JSC] Public class field should accept "static" as field name 2020-03-30 12:25:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209675 InRadar P2 Normal --- 1 ticaiolima ticaiolima caitp ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer xan.lopez ysuzuki oldest_to_newest 1635194 0 ticaiolima 2020-03-28 09:28:22 -0700 The following program should be valid, but throws a SyntaxError: ``` class A { super; static; set; get; test() { return "foo"; } } ``` 1635203 1 394826 ticaiolima 2020-03-28 09:59:24 -0700 Created attachment 394826 Patch 1635235 2 394826 ross.kirsling 2020-03-28 12:56:39 -0700 Comment on attachment 394826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394826&action=review > Source/JavaScriptCore/ChangeLog:8 > + It allows class fields being created using "static" as identifier. We should link to the spec here but unfortunately the PR is still unmerged. (https://github.com/tc39/ecma262/pull/1668) Since the idea is the same as other identifiers though, I suppose we could at least link to this: https://tc39.es/ecma262/#prod-IdentifierName > Source/JavaScriptCore/parser/Parser.cpp:2880 > + // Reparse "static()" as a method named or "static" as a class field. grammar nit: remove 'named' > JSTests/stress/class-fields-harmony.js:909 > +{ I think Cait brought this file over from V8. Are we sure we want to make arbitrary edits here? (https://github.com/v8/v8/blob/master/test/mjsunit/harmony/public-instance-class-fields.js) Also, perhaps we should add this to test262? Because SM is currently failing too. 1635499 3 394916 ticaiolima 2020-03-30 07:36:58 -0700 Created attachment 394916 Patch 1635500 4 394826 ticaiolima 2020-03-30 07:37:31 -0700 Comment on attachment 394826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394826&action=review Thank you very much for the review! >> Source/JavaScriptCore/ChangeLog:8 >> + It allows class fields being created using "static" as identifier. > > We should link to the spec here but unfortunately the PR is still unmerged. > (https://github.com/tc39/ecma262/pull/1668) > > Since the idea is the same as other identifiers though, I suppose we could at least link to this: > https://tc39.es/ecma262/#prod-IdentifierName I agree. Added. >> JSTests/stress/class-fields-harmony.js:909 >> +{ > > I think Cait brought this file over from V8. Are we sure we want to make arbitrary edits here? > (https://github.com/v8/v8/blob/master/test/mjsunit/harmony/public-instance-class-fields.js) > > Also, perhaps we should add this to test262? Because SM is currently failing too. I'll place this in a separate file to avoid any issue. Test262 were added by https://github.com/tc39/test262/pull/2550 1635607 5 394916 ross.kirsling 2020-03-30 11:20:50 -0700 Comment on attachment 394916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394916&action=review > JSTests/ChangeLog:8 > + * stress/class-fields-harmony.js: Oops, looks like the ChangeLog needs to be regenerated. 1635635 6 394944 ticaiolima 2020-03-30 11:59:37 -0700 Created attachment 394944 Patch 1635636 7 394944 ticaiolima 2020-03-30 12:00:43 -0700 Comment on attachment 394944 Patch Thank you very much for the review! 1635649 8 ews-feeder 2020-03-30 12:24:18 -0700 Committed r259216: <https://trac.webkit.org/changeset/259216> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394944. 1635650 9 webkit-bug-importer 2020-03-30 12:25:16 -0700 <rdar://problem/61067736> 394826 2020-03-28 09:59:24 -0700 2020-03-30 07:37:57 -0700 Patch bug-209703-20200328135923.patch text/plain 3265 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Yzc5Mjg4YzYwNzg4MjE1NDJhMWQ1YmEzNzhhOWUwNmNmZWI5ZTU2Li5lZWNkOWY1MWU5MTlmYmQ5 YmY0NjdkZjAwOTBjNmNmMTcwZTZkZmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMy0yOCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0pTQ10gUHVibGljIGNsYXNzIGZpZWxkIHNob3VsZCBhY2NlcHQgInN0YXRp YyIgYXMgZmllbGQgbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQgYWxsb3dzIGNsYXNzIGZpZWxkcyBiZWluZyBjcmVhdGVkIHVzaW5nICJzdGF0 aWMiIGFzIGlkZW50aWZpZXIuCisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAg ICAgKEpTQzo6UGFyc2VyPExleGVyVHlwZT46OnBhcnNlQ2xhc3MpOgorCiAyMDIwLTAzLTI3ICBS b3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSlNDXSBN YWtlIE9wZXJhdG9yIGFuIGVudW0gY2xhc3MgdG8gYXZvaWQgT3AqIGlkZW50aWZpZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKaW5kZXggNzNlODNmM2E0MjAwOGM5N2Vk NmUyMjQ2M2Q3Y2ViNmNhNGU3ZjkwYi4uNmY0ODc5NjAyZGEzYjJjMDk1ZDFkN2QzYTQ0NTRmOTkx ZGQ1NmI3YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMjg3 Niw4ICsyODc2LDggQEAgdGVtcGxhdGUgPGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlQ2xhc3NFeHBy ZXNzaW9uIFBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZUNsYXNzKFQKICAgICAgICAgaWYgKG1hdGNo KFJFU0VSVkVEX0lGX1NUUklDVCkgJiYgKm1fdG9rZW4ubV9kYXRhLmlkZW50ID09IG1fdm0ucHJv cGVydHlOYW1lcy0+c3RhdGljS2V5d29yZCkgewogICAgICAgICAgICAgU2F2ZVBvaW50IHNhdmVQ b2ludCA9IGNyZWF0ZVNhdmVQb2ludChjb250ZXh0KTsKICAgICAgICAgICAgIG5leHQoKTsKLSAg ICAgICAgICAgIGlmIChtYXRjaChPUEVOUEFSRU4pKSB7Ci0gICAgICAgICAgICAgICAgLy8gUmVw YXJzZSAic3RhdGljKCkiIGFzIGEgbWV0aG9kIG5hbWVkICJzdGF0aWMiLgorICAgICAgICAgICAg aWYgKG1hdGNoKE9QRU5QQVJFTikgfHwgbWF0Y2goU0VNSUNPTE9OKSB8fCBtYXRjaChFUVVBTCkp IHsKKyAgICAgICAgICAgICAgICAvLyBSZXBhcnNlICJzdGF0aWMoKSIgYXMgYSBtZXRob2QgbmFt ZWQgb3IgInN0YXRpYyIgYXMgYSBjbGFzcyBmaWVsZC4KICAgICAgICAgICAgICAgICByZXN0b3Jl U2F2ZVBvaW50KGNvbnRleHQsIHNhdmVQb2ludCk7CiAgICAgICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgICAgICB0YWcgPSBDbGFzc0VsZW1lbnRUYWc6OlN0YXRpYzsKZGlmZiAtLWdpdCBhL0pT VGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmMyMTVhMTA5NjQ0OTE2 YTI3NWE2NGMyNGUzNWY4ZjE1YjNhZDAxZC4uZWRmYjQ2MmE0ZTYyODZlMTljZjVlODcyNzkzOTc0 OTFhODJiMzY3MyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wMy0yOCAgQ2FpbyBMaW1hICA8dGljYWlv bGltYUBnbWFpbC5jb20+CisKKyAgICAgICAgW0pTQ10gUHVibGljIGNsYXNzIGZpZWxkIHNob3Vs ZCBhY2NlcHQgInN0YXRpYyIgYXMgZmllbGQgbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvY2xhc3MtZmllbGRzLWhhcm1vbnkuanM6 CisKIDIwMjAtMDMtMjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFNraXAgc3RyZXNzL3Rlc3Qtb3V0LW9mLW1lbW9yeS5qcyBvbiBtZW1vcnkgbGltaXRlZCBkZXZp Y2VzLgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvY2xhc3MtZmllbGRzLWhhcm1vbnkuanMg Yi9KU1Rlc3RzL3N0cmVzcy9jbGFzcy1maWVsZHMtaGFybW9ueS5qcwppbmRleCBkYmY0NmQ1Mjdi MWU0NTgyYWZlNTA4ZGY5ZjBlOGRmNWM3ZGVjY2NmLi5hMTU4OTRjNDRjMThjNjQ5N2YyOTViNTgw YWRjZjQ4NTA3YjdmYzU3IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9jbGFzcy1maWVsZHMt aGFybW9ueS5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9jbGFzcy1maWVsZHMtaGFybW9ueS5qcwpA QCAtOTA2LDMgKzkwNiw0MSBAQCB4KCkoKTsKICAgYXNzZXJ0U2FtZSh0aGlzSW5Db25zdHJ1Y3Rv ciwgYyk7CiB9CiAKK3sKKyAgY2xhc3MgQSB7CisgICAgYXN5bmMKKyAgICBnZXQKKyAgICB0ZXN0 KCkgeyByZXR1cm4gImZvbyI7IH0KKyAgfQorCisgIGxldCBhID0gbmV3IEEoKTsKKyAgYXNzZXJ0 RXF1YWxzKHRydWUsICdhc3luYycgaW4gYSk7CisgIGFzc2VydEVxdWFscygiZm9vIiwgYS50ZXN0 KTsKK30KKworeworICBjbGFzcyBBIHsKKyAgICBzdXBlcjsKKyAgICBzdGF0aWM7CisgICAgc2V0 OworICAgIGdldDsKKyAgICB0ZXN0KCkgeyByZXR1cm4gImZvbyI7IH0KKyAgfQorCisgIGxldCBh ID0gbmV3IEEoKTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdzZXQnIGluIGEpOworICBhc3NlcnRF cXVhbHModHJ1ZSwgJ2dldCcgaW4gYSk7CisgIGFzc2VydEVxdWFscyh0cnVlLCAnc3RhdGljJyBp biBhKTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdzdXBlcicgaW4gYSk7CisgIGFzc2VydEVxdWFs cygiZm9vIiwgYS50ZXN0KCkpOworfQorCit7CisgIGNsYXNzIEEgeworICAgIHN0YXRpYyA9ICJ0 ZXN0IjsKKyAgfQorCisgIGxldCBhID0gbmV3IEEoKTsKKyAgYXNzZXJ0RXF1YWxzKCJ0ZXN0Iiwg YS5zdGF0aWMpOworfQorCg== 394916 2020-03-30 07:36:58 -0700 2020-03-30 11:59:33 -0700 Patch bug-209703-20200330113656.patch text/plain 3448 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Yzc5Mjg4YzYwNzg4MjE1NDJhMWQ1YmEzNzhhOWUwNmNmZWI5ZTU2Li5lYzUzNWZkOWNmMmQ5ZDgw M2Q5ODM0ZGJlNDRiODA5OTYxOTEwYjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMy0yOCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0pTQ10gUHVibGljIGNsYXNzIGZpZWxkIHNob3VsZCBhY2NlcHQgInN0YXRp YyIgYXMgZmllbGQgbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQgYWxsb3dzIGNsYXNzIGZpZWxkcyBiZWluZyBjcmVhdGVkIHVzaW5nICJzdGF0 aWMiIGFzIGlkZW50aWZpZXIKKyAgICAgICAgKGh0dHBzOi8vdGMzOS5lcy9lY21hMjYyLyNwcm9k LUlkZW50aWZpZXJOYW1lKS4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAg ICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VDbGFzcyk6CisKIDIwMjAtMDMtMjcgIFJv c3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFtKU0NdIE1h a2UgT3BlcmF0b3IgYW4gZW51bSBjbGFzcyB0byBhdm9pZCBPcCogaWRlbnRpZmllcnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCA3M2U4M2YzYTQyMDA4Yzk3ZWQ2 ZTIyNDYzZDdjZWI2Y2E0ZTdmOTBiLi44NDg1ODIzYzRlNjQ1YmE2ZTYzMWNhNGEyZGMwNDZhNWY3 MDgzYWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC0yODc2 LDggKzI4NzYsOCBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+IFRyZWVDbGFzc0V4cHJl c3Npb24gUGFyc2VyPExleGVyVHlwZT46OnBhcnNlQ2xhc3MoVAogICAgICAgICBpZiAobWF0Y2go UkVTRVJWRURfSUZfU1RSSUNUKSAmJiAqbV90b2tlbi5tX2RhdGEuaWRlbnQgPT0gbV92bS5wcm9w ZXJ0eU5hbWVzLT5zdGF0aWNLZXl3b3JkKSB7CiAgICAgICAgICAgICBTYXZlUG9pbnQgc2F2ZVBv aW50ID0gY3JlYXRlU2F2ZVBvaW50KGNvbnRleHQpOwogICAgICAgICAgICAgbmV4dCgpOwotICAg ICAgICAgICAgaWYgKG1hdGNoKE9QRU5QQVJFTikpIHsKLSAgICAgICAgICAgICAgICAvLyBSZXBh cnNlICJzdGF0aWMoKSIgYXMgYSBtZXRob2QgbmFtZWQgInN0YXRpYyIuCisgICAgICAgICAgICBp ZiAobWF0Y2goT1BFTlBBUkVOKSB8fCBtYXRjaChTRU1JQ09MT04pIHx8IG1hdGNoKEVRVUFMKSkg eworICAgICAgICAgICAgICAgIC8vIFJlcGFyc2UgInN0YXRpYygpIiBhcyBhIG1ldGhvZCBvciAi c3RhdGljIiBhcyBhIGNsYXNzIGZpZWxkLgogICAgICAgICAgICAgICAgIHJlc3RvcmVTYXZlUG9p bnQoY29udGV4dCwgc2F2ZVBvaW50KTsKICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAg ICAgIHRhZyA9IENsYXNzRWxlbWVudFRhZzo6U3RhdGljOwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9D aGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBmYzIxNWExMDk2NDQ5MTZhMjc1YTY0 YzI0ZTM1ZjhmMTViM2FkMDFkLi5lZGZiNDYyYTRlNjI4NmUxOWNmNWU4NzI3OTM5NzQ5MWE4MmIz NjczIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAzLTI4ICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdt YWlsLmNvbT4KKworICAgICAgICBbSlNDXSBQdWJsaWMgY2xhc3MgZmllbGQgc2hvdWxkIGFjY2Vw dCAic3RhdGljIiBhcyBmaWVsZCBuYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDk3MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHN0cmVzcy9jbGFzcy1maWVsZHMtaGFybW9ueS5qczoKKwogMjAy MC0wMy0yNyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgU2tpcCBz dHJlc3MvdGVzdC1vdXQtb2YtbWVtb3J5LmpzIG9uIG1lbW9yeSBsaW1pdGVkIGRldmljZXMuCmRp ZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9jbGFzcy1maWVsZHMtd2l0aC1zcGVjaWFsLW5hbWVz LmpzIGIvSlNUZXN0cy9zdHJlc3MvY2xhc3MtZmllbGRzLXdpdGgtc3BlY2lhbC1uYW1lcy5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4xMDkyNTVkZmI5MjkyNDQ1ZjUzNWI4MmY5NWMwYmViNWQwOWY4ZjVkCi0tLSAv ZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvY2xhc3MtZmllbGRzLXdpdGgtc3BlY2lhbC1u YW1lcy5qcwpAQCAtMCwwICsxLDQ1IEBACisvL0AgcmVxdWlyZU9wdGlvbnMoIi0tdXNlUHVibGlj Q2xhc3NGaWVsZHM9dHJ1ZSIpCisKK2Z1bmN0aW9uIGFzc2VydEVxdWFscyhlLCBhKSB7CisgICAg aWYgKGEgIT09IGUpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigiRXhwZWN0ZWQ6ICIgKyBlICsg IiBidXQgZ290OiAiICsgYSk7Cit9CisKK3sKKyAgY2xhc3MgQSB7CisgICAgYXN5bmMKKyAgICBn ZXQKKyAgICB0ZXN0KCkgeyByZXR1cm4gImZvbyI7IH0KKyAgfQorCisgIGxldCBhID0gbmV3IEEo KTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdhc3luYycgaW4gYSk7CisgIGFzc2VydEVxdWFscygi Zm9vIiwgYS50ZXN0KTsKK30KKworeworICBjbGFzcyBBIHsKKyAgICBzdXBlcjsKKyAgICBzdGF0 aWM7CisgICAgc2V0OworICAgIGdldDsKKyAgICB0ZXN0KCkgeyByZXR1cm4gImZvbyI7IH0KKyAg fQorCisgIGxldCBhID0gbmV3IEEoKTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdzZXQnIGluIGEp OworICBhc3NlcnRFcXVhbHModHJ1ZSwgJ2dldCcgaW4gYSk7CisgIGFzc2VydEVxdWFscyh0cnVl LCAnc3RhdGljJyBpbiBhKTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdzdXBlcicgaW4gYSk7Cisg IGFzc2VydEVxdWFscygiZm9vIiwgYS50ZXN0KCkpOworfQorCit7CisgIGNsYXNzIEEgeworICAg IHN0YXRpYyA9ICJ0ZXN0IjsKKyAgfQorCisgIGxldCBhID0gbmV3IEEoKTsKKyAgYXNzZXJ0RXF1 YWxzKCJ0ZXN0IiwgYS5zdGF0aWMpOworfQorCg== 394944 2020-03-30 11:59:37 -0700 2020-03-30 12:24:18 -0700 Patch bug-209703-20200330155935.patch text/plain 3464 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Yzc5Mjg4YzYwNzg4MjE1NDJhMWQ1YmEzNzhhOWUwNmNmZWI5ZTU2Li4xOTEyOGFjMTUyNWFlYzBm NDBkZDBhM2NhYTNiMmUyOWVjM2YxMDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMy0zMCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0pTQ10gUHVibGljIGNsYXNzIGZpZWxkIHNob3VsZCBhY2NlcHQgInN0YXRp YyIgYXMgZmllbGQgbmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9zcyBLaXJzbGluZy4KKwor ICAgICAgICBJdCBhbGxvd3MgY2xhc3MgZmllbGRzIGJlaW5nIGNyZWF0ZWQgdXNpbmcgInN0YXRp YyIgYXMgaWRlbnRpZmllcgorICAgICAgICAoaHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIvI3Byb2Qt SWRlbnRpZmllck5hbWUpLgorCisgICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAg IChKU0M6OlBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZUNsYXNzKToKKwogMjAyMC0wMy0yNyAgUm9z cyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgW0pTQ10gTWFr ZSBPcGVyYXRvciBhbiBlbnVtIGNsYXNzIHRvIGF2b2lkIE9wKiBpZGVudGlmaWVycwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCmluZGV4IDczZTgzZjNhNDIwMDhjOTdlZDZl MjI0NjNkN2NlYjZjYTRlN2Y5MGIuLjg0ODU4MjNjNGU2NDViYTZlNjMxY2E0YTJkYzA0NmE1Zjcw ODNhYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTI4NzYs OCArMjg3Niw4IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUNsYXNzRXhwcmVz c2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VDbGFzcyhUCiAgICAgICAgIGlmIChtYXRjaChS RVNFUlZFRF9JRl9TVFJJQ1QpICYmICptX3Rva2VuLm1fZGF0YS5pZGVudCA9PSBtX3ZtLnByb3Bl cnR5TmFtZXMtPnN0YXRpY0tleXdvcmQpIHsKICAgICAgICAgICAgIFNhdmVQb2ludCBzYXZlUG9p bnQgPSBjcmVhdGVTYXZlUG9pbnQoY29udGV4dCk7CiAgICAgICAgICAgICBuZXh0KCk7Ci0gICAg ICAgICAgICBpZiAobWF0Y2goT1BFTlBBUkVOKSkgewotICAgICAgICAgICAgICAgIC8vIFJlcGFy c2UgInN0YXRpYygpIiBhcyBhIG1ldGhvZCBuYW1lZCAic3RhdGljIi4KKyAgICAgICAgICAgIGlm IChtYXRjaChPUEVOUEFSRU4pIHx8IG1hdGNoKFNFTUlDT0xPTikgfHwgbWF0Y2goRVFVQUwpKSB7 CisgICAgICAgICAgICAgICAgLy8gUmVwYXJzZSAic3RhdGljKCkiIGFzIGEgbWV0aG9kIG9yICJz dGF0aWMiIGFzIGEgY2xhc3MgZmllbGQuCiAgICAgICAgICAgICAgICAgcmVzdG9yZVNhdmVQb2lu dChjb250ZXh0LCBzYXZlUG9pbnQpOwogICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAg ICAgdGFnID0gQ2xhc3NFbGVtZW50VGFnOjpTdGF0aWM7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0No YW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZjMjE1YTEwOTY0NDkxNmEyNzVhNjRj MjRlMzVmOGYxNWIzYWQwMWQuLjIwYjMwYWRjODU0NzQyZGMyOWNmZDE3YzIwMjVkMWE3ODM5NmFj NjUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDMtMzAgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21h aWwuY29tPgorCisgICAgICAgIFtKU0NdIFB1YmxpYyBjbGFzcyBmaWVsZCBzaG91bGQgYWNjZXB0 ICJzdGF0aWMiIGFzIGZpZWxkIG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwOTcwMworCisgICAgICAgIFJldmlld2VkIGJ5IFJvc3MgS2lyc2xp bmcuCisKKyAgICAgICAgKiBzdHJlc3MvY2xhc3MtZmllbGRzLXdpdGgtc3BlY2lhbC1uYW1lcy5q czogQWRkZWQuCisKIDIwMjAtMDMtMjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFNraXAgc3RyZXNzL3Rlc3Qtb3V0LW9mLW1lbW9yeS5qcyBvbiBtZW1vcnkgbGlt aXRlZCBkZXZpY2VzLgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvY2xhc3MtZmllbGRzLXdp dGgtc3BlY2lhbC1uYW1lcy5qcyBiL0pTVGVzdHMvc3RyZXNzL2NsYXNzLWZpZWxkcy13aXRoLXNw ZWNpYWwtbmFtZXMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTA5MjU1ZGZiOTI5MjQ0NWY1MzViODJmOTVjMGJl YjVkMDlmOGY1ZAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2NsYXNzLWZpZWxk cy13aXRoLXNwZWNpYWwtbmFtZXMuanMKQEAgLTAsMCArMSw0NSBAQAorLy9AIHJlcXVpcmVPcHRp b25zKCItLXVzZVB1YmxpY0NsYXNzRmllbGRzPXRydWUiKQorCitmdW5jdGlvbiBhc3NlcnRFcXVh bHMoZSwgYSkgeworICAgIGlmIChhICE9PSBlKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoIkV4 cGVjdGVkOiAiICsgZSArICIgYnV0IGdvdDogIiArIGEpOworfQorCit7CisgIGNsYXNzIEEgewor ICAgIGFzeW5jCisgICAgZ2V0CisgICAgdGVzdCgpIHsgcmV0dXJuICJmb28iOyB9CisgIH0KKwor ICBsZXQgYSA9IG5ldyBBKCk7CisgIGFzc2VydEVxdWFscyh0cnVlLCAnYXN5bmMnIGluIGEpOwor ICBhc3NlcnRFcXVhbHMoImZvbyIsIGEudGVzdCk7Cit9CisKK3sKKyAgY2xhc3MgQSB7CisgICAg c3VwZXI7CisgICAgc3RhdGljOworICAgIHNldDsKKyAgICBnZXQ7CisgICAgdGVzdCgpIHsgcmV0 dXJuICJmb28iOyB9CisgIH0KKworICBsZXQgYSA9IG5ldyBBKCk7CisgIGFzc2VydEVxdWFscyh0 cnVlLCAnc2V0JyBpbiBhKTsKKyAgYXNzZXJ0RXF1YWxzKHRydWUsICdnZXQnIGluIGEpOworICBh c3NlcnRFcXVhbHModHJ1ZSwgJ3N0YXRpYycgaW4gYSk7CisgIGFzc2VydEVxdWFscyh0cnVlLCAn c3VwZXInIGluIGEpOworICBhc3NlcnRFcXVhbHMoImZvbyIsIGEudGVzdCgpKTsKK30KKworewor ICBjbGFzcyBBIHsKKyAgICBzdGF0aWMgPSAidGVzdCI7CisgIH0KKworICBsZXQgYSA9IG5ldyBB KCk7CisgIGFzc2VydEVxdWFscygidGVzdCIsIGEuc3RhdGljKTsKK30KKwo=