209690 2020-03-27 17:37:55 -0700 Skip stress/test-out-of-memory.js on memory limited devices. 2020-03-28 06:21:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam keith_miller ticaiolima webkit-bug-importer oldest_to_newest 1635070 0 mark.lam 2020-03-27 17:37:55 -0700 <rdar://problem/60659198> 1635071 1 394773 mark.lam 2020-03-27 17:42:46 -0700 Created attachment 394773 proposed patch. 1635072 2 394773 keith_miller 2020-03-27 17:45:09 -0700 Comment on attachment 394773 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review > JSTests/stress/test-out-of-memory.js:1 > +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) I think $memoryLimited is a superset of "arm"/"mips"? 1635074 3 mark.lam 2020-03-27 17:52:38 -0700 (In reply to Keith Miller from comment #2) > Comment on attachment 394773 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394773&action=review > > > JSTests/stress/test-out-of-memory.js:1 > > +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) > > I think $memoryLimited is a superset of "arm"/"mips"? I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. 1635075 4 394773 keith_miller 2020-03-27 17:53:33 -0700 Comment on attachment 394773 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review r=me. >>> JSTests/stress/test-out-of-memory.js:1 >>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) >> >> I think $memoryLimited is a superset of "arm"/"mips"? > > I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. sounds good. Can you make sure to ping them? 1635077 5 mark.lam 2020-03-27 17:57:29 -0700 Thanks. Landed in r259149: <http://trac.webkit.org/r259149>. 1635168 6 394773 ticaiolima 2020-03-28 06:21:22 -0700 Comment on attachment 394773 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review >>>> JSTests/stress/test-out-of-memory.js:1 >>>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) >>> >>> I think $memoryLimited is a superset of "arm"/"mips"? >> >> I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. > > sounds good. Can you make sure to ping them? Just for the record, `$memoryLimited` and `$architecture == "arm" or "mips"`are note related each other. However, we use `--memory-limited` to run stress tests in all bots for ARMv7 and MIPS. Since it is defined in bots configuration, I'm afraid we won't find any relationship of them on WebKit tree. I think it is fine to have a mental model that `$memoryLimited is a superset of "arm"/"mips"` now, but It can change in the future. 394773 2020-03-27 17:42:46 -0700 2020-03-27 17:53:33 -0700 proposed patch. bug-209690.patch text/plain 1056 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTkxNDcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBTa2lwIHN0cmVzcy90ZXN0LW91dC1vZi1tZW1vcnkuanMgb24gbWVtb3J5 IGxpbWl0ZWQgZGV2aWNlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwOTY5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjA2NTkxOTg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvdGVz dC1vdXQtb2YtbWVtb3J5LmpzOgorCiAyMDIwLTAzLTI3ICBQYXVsbyBNYXRvcyAgPHBtYXRvc0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFNraXAgbmV3IG1lbW9yeSB0ZXN0IHN0cmVzcy90eXBlZC1h cnJheS1vb20taW4uLi4gaW4gbWVtb3J5IGxpbWl0ZWQgZGV2aWNlcwpJbmRleDogSlNUZXN0cy9z dHJlc3MvdGVzdC1vdXQtb2YtbWVtb3J5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNz L3Rlc3Qtb3V0LW9mLW1lbW9yeS5qcwkocmV2aXNpb24gMjU5MTM1KQorKysgSlNUZXN0cy9zdHJl c3MvdGVzdC1vdXQtb2YtbWVtb3J5LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAot Ly9AIGlmIFsiYXJtIiwgIm1pcHMiXS5pbmNsdWRlPygkYXJjaGl0ZWN0dXJlKSB0aGVuIHNraXAg ZWxzZSBydW5EZWZhdWx0IGVuZAorLy9AIHNraXAgaWYgJG1lbW9yeUxpbWl0ZWQgb3IgWyJhcm0i LCAibWlwcyJdLmluY2x1ZGU/KCRhcmNoaXRlY3R1cmUpCisvL0AgcnVuRGVmYXVsdAogCiBjb25z dCBhID0gWzBdOwogYS5fX3Byb3RvX18gPSB7fTsK