209667 2020-03-27 11:07:57 -0700 Optimize frequently used Document::canAcceptChild 2020-03-27 11:27:37 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build All All NEW P2 Minor --- 1 eugenebut webkit-unassigned darin oldest_to_newest 1634888 0 eugenebut 2020-03-27 11:07:57 -0700 This came up during the codereview here: https://bugs.webkit.org/show_bug.cgi?id=208311#c53 Darin Adler said: "Can’t help noticing that this function is not written with efficiency in mind. The nodeType virtual function is pretty expensive and we call it 3 times!" and "this can be optimized for all the common cases to not call nodeType at all, using functions like isElementNode and isTextNode that are inline single bit checks. Only exotic cases would require calls to nodeType." 1634907 1 darin 2020-03-27 11:27:37 -0700 I do want to be a bit cautious about not complicating this to optimize it if there’s no evidence a faster version would make any practical difference. So maybe we shouldn’t do it even though I suggested it. Would be easy to do, though.