209650 2020-03-27 08:24:34 -0700 [css-grid] WPT Tests css/css-grid/grid-items/grid-item-percentage-sizes-*.html fail 2021-04-22 16:08:27 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugzilla.mozilla.org/show_bug.cgi?id=1526567 https://bugs.chromium.org/p/chromium/issues/detail?id=890278 https://bugs.webkit.org/show_bug.cgi?id=180633 InRadar P2 Normal --- 1 clopez webkit-unassigned changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan lingcherd_ho obrufau pdr rego svillar webkit-bug-importer zsun oldest_to_newest 1634810 0 clopez 2020-03-27 08:24:34 -0700 The following ref-test failures happen on WebKit for the WPT tests: css/css-grid/grid-items/grid-item-percentage-sizes-001.html css/css-grid/grid-items/grid-item-percentage-sizes-002.html css/css-grid/grid-items/grid-item-percentage-sizes-003.html Check here the diff of the images: https://wpt.fyi/results/css/css-grid/grid-items?label=master&product=chrome%5Bexperimental%5D&product=edge%5Bexperimental%5D&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&product=webkitgtk%5Bexperimental%5D&aligned&q=css%2Fcss-grid%2Fgrid-items%2Fgrid-item-percentage-sizes ^ click on the test name, then on compare on either safari or webkitgtk and a new window will appear 1635603 1 clopez 2020-03-30 11:09:58 -0700 This 3 tests were added to WPT from Mozilla bug https://bugzil.la/1526567 See also the Chromium https://crbug.com/890278 which is also related to this issue. As fas as I can see there are several bugs contributing to the failures on this tests. For example, on css/css-grid/grid-items/grid-item-percentage-sizes-001.html we have this: Row1 : .hl .item { writing-mode: horizontal-tb; direction:ltr; } Row2 : .vrl .item { writing-mode: vertical-rl; direction:ltr; } Row3 : .vrr .item { writing-mode: vertical-rl; direction:rtl; } Row4 : .vll .item { writing-mode: vertical-lr; direction:ltr; } Row5 : .vlr .item { writing-mode: vertical-lr; direction:rtl; } Row6 : .sll .item { writing-mode: sideways-lr; direction:ltr; } Row7 : .slr .item { writing-mode: sideways-lr; direction:rtl; } There are 7 rows with diferent writing-mode. And each row has 7 columns. Each one of this 7 columns tests different combinations of min-height/min-width, max-height/max-width and width/height. Here is the first row (extracted from the test): https://codepen.io/cl0p3z/pen/abOXjRz On Chrome and Firefox the last 3 blue squares have a small size, but not on WebKit. It looks something perhaps related to min-width/min-height, it seems on WebKit that has preference over width/height? On top of that, on the rows with vertical writing mode there are more failures, so I guess perhaps some of those are related to bug 180633 ? 1635643 2 obrufau 2020-03-30 12:21:12 -0700 In Chromium, grid-item-percentage-sizes-001.html and grid-item-percentage-sizes-002.html were fixed in https://crbug.com/931474. In WebKit, the corresponding issue is bug 195967, which I should fix since I already have a patch. The problem was that the tests improved but still failed due to unrelated issues. Regarding grid-item-percentage-sizes-003.html, in Chromium it used to pass in LayoutNG but not legacy. But later it was fixed in legacy as a side effect of https://crrev.com/c/1796323 1656588 3 obrufau 2020-05-27 14:34:43 -0700 These tests have improved. I think the only remaining issue that still makes them fail is not related to grid: <style> .grid { height: 50px; width: 50px; min-width: min-content; background: green; } .item { writing-mode: vertical-lr; width: 100%; } .content { width: 100px; } </style> There should be a green rectangle, 50px tall, 100px wide. <div class="grid"> <div class="item"> <div class="content"></div> </div> </div> WebKit produces a 50x50 square instead of a rectangle. 1657018 4 rego 2020-05-28 14:24:57 -0700 Thanks for the analysis Oriol. As you said that's not related to grid layout, so you might want to report a different bug for that, and link it from TestExpectations. And then close this one. 1657087 5 obrufau 2020-05-28 16:44:21 -0700 Actually in Firefox that's also a square, so now I'm less sure that it's supposed to be a rectangle. I'm not an expert in orthogonal flows. 1657157 6 rego 2020-05-28 22:33:29 -0700 I'm not sure but it looks like a bug to me, maybe we could fill a spec issue asking for clarification or fill a bug in Firefox and see what they think about it. In all browsers "item" has a 100px width. So I guess "min-width: min-content;" on the parent should use that width, I don't see any good reason not to do that. But I might be missing something. 1753089 7 426792 zsun 2021-04-22 02:23:55 -0700 Created attachment 426792 Patch 1753102 8 426792 svillar 2021-04-22 04:06:41 -0700 Comment on attachment 426792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426792&action=review Looking good. I've some improvements in mind though > Source/WebCore/ChangeLog:9 > + percentage height against. Overridden containing block size should aslo be chosen in favor Nits: overriden->overriding aslo->also > Source/WebCore/ChangeLog:15 > + Three tests that failed are now passed. Nit: passed->passing > Source/WebCore/rendering/RenderBox.cpp:3111 > + const RenderBlock* const realContainingBlock = cb; Blink uses overriding containing block sizes to stablish fences between LayoutNG and legacy code but that is not the case of WebKit. AFAIK only flex and grid set the overriding content logical sizes and in both cases cb would be equal to realContainingBlock because we wouldn't iterate the loop bellow that code as skipContainingBlockForPercentHeightCalculation() would return false independently on whether the item is orthogonal or quirks mode. That's why I think that we don't need the realContaininBlock variable and can directly use cb. > Source/WebCore/rendering/RenderBox.cpp:3124 > We could perhaps define at this point a variable like: bool isOrthogonal = isHorizontal != cb->isHorizontalWritingMode(); and use it in the following checks (either isOrthogonal or !isOrthogonal depending on the case). > LayoutTests/ChangeLog:8 > + * TestExpectations: Nit: just mention here that grid-item-percentage-sizes-00{1-3}.html are unskipped because they're passing now. 1753126 9 426804 zsun 2021-04-22 06:13:02 -0700 Created attachment 426804 Patch 1753207 10 426804 svillar 2021-04-22 10:08:47 -0700 Comment on attachment 426804 Patch Super! 1753209 11 ews-feeder 2021-04-22 10:12:32 -0700 Committed r276445 (236905@main): <https://commits.webkit.org/236905@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426804. 1753338 12 lingcherd_ho 2021-04-22 16:08:27 -0700 <rdar://77026533> 426792 2021-04-22 02:23:55 -0700 2021-04-22 06:12:56 -0700 Patch bug-209650-20210422102354.patch text/plain 5172 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M1M2NlZGNhOTg1YmRj YTU2MjUwMGU4ODE1OTRjOTZiM2Q2ZGFmZi4uZGY4ZTQ3YjNjOGJiNjdhZGE4NGVmYTg1Yjg2MWEy ZjJlOGVkYzhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA0LTIyICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBXUFQgVGVzdHMg Y3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1pdGVtLXBlcmNlbnRhZ2Utc2l6ZXMtKi5odG1s IGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IG5lZWQgdG8gY2hlY2sgY2hpbGQncyB3cml0aW5nIG1vZGUgaW4gb3JkZXIgdG8gcGljayB0aGUg Y29ycmVjdCBkaW1lbnNpb24gdG8gcmVzb2x2ZQorICAgICAgICBwZXJjZW50YWdlIGhlaWdodCBh Z2FpbnN0LiBPdmVycmlkZGVuIGNvbnRhaW5pbmcgYmxvY2sgc2l6ZSBzaG91bGQgYXNsbyBiZSBj aG9zZW4gaW4gZmF2b3IKKyAgICAgICAgb2Ygc3BlY2lhbCBjb2RlIGZvciBvcnRob2dvbmFsIHdy aXRpbmcgbW9kZS4KKyAKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMgYW4gaW1wb3J0IG9mIENocm9t aXVtIENMIGF0CisgICAgICAgIGh0dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5j b20vYy9jaHJvbWl1bS9zcmMvKy8xMzQ4MDU1LgorIAorICAgICAgICBUaHJlZSB0ZXN0cyB0aGF0 IGZhaWxlZCBhcmUgbm93IHBhc3NlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3gu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpjb21wdXRlUGVyY2VudGFnZUxvZ2lj YWxIZWlnaHQgY29uc3QpOgorCiAyMDIxLTA0LTIyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gV2ViIHByb2Nlc3NlcyByZWNyZWF0ZWQg YWZ0ZXIgY3Jhc2hpbmcgYXJlIG5vdCBjcmVhdGVkIHdpdGggdGhlIHJpZ2h0IGNvbnRlbnRTaXpl Q2F0ZWdvcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggMTkyNDQw YjMzODgwOGEwM2VmMThjMTg5NjE2ZGU5YTliYmZlYmRlZC4uNDExNjFjNWUwZTdmZjhjY2ExOTE2 ZmZiOTdiYmI3OTQ0NWQ3ZjBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5j cHAKQEAgLTMxMDgsNiArMzEwOCw3IEBAIE9wdGlvbmFsPExheW91dFVuaXQ+IFJlbmRlckJveDo6 Y29tcHV0ZVBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0KGNvbnN0IExlbmd0aCYgaGVpCiAKICAgICBi b29sIHNraXBwZWRBdXRvSGVpZ2h0Q29udGFpbmluZ0Jsb2NrID0gZmFsc2U7CiAgICAgUmVuZGVy QmxvY2sqIGNiID0gY29udGFpbmluZ0Jsb2NrKCk7CisgICAgY29uc3QgUmVuZGVyQmxvY2sqIGNv bnN0IHJlYWxDb250YWluaW5nQmxvY2sgPSBjYjsKICAgICBjb25zdCBSZW5kZXJCb3gqIGNvbnRh aW5pbmdCbG9ja0NoaWxkID0gdGhpczsKICAgICBMYXlvdXRVbml0IHJvb3RNYXJnaW5Cb3JkZXJQ YWRkaW5nSGVpZ2h0OwogICAgIGJvb2wgaXNIb3Jpem9udGFsID0gaXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKTsKQEAgLTMxMjEsMTAgKzMxMjIsMTIgQEAgT3B0aW9uYWw8TGF5b3V0VW5pdD4gUmVu ZGVyQm94Ojpjb21wdXRlUGVyY2VudGFnZUxvZ2ljYWxIZWlnaHQoY29uc3QgTGVuZ3RoJiBoZWkK ICAgICBpZiAodXBkYXRlRGVzY2VuZGFudHMgPT0gVXBkYXRlUGVyY2VudGFnZUhlaWdodERlc2Nl bmRhbnRzOjpZZXMpCiAgICAgICAgIGNiLT5hZGRQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChjb25z dF9jYXN0PFJlbmRlckJveCY+KCp0aGlzKSk7CiAKLSAgICBpZiAoaXNIb3Jpem9udGFsICE9IGNi LT5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQotICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBj b250YWluaW5nQmxvY2tDaGlsZC0+Y29udGFpbmluZ0Jsb2NrTG9naWNhbFdpZHRoRm9yQ29udGVu dCgpOwotICAgIGVsc2UgaWYgKGhhc092ZXJyaWRpbmdDb250YWluaW5nQmxvY2tDb250ZW50TG9n aWNhbEhlaWdodCgpKQorICAgIGlmIChoYXNPdmVycmlkaW5nQ29udGFpbmluZ0Jsb2NrQ29udGVu dExvZ2ljYWxXaWR0aCgpICYmIGlzSG9yaXpvbnRhbCAhPSByZWFsQ29udGFpbmluZ0Jsb2NrLT5p c0hvcml6b250YWxXcml0aW5nTW9kZSgpKQorICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBvdmVy cmlkaW5nQ29udGFpbmluZ0Jsb2NrQ29udGVudExvZ2ljYWxXaWR0aCgpOworICAgIGVsc2UgaWYg KGhhc092ZXJyaWRpbmdDb250YWluaW5nQmxvY2tDb250ZW50TG9naWNhbEhlaWdodCgpICYmIGlz SG9yaXpvbnRhbCA9PSByZWFsQ29udGFpbmluZ0Jsb2NrLT5pc0hvcml6b250YWxXcml0aW5nTW9k ZSgpKQogICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBvdmVycmlkaW5nQ29udGFpbmluZ0Jsb2Nr Q29udGVudExvZ2ljYWxIZWlnaHQoKTsKKyAgICBlbHNlIGlmIChpc0hvcml6b250YWwgIT0gY2It PmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCisgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IGNv bnRhaW5pbmdCbG9ja0NoaWxkLT5jb250YWluaW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50 KCk7CiAgICAgZWxzZSBpZiAoaXM8UmVuZGVyVGFibGVDZWxsPigqY2IpKSB7CiAgICAgICAgIGlm ICghc2tpcHBlZEF1dG9IZWlnaHRDb250YWluaW5nQmxvY2spIHsKICAgICAgICAgICAgIC8vIFRh YmxlIGNlbGxzIHZpb2xhdGUgd2hhdCB0aGUgQ1NTIHNwZWMgc2F5cyB0byBkbyB3aXRoIGhlaWdo dHMuIEJhc2ljYWxseSB3ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDdhOGFmMTMzNmFjYWMwNDBjZmI3ZmE3MzgwOWI5NjJm MmE3NDQyZGIuLmEzOWEwMzkxOTMwNWM1ZjdhNDBiZGRhZTI4MmUxMDk0ZTlhNzM2MzYgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAyMS0wNC0yMiAgWmlyYW4gU3VuICA8enN1bkBpZ2FsaWEuY29t PgorCisgICAgICAgIFtjc3MtZ3JpZF0gV1BUIFRlc3RzIGNzcy9jc3MtZ3JpZC9ncmlkLWl0ZW1z L2dyaWQtaXRlbS1wZXJjZW50YWdlLXNpemVzLSouaHRtbCBmYWlsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk2NTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIw MjEtMDQtMjEgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBvcnQg Y3NzL2Nzcy13aWxsLWNoYW5nZSB0ZXN0cyBmcm9tIFdQVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg NmJhOTBlMzQ0MDU5ZjYzYTE1MmUzMDZmMDM5ZTZhMzA4NTgzNWM2MS4uMDZlMDE5ZTQ1OTRiNzM0 Zjc5ZDhhNDFlNzliMGFlZWMwZGM5ZTYxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4 cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC00MDU5LDkg KzQwNTksNiBAQCB3ZWJraXQub3JnL2IvMjA5NDYwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1ncmlkL2Fic3Bvcy9kZXNjZW5kYQogd2Via2l0Lm9yZy9iLzIwOTQ2MCBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvZGVzY2Vu ZGFudC1zdGF0aWMtcG9zaXRpb24tMDAyLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtp dC5vcmcvYi8yMDk0NjAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdy aWQvYWJzcG9zL2Rlc2NlbmRhbnQtc3RhdGljLXBvc2l0aW9uLTAwMy5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjA5NDYwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1ncmlkL2Fic3Bvcy9kZXNjZW5kYW50LXN0YXRpYy1wb3NpdGlvbi0wMDQu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIwOTY1MCBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9ncmlkLWl0ZW1zL2dyaWQtaXRlbS1w ZXJjZW50YWdlLXNpemVzLTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3Jn L2IvMjA5NjUwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dy aWQtaXRlbXMvZ3JpZC1pdGVtLXBlcmNlbnRhZ2Utc2l6ZXMtMDAyLmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMDk2NTAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9ncmlkLWl0ZW0tcGVyY2VudGFnZS1zaXplcy0w MDMuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxMjIwMSBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9ncmlkLWRlZmluaXRpb24vZ3Jp ZC1saW1pdHMtMDAxLmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8yMDk2NTYgaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1tb2RlbC9ncmlkLWJ1dHRv bi0wMDEuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxMjI0NiBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1iYXNlbGluZS1h bGlnbi1jeWNsZXMtMDAxLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K 426804 2021-04-22 06:13:02 -0700 2021-04-22 10:12:33 -0700 Patch bug-209650-20210422141300.patch text/plain 4780 zsun U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M1M2NlZGNhOTg1YmRj YTU2MjUwMGU4ODE1OTRjOTZiM2Q2ZGFmZi4uNDEwNmQ4MTJmMTJmNGIwNWNjZjEwYTljOGUxMjFh NzM5MzcwZGYxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA0LTIyICBaaXJh biBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBXUFQgVGVzdHMg Y3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1pdGVtLXBlcmNlbnRhZ2Utc2l6ZXMtKi5odG1s IGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IG5lZWQgdG8gY2hlY2sgY2hpbGQncyB3cml0aW5nIG1vZGUgaW4gb3JkZXIgdG8gcGljayB0aGUg Y29ycmVjdCBkaW1lbnNpb24gdG8gcmVzb2x2ZQorICAgICAgICBwZXJjZW50YWdlIGhlaWdodCBh Z2FpbnN0LiBPdmVycmlkaW5nIGNvbnRhaW5pbmcgYmxvY2sgc2l6ZSBzaG91bGQgYWxzbyBiZSBj aG9zZW4gaW4gZmF2b3VyCisgICAgICAgIG9mIHNwZWNpYWwgY29kZSBmb3Igb3J0aG9nb25hbCB3 cml0aW5nIG1vZGUuCisgCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIGFuIGltcG9ydCBvZiBDaHJv bWl1bSBDTCBhdAorICAgICAgICBodHRwczovL2Nocm9taXVtLXJldmlldy5nb29nbGVzb3VyY2Uu Y29tL2MvY2hyb21pdW0vc3JjLysvMTM0ODA1NS4KKyAKKyAgICAgICAgVGhyZWUgdGVzdHMgdGhh dCBmYWlsZWQgYXJlIG5vdyBwYXNzaW5nLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJv eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmNvbXB1dGVQZXJjZW50YWdlTG9n aWNhbEhlaWdodCBjb25zdCk6CisKIDIwMjEtMDQtMjIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1h eGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBXZWIgcHJvY2Vzc2VzIHJlY3JlYXRl ZCBhZnRlciBjcmFzaGluZyBhcmUgbm90IGNyZWF0ZWQgd2l0aCB0aGUgcmlnaHQgY29udGVudFNp emVDYXRlZ29yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCAxOTI0 NDBiMzM4ODA4YTAzZWYxOGMxODk2MTZkZTlhOWJiZmViZGVkLi42MTFhY2U3NmIyZDFjOWFkNjI4 NzY2NGFiZTFmNjVkOTFmN2JiODQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmNwcApAQCAtMzEyMSwxMCArMzEyMSwxMyBAQCBPcHRpb25hbDxMYXlvdXRVbml0PiBSZW5kZXJC b3g6OmNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodChjb25zdCBMZW5ndGgmIGhlaQogICAg IGlmICh1cGRhdGVEZXNjZW5kYW50cyA9PSBVcGRhdGVQZXJjZW50YWdlSGVpZ2h0RGVzY2VuZGFu dHM6OlllcykKICAgICAgICAgY2ItPmFkZFBlcmNlbnRIZWlnaHREZXNjZW5kYW50KGNvbnN0X2Nh c3Q8UmVuZGVyQm94Jj4oKnRoaXMpKTsKIAotICAgIGlmIChpc0hvcml6b250YWwgIT0gY2ItPmlz SG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCi0gICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IGNvbnRh aW5pbmdCbG9ja0NoaWxkLT5jb250YWluaW5nQmxvY2tMb2dpY2FsV2lkdGhGb3JDb250ZW50KCk7 Ci0gICAgZWxzZSBpZiAoaGFzT3ZlcnJpZGluZ0NvbnRhaW5pbmdCbG9ja0NvbnRlbnRMb2dpY2Fs SGVpZ2h0KCkpCisgICAgYm9vbCBpc09ydGhvZ29uYWwgPSBpc0hvcml6b250YWwgIT0gY2ItPmlz SG9yaXpvbnRhbFdyaXRpbmdNb2RlKCk7CisgICAgaWYgKGhhc092ZXJyaWRpbmdDb250YWluaW5n QmxvY2tDb250ZW50TG9naWNhbFdpZHRoKCkgJiYgaXNPcnRob2dvbmFsKQorICAgICAgICBhdmFp bGFibGVIZWlnaHQgPSBvdmVycmlkaW5nQ29udGFpbmluZ0Jsb2NrQ29udGVudExvZ2ljYWxXaWR0 aCgpOworICAgIGVsc2UgaWYgKGhhc092ZXJyaWRpbmdDb250YWluaW5nQmxvY2tDb250ZW50TG9n aWNhbEhlaWdodCgpICYmICFpc09ydGhvZ29uYWwpCiAgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9 IG92ZXJyaWRpbmdDb250YWluaW5nQmxvY2tDb250ZW50TG9naWNhbEhlaWdodCgpOworICAgIGVs c2UgaWYgKGlzT3J0aG9nb25hbCkKKyAgICAgICAgYXZhaWxhYmxlSGVpZ2h0ID0gY29udGFpbmlu Z0Jsb2NrQ2hpbGQtPmNvbnRhaW5pbmdCbG9ja0xvZ2ljYWxXaWR0aEZvckNvbnRlbnQoKTsKICAg ICBlbHNlIGlmIChpczxSZW5kZXJUYWJsZUNlbGw+KCpjYikpIHsKICAgICAgICAgaWYgKCFza2lw cGVkQXV0b0hlaWdodENvbnRhaW5pbmdCbG9jaykgewogICAgICAgICAgICAgLy8gVGFibGUgY2Vs bHMgdmlvbGF0ZSB3aGF0IHRoZSBDU1Mgc3BlYyBzYXlzIHRvIGRvIHdpdGggaGVpZ2h0cy4gQmFz aWNhbGx5IHdlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggN2E4YWYxMzM2YWNhYzA0MGNmYjdmYTczODA5Yjk2MmYyYTc0NDJk Yi4uY2MyMzllYmM1NGNjNjI0YTMzZTY5MzU0MDgwMDhmNTVlYWVhOGI5MSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA0LTIyICBaaXJhbiBTdW4gIDx6c3VuQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW2Nzcy1ncmlkXSBXUFQgVGVzdHMgY3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1p dGVtLXBlcmNlbnRhZ2Utc2l6ZXMtKi5odG1sIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogZ3JpZC1pdGVtLXBl cmNlbnRhZ2Utc2l6ZXMtMDB7MS0zfS5odG1sIGFyZSBwYXNzaW5nIGFuZCB1bnNraXBwZWQgbm93 LgorCiAyMDIxLTA0LTIxICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAg SW1wb3J0IGNzcy9jc3Mtd2lsbC1jaGFuZ2UgdGVzdHMgZnJvbSBXUFQKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDZiYTkwZTM0NDA1OWY2M2ExNTJlMzA2ZjAzOWU2YTMwODU4MzVjNjEuLjA2ZTAxOWU0 NTk0YjczNGY3OWQ4YTQxZTc5YjBhZWVjMGRjOWU2MWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAt NDA1OSw5ICs0MDU5LDYgQEAgd2Via2l0Lm9yZy9iLzIwOTQ2MCBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvZGVzY2VuZGEKIHdlYmtpdC5vcmcvYi8y MDk0NjAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvYWJzcG9z L2Rlc2NlbmRhbnQtc3RhdGljLXBvc2l0aW9uLTAwMi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMjA5NDYwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz L2Nzcy1ncmlkL2Fic3Bvcy9kZXNjZW5kYW50LXN0YXRpYy1wb3NpdGlvbi0wMDMuaHRtbCBbIElt YWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIwOTQ2MCBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hYnNwb3MvZGVzY2VuZGFudC1zdGF0aWMtcG9zaXRp b24tMDA0Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMDk2NTAgaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9ncmlk LWl0ZW0tcGVyY2VudGFnZS1zaXplcy0wMDEuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotd2Vi a2l0Lm9yZy9iLzIwOTY1MCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt Z3JpZC9ncmlkLWl0ZW1zL2dyaWQtaXRlbS1wZXJjZW50YWdlLXNpemVzLTAwMi5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMjA5NjUwIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1pdGVtLXBlcmNlbnRhZ2Ut c2l6ZXMtMDAzLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTIyMDEg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1kZWZpbml0 aW9uL2dyaWQtbGltaXRzLTAwMS5odG1sIFsgU2tpcCBdCiB3ZWJraXQub3JnL2IvMjA5NjU2IGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQtbW9kZWwvZ3Jp ZC1idXR0b24tMDAxLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTIyNDYgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvYWxpZ25tZW50L2dyaWQtYmFz ZWxpbmUtYWxpZ24tY3ljbGVzLTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCg==