209647 2020-03-27 03:16:41 -0700 [WPE] Unnecessary gl synchronization when using an OpenMAX video decoder and GLES2 2020-03-27 06:14:07 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez aperez bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1634783 0 magomez 2020-03-27 03:16:41 -0700 On platforms that use an OpenMAX video decoder (like the rpi3) and GLES2, the call to gst_gl_sync_meta_wait_cpu() (which is internally translated into a glFinish call), causes unnecessary waits when trying to the video frame using gstreamer-gl, reducing the framerate. On these platforms the call to gst_gl_sync_meta_wait_cpu() can be omitted cause we know that OpenGL will ensure that the video frame will be ready when we want to draw it. 1634786 1 394715 magomez 2020-03-27 03:39:02 -0700 Created attachment 394715 Patch 1634796 2 aperez 2020-03-27 05:45:12 -0700 Minor nit: The bug tile should have “[GStreamer]” instead of “[WPE]” 😉️ 1634799 3 394715 calvaris 2020-03-27 06:04:46 -0700 Comment on attachment 394715 Patch I would have changed the name of the method to waitForCPUSyncIfNeeded 1634801 4 ews-feeder 2020-03-27 06:14:06 -0700 Committed r259113: <https://trac.webkit.org/changeset/259113> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394715. 394715 2020-03-27 03:39:02 -0700 2020-03-27 06:14:07 -0700 Patch bug-209647-20200327113901.patch text/plain 3224 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjM0NDg5ZTQ3Y2EyZjU2 M2QzMDk1MmVhNzk4NjQ3NGViNDA2NjYwOC4uMGM3MTgyZDUxYTNhODVmNWJiYTg0NGQ0MWE2ODNj MTQ3NDI3ZDMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTI3ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gVW5uZWNlc3Nh cnkgZ2wgc3luY2hyb25pemF0aW9uIHdoZW4gdXNpbmcgYW4gT3Blbk1BWCB2aWRlbyBkZWNvZGVy IGFuZCBHTEVTMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA5NjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG9uJ3QgcGVyZm9ybSB0aGUgY2FsbCB0byBnc3RfZ2xfc3luY19tZXRhX3dhaXRfY3B1KCkg d2hlbiB1c2luZyBhbiBPcGVuTUFYIGRlY29kZXIsCisgICAgICAgIGFzIHdlIGRvbid0IG5lZWQg c3luY2hyb25pemF0aW9uIGluIHRoYXQgY2FzZSBhbmQgdGhlIGludGVybmFsIGNhbGwgdG8gZ2xG aW5pc2goKQorICAgICAgICBjYXN1ZXMgYW4gaW1wb3J0YW50IGZwcyBkcm9wLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3N0VmlkZW9GcmFtZUhvbGRlcjo6d2FpdEZvckNQ VVN5bmMpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpj cmVhdGVHU1RQbGF5QmluKToKKwogMjAyMC0wMy0yNiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0 ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtNU1ZDXSBSZW1vdmUgZXhwZXJpbWVudGFsIGxhbWJk YSBwcm9jZXNzb3IgdXNhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uaAppbmRleCA5NjljN2MzMzRi OTUwM2EyMWE3MmUzNzlmMTM3YzI3YTZiOTE4MTI1Li5hMWU1NjI0NGIxN2VhZTQ2YjllNTRkYWVm MmRiZGMxYTQwMmJiNmU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyQ29tbW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5oCkBAIC0yMTksNyArMjE5 LDcgQEAgcHJpdmF0ZToKIHZvaWQgY29ubmVjdFNpbXBsZUJ1c01lc3NhZ2VDYWxsYmFjayhHc3RF bGVtZW50KiBwaXBlbGluZSk7CiB2b2lkIGRpc2Nvbm5lY3RTaW1wbGVCdXNNZXNzYWdlQ2FsbGJh Y2soR3N0RWxlbWVudCogcGlwZWxpbmUpOwogCi1lbnVtIGNsYXNzIEdzdFZpZGVvRGVjb2RlclBs YXRmb3JtIHsgSW14VlBVLCBWaWRlbzRMaW51eCB9OworZW51bSBjbGFzcyBHc3RWaWRlb0RlY29k ZXJQbGF0Zm9ybSB7IElteFZQVSwgVmlkZW80TGludXgsIE9wZW5NQVggfTsKIAogYm9vbCBpc0dT dHJlYW1lclBsdWdpbkF2YWlsYWJsZShjb25zdCBjaGFyKiBuYW1lKTsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBjZjFhYzUyYThlYTQ1 MDUyMmQ1MmZhMGMzMjI5M2I4YzQxYjQ2MWFjLi4xM2U1OTU5Njc0NTRmYjdjYWI2MjU2MDc4NDdi MmYwYzk4MzczYjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcApAQCAtMjc2LDYgKzI3NiwxMCBAQCBwdWJsaWM6CiAjaWYgVVNFKEdTVFJFQU1F Ul9HTCkKICAgICB2aXJ0dWFsIHZvaWQgd2FpdEZvckNQVVN5bmMoKQogICAgIHsKKyAgICAgICAg Ly8gTm8gbmVlZCBmb3IgT3BlbkdMIHN5bmNocm9uaXphdGlvbiB3aGVuIHVzaW5nIHRoZSBPcGVu TUFYIGRlY29kZXIuCisgICAgICAgIGlmIChtX3ZpZGVvRGVjb2RlclBsYXRmb3JtID09IEdzdFZp ZGVvRGVjb2RlclBsYXRmb3JtOjpPcGVuTUFYKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAg ICAgIEdzdEdMU3luY01ldGEqIG1ldGEgPSBnc3RfYnVmZmVyX2dldF9nbF9zeW5jX21ldGEobV9i dWZmZXIuZ2V0KCkpOwogICAgICAgICBpZiAobWV0YSkgewogICAgICAgICAgICAgR3N0TWVtb3J5 KiBtZW0gPSBnc3RfYnVmZmVyX3BlZWtfbWVtb3J5KG1fYnVmZmVyLmdldCgpLCAwKTsKQEAgLTI5 OTQsNiArMjk5OCw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpjcmVhdGVH U1RQbGF5QmluKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmCiAgICAgICAgICAgICBwbGF5 ZXItPm1fdmlkZW9EZWNvZGVyUGxhdGZvcm0gPSBHc3RWaWRlb0RlY29kZXJQbGF0Zm9ybTo6Vmlk ZW80TGludXg7CiAgICAgICAgIGVsc2UgaWYgKGdfc3RyX2hhc19wcmVmaXgoZWxlbWVudE5hbWUu Z2V0KCksICJpbXh2cHVkZWMiKSkKICAgICAgICAgICAgIHBsYXllci0+bV92aWRlb0RlY29kZXJQ bGF0Zm9ybSA9IEdzdFZpZGVvRGVjb2RlclBsYXRmb3JtOjpJbXhWUFU7CisgICAgICAgIGVsc2Ug aWYgKGdfc3RyX2hhc19wcmVmaXgoZWxlbWVudE5hbWUuZ2V0KCksICJvbXgiKSkKKyAgICAgICAg ICAgIHBsYXllci0+bV92aWRlb0RlY29kZXJQbGF0Zm9ybSA9IEdzdFZpZGVvRGVjb2RlclBsYXRm b3JtOjpPcGVuTUFYOwogCiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQogICAgICAgICBwbGF5 ZXItPnVwZGF0ZVRleHR1cmVNYXBwZXJGbGFncygpOwo=