209621 2020-03-26 14:41:54 -0700 [ Mac wk1 ] fast/loader/child-frame-add-after-back-forward.html is flaky timing out. 2020-04-02 11:12:51 -0700 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Mac macOS 10.14 RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j cdumez achristensen ap cdumez ggaren jbedard rniwa webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1634578 0 Lawrence.j 2020-03-26 14:41:54 -0700 fast/loader/child-frame-add-after-back-forward.html Description: This test is flaky timing out on Mac wk1. The flaky timeouts are apparent through most of the visible history, with the oldest appearing on 12/31/2019. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fchild-frame-add-after-back-forward.html&platform=mac&flavor=wk1&style=release&style=debug&limit=50000 Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-actual.txt @@ -1,8 +1,5 @@ main frame - has 1 onunload handler(s) -main frame - has 1 onunload handler(s) -Go forward then back. +FAIL: Timed out waiting for notifyDone to be called +This tests the parsing of charset in the meta tag. The following should be a Hebrew word: --------- -Frame: '<!--frame1-->' --------- -PASS +עברית 1634580 1 webkit-bug-importer 2020-03-26 14:43:21 -0700 <rdar://problem/60937276> 1634583 2 Lawrence.j 2020-03-26 14:51:21 -0700 I have marked this test as timing out while this issue is investigated. https://trac.webkit.org/changeset/259082/webkit 1636708 3 cdumez 2020-04-01 15:56:23 -0700 Looks like this could be a test harness issue, not an issue with the test in question. The output seems to be for another test: fast/loader/charset-parse.html Likely the preceding test. 1636711 4 cdumez 2020-04-01 15:58:37 -0700 (In reply to Chris Dumez from comment #3) > Looks like this could be a test harness issue, not an issue with the test in > question. The output seems to be for another test: > fast/loader/charset-parse.html > > Likely the preceding test. Or maybe fast/loader/child-frame-add-after-back-forward.html ends up navigating too far back in some cases (back to the previous test which was loaded in the same view). I think this makes some sense. 1636916 5 cdumez 2020-04-02 09:36:02 -0700 Unable to reproduce so far. If someone is, please let me know how. 1636926 6 cdumez 2020-04-02 09:53:48 -0700 I don't see anything particularly wrong or racy with the test.. 1636929 7 395275 cdumez 2020-04-02 09:58:08 -0700 Created attachment 395275 Patch 1636957 8 ews-feeder 2020-04-02 11:12:50 -0700 Committed r259395: <https://trac.webkit.org/changeset/259395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395275. 395275 2020-04-02 09:58:08 -0700 2020-04-02 11:12:50 -0700 Patch bug-209621-20200402095807.patch text/plain 2685 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5Mzg2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTA2NTlkODU2N2RjMzk3OWM0OGQ4 ZDk3NGJlYzVkM2EyYTdiYzNjZi4uM2QxYzAyMmJhZWNkMzlkNDU0ODZhMDc3MjRlZGU2ZDc4YTEx ZjU4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTAyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBNYWMgd2sxIF0gZmFzdC9sb2FkZXIvY2hpbGQt ZnJhbWUtYWRkLWFmdGVyLWJhY2stZm9yd2FyZC5odG1sICBpcyBmbGFreSB0aW1pbmcgb3V0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NjIxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MDkzNzI3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgZW1wdHktZG9jdW1lbnQtZ29lcy1iYWNr Lmh0bWwgdG8gc2NoZWR1bGUgdGhlIGhpc3RvcnkuYmFjaygpIGNhbGwgKmFmdGVyKiB0aGUgbG9h ZAorICAgICAgICBldmVudCBoYXMgYmVlbiBmaXJlZCwgc28gdGhhdCBhIEhpc3RvcnlJdGVtIGhh cyBhY3R1YWxseSBiZWVuIGNyZWF0ZWQuCisKKyAgICAgICAgKiBmYXN0L2xvYWRlci9yZXNvdXJj ZXMvZW1wdHktZG9jdW1lbnQtZ29lcy1iYWNrLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFj LXdrMS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIwLTA0LTAyICB5b3Vlbm4gZmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWJ1ZyBjcmFzaDogQVNTRVJUSU9OIEZBSUxFRDog bV9vbmdvaW5nRmV0Y2hlcy5jb250YWlucyh0YXNrLmZldGNoSWRlbnRpZmllcigpKQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvcmVzb3VyY2VzL2VtcHR5LWRvY3VtZW50LWdv ZXMtYmFjay5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvcmVzb3VyY2VzL2VtcHR5LWRv Y3VtZW50LWdvZXMtYmFjay5odG1sCmluZGV4IGY4ZjE1YjdjMzQzYTJiM2QzYzU3NjFlOGNkOTky OTAzMTgwM2JhYmEuLjM2NWJkMGY1MjNlZTMzZWRiZjZlNDk5NmU5MjZhNTQ5ZmY5NzZhNzIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3Jlc291cmNlcy9lbXB0eS1kb2N1bWVu dC1nb2VzLWJhY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZXNvdXJjZXMv ZW1wdHktZG9jdW1lbnQtZ29lcy1iYWNrLmh0bWwKQEAgLTIsNyArMiw5IEBACiA8Ym9keT4KIDxz Y3JpcHQ+CiAgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsKLSAgICBzZXRUaW1lb3V0KCJ3 aW5kb3cuaGlzdG9yeS5iYWNrKCk7IiwgMCk7CisgICAgb25sb2FkID0gKCkgPT4geworICAgICAg ICBzZXRUaW1lb3V0KCJ3aW5kb3cuaGlzdG9yeS5iYWNrKCk7IiwgMCk7CisgICAgfQogPC9zY3Jp cHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggNjM1MjA1ZGM1OWIyYmFlY2I0OWU1NjBjNGQ3YWY1NDlhOGI1 Yzg5ZC4uMGY1NzA1MDZkNGQxNzk5ZGNjZjY2NDk2OGJhY2IxNzJkOWZmYTRjZiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTQzLDEwICs5 NDMsOCBAQCB3ZWJraXQub3JnL2IvMjA5NDk0IGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1uby1t b3VzZW1vdmUuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMDk1NjAgaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvc2VuZC1yZXNwb25zZS11cGxvYWQtZXZl bnQtcHJvZ3Jlc3MuaHRtIFsgUGFzcyBDcmFzaCBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzIw OTYyMSBmYXN0L2xvYWRlci9jaGlsZC1mcmFtZS1hZGQtYWZ0ZXItYmFjay1mb3J3YXJkLmh0bWwg WyBQYXNzIFRpbWVvdXQgXQotCiB3ZWJraXQub3JnL2IvMjA5ODM3IFsgTW9qYXZlIFJlbGVhc2Ug XSBmYXN0L2NhbnZhcy93ZWJnbC90ZXhJbWFnZTJELW1zZS1mbGlwWS10cnVlLmh0bWwgWyBQYXNz IFRpbWVvdXQgXQogCiB3ZWJraXQub3JnL2IvMjA5ODY2IFsgTW9qYXZlIFJlbGVhc2UgXSBwbGF0 Zm9ybS9tYWMvbWVkaWEvbWVkaWEtc291cmNlL3ZpZGVvcGxheWJhY2txdWFsaXR5LWRlY29tcHJl c3Npb25zZXNzaW9uLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjA5ODgy IFsgRGVidWcgXSBpbnNwZWN0b3IvcGFnZS9vdmVycmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmls dGVyaW5nRW5hYmxlZC5odG1sIFsgUGFzcyBUaW1lb3V0IF0KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCit3ZWJraXQub3JnL2IvMjA5ODgyIFsgRGVidWcgXSBpbnNwZWN0b3IvcGFnZS9vdmVy cmlkZVNldHRpbmctSUNFQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZC5odG1sIFsgUGFzcyBUaW1l b3V0IF0K