209613 2020-03-26 12:28:03 -0700 Unable to present file upload picker after interactively dismissing a previously opened picker 2020-07-23 13:16:55 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 david_quesada webkit-unassigned thorton webkit-bug-importer oldest_to_newest 1634485 0 david_quesada 2020-03-26 12:28:03 -0700 - Present a file upload picker for a file <input> on iOS. - Dismiss the picker by swiping down on it. - Attempt to open the file picker again. (Expected: I can open the file picker) (Actual result: Nothing happens) Extra credit: - Cause the web view to be deallocated (e.g. close a browser tab) (Expected: Nothing interesting happens) (Actual result: The app crashes due an exception in +[UIViewController _viewControllerForFullScreenPresentationFromView:] because the 'view' parameter nil. This is hit while trying to dismiss the file upload panel, which the WKContentView still thinks is presented.) 1634486 1 webkit-bug-importer 2020-03-26 12:28:36 -0700 <rdar://problem/60931009> 1634587 2 394660 david_quesada 2020-03-26 15:00:38 -0700 Created attachment 394660 Patch 1635343 3 394660 dbates 2020-03-29 09:19:39 -0700 Comment on attachment 394660 Patch This patch looks good. A better solution would include a test for this change or a test for the crash (or both). I think it's testable from layout tests. See internals.cpp 1674334 4 ews-feeder 2020-07-23 13:16:55 -0700 Committed r264785: <https://trac.webkit.org/changeset/264785> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394660. 394660 2020-03-26 15:00:38 -0700 2020-07-23 13:16:55 -0700 Patch file_209613.txt text/plain 4526 david_quesada Y29tbWl0IDk0Mzk1OWVkNTg0ZDE2MjcwNjU5MTI1MDQyODhhNzQ5NjJkMThlMDANCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFRodSBNYXIg MjYgMTQ6NTg6MTYgMjAyMCAtMDcwMA0KDQogICAgVW5hYmxlIHRvIHByZXNlbnQgZmlsZSB1cGxv YWQgcGlja2VyIGFmdGVyIGludGVyYWN0aXZlbHkgZGlzbWlzc2luZyBhIHByZXZpb3VzbHkgb3Bl bmVkIHBpY2tlcg0KICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDk2MTMNCiAgICByZGFyOi8vcHJvYmxlbS82MDkzMTAwOQ0KICAgIA0KICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLg0KICAgIA0KICAgIC1bPFVJRG9jdW1lbnRQaWNrZXJWaWV3Q29udHJv bGxlcj4gZG9jdW1lbnRQaWNrZXJXYXNDYW5jZWxsZWQ6XSBkb2Vzbid0IGdldCBjYWxsZWQgaWYg eW91DQogICAgZGlzbWlzcyB0aGUgdmlldyBjb250cm9sbGVyIHVzaW5nIHRoZSBpbnRlcmFjdGl2 ZSBzd2lwZSBkaXNtaXNzYWwgZ2VzdHVyZSBhZGRlZCBpbiBpT1MgMTMuDQogICAgQXMgYSByZXN1 bHQsIHRoZSB3ZWIgdmlldyB3aWxsIGNvbnRpbnVlIHRvIHRoaW5rIGl0J3Mgc2hvd2luZyBhIGZp bGUgcGlja2VyIGFmdGVyIGRpc21pc3NpbmcNCiAgICBpdCB0aGlzIHdheSwgbWVhbmluZyB5b3Ug Y2FuJ3QgcHJlc2VudCBhbnkgb3RoZXIgZmlsZSBwaWNrZXJzIGZyb20gdGhlIHNhbWUgd2ViIHZp ZXcuIEZpeA0KICAgIHRoaXMgYnkgaW1wbGVtZW50aW5nIFVJQWRhcHRpdmVQcmVzZW50YXRpb25D b250cm9sbGVyRGVsZWdhdGUgaW4gV0tGaWxlVXBsb2FkUGFuZWwgdG8gY2FuY2VsDQogICAgYW5k IHRlYXIgZG93biB0aGUgZmlsZSBwaWNrZXIgb3BlcmF0aW9uIHdoZW4gdGhlIHZpZXcgY29udHJv bGxlciBpcyBpbnRlcmFjdGl2ZWx5IGRpc21pc2VkLg0KICAgIA0KICAgICogVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbToNCiAgICAoLVtXS0ZpbGVVcGxvYWRQYW5lbCBz aG93RmlsZVBpY2tlck1lbnVdKToNCiAgICAoLVtXS0ZpbGVVcGxvYWRQYW5lbCBwcmVzZW50YXRp b25Db250cm9sbGVyRGlkRGlzbWlzczpdKToNCg0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cNCmluZGV4IGE5MDZmZTRiOTY2Li4x YjM0OWJlZjlhNiAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQorKysgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KQEAgLTEsMyArMSwyMiBAQA0KKzIwMjAtMDMtMjYgIERh dmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNvbT4NCisNCisgICAgICAgIFVuYWJs ZSB0byBwcmVzZW50IGZpbGUgdXBsb2FkIHBpY2tlciBhZnRlciBpbnRlcmFjdGl2ZWx5IGRpc21p c3NpbmcgYSBwcmV2aW91c2x5IG9wZW5lZCBwaWNrZXINCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk2MTMNCisgICAgICAgIHJkYXI6Ly9wcm9ibGVt LzYwOTMxMDA5DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisg ICAgICAgIC1bPFVJRG9jdW1lbnRQaWNrZXJWaWV3Q29udHJvbGxlcj4gZG9jdW1lbnRQaWNrZXJX YXNDYW5jZWxsZWQ6XSBkb2Vzbid0IGdldCBjYWxsZWQgaWYgeW91DQorICAgICAgICBkaXNtaXNz IHRoZSB2aWV3IGNvbnRyb2xsZXIgdXNpbmcgdGhlIGludGVyYWN0aXZlIHN3aXBlIGRpc21pc3Nh bCBnZXN0dXJlIGFkZGVkIGluIGlPUyAxMy4NCisgICAgICAgIEFzIGEgcmVzdWx0LCB0aGUgd2Vi IHZpZXcgd2lsbCBjb250aW51ZSB0byB0aGluayBpdCdzIHNob3dpbmcgYSBmaWxlIHBpY2tlciBh ZnRlciBkaXNtaXNzaW5nDQorICAgICAgICBpdCB0aGlzIHdheSwgbWVhbmluZyB5b3UgY2FuJ3Qg cHJlc2VudCBhbnkgb3RoZXIgZmlsZSBwaWNrZXJzIGZyb20gdGhlIHNhbWUgd2ViIHZpZXcuIEZp eA0KKyAgICAgICAgdGhpcyBieSBpbXBsZW1lbnRpbmcgVUlBZGFwdGl2ZVByZXNlbnRhdGlvbkNv bnRyb2xsZXJEZWxlZ2F0ZSBpbiBXS0ZpbGVVcGxvYWRQYW5lbCB0byBjYW5jZWwNCisgICAgICAg IGFuZCB0ZWFyIGRvd24gdGhlIGZpbGUgcGlja2VyIG9wZXJhdGlvbiB3aGVuIHRoZSB2aWV3IGNv bnRyb2xsZXIgaXMgaW50ZXJhY3RpdmVseSBkaXNtaXNlZC4NCisNCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbToNCisgICAgICAgICgtW1dLRmlsZVVw bG9hZFBhbmVsIHNob3dGaWxlUGlja2VyTWVudV0pOg0KKyAgICAgICAgKC1bV0tGaWxlVXBsb2Fk UGFuZWwgcHJlc2VudGF0aW9uQ29udHJvbGxlckRpZERpc21pc3M6XSk6DQorDQogMjAyMC0wMy0y NiAgRGF2aWQgUXVlc2FkYSAgPGRhdmlkX3F1ZXNhZGFAYXBwbGUuY29tPg0KIA0KICAgICAgICAg QWRkIFNQSSB0byBzcGVjaWZ5IHdoZXRoZXIgZmlsZSB1cGxvYWQgcGFuZWxzIGFyZSB1cGxvYWRp bmcgdG8gYW4gZW50ZXJwcmlzZS1tYW5hZ2VkIGRlc3RpbmF0aW9uDQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tDQppbmRl eCAyZjkyYmI2ZTRhYy4uZjliZTkyYThkZmQgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0NCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQ0KQEAgLTE1MSw3ICsx NTEsNyBAQCBAZW5kDQogI3ByYWdtYSBtYXJrIC0gV0tGaWxlVXBsb2FkUGFuZWwNCiANCiANCi1A aW50ZXJmYWNlIFdLRmlsZVVwbG9hZFBhbmVsICgpIDxVSVBvcG92ZXJDb250cm9sbGVyRGVsZWdh dGUsIFVJTmF2aWdhdGlvbkNvbnRyb2xsZXJEZWxlZ2F0ZSwgVUlJbWFnZVBpY2tlckNvbnRyb2xs ZXJEZWxlZ2F0ZSwgVUlEb2N1bWVudFBpY2tlckRlbGVnYXRlDQorQGludGVyZmFjZSBXS0ZpbGVV cGxvYWRQYW5lbCAoKSA8VUlQb3BvdmVyQ29udHJvbGxlckRlbGVnYXRlLCBVSU5hdmlnYXRpb25D b250cm9sbGVyRGVsZWdhdGUsIFVJSW1hZ2VQaWNrZXJDb250cm9sbGVyRGVsZWdhdGUsIFVJRG9j dW1lbnRQaWNrZXJEZWxlZ2F0ZSwgVUlBZGFwdGl2ZVByZXNlbnRhdGlvbkNvbnRyb2xsZXJEZWxl Z2F0ZQ0KICNpZiBVU0UoVUlDT05URVhUTUVOVSkNCiAsIFVJQ29udGV4dE1lbnVJbnRlcmFjdGlv bkRlbGVnYXRlDQogI2VuZGlmDQpAQCAtNTAxLDYgKzUwMSw3IEBAIC0gKHZvaWQpc2hvd0ZpbGVQ aWNrZXJNZW51DQogICAgIF9kb2N1bWVudFBpY2tlckNvbnRyb2xsZXIgPSBhZG9wdE5TKFtbVUlE b2N1bWVudFBpY2tlclZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aERvY3VtZW50VHlwZXM6 ZG9jdW1lbnRUeXBlcyBpbk1vZGU6VUlEb2N1bWVudFBpY2tlck1vZGVJbXBvcnRdKTsNCiAgICAg W19kb2N1bWVudFBpY2tlckNvbnRyb2xsZXIgc2V0QWxsb3dzTXVsdGlwbGVTZWxlY3Rpb246X2Fs bG93TXVsdGlwbGVGaWxlc107DQogICAgIFtfZG9jdW1lbnRQaWNrZXJDb250cm9sbGVyIHNldERl bGVnYXRlOnNlbGZdOw0KKyAgICBbX2RvY3VtZW50UGlja2VyQ29udHJvbGxlciBwcmVzZW50YXRp b25Db250cm9sbGVyXS5kZWxlZ2F0ZSA9IHNlbGY7DQogICAgIGlmIChbX2RlbGVnYXRlIHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoZmlsZVVwbG9hZFBhbmVsRGVzdGluYXRpb25Jc01hbmFn ZWQ6KV0pDQogICAgICAgICBbX2RvY3VtZW50UGlja2VyQ29udHJvbGxlciBfc2V0SXNDb250ZW50 TWFuYWdlZDpbX2RlbGVnYXRlIGZpbGVVcGxvYWRQYW5lbERlc3RpbmF0aW9uSXNNYW5hZ2VkOnNl bGZdXTsNCiAgICAgW3NlbGYgX3ByZXNlbnRGdWxsc2NyZWVuVmlld0NvbnRyb2xsZXI6X2RvY3Vt ZW50UGlja2VyQ29udHJvbGxlci5nZXQoKSBhbmltYXRlZDpZRVNdOw0KQEAgLTYwOCw2ICs2MDks MTMgQEAgLSAodm9pZClfcHJlc2VudEZ1bGxzY3JlZW5WaWV3Q29udHJvbGxlcjooVUlWaWV3Q29u dHJvbGxlciAqKXZpZXdDb250cm9sbGVyIGFuaW0NCiAgICAgW19wcmVzZW50YXRpb25WaWV3Q29u dHJvbGxlciBwcmVzZW50Vmlld0NvbnRyb2xsZXI6dmlld0NvbnRyb2xsZXIgYW5pbWF0ZWQ6YW5p bWF0ZWQgY29tcGxldGlvbjpuaWxdOw0KIH0NCiANCisjcHJhZ21hIG1hcmsgLSBVSUFkYXB0aXZl UHJlc2VudGF0aW9uQ29udHJvbGxlckRlbGVnYXRlDQorDQorLSAodm9pZClwcmVzZW50YXRpb25D b250cm9sbGVyRGlkRGlzbWlzczooVUlQcmVzZW50YXRpb25Db250cm9sbGVyICopcHJlc2VudGF0 aW9uQ29udHJvbGxlcg0KK3sNCisgICAgW3NlbGYgX2NhbmNlbF07DQorfQ0KKw0KICNwcmFnbWEg bWFyayAtIFVJUG9wb3ZlckNvbnRyb2xsZXJEZWxlZ2F0ZQ0KIA0KIEFMTE9XX0RFUFJFQ0FURURf SU1QTEVNRU5UQVRJT05TX0JFR0lODQo=