209593 2020-03-26 05:46:26 -0700 [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its size when it's updated 2020-03-30 02:35:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 209591 1 cgarcia webkit-unassigned aperez bugs-noreply calvaris eric.carlson ews-watchlist glenn jer.noble philipj sergio oldest_to_newest 1634282 0 cgarcia 2020-03-26 05:46:26 -0700 This regressed in r257775 for me, because my system font doesn't use fixed width for digits. We should try to use the tabular-nums font variant if available. 1634283 1 394597 cgarcia 2020-03-26 05:50:07 -0700 Created attachment 394597 Patch 1634289 2 394597 calvaris 2020-03-26 06:06:36 -0700 Comment on attachment 394597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > -audio::-webkit-media-controls-time-remaining-display.hidden, > -video::-webkit-media-controls-time-remaining-display.hidden { Why do you remove this? 1634291 3 cgarcia 2020-03-26 06:12:52 -0700 (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 394597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394597&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > > -audio::-webkit-media-controls-time-remaining-display.hidden, > > -video::-webkit-media-controls-time-remaining-display.hidden { > > Why do you remove this? Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch. 1634304 4 394597 aperez 2020-03-26 07:02:00 -0700 Comment on attachment 394597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:203 > + font-variant-numeric: tabular-nums; OpenType Font Features 💖️ 1634342 5 394597 calvaris 2020-03-26 08:24:15 -0700 Comment on attachment 394597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review >>> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 >>> -video::-webkit-media-controls-time-remaining-display.hidden { >> >> Why do you remove this? > > Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch. I would prefer you move it to its own patch but I don't care too much, your call. 1635427 6 cgarcia 2020-03-30 02:35:12 -0700 Committed r259191: <https://trac.webkit.org/changeset/259191> 394597 2020-03-26 05:50:07 -0700 2020-03-26 08:24:15 -0700 Patch wcore-media-controls-current-time-font.diff text/plain 2042 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTNkYmE0ODBhOC4uMDNhNzBjYWY0MzggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wMy0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBSRUdSRVNTSU9OKHIyNTc3NzUpOiBNZWRp YSBjb250cm9scyBjdXJyZW50IHRpbWUgbGFiZWwgY2hhbmdlcyBpdHMgc2l6ZSB3aGVuIGl0J3Mg dXBkYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA5NTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyByZWdyZXNzZWQgaW4gcjI1Nzc3NSBmb3IgbWUsIGJlY2F1c2UgbXkgc3lzdGVtIGZvbnQg ZG9lc24ndCB1c2UgZml4ZWQgd2lkdGggZm9yIGRpZ2l0cy4gV2Ugc2hvdWxkIHRyeSB0bworICAg ICAgICB1c2UgdGhlIHRhYnVsYXItbnVtcyBmb250IHZhcmlhbnQgaWYgYXZhaWxhYmxlLgorCisg ICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmNzczoK KyAgICAgICAgKGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNw bGF5LCk6IEFkZCBmb250LXZhcmlhbnQtbnVtZXJpYzogdGFidWxhci1udW1zOworICAgICAgICAo YXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkuaGlkZGVu LCk6IFJlbW92ZSByZWZlcmVuY2VzIHRvIC13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1h aW5pbmctZGlzcGxheS4KKwogMjAyMC0wMy0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0hhcmZCdXp6XSBOb3QgYWxsIENTUyBmb250IGZl YXR1cmVzIGFyZSBhcHBsaWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0Fkd2FpdGEuY3NzIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmNzcwppbmRleCA1YmI0MTlh NTNlYi4uMzAyODdhYmJiZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzQWR3YWl0YS5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBZHdhaXRhLmNzcwpAQCAtMjAwLDYg KzIwMCw3IEBAIHZpZGVvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNw bGF5IHsKIAogICAgIGxpbmUtaGVpZ2h0OiAzMHB4OwogICAgIGZvbnQtZmFtaWx5OiAtd2Via2l0 LXN5c3RlbS1mb250OworICAgIGZvbnQtdmFyaWFudC1udW1lcmljOiB0YWJ1bGFyLW51bXM7CiAg ICAgZm9udC1zaXplOiAxM3B4OwogICAgIGZvbnQtd2VpZ2h0OiBub3JtYWw7CiAgICAgZm9udC1z dHlsZTogbm9ybWFsOwpAQCAtMjE5LDkgKzIyMCw3IEBAIHZpZGVvOjotd2Via2l0LW1lZGlhLWNv bnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5Lm5vLWR1cmF0aW9uIHsKIH0KIAogYXVkaW86Oi13 ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkuaGlkZGVuLAotdmlkZW86 Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY3VycmVudC10aW1lLWRpc3BsYXkuaGlkZGVuLAotYXVk aW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtdGltZS1yZW1haW5pbmctZGlzcGxheS5oaWRkZW4s Ci12aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5Lmhp ZGRlbiB7Cit2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jdXJyZW50LXRpbWUtZGlzcGxh eS5oaWRkZW4gewogICAgIGRpc3BsYXk6IG5vbmUgIWltcG9ydGFudDsKIH0KIAo=