209561 2020-03-25 13:55:18 -0700 Remove hitTestOrder from ElementContext as it is no longer needed 2020-03-26 16:06:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208463 1 dbates dbates cdumez esprehn+autocc ews-watchlist kangil.han webkit-bug-importer wenson_hsieh oldest_to_newest 1634039 0 dbates 2020-03-25 13:55:18 -0700 In bug #208463 I temporarily added a hit test order property to ElementContext as a holdover until <rdar://problem/59602885> is fixed. That radar has since been fixed. Let's remove the hit test order logic. 1634040 1 webkit-bug-importer 2020-03-25 13:55:28 -0700 <rdar://problem/60888305> 1634044 2 394542 dbates 2020-03-25 14:03:59 -0700 Created attachment 394542 Patch 1634045 3 394542 wenson_hsieh 2020-03-25 14:04:33 -0700 Comment on attachment 394542 Patch r=mews 1634619 4 394542 dbates 2020-03-26 16:06:35 -0700 Comment on attachment 394542 Patch Clearing flags on attachment: 394542 Committed r259089: <https://trac.webkit.org/changeset/259089> 1634620 5 dbates 2020-03-26 16:06:36 -0700 All reviewed patches have been landed. Closing bug. 394542 2020-03-25 14:03:59 -0700 2020-03-26 16:06:35 -0700 Patch bug-209561-20200325140359.patch text/plain 6637 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjhjMDkxYTg5NWZkMTJm MjI4NmU0Yjc2ODEzMDdhMTgxOTA4MzY1NS4uNTAzZjk5MjNjYmJmNmJhYmFjYzYwNDZhMzRlNWE1 NGZkMzk1YTMxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTI1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgaGl0VGVzdE9y ZGVyIGZyb20gRWxlbWVudENvbnRleHQgYXMgaXQgaXMgbm8gbG9uZ2VyIG5lZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTU2MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNjA4ODgzMDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmV2ZXJ0IHRoZSB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCBtYWRlIGlu IHIyNTc3NDkgYXMgPHJkYXI6Ly9wcm9ibGVtLzU5NjAyODg1PgorICAgICAgICBoYXMgYmVlbiBm aXhlZC4KKworICAgICAgICAqIGRvbS9FbGVtZW50Q29udGV4dC5oOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudENvbnRleHQ6OmVuY29kZSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpFbGVt ZW50Q29udGV4dDo6ZGVjb2RlKToKKwogMjAxOS0wOS0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRl c0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBidWlsZGluZyBXZWJLaXQgZm9yIE1hYyBD YXRhbHlzdCBmcm9tIFhjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZmNjViNzAwZDBkMTY1NDdlYjA1MDEzZDgw ZmVhZTIyNjU0ODRmZDMuLmU0MjAyMDIwOTAyN2E3NDQyMmEzOTczODE3YjMyNGMxNDU2ZTZlYTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDMtMjUgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBoaXRUZXN0T3JkZXIgZnJvbSBFbGVt ZW50Q29udGV4dCBhcyBpdCBpcyBubyBsb25nZXIgbmVlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NTYxCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82MDg4ODMwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZXZlcnQgdGhlIHRlbXBvcmFyeSB3b3JrYXJvdW5kIG1hZGUgaW4gcjI1Nzc0OSBhcyA8 cmRhcjovL3Byb2JsZW0vNTk2MDI4ODU+CisgICAgICAgIGhhcyBiZWVuIGZpeGVkOiBXZWJLaXQg bm8gbG9uZ2VyIG5lZWRzIHRvIGV4cGxpY2l0bHkgYW5ub3RhdGUgdGhlIHJlc3VsdGluZworICAg ICAgICBlbGVtZW50cyBmb3VuZCBpbiB0ZXh0SW5wdXRDb250ZXh0c0luUmVjdCgpIHdpdGggdGhl aXIgaGl0IHRlc3Qgb3JkZXIuCisgICAgICAgIEluc3RlYWQgY2xpZW50IGNvZGUgaGFzIGJlZW4g dXBkYXRlZCB0byBhc3N1bWUgdGhlc2UgZWxlbWVudHMgYXJlIHJldHVybmVkCisgICAgICAgIGlu IGhpdCB0ZXN0IG9yZGVyLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUZXh0 SW5wdXRDb250ZXh0Lm1tOgorICAgICAgICAoLVtfV0tUZXh0SW5wdXRDb250ZXh0IF9oaXRUZXN0 T3JkZXJdKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1RleHRJ bnB1dENvbnRleHRJbnRlcm5hbC5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6dGV4dElucHV0Q29udGV4dHNJblJl Y3QpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpjb250ZXh0Rm9yRWxlbWVudCBjb25zdCk6 CisKIDIwMjAtMDMtMjUgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIFNob3VsZCBzaG93IGlucHV0IHZpZXcgd2hlbiBiZWNhbWUgZmlyc3QgcmVzcG9u ZGVyIGlmIGtleWJvYXJkIHdhcyBzaG93aW5nIHdoZW4gdGhlIHZpZXcgd2FzIHJlc2lnbmVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudENvbnRleHQuaCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50Q29udGV4dC5oCmluZGV4IGE1MGMwZjk4MTQxYTczZjgzZGVmZmI1 NWRlYTQ5MjRjYTQzM2NiZWYuLjY4OWIwNjEwYWJlMjdjMTg2MTU5Yjk0MGI0NWMyN2UwMWIzY2Y3 NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50Q29udGV4dC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50Q29udGV4dC5oCkBAIC0zNSwxMCArMzUsNiBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiBzdHJ1Y3QgRWxlbWVudENvbnRleHQgewogICAgIEZsb2F0UmVj dCBib3VuZGluZ1JlY3Q7CiAKLSAgICAvLyBMb3dlciBvcmRpbmFsIG1lYW5zIHRoZSBlbGVtZW50 IGlzIHZpc3VhbGx5IGNsb3NlciB0byBhIHBlcnNvbidzIGZhY2UuCi0gICAgLy8gRklYTUU6IFJl bW92ZSB0aGlzIG9uY2UgPHJkYXI6Ly9wcm9ibGVtLzU5NzM3MTE4PiBpcyBmaXhlZC4KLSAgICBP cHRpb25hbDx1bnNpZ25lZD4gaGl0VGVzdE9yZGVyOwotCiAgICAgUGFnZUlkZW50aWZpZXIgd2Vi UGFnZUlkZW50aWZpZXI7CiAgICAgRG9jdW1lbnRJZGVudGlmaWVyIGRvY3VtZW50SWRlbnRpZmll cjsKICAgICBFbGVtZW50SWRlbnRpZmllciBlbGVtZW50SWRlbnRpZmllcjsKQEAgLTYyLDcgKzU4 LDYgQEAgaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBFbGVtZW50Q29udGV4dCYgYSwgY29u c3QgRWxlbWVudENvbnRleHQmIGIpCiB0ZW1wbGF0ZTxjbGFzcyBFbmNvZGVyPgogdm9pZCBFbGVt ZW50Q29udGV4dDo6ZW5jb2RlKEVuY29kZXImIGVuY29kZXIpIGNvbnN0CiB7Ci0gICAgZW5jb2Rl ciA8PCBoaXRUZXN0T3JkZXI7CiAgICAgZW5jb2RlciA8PCBib3VuZGluZ1JlY3Q7CiAgICAgZW5j b2RlciA8PCB3ZWJQYWdlSWRlbnRpZmllcjsKICAgICBlbmNvZGVyIDw8IGRvY3VtZW50SWRlbnRp ZmllcjsKQEAgLTc0LDkgKzY5LDYgQEAgT3B0aW9uYWw8RWxlbWVudENvbnRleHQ+IEVsZW1lbnRD b250ZXh0OjpkZWNvZGUoRGVjb2RlciYgZGVjb2RlcikKIHsKICAgICBFbGVtZW50Q29udGV4dCBj b250ZXh0OwogCi0gICAgaWYgKCFkZWNvZGVyLmRlY29kZShjb250ZXh0LmhpdFRlc3RPcmRlcikp Ci0gICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7Ci0KICAgICBpZiAoIWRlY29kZXIuZGVjb2Rl KGNvbnRleHQuYm91bmRpbmdSZWN0KSkKICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RleHRJbnB1 dENvbnRleHQubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGV4dElu cHV0Q29udGV4dC5tbQppbmRleCAzZmQwYjE2ZjI5NTY3ZjE3NDEwM2JhMDg1NDdmZTc3NzFkYTE3 YTRhLi43ZWI2NWQwMDA5ZmE5NzhiMzBiMTVjMmVkODdiYjA4MGU5NTlmMzMyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGV4dElucHV0Q29udGV4dC5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGV4dElucHV0Q29u dGV4dC5tbQpAQCAtNTQsMTIgKzU0LDYgQEAgLSAoQ0dSZWN0KWJvdW5kaW5nUmVjdAogICAgIHJl dHVybiBfdGV4dElucHV0Q29udGV4dC5ib3VuZGluZ1JlY3Q7CiB9CiAKLS0gKE5TVUludGVnZXIp X2hpdFRlc3RPcmRlcgotewotICAgIC8vIEFsbCBlbGVtZW50cyB0aGF0IGRvIG5vdCBoYXZlIGEg aGl0IHRlc3Qgb3JkZXIgYXJlIGNvbnNpZGVyZWQgZnJvbnRtb3N0LgotICAgIHJldHVybiBfdGV4 dElucHV0Q29udGV4dC5oaXRUZXN0T3JkZXIudmFsdWVPcigwKTsKLX0KLQogLSAoY29uc3QgV2Vi Q29yZTo6RWxlbWVudENvbnRleHQmKV90ZXh0SW5wdXRDb250ZXh0CiB7CiAgICAgcmV0dXJuIF90 ZXh0SW5wdXRDb250ZXh0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS1RleHRJbnB1dENvbnRleHRJbnRlcm5hbC5oIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0NvY29hL19XS1RleHRJbnB1dENvbnRleHRJbnRlcm5hbC5oCmluZGV4IDAyOTdh NjcxZDFmOGZhMzdmNWE5YmZmMWYxYjVlZTdhODQzZWMyNjUuLjhmNjdmYzI5ZWExOTAxOWUzODEz N2FjN2Y3NmMwOWFlZGM5YTg1YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tUZXh0SW5wdXRDb250ZXh0SW50ZXJuYWwuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGV4dElucHV0Q29udGV4dEludGVybmFsLmgKQEAg LTM1LDcgKzM1LDQgQEAgc3RydWN0IEVsZW1lbnRDb250ZXh0OwogCiAtIChjb25zdCBXZWJDb3Jl OjpFbGVtZW50Q29udGV4dCYpX3RleHRJbnB1dENvbnRleHQ7CiAKLS8vIExvd2VyIG9yZGluYWwg bWVhbnMgdGhlIGVsZW1lbnQgaXMgdmlzdWFsbHkgY2xvc2VyIHRvIGEgcGVyc29uJ3MgZmFjZS4K LUBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNVSW50ZWdlciBfaGl0VGVzdE9yZGVy OwotCiBAZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CmluZGV4IDJiY2IyMzc4NjNmODNlYzUzYWExN2Y5MmQwOWYyNTYzNWM1ZjRlMzQuLjU0NThhNTk4 NzBjY2JjNDg2YmY4ZTQ4ZDgwYzIwYTkzZmNkODkyMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC02ODQyLDcgKzY4NDIsNiBAQCB2b2lkIFdl YlBhZ2U6OnVwZGF0ZUlucHV0Q29udGV4dEFmdGVyQmx1cnJpbmdBbmRSZWZvY3VzaW5nRWxlbWVu dElmTmVlZGVkKEVsZW1lbgogCiB2b2lkIFdlYlBhZ2U6OnRleHRJbnB1dENvbnRleHRzSW5SZWN0 KFdlYkNvcmU6OkZsb2F0UmVjdCBzZWFyY2hSZWN0LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGNv bnN0IFZlY3RvcjxXZWJDb3JlOjpFbGVtZW50Q29udGV4dD4mKT4mJiBjb21wbGV0aW9uSGFuZGxl cikKIHsKLSAgICB1bnNpZ25lZCBjb3VudCA9IDE7IC8vIFplcm8gaXMgcmVzZXJ2ZWQgZm9yIF9X S1RleHRJbnB1dENvbnRleHQgb2JqZWN0cyB0aGF0IGRvIG5vdCBoYXZlIGEgaGl0IHRlc3Qgb3Jk ZXIuCiAgICAgYXV0byBjb250ZXh0cyA9IG1fcGFnZS0+ZWRpdGFibGVFbGVtZW50c0luUmVjdChz ZWFyY2hSZWN0KS5tYXAoWyZdIChjb25zdCBhdXRvJiBlbGVtZW50KSB7CiAgICAgICAgIGF1dG8m IGRvY3VtZW50ID0gZWxlbWVudC0+ZG9jdW1lbnQoKTsKIApAQCAtNjg1MSw3ICs2ODUwLDYgQEAg dm9pZCBXZWJQYWdlOjp0ZXh0SW5wdXRDb250ZXh0c0luUmVjdChXZWJDb3JlOjpGbG9hdFJlY3Qg c2VhcmNoUmVjdCwgQ29tcGxldGlvbkgKICAgICAgICAgY29udGV4dC5kb2N1bWVudElkZW50aWZp ZXIgPSBkb2N1bWVudC5pZGVudGlmaWVyKCk7CiAgICAgICAgIGNvbnRleHQuZWxlbWVudElkZW50 aWZpZXIgPSBkb2N1bWVudC5pZGVudGlmaWVyRm9yRWxlbWVudChlbGVtZW50KTsKICAgICAgICAg Y29udGV4dC5ib3VuZGluZ1JlY3QgPSBlbGVtZW50LT5jbGllbnRSZWN0KCk7Ci0gICAgICAgIGNv bnRleHQuaGl0VGVzdE9yZGVyID0gY291bnQrKzsKICAgICAgICAgcmV0dXJuIGNvbnRleHQ7CiAg ICAgfSk7CiAgICAgY29tcGxldGlvbkhhbmRsZXIoY29udGV4dHMpOwpAQCAtNjg5OSw3ICs2ODk3 LDcgQEAgT3B0aW9uYWw8V2ViQ29yZTo6RWxlbWVudENvbnRleHQ+IFdlYlBhZ2U6OmNvbnRleHRG b3JFbGVtZW50KFdlYkNvcmU6OkVsZW1lbnQmIGUKICAgICBpZiAoIWZyYW1lKQogICAgICAgICBy ZXR1cm4gV1RGOjpudWxsb3B0OwogCi0gICAgcmV0dXJuIFdlYkNvcmU6OkVsZW1lbnRDb250ZXh0 IHsgZWxlbWVudC5jbGllbnRSZWN0KCksIFdURjo6bnVsbG9wdCwgbV9pZGVudGlmaWVyLCBkb2N1 bWVudC5pZGVudGlmaWVyKCksIGRvY3VtZW50LmlkZW50aWZpZXJGb3JFbGVtZW50KGVsZW1lbnQp IH07CisgICAgcmV0dXJuIFdlYkNvcmU6OkVsZW1lbnRDb250ZXh0IHsgZWxlbWVudC5jbGllbnRS ZWN0KCksIG1faWRlbnRpZmllciwgZG9jdW1lbnQuaWRlbnRpZmllcigpLCBkb2N1bWVudC5pZGVu dGlmaWVyRm9yRWxlbWVudChlbGVtZW50KSB9OwogfQogCiB2b2lkIFdlYlBhZ2U6OnN0YXJ0VGV4 dE1hbmlwdWxhdGlvbnMoVmVjdG9yPFdlYkNvcmU6OlRleHRNYW5pcHVsYXRpb25Db250cm9sbGVy OjpFeGNsdXNpb25SdWxlPiYmIGV4Y2x1c2lvblJ1bGVzLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lk KCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCg==