209550 2020-03-25 10:34:46 -0700 [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog 2020-03-25 11:25:16 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1633939 0 aakash_jain 2020-03-25 10:34:46 -0700 commit-queue should comment on bug if it fails to find any modified ChangeLog. 1633940 1 394516 aakash_jain 2020-03-25 10:36:38 -0700 Created attachment 394516 Patch 1633956 2 394516 jbedard 2020-03-25 11:08:41 -0700 Comment on attachment 394516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2491 > + if self.getProperty('buildername', '').lower() == 'commit-queue': I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently. 1633958 3 394516 aakash_jain 2020-03-25 11:19:15 -0700 Comment on attachment 394516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:2491 >> + if self.getProperty('buildername', '').lower() == 'commit-queue': > > I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently. We can look into it, but probably not worth the effort. This is probably the last one in the series. 1633963 4 ews-feeder 2020-03-25 11:24:36 -0700 Committed r258999: <https://trac.webkit.org/changeset/258999> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394516. 1633964 5 webkit-bug-importer 2020-03-25 11:25:16 -0700 <rdar://problem/60881407> 394516 2020-03-25 10:36:38 -0700 2020-03-25 11:24:37 -0700 Patch bug-209550-20200325133637.patch text/plain 5748 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODk5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTAzLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIGNvbW1lbnQgb24gYnVnIGlm IGl0IGZhaWxzIHRvIGZpbmQgYW55IG1vZGlmaWVkIENoYW5nZUxvZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NTUwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHk6CisgICAgICAgIChGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzKTogU2V0IGhh bHRPbkZhaWx1cmUgdG8gZmFsc2UuCisgICAgICAgIChGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzLmdl dFJlc3VsdFN1bW1hcnkpOgorICAgICAgICAoRmluZE1vZGlmaWVkQ2hhbmdlTG9ncy5ldmFsdWF0 ZUNvbW1hbmQpOiBBZGQgYnVpbGQgc3RlcHMgdG8gY29tbWVudCBvbiBidWcgYW5kIHNldCBjcS0g b24gcGF0Y2ggYXBwcm9wcmlhdGVseS4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAyMC0wMy0y NSAgVGluZy1XZWkgTGFuICA8bGFudHc0NEBnbWFpbC5jb20+CiAKICAgICAgICAgW0dUS10gQWRk IHVzZXIgYWdlbnQgcXVpcmsgZm9yIGF1dGgubWF5b2hyLmNvbQpJbmRleDogVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjU4OTk0KQorKysgVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yNDY0LDcgKzI0NjQsNyBAQCBjbGFzcyBGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzKHNoZWxsLlNo ZWxsCiAgICAgbmFtZSA9ICdmaW5kLW1vZGlmaWVkLWNoYW5nZWxvZ3MnCiAgICAgZGVzY3JpcHRp b25Eb25lID0gWydGb3VuZCBtb2RpZmllZCBDaGFuZ2VMb2dzJ10KICAgICBjb21tYW5kID0gWydn aXQnLCAnZGlmZicsICctcicsICctLW5hbWUtc3RhdHVzJywgJy0tbm8tcmVuYW1lcycsICctLW5v LWV4dC1kaWZmJywgJy0tZnVsbC1pbmRleCddCi0gICAgaGFsdE9uRmFpbHVyZSA9IFRydWUKKyAg ICBoYWx0T25GYWlsdXJlID0gRmFsc2UKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJn cyk6CiAgICAgICAgIHNoZWxsLlNoZWxsQ29tbWFuZC5fX2luaXRfXyhzZWxmLCB0aW1lb3V0PTMg KiA2MCwgbG9nRW52aXJvbj1GYWxzZSwgKiprd2FyZ3MpCkBAIC0yNDc2LDcgKzI0NzYsOCBAQCBj bGFzcyBGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzKHNoZWxsLlNoZWxsCiAKICAgICBkZWYgZ2V0UmVz dWx0U3VtbWFyeShzZWxmKToKICAgICAgICAgaWYgc2VsZi5yZXN1bHRzICE9IFNVQ0NFU1M6Ci0g ICAgICAgICAgICByZXR1cm4ge3Unc3RlcCc6IHUnRmFpbGVkIHRvIGZpbmQgbGlzdCBvZiBtb2Rp ZmllZCBDaGFuZ2VMb2dzJ30KKyAgICAgICAgICAgIHBhdGNoX2lkID0gc2VsZi5nZXRQcm9wZXJ0 eSgncGF0Y2hfaWQnLCAnJykKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVwJzogdSdGYWlsZWQg dG8gZmluZCBhbnkgbW9kaWZpZWQgQ2hhbmdlTG9nIGluIFBhdGNoIHt9Jy5mb3JtYXQocGF0Y2hf aWQpfQogICAgICAgICByZXR1cm4gc2hlbGwuU2hlbGxDb21tYW5kLmdldFJlc3VsdFN1bW1hcnko c2VsZikKIAogICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKQEAgLTI0ODQsNiAr MjQ4NSwxNSBAQCBjbGFzcyBGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzKHNoZWxsLlNoZWxsCiAgICAg ICAgIGxvZ190ZXh0ID0gc2VsZi5sb2dfb2JzZXJ2ZXIuZ2V0U3Rkb3V0KCkgKyBzZWxmLmxvZ19v YnNlcnZlci5nZXRTdGRlcnIoKQogICAgICAgICBtb2RpZmllZF9jaGFuZ2Vsb2dzID0gc2VsZi5l eHRyYWN0X2NoYW5nZWxvZ3MobG9nX3RleHQsIHNlbGYuX3N0YXR1c19yZWdleHAoJ01BJykpCiAg ICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ21vZGlmaWVkX2NoYW5nZWxvZ3MnLCBtb2RpZmllZF9j aGFuZ2Vsb2dzKQorICAgICAgICBpZiByYyA9PSBGQUlMVVJFIG9yIG5vdCBtb2RpZmllZF9jaGFu Z2Vsb2dzOgorICAgICAgICAgICAgcGF0Y2hfaWQgPSBzZWxmLmdldFByb3BlcnR5KCdwYXRjaF9p ZCcsICcnKQorICAgICAgICAgICAgbWVzc2FnZSA9ICdVbmFibGUgdG8gZmluZCBhbnkgbW9kaWZp ZWQgQ2hhbmdlTG9nIGluIFBhdGNoIHt9Jy5mb3JtYXQocGF0Y2hfaWQpCisgICAgICAgICAgICBp ZiBzZWxmLmdldFByb3BlcnR5KCdidWlsZGVybmFtZScsICcnKS5sb3dlcigpID09ICdjb21taXQt cXVldWUnOgorICAgICAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1Z3ppbGxhX2NvbW1l bnRfdGV4dCcsIG1lc3NhZ2UucmVwbGFjZSgnUGF0Y2gnLCAnQXR0YWNobWVudCcpKQorICAgICAg ICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5JywgbWVzc2Fn ZSkKKyAgICAgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChb Q29tbWVudE9uQnVnKCksIFNldENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRjaCgpXSkKKyAgICAg ICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFtt ZXNzYWdlXSwgRkFJTFVSRSkKICAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgaXNfcGF0aF90 b19jaGFuZ2Vsb2coc2VsZiwgcGF0aCk6CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTg5OTQpCisr KyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTMxNDgsNiArMzE0OCw4IEBAIGNsYXNzIFRlc3RGaW5kTW9kaWZpZWRD aGFuZ2VMb2dzKEJ1aWxkU3QKIAogICAgIGRlZiB0ZXN0X21vZGlmaWVkX2NoYW5nZWxvZ3Moc2Vs Zik6CiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKEZpbmRNb2RpZmllZENoYW5nZUxvZ3MoKSkKKyAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChGaW5kTW9kaWZpZWRDaGFuZ2VMb2dzLmhhbHRPbkZhaWx1 cmUsIEZhbHNlKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdDb21t aXQtUXVldWUnKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAg ICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAogICAgICAgICAgICAgICAgICAgICAgICAg dGltZW91dD0xODAsCkBAIC0zMTYzLDYgKzMxNjUsOCBAQCBNCVRvb2xzL1Rlc3RXZWJLaXRBUEkv Q01ha2VMaXN0cy50eHQnJycpCiAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VD Q0VTUywgc3RhdGVfc3RyaW5nPSdGb3VuZCBtb2RpZmllZCBDaGFuZ2VMb2dzJykKICAgICAgICAg cmMgPSBzZWxmLnJ1blN0ZXAoKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJv cGVydHkoJ21vZGlmaWVkX2NoYW5nZWxvZ3MnKSwgWydTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cn LCAnVG9vbHMvQ2hhbmdlTG9nJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQ cm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JyksIE5vbmUpCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknKSwgTm9uZSkK ICAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9zdWNjZXNzX2FkZGVkX2NoYW5nZWxv ZyhzZWxmKToKQEAgLTMxNzksMTAgKzMxODMsMTQgQEAgTQlUb29scy9TY3JpcHRzL3J1bi1hcGkt dGVzdHMnJycpICsKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBz dGF0ZV9zdHJpbmc9J0ZvdW5kIG1vZGlmaWVkIENoYW5nZUxvZ3MnKQogICAgICAgICByYyA9IHNl bGYucnVuU3RlcCgpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgn bW9kaWZpZWRfY2hhbmdlbG9ncycpLCBbJ1Rvb2xzL1NjcmlwdHMvQ2hhbmdlTG9nJ10pCisgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90 ZXh0JyksIE5vbmUpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgn YnVpbGRfZmluaXNoX3N1bW1hcnknKSwgTm9uZSkKICAgICAgICAgcmV0dXJuIHJjCiAKICAgICBk ZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgogICAgICAgICBzZWxmLnNldHVwU3RlcChGaW5kTW9kaWZp ZWRDaGFuZ2VMb2dzKCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEy MzQnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdDb21taXQtUXVl dWUnKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhw ZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAogICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91 dD0xODAsCkBAIC0zMTkxLDggKzMxOTksMTEgQEAgTQlUb29scy9TY3JpcHRzL3J1bi1hcGktdGVz dHMnJycpICsKICAgICAgICAgICAgIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9J1Vu ZXhwZWN0ZWQgZmFpbHVyZScpICsKICAgICAgICAgICAgIDIsCiAgICAgICAgICkKLSAgICAgICAg c2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0ZhaWxlZCB0 byBmaW5kIGxpc3Qgb2YgbW9kaWZpZWQgQ2hhbmdlTG9ncycpCi0gICAgICAgIHJldHVybiBzZWxm LnJ1blN0ZXAoKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0 YXRlX3N0cmluZz0nRmFpbGVkIHRvIGZpbmQgYW55IG1vZGlmaWVkIENoYW5nZUxvZyBpbiBQYXRj aCAxMjM0JykKKyAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAoKQorICAgICAgICBzZWxmLmFzc2Vy dEVxdWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2J1Z3ppbGxhX2NvbW1lbnRfdGV4dCcpLCAnVW5hYmxl IHRvIGZpbmQgYW55IG1vZGlmaWVkIENoYW5nZUxvZyBpbiBBdHRhY2htZW50IDEyMzQnKQorICAg ICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1t YXJ5JyksICdVbmFibGUgdG8gZmluZCBhbnkgbW9kaWZpZWQgQ2hhbmdlTG9nIGluIFBhdGNoIDEy MzQnKQorICAgICAgICByZXR1cm4gcmMKIAogCiBjbGFzcyBUZXN0Q3JlYXRlTG9jYWxHSVRDb21t aXQoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToK