209543 2020-03-25 07:36:55 -0700 [ews] status-bubble should link to buildbot queue while waiting in queue 2020-03-26 09:00:56 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197520 https://bugs.webkit.org/show_bug.cgi?id=209598 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1633858 0 aakash_jain 2020-03-25 07:36:55 -0700 While a patch is waiting in queue, its ews status bubble shows position in queue, but doesn't link to anything. I would be nice if the status-bubble could link to the corresponding buildbot queue. This will allow the users to easily navigate to corresponding buildbot queue and check recent builds and pending patches in queue. 1633859 1 394493 aakash_jain 2020-03-25 07:39:55 -0700 Created attachment 394493 Patch 1633860 2 aakash_jain 2020-03-25 07:40:54 -0700 e.g.: https://ews.webkit-uat.org/status-bubble/394352/ 1633862 3 webkit-bug-importer 2020-03-25 07:41:48 -0700 <rdar://problem/60871777> 1633953 4 394493 jbedard 2020-03-25 11:04:00 -0700 Comment on attachment 394493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99 > + if self._get_parent_queue(queue): Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something. 1633954 5 394493 aakash_jain 2020-03-25 11:06:02 -0700 Comment on attachment 394493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review >> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99 >> + if self._get_parent_queue(queue): > > Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something. Yeah, it's just a local dictionary lookup. 1633955 6 ews-feeder 2020-03-25 11:08:06 -0700 Committed r258997: <https://trac.webkit.org/changeset/258997> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394493. 394493 2020-03-25 07:39:55 -0700 2020-03-25 11:08:06 -0700 Patch bug-209543-20200325103953.patch text/plain 2930 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODk3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAzLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBzdGF0dXMtYnViYmxlIHNob3VsZCBsaW5rIHRvIGJ1aWxkYm90 IHF1ZXVlIHdoaWxlIHdhaXRpbmcgaW4gcXVldWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTU0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmll d3Mvc3RhdHVzYnViYmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlLl9idWlsZF9idWJibGUp OiBMaW5rIHRvIGJ1aWxkYm90IHF1ZXVlIHdoaWwgcGF0Y2ggaXMgd2FpdGluZyBpbiBxdWV1ZS4K KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3Qu cHk6CisgICAgICAgIChCdWlsZGJvdC51cGRhdGVfaWNvbnNfZm9yX3F1ZXVlc19tYXBwaW5nKTog R2VuZXJhdGUgdGhlIG1hcHBpbmcgZm9yIHNob3J0bmFtZSB0byBmdWxsIHF1ZXVlIG5hbWUuCisK IDIwMjAtMDMtMjUgIFRpbmctV2VpIExhbiAgPGxhbnR3NDRAZ21haWwuY29tPgogCiAgICAgICAg IFtHVEtdIEFkZCB1c2VyIGFnZW50IHF1aXJrIGZvciBhdXRoLm1heW9oci5jb20KSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVp bGRib3QucHkJKHJldmlzaW9uIDI1ODk3OSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzks NyBAQCBjbGFzcyBCdWlsZGJvdCgpOgogICAgIEFMTF9SRVNVTFRTID0gbHJhbmdlKDcpCiAgICAg U1VDQ0VTUywgV0FSTklOR1MsIEZBSUxVUkUsIFNLSVBQRUQsIEVYQ0VQVElPTiwgUkVUUlksIENB TkNFTExFRCA9IEFMTF9SRVNVTFRTCiAgICAgaWNvbnNfZm9yX3F1ZXVlc19tYXBwaW5nID0ge30K KyAgICBxdWV1ZV9uYW1lX2J5X3Nob3J0bmFtZV9tYXBwaW5nID0ge30KICAgICBidWlsZGVyX25h bWVfdG9faWRfbWFwcGluZyA9IHt9CiAKICAgICBAY2xhc3NtZXRob2QKQEAgLTk2LDkgKzk3LDEy IEBAIGNsYXNzIEJ1aWxkYm90KCk6CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIHVwZGF0ZV9p Y29uc19mb3JfcXVldWVzX21hcHBpbmcoY2xzKToKICAgICAgICAgY29uZmlnID0gY2xzLmZldGNo X2NvbmZpZygpCisgICAgICAgIGlmIG5vdCBjb25maWc6CisgICAgICAgICAgICBfbG9nLndhcm4o J1VuYWJsZSB0byBmZXRjaCBidWlsZGJvdCBjb25maWcuanNvbicpCiAgICAgICAgIGZvciBidWls ZGVyIGluIGNvbmZpZy5nZXQoJ2J1aWxkZXJzJywgW10pOgogICAgICAgICAgICAgc2hvcnRuYW1l ID0gYnVpbGRlci5nZXQoJ3Nob3J0bmFtZScpCiAgICAgICAgICAgICBCdWlsZGJvdC5pY29uc19m b3JfcXVldWVzX21hcHBpbmdbc2hvcnRuYW1lXSA9IGJ1aWxkZXIuZ2V0KCdpY29uJykKKyAgICAg ICAgICAgIEJ1aWxkYm90LnF1ZXVlX25hbWVfYnlfc2hvcnRuYW1lX21hcHBpbmdbc2hvcnRuYW1l XSA9IGJ1aWxkZXIuZ2V0KCduYW1lJykKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiB1cGRh dGVfYnVpbGRlcl9uYW1lX3RvX2lkX21hcHBpbmcoY2xzKToKSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUu cHkJKHJldmlzaW9uIDI1ODk3OSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtOTYsNiArOTYsMTEg QEAgY2xhc3MgU3RhdHVzQnViYmxlKFZpZXcpOgogICAgICAgICAgICAgYnViYmxlWydxdWV1ZV9w b3NpdGlvbiddID0gcXVldWVfcG9zaXRpb24KICAgICAgICAgICAgIGlmIG5vdCBxdWV1ZV9wb3Np dGlvbjoKICAgICAgICAgICAgICAgICByZXR1cm4gTm9uZQorICAgICAgICAgICAgaWYgc2VsZi5f Z2V0X3BhcmVudF9xdWV1ZShxdWV1ZSk6CisgICAgICAgICAgICAgICAgcXVldWUgPSBzZWxmLl9n ZXRfcGFyZW50X3F1ZXVlKHF1ZXVlKQorICAgICAgICAgICAgcXVldWVfZnVsbF9uYW1lID0gQnVp bGRib3QucXVldWVfbmFtZV9ieV9zaG9ydG5hbWVfbWFwcGluZy5nZXQocXVldWUpCisgICAgICAg ICAgICBpZiBxdWV1ZV9mdWxsX25hbWU6CisgICAgICAgICAgICAgICAgYnViYmxlWyd1cmwnXSA9 ICdodHRwczovL3t9LyMvYnVpbGRlcnMve30nLmZvcm1hdChjb25maWcuQlVJTERCT1RfU0VSVkVS X0hPU1QsIHF1ZXVlX2Z1bGxfbmFtZSkKICAgICAgICAgICAgIGJ1YmJsZVsnZGV0YWlsc19tZXNz YWdlJ10gPSAnV2FpdGluZyBpbiBxdWV1ZSwgcHJvY2Vzc2luZyBoYXMgbm90IHN0YXJ0ZWQgeWV0 LlxuXG5Qb3NpdGlvbiBpbiBxdWV1ZToge30nLmZvcm1hdChxdWV1ZV9wb3NpdGlvbikKICAgICAg ICAgICAgIHJldHVybiBidWJibGUKIAo=