209522 2020-03-24 16:54:31 -0700 [Cocoa] Avoid logging sensitive information for all network sessions 2020-05-29 16:44:47 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212551 InRadar P2 Normal --- 211266 1 bfulgham bfulgham achristensen bfulgham pvollan webkit-bug-importer wilander oldest_to_newest 1633661 0 bfulgham 2020-03-24 16:54:31 -0700 We avoid logging sensitive information (such as visited URLs) on production builds and for ephemeral sessions. We should also avoid such logging for engineering and prerelease builds to reduce the possibility of personally identifiable information being retained in logs. 1633662 1 bfulgham 2020-03-24 16:56:17 -0700 <rdar://problem/54807157> 1633663 2 394442 bfulgham 2020-03-24 16:58:15 -0700 Created attachment 394442 Patch 1633759 3 bfulgham 2020-03-24 20:34:39 -0700 The Windows test case failure is not related to this Cocoa-only change. 1633935 4 ews-feeder 2020-03-25 10:27:07 -0700 Committed r258994: <https://trac.webkit.org/changeset/258994> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394442. 394442 2020-03-24 16:58:15 -0700 2020-03-25 10:27:07 -0700 Patch bug-209522-20200324165814.patch text/plain 2409 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA1MzUyYzYxMGY4Yzc3MjRl Mjc1YjJmNWNkMjY5YWZmYjgzMDc2ZGEuLjEwNDE4MGRlZDBkNzkyY2FlNjA4MzRiYzZlMTg2MDMw NWY2MGJjNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDMtMjQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgbG9nZ2luZyBzZW5z aXRpdmUgaW5mb3JtYXRpb24gZm9yIGFsbCBuZXR3b3JrIHNlc3Npb25zCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk1MjIKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzU0ODA3MTU3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlIGF2b2lkIGxvZ2dpbmcgc2Vuc2l0aXZlIGluZm9ybWF0aW9uIChzdWNo IGFzIHZpc2l0ZWQgVVJMcykgb24gcHJvZHVjdGlvbiBidWlsZHMgYW5kIGZvciBlcGhlbWVyYWwg c2Vzc2lvbnMuCisKKyAgICAgICAgV2Ugc2hvdWxkIGFsc28gYXZvaWQgc3VjaCBsb2dnaW5nIGZv ciBlbmdpbmVlcmluZyBhbmQgcHJlcmVsZWFzZSBidWlsZHMgdG8gcmVkdWNlIHRoZSBwb3NzaWJp bGl0eSBvZiBhbnkKKyAgICAgICAgcGVyc29uYWxseSBpZGVudGlmaWFibGUgaW5mb3JtYXRpb24g YmVpbmcgcmV0YWluZWQgaW4gbG9ncy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29h L05ldHdvcmtTZXNzaW9uQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OmNvbmZpZ3VyYXRpb25G b3JTZXNzaW9uSUQpOiBEZW55IHNlbnN0aXZlIGxvZ2dpbmcgZm9yIGFsbCBzZXNzaW9ucy4KKwog MjAyMC0wMy0yNCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0NvY29hXSBGaXggbGF1bmNoIHRpbWUgcmVncmVzc2lvbiB3aXRoIENGIHByZWZzIGRpcmVj dCBtb2RlIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQppbmRleCA4MmU2ZmZkMThhM2JjZDhhMTRl NGExODkwZmI1NDkyNjljOGI0MjUyLi5lODdjODY4ZjdhOTBhYzhkMmM3NmMwNzVjM2Y4N2FmNTI1 YjQ2YTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05l dHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9j b2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCkBAIC05OTQsMTUgKzk5NCwxNyBAQCBzdGF0aWMg Ym9vbCBzZXNzaW9uc0NyZWF0ZWQgPSBmYWxzZTsKIAogc3RhdGljIE5TVVJMU2Vzc2lvbkNvbmZp Z3VyYXRpb24gKmNvbmZpZ3VyYXRpb25Gb3JTZXNzaW9uSUQoY29uc3QgUEFMOjpTZXNzaW9uSUQm IHNlc3Npb24pCiB7CisgICAgTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlvbiAqY29uZmlndXJhdGlv bjsKICAgICBpZiAoc2Vzc2lvbi5pc0VwaGVtZXJhbCgpKSB7Ci0gICAgICAgIE5TVVJMU2Vzc2lv bkNvbmZpZ3VyYXRpb24gKmNvbmZpZ3VyYXRpb24gPSBbTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlv biBlcGhlbWVyYWxTZXNzaW9uQ29uZmlndXJhdGlvbl07CisgICAgICAgIGNvbmZpZ3VyYXRpb24g PSBbTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlvbiBlcGhlbWVyYWxTZXNzaW9uQ29uZmlndXJhdGlv bl07CiAgICAgICAgIGNvbmZpZ3VyYXRpb24uX3Nob3VsZFNraXBQcmVmZXJyZWRDbGllbnRDZXJ0 aWZpY2F0ZUxvb2t1cCA9IFlFUzsKKyAgICB9IGVsc2UKKyAgICAgICAgY29uZmlndXJhdGlvbiA9 IFtOU1VSTFNlc3Npb25Db25maWd1cmF0aW9uIGRlZmF1bHRTZXNzaW9uQ29uZmlndXJhdGlvbl07 CisKICNpZiBIQVZFKEFMTE9XU19TRU5TSVRJVkVfTE9HR0lORykKLSAgICAgICAgY29uZmlndXJh dGlvbi5fYWxsb3dzU2Vuc2l0aXZlTG9nZ2luZyA9IE5POworICAgIGNvbmZpZ3VyYXRpb24uX2Fs bG93c1NlbnNpdGl2ZUxvZ2dpbmcgPSBOTzsKICNlbmRpZgotICAgICAgICByZXR1cm4gY29uZmln dXJhdGlvbjsKLSAgICB9Ci0gICAgcmV0dXJuIFtOU1VSTFNlc3Npb25Db25maWd1cmF0aW9uIGRl ZmF1bHRTZXNzaW9uQ29uZmlndXJhdGlvbl07CisgICAgcmV0dXJuIGNvbmZpZ3VyYXRpb247CiB9 CiAKIGNvbnN0IFN0cmluZyYgTmV0d29ya1Nlc3Npb25Db2NvYTo6Ym91bmRJbnRlcmZhY2VJZGVu dGlmaWVyKCkgY29uc3QK