209519 2020-03-24 16:03:24 -0700 REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer() 2020-03-24 17:18:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson ews-watchlist glenn philipj sergio webkit-bug-importer oldest_to_newest 1633622 0 jer.noble 2020-03-24 16:03:24 -0700 REGRESSION(r258314): Leak in MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer() 1633626 1 jer.noble 2020-03-24 16:04:58 -0700 <rdar://problem/60609824> 1633627 2 394433 jer.noble 2020-03-24 16:05:50 -0700 Created attachment 394433 Patch 1633631 3 394433 eric.carlson 2020-03-24 16:09:42 -0700 Comment on attachment 394433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394433&action=review > Source/WebCore/ChangeLog:8 > + Obey the "create" rule and adopt the results of -copyPixelBufferForSourceTime:sourceTimeForDisplay:. Maybe `"copy" rule` would be more appropriate given the method name? 1633656 4 394440 jer.noble 2020-03-24 16:47:34 -0700 Created attachment 394440 Patch for landing 1633688 5 ews-feeder 2020-03-24 17:18:15 -0700 Committed r258962: <https://trac.webkit.org/changeset/258962> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394440. 394433 2020-03-24 16:05:50 -0700 2020-03-24 16:09:42 -0700 Patch bug-209519-20200324160550.patch text/plain 2048 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYwOTdkNDViYjhkYzQ0 ZDAwNjIxMThiOGQyMDYxMjJlOTY2OGE3Yy4uYjQ0Zjc4MGMzOWEwNmFhYTYwYzNmYWFkZWEzYTI1 N2UyNzQxNzg0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI1ODMx NCk6IExlYWsgaW4gTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjp1cGRhdGVM YXN0UGl4ZWxCdWZmZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgT2JleSB0aGUgImNyZWF0ZSIgcnVsZSBhbmQgYWRvcHQgdGhlIHJlc3VsdHMgb2Yg LWNvcHlQaXhlbEJ1ZmZlckZvclNvdXJjZVRpbWU6c291cmNlVGltZUZvckRpc3BsYXk6LgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjp1cGRhdGVMYXN0UGl4ZWxCdWZmZXIpOgorCiAy MDIwLTAzLTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFNhZmFyaSBqZXRzYW1zIHdpdGggcmVwZWF0ZWQgZHJhd0ltYWdlL2dldEltYWdlRGF0YQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCmluZGV4IDM2YjNjYjJjNGQ3ZGUyZjEzNGQ2Y2VkNGM1 NjkzMWMyYTFmZGQyMTQuLmNhOWJiYmU5ZDVjNzU2YzNlMzFiYWU5ODQ1OTM0MjU5YmZlZjA4ZWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KQEAgLTU4OCw3ICs1ODgsNyBAQCBib29sIE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6dXBkYXRlTGFzdFBpeGVsQnVmZmVy KCkKICNpZiBIQVZFKEFWU0FNUExFQlVGRkVSVklERU9PVVRQVVQpCiAgICAgaWYgKG1fdmlkZW9P dXRwdXQpIHsKICAgICAgICAgQ01UaW1lIG91dHB1dFRpbWU7Ci0gICAgICAgIGlmIChhdXRvIHBp eGVsQnVmZmVyID0gW21fdmlkZW9PdXRwdXQgY29weVBpeGVsQnVmZmVyRm9yU291cmNlVGltZTp0 b0NNVGltZShjdXJyZW50TWVkaWFUaW1lKCkpIHNvdXJjZVRpbWVGb3JEaXNwbGF5OiZvdXRwdXRU aW1lXSkgeworICAgICAgICBpZiAoYXV0byBwaXhlbEJ1ZmZlciA9IGFkb3B0Q0YoW21fdmlkZW9P dXRwdXQgY29weVBpeGVsQnVmZmVyRm9yU291cmNlVGltZTp0b0NNVGltZShjdXJyZW50TWVkaWFU aW1lKCkpIHNvdXJjZVRpbWVGb3JEaXNwbGF5OiZvdXRwdXRUaW1lXSkpIHsKICAgICAgICAgICAg IElORk9fTE9HKExPR0lERU5USUZJRVIsICJuZXcgcGl4ZWxidWZmZXIgZm91bmQgZm9yIHRpbWUg IiwgdG9NZWRpYVRpbWUob3V0cHV0VGltZSkpOwogICAgICAgICAgICAgbV9sYXN0UGl4ZWxCdWZm ZXIgPSBXVEZNb3ZlKHBpeGVsQnVmZmVyKTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwo= 394440 2020-03-24 16:47:34 -0700 2020-03-24 17:18:16 -0700 Patch for landing bug-209519-20200324164733.patch text/plain 2044 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYwOTdkNDViYjhkYzQ0 ZDAwNjIxMThiOGQyMDYxMjJlOTY2OGE3Yy4uNDE1OTk4ZGJkZmI1ZGQ0YmY1ZDg5ZjhjYjU4YzBi OTIyY2ZkNGUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTI0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI1ODMx NCk6IExlYWsgaW4gTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjp1cGRhdGVM YXN0UGl4ZWxCdWZmZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisg ICAgICAgIE9iZXkgdGhlICJjb3B5IiBydWxlIGFuZCBhZG9wdCB0aGUgcmVzdWx0cyBvZiAtY29w eVBpeGVsQnVmZmVyRm9yU291cmNlVGltZTpzb3VyY2VUaW1lRm9yRGlzcGxheTouCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVNZWRpYVNvdXJjZUFWRk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6OnVwZGF0ZUxhc3RQaXhlbEJ1ZmZlcik6CisKIDIwMjAt MDMtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg U2FmYXJpIGpldHNhbXMgd2l0aCByZXBlYXRlZCBkcmF3SW1hZ2UvZ2V0SW1hZ2VEYXRhCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0gYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVN ZWRpYVNvdXJjZUFWRk9iakMubW0KaW5kZXggMzZiM2NiMmM0ZDdkZTJmMTM0ZDZjZWQ0YzU2OTMx YzJhMWZkZDIxNC4uY2E5YmJiZTlkNWM3NTZjM2UzMWJhZTk4NDU5MzQyNTliZmVmMDhlYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJp dmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQpAQCAtNTg4LDcgKzU4OCw3IEBAIGJvb2wgTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjp1cGRhdGVMYXN0UGl4ZWxCdWZmZXIoKQog I2lmIEhBVkUoQVZTQU1QTEVCVUZGRVJWSURFT09VVFBVVCkKICAgICBpZiAobV92aWRlb091dHB1 dCkgewogICAgICAgICBDTVRpbWUgb3V0cHV0VGltZTsKLSAgICAgICAgaWYgKGF1dG8gcGl4ZWxC dWZmZXIgPSBbbV92aWRlb091dHB1dCBjb3B5UGl4ZWxCdWZmZXJGb3JTb3VyY2VUaW1lOnRvQ01U aW1lKGN1cnJlbnRNZWRpYVRpbWUoKSkgc291cmNlVGltZUZvckRpc3BsYXk6Jm91dHB1dFRpbWVd KSB7CisgICAgICAgIGlmIChhdXRvIHBpeGVsQnVmZmVyID0gYWRvcHRDRihbbV92aWRlb091dHB1 dCBjb3B5UGl4ZWxCdWZmZXJGb3JTb3VyY2VUaW1lOnRvQ01UaW1lKGN1cnJlbnRNZWRpYVRpbWUo KSkgc291cmNlVGltZUZvckRpc3BsYXk6Jm91dHB1dFRpbWVdKSkgewogICAgICAgICAgICAgSU5G T19MT0coTE9HSURFTlRJRklFUiwgIm5ldyBwaXhlbGJ1ZmZlciBmb3VuZCBmb3IgdGltZSAiLCB0 b01lZGlhVGltZShvdXRwdXRUaW1lKSk7CiAgICAgICAgICAgICBtX2xhc3RQaXhlbEJ1ZmZlciA9 IFdURk1vdmUocGl4ZWxCdWZmZXIpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7Cg==