209507 2020-03-24 15:04:56 -0700 Fix isEmpty AssemblyHelpers function and add isNotEmpty 2020-03-24 15:54:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209457 InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1633535 0 keith_miller 2020-03-24 15:04:56 -0700 Fix isEmpty AssemblyHelpers function and add isNotEmpty 1633537 1 394418 keith_miller 2020-03-24 15:06:07 -0700 Created attachment 394418 Patch 1633558 2 394418 ticaiolima 2020-03-24 15:24:29 -0700 Comment on attachment 394418 Patch LGTM as well. I tested it locally and it is passing all 189 failing tests 1633561 3 ticaiolima 2020-03-24 15:26:34 -0700 *** Bug 209505 has been marked as a duplicate of this bug. *** 1633607 4 ews-feeder 2020-03-24 15:53:09 -0700 Committed r258952: <https://trac.webkit.org/changeset/258952> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394418. 1633611 5 webkit-bug-importer 2020-03-24 15:54:14 -0700 <rdar://problem/60845969> 394418 2020-03-24 15:06:07 -0700 2020-03-24 15:53:09 -0700 Patch bug-209507-20200324150607.patch text/plain 2697 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MmI2YmJmZGIzZTg1ZTdhY2E5OTdmMzAwODhkZjBjMGY3NTg4ZjIyLi4wODMyM2ExNzY2MTA1NmJh M2Y5M2VkMTI1M2IxYzEyMTkzYzJkYzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0wMy0yNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggaXNFbXB0eSBBc3NlbWJseUhlbHBlcnMgZnVuY3Rpb24gYW5k IGFkZCBpc05vdEVtcHR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDk1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGZpeGVzIHRoZSAzMiB2ZXJzaW9uIG9mIG15IEhhc0luZGV4ZWRQcm9wZXJ0 eSBwYXRjaCBhcyB3ZWxsCisgICAgICAgIGFzIHByb3Blcmx5IG5hbWVzIHRoZSBmdW5jdGlvbnMg Zm9yIHdoYXQgdGhleSBkby4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVIYXNJbmRleGVkUHJv cGVydHkpOgorICAgICAgICAqIGppdC9Bc3NlbWJseUhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6 QXNzZW1ibHlIZWxwZXJzOjppc0VtcHR5KToKKyAgICAgICAgKEpTQzo6QXNzZW1ibHlIZWxwZXJz Ojppc05vdEVtcHR5KToKKwogMjAyMC0wMy0yMyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVy QGFwcGxlLmNvbT4KIAogICAgICAgICBIYXNJbmRleGVkUHJvcGVydHkgc2hvdWxkIGtub3cgYWJv dXQgc2FuZSBjaGFpbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklULmNwcAppbmRleCBjMjU2MjUyYTNjMjhhZDA2MjgxZGVjMjYwNWUxY2VmYWNmYWVhNGMy Li42ODM3YjAwZmU2MzZlOTNmNmU5ZTIxMmE3NzZmM2E2YTM1ZTRhYjBmIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcApAQCAtMTM1OTMsNyAr MTM1OTMsNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlSGFzSW5kZXhlZFByb3BlcnR5 KE5vZGUqIG5vZGUpCiAjZW5kaWYKIAogICAgICAgICBpZiAobW9kZS5pc1NhbmVDaGFpbigpKSB7 Ci0gICAgICAgICAgICBtX2ppdC5pc0VtcHR5KHNjcmF0Y2hHUFIsIHJlc3VsdEdQUik7CisgICAg ICAgICAgICBtX2ppdC5pc05vdEVtcHR5KHNjcmF0Y2hHUFIsIHJlc3VsdEdQUik7CiAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgfQogCkBAIC0xMzY1NSw3ICsxMzY1NSw3IEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGVIYXNJbmRleGVkUHJvcGVydHkoTm9kZSogbm9kZSkKICNlbmRp ZgogCiAgICAgICAgIGlmIChtb2RlLmlzU2FuZUNoYWluKCkpIHsKLSAgICAgICAgICAgIG1faml0 LmlzRW1wdHkoc2NyYXRjaEdQUiwgcmVzdWx0R1BSKTsKKyAgICAgICAgICAgIG1faml0LmlzTm90 RW1wdHkoc2NyYXRjaEdQUiwgcmVzdWx0R1BSKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlIZWxw ZXJzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2VtYmx5SGVscGVycy5oCmluZGV4 IGE5MjYyOTFmNWU3OTNmOTZkZjYzNmMyN2NlM2IxOTM0YTFiMTY4MWEuLjcwZjVkZDQ4MWYxNmRm MTZhYmRkMzIzYmI0NjRiNTcwMjY0ZGIzYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9Bc3NlbWJseUhlbHBlcnMuaApAQCAtOTY0LDEyICs5NjQsMjEgQEAgcHVibGljOgogICAgIHZv aWQgaXNFbXB0eShHUFJSZWcgZ3ByLCBHUFJSZWcgZHN0KQogICAgIHsKICNpZiBVU0UoSlNWQUxV RTY0KQotICAgICAgICB0ZXN0NjQoTm9uWmVybywgZ3ByLCBUcnVzdGVkSW1tMzIoLTEpLCBkc3Qp OworICAgICAgICB0ZXN0NjQoWmVybywgZ3ByLCBncHIsIGRzdCk7CiAjZWxzZQogICAgICAgICBj b21wYXJlMzIoRXF1YWwsIGdwciwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkVtcHR5VmFsdWVUYWcp LCBkc3QpOwogI2VuZGlmCiAgICAgfQogCisgICAgdm9pZCBpc05vdEVtcHR5KEdQUlJlZyBncHIs IEdQUlJlZyBkc3QpCisgICAgeworI2lmIFVTRShKU1ZBTFVFNjQpCisgICAgICAgIHRlc3Q2NChO b25aZXJvLCBncHIsIGdwciwgZHN0KTsKKyNlbHNlCisgICAgICAgIGNvbXBhcmUzMihOb3RFcXVh bCwgZ3ByLCBUcnVzdGVkSW1tMzIoSlNWYWx1ZTo6RW1wdHlWYWx1ZVRhZyksIGRzdCk7CisjZW5k aWYKKyAgICB9CisKICAgICBKdW1wIGJyYW5jaElmRW1wdHkoR1BSUmVnIGdwcikKICAgICB7CiAj aWYgVVNFKEpTVkFMVUU2NCkK