209506 2020-03-24 15:03:35 -0700 requestDocumentEditingContext() should bail out if the focused frame does not have a view 2024-03-11 17:26:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 13 ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=209493 InRadar P2 Normal --- 1 dbates dbates achristensen ahmad.saleem792 darin webkit-bug-importer oldest_to_newest 1633530 0 dbates 2020-03-24 15:03:35 -0700 requestDocumentEditingContext() performs a layout, which can do anything, including document destruction. Ensure that the focused frame has a view before computing the editing context. 1633531 1 webkit-bug-importer 2020-03-24 15:03:45 -0700 <rdar://problem/60843660> 1633538 2 394419 dbates 2020-03-24 15:07:03 -0700 Created attachment 394419 Patch 1633630 3 394419 darin 2020-03-24 16:09:35 -0700 Comment on attachment 394419 Patch Why no test case? 1633648 4 dbates 2020-03-24 16:36:56 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 394419 [details] > Patch > > Why no test case? It is hard to write one. I don't even know how to write such a test. I mean, here's what I need to do: 1. Write a test that will run JavaScript on layout (so, probably need a resize observer) that performs a synchronous navigation. 2. Write an API test that loads that page, get the page into a state where layout is needed, but **not** performed, then call -requestDocumentContext: (again, hoping that layout timer has not run before message gets to web process; otherwise, need to disable that). Then -requestDocumentContext will message to requestDocumentEditingContext(), which will update layout => triggers navigation => view destroyed and the test will crash without the patch and not crash with it. 1633649 5 dbates 2020-03-24 16:37:34 -0700 If there is an easier way to write a test I am all ears 1633676 6 darin 2020-03-24 17:10:08 -0700 That sounds like the right way to write the test. We should really write it. Otherwise we are just making code changes and crossing our fingers. 2020295 7 ahmad.saleem792 2024-03-11 17:26:44 -0700 This patch was modifying: https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm#4935 Which is: RefPtr frame = m_page->checkedFocusController()->focusedOrMainFrame(); if (!frame) return completionHandler({ }); __ So I think 275171@main addressed this in bug 269761 and rdar://116201648. @Alex - above commit was from your side, do you think we need to do anything more here or we can tag this as 'Duplicate' to above bug? 394419 2020-03-24 15:07:03 -0700 2020-03-24 15:07:03 -0700 Patch bug-209506-20200324150702.patch text/plain 1894 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4ODAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZkYWQyYjk5NDk4ZmVhMDRh ZDkyOGY0MDU4ODBlZWZiNGY4NmQ4YWEuLmQ0MmE2YWVlZjQ5YzE0YTUyY2I4ZTk3YWZkOTIyZTVi OGVjMzdlODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDMtMjQgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIHJlcXVlc3REb2N1bWVudEVkaXRp bmdDb250ZXh0KCkgc2hvdWxkIGJhaWwgb3V0IGlmIHRoZSBmb2N1c2VkIGZyYW1lIGRvZXMgbm90 IGhhdmUgYSB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDk1MDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwODQzNjYwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZSB0aGF0IHRoZSBm b2N1c2VkIGZyYW1lIGhhcyBhIHZpZXcgYmVmb3JlIHByb2NlZWRpbmcgYW5kIGNvbXB1dGluZyB0 aGUgZWRpdGluZworICAgICAgICBjb250ZXh0IGFzIHN1Y2ggc3RhdGUgaXMgbm8gbG9uZ2VyIG1l YW5pbmdmdWwgdG8gYSBjYWxsZXIuIFRoZSBmb2N1c2VkIGZyYW1lIG1heSBiZQorICAgICAgICBk ZXRhY2hlZCBmcm9tIGl0cyB2aWV3IGFzIGEgcmVzdWx0IG9mIHVwZGF0aW5nIGxheW91dCwgd2hp Y2ggY2FuIGNhdXNlIGFyYml0cmFyeQorICAgICAgICBKYXZhU2NyaXB0IGV4ZWN1dGlvbiwgdGhh dCBjYW4gZG8gYW55dGhpbmcuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnJlcXVlc3REb2N1bWVudEVk aXRpbmdDb250ZXh0KToKKwogMjAyMC0wMy0yNCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgVXNlIFNpbXBsZVJhbmdlIGluIGNoYXJhY3RlclJlY3RzRm9yUmFu Z2UoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFn ZUlPUy5tbQppbmRleCA2YTY1ZWE4NjIxZDhjNGZhNGJkNmRlZDZkMjcyMTVmYjU3NjRmZGEzLi41 MjIyMjVjNDJhZWUzYTAzNTZmMzg0Zjg5OTc1NTFjNDI5ZjM4OWE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtNDExOSw2 ICs0MTE5LDExIEBAIHZvaWQgV2ViUGFnZTo6cmVxdWVzdERvY3VtZW50RWRpdGluZ0NvbnRleHQo RG9jdW1lbnRFZGl0aW5nQ29udGV4dFJlcXVlc3QgcmVxdWVzCiAgICAgbV9wYWdlLT5mb2N1c0Nv bnRyb2xsZXIoKS5mb2N1c2VkT3JNYWluRnJhbWUoKS5kb2N1bWVudCgpLT51cGRhdGVMYXlvdXRJ Z25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKIAogICAgIFJlZjxGcmFtZT4gZnJhbWUgPSBtX3Bh Z2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIGlmICghZnJh bWUtPnZpZXcoKSkgeworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0pOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgVmlzaWJsZVNlbGVjdGlvbiBzZWxlY3Rpb24gPSBmcmFtZS0+ c2VsZWN0aW9uKCkuc2VsZWN0aW9uKCk7CiAKICAgICBWaXNpYmxlUG9zaXRpb24gcmFuZ2VPZklu dGVyZXN0U3RhcnQ7Cg==