209484 2020-03-24 10:38:34 -0700 Add user agent quirk for Red Hat Bugzilla 2020-03-30 10:12:05 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply calvaris mcatanzaro oldest_to_newest 1633379 0 mcatanzaro 2020-03-24 10:38:34 -0700 Red Hat Bugzilla displays a warning page when performing searches unless we use a Firefox or Google user agent quirk. I've contacted the developers and they do not want to stop abusing the user agent header for this purpose, so let's do the usual. 1633380 1 394381 mcatanzaro 2020-03-24 10:42:37 -0700 Created attachment 394381 Patch 1633674 2 394381 aperez 2020-03-24 17:08:14 -0700 Comment on attachment 394381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394381&action=review > Source/WebCore/platform/UserAgentQuirks.cpp:98 > + if (domain == "bugzilla.redhat.com") I find it a bit odd that a particular instance of Bugzilla needs a quirk, and others do not need it ¯\_(ツ)_/¯ 1633781 3 ap 2020-03-24 22:30:17 -0700 This file looks like it's cross-platform, and so do function names. But this function is only used by WebCore/platform/glib/UserAgentGLib.cpp. 1633847 4 mcatanzaro 2020-03-25 06:56:56 -0700 We do occasionally have mostly cross-platform files that don't make sense on one particular platform. The quirks are separated from UserAgentGLib.cpp because they are intended to be entirely cross-platform. It's pretty likely that any websites causing problems for GLib ports will also be causing the same problems for Windows and PlayStation as well, for instance. I would recommend these quirks to any non-Apple port. If it would help avoid confusion, we could guard the whole thing with #if !PLATFORM(COCOA). (In reply to Adrian Perez from comment #2) > I find it a bit odd that a particular instance of Bugzilla > needs a quirk, and others do not need it ¯\_(ツ)_/¯ I see you haven't spent much time on Red Hat Bugzilla. :P It's really its own thing. 1635563 5 ews-feeder 2020-03-30 10:12:04 -0700 Committed r259204: <https://trac.webkit.org/changeset/259204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394381. 394381 2020-03-24 10:42:37 -0700 2020-03-30 10:12:04 -0700 Patch bug-209484-20200324124236.patch text/plain 2949 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYwOTdkNDViYjhkYzQ0 ZDAwNjIxMThiOGQyMDYxMjJlOTY2OGE3Yy4uZWE5YWYyYTM4NjA1ZTkxZmQ0ZTNiY2RkNmE0MmNm NDk0YTMwNDVjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTI0ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIEFkZCB1c2Vy IGFnZW50IHF1aXJrIGZvciBSZWQgSGF0IEJ1Z3ppbGxhCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk0ODQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWQgSGF0IEJ1Z3ppbGxhIGRpc3BsYXlzIGEgd2Fy bmluZyBwYWdlIHdoZW4gcGVyZm9ybWluZyBzZWFyY2hlcyB3aXRoIFdlYktpdEdUSydzIHN0YW5k YXJkCisgICAgICAgIHVzZXIgYWdlbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Vc2VyQWdlbnRR dWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXJsUmVxdWlyZXNGaXJlZm94QnJvd3Nlcik6 CisKIDIwMjAtMDMtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgU2FmYXJpIGpldHNhbXMgd2l0aCByZXBlYXRlZCBkcmF3SW1hZ2UvZ2V0SW1hZ2VE YXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3Mu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAppbmRleCBj ZjE5MzMxMjM0MjUyMDcxZjYwMTkzNjg2YmM0YTgxNmNlMmEyZmMyLi5mNWNiMTBkMzIxNGEwMGIz ODJiMmNkZDM1MDg0MWY2Njc1YjI5Zjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Vz ZXJBZ2VudFF1aXJrcy5jcHAKQEAgLTkzLDYgKzkzLDExIEBAIHN0YXRpYyBib29sIHVybFJlcXVp cmVzRmlyZWZveEJyb3dzZXIoY29uc3QgVVJMJiB1cmwpCiAgICAgaWYgKGRvbWFpbiA9PSAiZHJp dmUuZ29vZ2xlLmNvbSIpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgLy8gUmVkIEhhdCBC dWd6aWxsYSBkaXNwbGF5cyBhIHdhcm5pbmcgcGFnZSB3aGVuIHBlcmZvcm1pbmcgc2VhcmNoZXMg d2l0aCBXZWJLaXRHVEsncyBzdGFuZGFyZAorICAgIC8vIHVzZXIgYWdlbnQuCisgICAgaWYgKGRv bWFpbiA9PSAiYnVnemlsbGEucmVkaGF0LmNvbSIpCisgICAgICAgIHJldHVybiB0cnVlOworCiAg ICAgcmV0dXJuIGZhbHNlOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggYWViM2Y4YTBmMzQ2ZTZkZjI2YTFjZGRiMTQ2ZGQ2MGQ0M2U3Yzdm ZS4uOGU3NzBmMDU0MThjM2U5MWY1MDliNjk0OWQ0OTljMDVhZjlmMGMyOSAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy MDIwLTAzLTI0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisg ICAgICAgIEFkZCB1c2VyIGFnZW50IHF1aXJrIGZvciBSZWQgSGF0IEJ1Z3ppbGxhCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk0ODQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQ STo6VEVTVCk6CisKIDIwMjAtMDMtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgW21hYy13azFdIGZhc3Qvc2Nyb2xsaW5nL2Fycm93LWtleS1zY3Jv bGwtaW4tcnRsLWRvY3VtZW50Lmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0CmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcCBiL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCmluZGV4 IDRlNzk3YjY2ZGZmOTg0MmVhYmVlMWZhZDU0NTIzYTUzNTFjMDAxODYuLjc0NDAzZmJjY2U4Y2Vl ZTkxOTlkNzJhYTEyNTQ0NjQwNjE4N2JjNjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwCkBAIC05NCw2ICs5NCw3IEBA IFRFU1QoVXNlckFnZW50VGVzdCwgUXVpcmtzKQogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhh c0ZpcmVmb3hCcm93c2VyUXVpcmsoImh0dHA6Ly9hY2NvdW50cy55b3V0dWJlLmNvbS8iKTsKICAg ICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNGaXJlZm94QnJvd3NlclF1aXJrKCJodHRwOi8vZG9j cy5nb29nbGUuY29tLyIpOwogICAgIGFzc2VydFVzZXJBZ2VudEZvclVSTEhhc0ZpcmVmb3hCcm93 c2VyUXVpcmsoImh0dHA6Ly9kcml2ZS5nb29nbGUuY29tLyIpOworICAgIGFzc2VydFVzZXJBZ2Vu dEZvclVSTEhhc0ZpcmVmb3hCcm93c2VyUXVpcmsoImh0dHA6Ly9idWd6aWxsYS5yZWRoYXQuY29t LyIpOwogCiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGludXhQbGF0Zm9ybVF1aXJrKCJo dHRwOi8vd3d3Lmdvb2dsZS5jb20vIik7CiAgICAgYXNzZXJ0VXNlckFnZW50Rm9yVVJMSGFzTGlu dXhQbGF0Zm9ybVF1aXJrKCJodHRwOi8vd3d3Lmdvb2dsZS5lcy8iKTsK