209478 2020-03-24 08:14:20 -0700 [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working 2020-03-24 08:47:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clord clord aperez clopez mcatanzaro pnormand webkit-bug-importer oldest_to_newest 1633306 0 clord 2020-03-24 08:14:20 -0700 This was caused by the switch to Flatpak dependencies, which now sandboxes the environment. These variables need to be white-listed. 1633308 1 394367 clord 2020-03-24 08:19:24 -0700 Created attachment 394367 Patch 1633309 2 394367 pnormand 2020-03-24 08:22:21 -0700 Comment on attachment 394367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394367&action=review > Tools/ChangeLog:6 > + Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox. An alternative could have been to add this to `env_var_suffixes_to_keep` but I'm also OK with this approach. Explicit is better than implicit usually :) 1633311 3 394367 clord 2020-03-24 08:25:26 -0700 Comment on attachment 394367 Patch I agree with explicit being better (though maybe I'll disagree when this comes back and bites us again ;)) so leaving as is. It would be good if these variables had 'WEBKIT' somewhere in them I think, if we were going to whitelist the suffix. 1633316 4 pnormand 2020-03-24 08:37:46 -0700 Yeah, or a WEBKIT_ prefix :) 1633318 5 ews-feeder 2020-03-24 08:46:52 -0700 Committed r258910: <https://trac.webkit.org/changeset/258910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394367. 1633319 6 webkit-bug-importer 2020-03-24 08:47:14 -0700 <rdar://problem/60826356> 394367 2020-03-24 08:19:24 -0700 2020-03-24 08:46:52 -0700 Patch bug-209478-20200324151923.patch text/plain 1433 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4ODMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJhNWE5NmFiMGZhMWJiNzM5YzUzN2RlZDkwMmE4NjJh NTJlYjRhNi4uNmU4ZGIwYWQ3YTZiMmUxYzNiMzBiZGRiZDVhMWY3ZDBlNmViZDczNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAzLTI0ICBDaHJpcyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXVtXUEVdIFdFQl9QUk9DRVNTX0NNRF9QUkVGSVggYW5kIG90aGVycyBoYXZlIHN0b3Bw ZWQgd29ya2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA5NDc4CisKKyAgICAgICAgTWFrZSBzdXJlICpfUFJPQ0VTU19DTURfUFJFRklYIHZhcmlh YmxlcyBhcmUgd2hpdGVsaXN0ZWQgaW4gdGhlIEZsYXRwYWsgc2FuZGJveC4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZsYXRwYWsvZmxhdHBha3V0 aWxzLnB5OgorICAgICAgICAoV2Via2l0RmxhdHBhay5ydW5faW5fc2FuZGJveCk6CisKIDIwMjAt MDMtMjMgIENocmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIEFkZCBtaXNz aW5nIGNvbW1pdHRlciBzdGF0dXMgdG8gQ2hyaXMgTG9yZCBpbiBjb250cmlidXRvcnMuanNvbgpk aWZmIC0tZ2l0IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkgYi9Ub29scy9mbGF0cGFr L2ZsYXRwYWt1dGlscy5weQppbmRleCBmNWNmYzk2NjhjNzBmNWNiNjBiZDNkOGE5M2YxZGZmYWY5 NjUxY2I2Li5lNzhkNWI2MThkZTdiNGQ2NTNiMzFjYTM0ZjRkMzRlN2QxYjcyZmRiIDEwMDY0NAot LS0gYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQorKysgYi9Ub29scy9mbGF0cGFrL2Zs YXRwYWt1dGlscy5weQpAQCAtNjQzLDEwICs2NDMsMTQgQEAgY2xhc3MgV2Via2l0RmxhdHBhazoK ICAgICAgICAgICAgICJMQU5HIiwKICAgICAgICAgICAgICJMREZMQUdTIiwKICAgICAgICAgICAg ICJNYWxsb2MiLAorICAgICAgICAgICAgIkdQVV9QUk9DRVNTX0NNRF9QUkVGSVgiLAorICAgICAg ICAgICAgIk5FVFdPUktfUFJPQ0VTU19DTURfUFJFRklYIiwKICAgICAgICAgICAgICJOVU1CRVJf T0ZfUFJPQ0VTU09SUyIsCisgICAgICAgICAgICAiUExVR0lOX1BST0NFU1NfQ01EX1BSRUZJWCIs CiAgICAgICAgICAgICAiUU1MMl9JTVBPUlRfUEFUSCIsCiAgICAgICAgICAgICAiV0FZTEFORF9E SVNQTEFZIiwKICAgICAgICAgICAgICJXQVlMQU5EX1NPQ0tFVCIsCisgICAgICAgICAgICAiV0VC X1BST0NFU1NfQ01EX1BSRUZJWCIKICAgICAgICAgXQogCiAgICAgICAgIGVudl92YXJzID0gb3Mu ZW52aXJvbgo=