<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>209444</bug_id>
          
          <creation_ts>2020-03-23 15:48:19 -0700</creation_ts>
          <short_desc>Add console message when legacy TLS is used</short_desc>
          <delta_ts>2020-03-24 16:34:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>cdumez</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>japhet</cc>
    
    <cc>mkwst</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1633081</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 15:48:19 -0700</bug_when>
    <thetext>Add console message when legacy TLS is used</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633082</commentid>
    <comment_count>1</comment_count>
      <attachid>394314</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 15:48:44 -0700</bug_when>
    <thetext>Created attachment 394314
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633089</commentid>
    <comment_count>2</comment_count>
      <attachid>394314</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-03-23 15:56:57 -0700</bug_when>
    <thetext>Comment on attachment 394314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394314&amp;action=review

&gt; Source/WebCore/loader/ResourceLoader.cpp:511
&gt;                  document-&gt;setUsedLegacyTLS(true);

Could have put that inside the braces.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633117</commentid>
    <comment_count>3</comment_count>
      <attachid>394320</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 16:22:20 -0700</bug_when>
    <thetext>Created attachment 394320
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633119</commentid>
    <comment_count>4</comment_count>
      <attachid>394320</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 16:23:03 -0700</bug_when>
    <thetext>Comment on attachment 394320
Patch

Done.  I also removed the host from the logs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633120</commentid>
    <comment_count>5</comment_count>
      <attachid>394320</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-03-23 16:23:40 -0700</bug_when>
    <thetext>Comment on attachment 394320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394320&amp;action=review

&gt; Source/WebCore/loader/ResourceLoader.cpp:509
&gt; +                        page-&gt;console().addMessage(MessageSource::Network, MessageLevel::Warning, &quot;Loaded resource using TLS 1.0 or 1.1, which are deprecated protocols that will be removed.  Please use TLS 1.2 or newer instead.&quot;_s, 0, document);

Two spaces after a period!? Not sure what our style is, but I never do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633121</commentid>
    <comment_count>6</comment_count>
      <attachid>394321</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 16:24:20 -0700</bug_when>
    <thetext>Created attachment 394321
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633124</commentid>
    <comment_count>7</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-23 16:26:40 -0700</bug_when>
    <thetext>Our style doesn&apos;t seem to care.  I&apos;ve done it consistently since elementary school unless told otherwise, but I removed it here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633142</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-03-23 17:06:35 -0700</bug_when>
    <thetext>Committed r258890: &lt;https://trac.webkit.org/changeset/258890&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394321.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633143</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-03-23 17:09:06 -0700</bug_when>
    <thetext>&lt;rdar://problem/60800462&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633144</commentid>
    <comment_count>10</comment_count>
      <attachid>394321</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-03-23 17:09:29 -0700</bug_when>
    <thetext>Comment on attachment 394321
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394321&amp;action=review

&gt; Source/WebCore/loader/ResourceLoader.cpp:505
&gt;      if (r.usedLegacyTLS()) {
&gt;          if (m_frame) {

Just noticed we could indent this a little bit less by using &amp;&amp; here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633367</commentid>
    <comment_count>11</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-24 09:56:57 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633368</commentid>
    <comment_count>12</comment_count>
      <attachid>394380</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-03-24 09:56:58 -0700</bug_when>
    <thetext>Created attachment 394380
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633372</commentid>
    <comment_count>13</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-03-24 10:20:36 -0700</bug_when>
    <thetext>commit-queue failed to commit attachment 394380 to WebKit repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633454</commentid>
    <comment_count>14</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-03-24 13:36:08 -0700</bug_when>
    <thetext>(In reply to EWS from comment #13)
&gt; commit-queue failed to commit attachment 394380 [details] to WebKit repository.
There was another commit (modifying same ChangeLog) https://trac.webkit.org/r258916 almost at the same time when commit-queue tried to land this. Please cq+ again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633645</commentid>
    <comment_count>15</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-03-24 16:34:04 -0700</bug_when>
    <thetext>Committed r258957: &lt;https://trac.webkit.org/changeset/258957&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394380.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394314</attachid>
            <date>2020-03-23 15:48:44 -0700</date>
            <delta_ts>2020-03-23 16:22:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-209444-20200323154843.patch</filename>
            <type>text/plain</type>
            <size>1792</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODg4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIzICBBbGV4IENo
cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGNvbnNv
bGUgbWVzc2FnZSB3aGVuIGxlZ2FjeSBUTFMgaXMgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisK
IDIwMjAtMDMtMjQgIEphbWVzIERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hyb21pdW0ub3JnPgog
CiAgICAgICAgIFNldCBpbXBvcnRhbnQgRUdMIGNvbnRleHQgYXR0cmlidXRlcwpJbmRleDogU291
cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAyNTg2ODApCisr
KyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSAiTG9hZGVyU3RyYXRlZ3kuaCIKICNpbmNsdWRl
ICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlBhZ2VDb25zb2xlQ2xp
ZW50LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJhdGVnaWVzLmgiCiAjaW5jbHVkZSAiUHJvZ3Jl
c3NUcmFja2VyLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJvci5oIgpAQCAtNTAyLDggKzUwMywx
MyBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoCiAKICAgICBpZiAo
ci51c2VkTGVnYWN5VExTKCkpIHsKICAgICAgICAgaWYgKG1fZnJhbWUpIHsKLSAgICAgICAgICAg
IGlmIChhdXRvKiBkb2N1bWVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCkpCisgICAgICAgICAgICBp
ZiAoYXV0byogZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CisgICAgICAgICAgICAg
ICAgaWYgKCFkb2N1bWVudC0+dXNlZExlZ2FjeVRMUygpKSB7CisgICAgICAgICAgICAgICAgICAg
IGlmIChhdXRvKiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkKKyAgICAgICAgICAgICAgICAgICAg
ICAgIHBhZ2UtPmNvbnNvbGUoKS5hZGRNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6Ok5ldHdvcmssIE1l
c3NhZ2VMZXZlbDo6V2FybmluZywgbWFrZVN0cmluZygiTG9hZGVkIHJlc291cmNlIGZyb20gIiwg
ci51cmwoKS5ob3N0KCksICIgdXNpbmcgVExTIDEuMCBvciAxLjEsIHdoaWNoIGFyZSBkZXByZWNh
dGVkIHByb3RvY29scyB0aGF0IHdpbGwgYmUgcmVtb3ZlZC4gIFBsZWFzZSB1c2UgVExTIDEuMiBv
ciBuZXdlciBpbnN0ZWFkLiIpLCAwLCBkb2N1bWVudCk7CisgICAgICAgICAgICAgICAgfQogICAg
ICAgICAgICAgICAgIGRvY3VtZW50LT5zZXRVc2VkTGVnYWN5VExTKHRydWUpOworICAgICAgICAg
ICAgfQogICAgICAgICB9CiAgICAgfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394320</attachid>
            <date>2020-03-23 16:22:20 -0700</date>
            <delta_ts>2020-03-23 16:24:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-209444-20200323162220.patch</filename>
            <type>text/plain</type>
            <size>1808</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODg4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIzICBBbGV4IENo
cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGNvbnNv
bGUgbWVzc2FnZSB3aGVuIGxlZ2FjeSBUTFMgaXMgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisKIDIw
MjAtMDMtMjQgIEphbWVzIERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hyb21pdW0ub3JnPgogCiAg
ICAgICAgIFNldCBpbXBvcnRhbnQgRUdMIGNvbnRleHQgYXR0cmlidXRlcwpJbmRleDogU291cmNl
L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAyNTg2ODApCisrKyBT
b3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSAiTG9hZGVyU3RyYXRlZ3kuaCIKICNpbmNsdWRlICJM
b2dnaW5nLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlBhZ2VDb25zb2xlQ2xpZW50
LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJhdGVnaWVzLmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NU
cmFja2VyLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJvci5oIgpAQCAtNTAyLDggKzUwMywxMyBA
QCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoCiAKICAgICBpZiAoci51
c2VkTGVnYWN5VExTKCkpIHsKICAgICAgICAgaWYgKG1fZnJhbWUpIHsKLSAgICAgICAgICAgIGlm
IChhdXRvKiBkb2N1bWVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCkpCi0gICAgICAgICAgICAgICAg
ZG9jdW1lbnQtPnNldFVzZWRMZWdhY3lUTFModHJ1ZSk7CisgICAgICAgICAgICBpZiAoYXV0byog
ZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CisgICAgICAgICAgICAgICAgaWYgKCFk
b2N1bWVudC0+dXNlZExlZ2FjeVRMUygpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChhdXRv
KiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHBhZ2Ut
PmNvbnNvbGUoKS5hZGRNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6Ok5ldHdvcmssIE1lc3NhZ2VMZXZl
bDo6V2FybmluZywgIkxvYWRlZCByZXNvdXJjZSB1c2luZyBUTFMgMS4wIG9yIDEuMSwgd2hpY2gg
YXJlIGRlcHJlY2F0ZWQgcHJvdG9jb2xzIHRoYXQgd2lsbCBiZSByZW1vdmVkLiAgUGxlYXNlIHVz
ZSBUTFMgMS4yIG9yIG5ld2VyIGluc3RlYWQuIl9zLCAwLCBkb2N1bWVudCk7CisgICAgICAgICAg
ICAgICAgICAgIGRvY3VtZW50LT5zZXRVc2VkTGVnYWN5VExTKHRydWUpOworICAgICAgICAgICAg
ICAgIH0KKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394321</attachid>
            <date>2020-03-23 16:24:20 -0700</date>
            <delta_ts>2020-03-24 09:56:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-209444-20200323162419.patch</filename>
            <type>text/plain</type>
            <size>1807</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODg4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIzICBBbGV4IENo
cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGNvbnNv
bGUgbWVzc2FnZSB3aGVuIGxlZ2FjeSBUTFMgaXMgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisKIDIw
MjAtMDMtMjQgIEphbWVzIERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hyb21pdW0ub3JnPgogCiAg
ICAgICAgIFNldCBpbXBvcnRhbnQgRUdMIGNvbnRleHQgYXR0cmlidXRlcwpJbmRleDogU291cmNl
L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAyNTg2ODApCisrKyBT
b3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC00NSw2ICs0NSw3IEBACiAjaW5jbHVkZSAiTG9hZGVyU3RyYXRlZ3kuaCIKICNpbmNsdWRlICJM
b2dnaW5nLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIlBhZ2VDb25zb2xlQ2xpZW50
LmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJhdGVnaWVzLmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NU
cmFja2VyLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VFcnJvci5oIgpAQCAtNTAyLDggKzUwMywxMyBA
QCB2b2lkIFJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoCiAKICAgICBpZiAoci51
c2VkTGVnYWN5VExTKCkpIHsKICAgICAgICAgaWYgKG1fZnJhbWUpIHsKLSAgICAgICAgICAgIGlm
IChhdXRvKiBkb2N1bWVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCkpCi0gICAgICAgICAgICAgICAg
ZG9jdW1lbnQtPnNldFVzZWRMZWdhY3lUTFModHJ1ZSk7CisgICAgICAgICAgICBpZiAoYXV0byog
ZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CisgICAgICAgICAgICAgICAgaWYgKCFk
b2N1bWVudC0+dXNlZExlZ2FjeVRMUygpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChhdXRv
KiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHBhZ2Ut
PmNvbnNvbGUoKS5hZGRNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6Ok5ldHdvcmssIE1lc3NhZ2VMZXZl
bDo6V2FybmluZywgIkxvYWRlZCByZXNvdXJjZSB1c2luZyBUTFMgMS4wIG9yIDEuMSwgd2hpY2gg
YXJlIGRlcHJlY2F0ZWQgcHJvdG9jb2xzIHRoYXQgd2lsbCBiZSByZW1vdmVkLiBQbGVhc2UgdXNl
IFRMUyAxLjIgb3IgbmV3ZXIgaW5zdGVhZC4iX3MsIDAsIGRvY3VtZW50KTsKKyAgICAgICAgICAg
ICAgICAgICAgZG9jdW1lbnQtPnNldFVzZWRMZWdhY3lUTFModHJ1ZSk7CisgICAgICAgICAgICAg
ICAgfQorICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394380</attachid>
            <date>2020-03-24 09:56:58 -0700</date>
            <delta_ts>2020-03-24 16:34:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-209444-20200324095658.patch</filename>
            <type>text/plain</type>
            <size>2358</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODkxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAzLTI0ICBBbGV4IENo
cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGNvbnNv
bGUgbWVzc2FnZSB3aGVuIGxlZ2FjeSBUTFMgaXMgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NDQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisgICAg
ICAgIEluZGVudCBsZXNzLCBhZGQgaG9zdCB0byBpbnNwZWN0b3IsIGFkZCByZWxlYXNlIGxvZ2dp
bmcgd2l0aG91dCBob3N0LgorCiAyMDIwLTAzLTI0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0Bh
cHBsZS5jb20+CiAKICAgICAgICAgW2lPUyttYWNPUyBEZWJ1Z10gQVNTRVJUSU9OIEZBSUxFRDog
bV9lZmZlY3RzLmlzRW1wdHkoKSBpbiBXZWJDb3JlOjpLZXlmcmFtZUVmZmVjdFN0YWNrOjp+S2V5
ZnJhbWVFZmZlY3RTdGFjaygpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VM
b2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv
YWRlci5jcHAJKHJldmlzaW9uIDI1ODkxMykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNv
dXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwMSwxNCArNTAxLDE0IEBAIHZvaWQg
UmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSgKICAgICAvLyBhbnl0aGluZyBpbmNs
dWRpbmcgcG9zc2libHkgZGVyZWZpbmcgdGhpczsgb25lIGV4YW1wbGUgb2YgdGhpcyBpcyBSYWRh
ciAzMjY2MjE2LgogICAgIFJlZjxSZXNvdXJjZUxvYWRlcj4gcHJvdGVjdGVkVGhpcygqdGhpcyk7
CiAKLSAgICBpZiAoci51c2VkTGVnYWN5VExTKCkpIHsKLSAgICAgICAgaWYgKG1fZnJhbWUpIHsK
LSAgICAgICAgICAgIGlmIChhdXRvKiBkb2N1bWVudCA9IG1fZnJhbWUtPmRvY3VtZW50KCkpIHsK
LSAgICAgICAgICAgICAgICBpZiAoIWRvY3VtZW50LT51c2VkTGVnYWN5VExTKCkpIHsKLSAgICAg
ICAgICAgICAgICAgICAgaWYgKGF1dG8qIHBhZ2UgPSBkb2N1bWVudC0+cGFnZSgpKQotICAgICAg
ICAgICAgICAgICAgICAgICAgcGFnZS0+Y29uc29sZSgpLmFkZE1lc3NhZ2UoTWVzc2FnZVNvdXJj
ZTo6TmV0d29yaywgTWVzc2FnZUxldmVsOjpXYXJuaW5nLCAiTG9hZGVkIHJlc291cmNlIHVzaW5n
IFRMUyAxLjAgb3IgMS4xLCB3aGljaCBhcmUgZGVwcmVjYXRlZCBwcm90b2NvbHMgdGhhdCB3aWxs
IGJlIHJlbW92ZWQuIFBsZWFzZSB1c2UgVExTIDEuMiBvciBuZXdlciBpbnN0ZWFkLiJfcywgMCwg
ZG9jdW1lbnQpOwotICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC0+c2V0VXNlZExlZ2FjeVRM
Uyh0cnVlKTsKKyAgICBpZiAoci51c2VkTGVnYWN5VExTKCkgJiYgbV9mcmFtZSkgeworICAgICAg
ICBpZiAoYXV0byogZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpKSB7CisgICAgICAgICAg
ICBpZiAoIWRvY3VtZW50LT51c2VkTGVnYWN5VExTKCkpIHsKKyAgICAgICAgICAgICAgICBpZiAo
YXV0byogcGFnZSA9IGRvY3VtZW50LT5wYWdlKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgUkVM
RUFTRV9MT0dfSUZfQUxMT1dFRCgidXNlZExlZ2FjeVRMUzoiKTsKKyAgICAgICAgICAgICAgICAg
ICAgcGFnZS0+Y29uc29sZSgpLmFkZE1lc3NhZ2UoTWVzc2FnZVNvdXJjZTo6TmV0d29yaywgTWVz
c2FnZUxldmVsOjpXYXJuaW5nLCBtYWtlU3RyaW5nKCJMb2FkZWQgcmVzb3VyY2UgZnJvbSAiLCBy
LnVybCgpLmhvc3QoKSwgIiB1c2luZyBUTFMgMS4wIG9yIDEuMSwgd2hpY2ggYXJlIGRlcHJlY2F0
ZWQgcHJvdG9jb2xzIHRoYXQgd2lsbCBiZSByZW1vdmVkLiBQbGVhc2UgdXNlIFRMUyAxLjIgb3Ig
bmV3ZXIgaW5zdGVhZC4iKSwgMCwgZG9jdW1lbnQpOwogICAgICAgICAgICAgICAgIH0KKyAgICAg
ICAgICAgICAgICBkb2N1bWVudC0+c2V0VXNlZExlZ2FjeVRMUyh0cnVlKTsKICAgICAgICAgICAg
IH0KICAgICAgICAgfQogICAgIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>