209431 2020-03-23 11:39:00 -0700 [GTK] [2.28.0] The Yelp build crashes if DISPLAY is not set 2020-04-27 04:52:17 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned bugs-noreply cgarcia clopez oldest_to_newest 1632950 0 berto 2020-03-23 11:39:00 -0700 It seems that it's impossible to build Yelp (which links against WebKitGTK) if DISPLAY is unset: Gtk-CRITICAL **: 18:22:42.130: gtk_icon_theme_get_for_screen: assertion 'GDK_IS_SCREEN (screen)' failed WARNING **: 18:22:42.132: Unable to connect to dbus: Cannot autolaunch D-Bus without X11 $DISPLAY Unable to init server: Could not connect: Connection refused I don't have a full backtrace with all symbols but this one already points at the problem: Thread 1 "libyelp-scan" received signal SIGABRT, Aborted. 0x00007ffff7c56761 in raise () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) bt #0 0x00007ffff7c56761 in raise () at /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007ffff7c4055b in abort () at /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007ffff4ba02ed in () at /usr/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37 #3 0x00007ffff507079b in WebKit::HardwareAccelerationManager::HardwareAccelerationManager() () at ../Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp:55 #4 0x00007ffff507081c in WTF::NeverDestroyed<WebKit::HardwareAccelerationManager>::NeverDestroyed<>() () at DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h:52 #5 WebKit::HardwareAccelerationManager::singleton() () at ../Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp:36 #6 0x00007ffff50786d9 in WebKit::WebPreferences::platformInitializeStore() () at ../Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp:42 #7 0x00007ffff4eea222 in WebKit::WebPreferences::create(WTF::String const&, WTF::String const&, WTF::String const&) () at ../Source/WebKit/UIProcess/WebPreferences.cpp:45 #8 0x00007ffff4fbb101 in _WebKitSettingsPrivate::_WebKitSettingsPrivate() () at ../Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:59 #9 0x00007ffff7fa8e6d in g_type_create_instance () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #10 0x00007ffff7f886dd in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #11 0x00007ffff7f8a5e9 in g_object_new_valist () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #12 0x00007ffff4fb5588 in webkit_settings_new_with_settings() () at ../Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:1577 #13 0x00007ffff7e32726 in yelp_view_get_global_settings () at libyelp/yelp-view.c:153 #14 0x00007ffff7e3274d in settings_show_text_cursor (settings=settings@entry=0x5555555b8150) at libyelp/yelp-view.c:2094 #15 0x00007ffff7e327e3 in yelp_view_class_init (klass=0x5555555b6520) at libyelp/yelp-view.c:465 #16 yelp_view_class_intern_init (klass=0x5555555b6520) at libyelp/yelp-view.c:144 #17 0x00007ffff7fa6ef1 in g_type_class_ref () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #18 0x00005555555565bc in get_object_types () at libyelp-scan.c:62 #19 main () at libyelp-scan.c:113 That's here: if (!AcceleratedBackingStore::checkRequirements()) { m_canUseHardwareAcceleration = false; return; } See also bug 156972 for a related problem already fixed 4 years ago. 1632988 1 berto 2020-03-23 13:01:19 -0700 Ok, so we're hitting the RELEASE_ASSERT_NOT_REACHED() in AcceleratedBackingStore::checkRequirements(), and the reason is that the PlatformDisplay type is neither Wayland nor X11, but WPE. 1636433 2 cgarcia 2020-04-01 02:33:43 -0700 (In reply to Alberto Garcia from comment #1) > Ok, so we're hitting the RELEASE_ASSERT_NOT_REACHED() in > AcceleratedBackingStore::checkRequirements(), and the reason is that > the PlatformDisplay type is neither Wayland nor X11, but WPE. I think we can just remove that assert 1636436 3 395152 cgarcia 2020-04-01 02:46:40 -0700 Created attachment 395152 Patch 1636830 4 cgarcia 2020-04-02 01:45:42 -0700 Committed r259380: <https://trac.webkit.org/changeset/259380> 1645774 5 berto 2020-04-26 07:28:25 -0700 It looks like the Yelp build still crashes, different backtrace this time: (process:35799): Gtk-CRITICAL **: 13:40:20.270: gtk_icon_theme_get_for_screen: assertion 'GDK_IS_SCREEN (screen)' failed ** (process:35799): WARNING **: 13:40:20.271: Unable to connect to dbus: Cannot autolaunch D-Bus without X11 $DISPLAY Unable to init server: Could not connect: Connection refused Segmentation fault Thread 1 "libyelp-scan" received signal SIGSEGV, Segmentation fault. 0x00007ffff335cbd4 in wpe_renderer_backend_egl_destroy (backend=0x0) at ./src/renderer-backend-egl.c:54 54 backend->base.interface->destroy(backend->base.interface_data); (gdb) bt #0 0x00007ffff335cbd4 in wpe_renderer_backend_egl_destroy (backend=0x0) at ./src/renderer-backend-egl.c:54 #1 0x00007ffff63bc8bb in WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE() () at ../Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:66 #2 0x00007ffff63bc8d9 in WebCore::PlatformDisplayLibWPE::~PlatformDisplayLibWPE() () at ../Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:67 #3 0x00007ffff7c59e27 in __run_exit_handlers (status=0, listp=0x7ffff7dd8718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108 #4 0x00007ffff7c59fda in __GI_exit (status=<optimized out>) at exit.c:139 #5 0x00007ffff7c42e12 in __libc_start_main (main= 0x555555556480 <main>, argc=1, argv=0x7fffffffdd78, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdd68) at ../csu/libc-start.c:342 #6 0x0000555555557b7a in _start () at libyelp-scan.c:1025 So it seems that m_backend is null in the PlatformDisplayLibWPE destructor. 1645780 6 berto 2020-04-26 08:19:31 -0700 I confirm that checking for null in wpe_renderer_backend_egl_destroy() is enough to avoid the crash and fix the Yelp build, but perhaps the change should be in WebKit ? 1645911 7 cgarcia 2020-04-27 00:27:21 -0700 I don't think we should create a PlatformDisplayLibWPE as fallback. We could fix it in PlatformDisplay::createPlatformDisplay() either: #if USE(WPE_RENDERER) -> #if USE(LIBWPE) or just move the block: #if USE(WPE_RENDERER) return PlatformDisplayLibWPE::create(); #elif PLATFORM(WIN) return PlatformDisplayWin::create(); #endif at the end of the function, right before the RELEASE_ASSERT_NOT_REACHED() Could you try any of these solutions, please? 1645953 8 berto 2020-04-27 03:25:26 -0700 (In reply to Carlos Garcia Campos from comment #7) > or just move the block: > > #if USE(WPE_RENDERER) > return PlatformDisplayLibWPE::create(); > #elif PLATFORM(WIN) > return PlatformDisplayWin::create(); > #endif > > at the end of the function, right before the RELEASE_ASSERT_NOT_REACHED() I confirm that this one works and fixes the problem. Do you want me to try the other one, or to prepare a patch with this one, or what? 1645956 9 cgarcia 2020-04-27 03:54:09 -0700 Yes, please, just submit a patch with any of the solutions if you don't mind :-) 1645958 10 397668 berto 2020-04-27 04:06:29 -0700 Created attachment 397668 Patch 1645963 11 berto 2020-04-27 04:52:17 -0700 Committed r260750: <https://trac.webkit.org/changeset/260750> 395152 2020-04-01 02:46:40 -0700 2020-04-01 12:45:18 -0700 Patch wk-no-display.diff text/plain 1247 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGQ1YWU2Y2Y4ZGU0Li5hMzhjZThmZDU0OGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDQtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFsyLjI4LjBdIFRoZSBZZWxwIGJ1aWxkIGNyYXNoZXMg aWYgRElTUExBWSBpcyBub3Qgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDk0MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgdGhlIGFzc2VydCB3aGVuIGRpc3BsYXkgaXMgbm90IFgxMSBu b3IgV2F5bGFuZCwgYW5kIHNpbXBseSByZXR1cm4gZmFsc2UgdG8gZW5zdXJlIGFjY2VsZXJhdGlv biBpcyBub3QgdXNlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNr aW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpBY2NlbGVyYXRlZEJhY2tpbmdTdG9yZTo6 Y2hlY2tSZXF1aXJlbWVudHMpOgorCiAyMDIwLTA0LTAxICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IHJlc29sdXRpb24gb2YgSVB2NiBTVFVOL1RV Uk4gYWRkcmVzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvQWNj ZWxlcmF0ZWRCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0Fj Y2VsZXJhdGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCAzOTA5YWE0MmZmMDguLmQxNGRkZDk5MzM1 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFj a2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0 ZWRCYWNraW5nU3RvcmUuY3BwCkBAIC01Myw3ICs1Myw2IEBAIGJvb2wgQWNjZWxlcmF0ZWRCYWNr aW5nU3RvcmU6OmNoZWNrUmVxdWlyZW1lbnRzKCkKICAgICAgICAgcmV0dXJuIEFjY2VsZXJhdGVk QmFja2luZ1N0b3JlWDExOjpjaGVja1JlcXVpcmVtZW50cygpOwogI2VuZGlmCiAKLSAgICBSRUxF QVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIAo= 397668 2020-04-27 04:06:29 -0700 2020-04-27 04:48:11 -0700 Patch 209431.diff text/plain 1711 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNWFjMjgwYzdmM2EuLmY3YTM2MTY2NDJkNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTA0LTI3ICBBbGJlcnRvIEdhcmNpYSAgPGJlcnRvQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gWzIuMjguMF0gVGhlIFllbHAgYnVpbGQgY3Jhc2hlcyBpZiBE SVNQTEFZIGlzIG5vdCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwOTQzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIERvbid0IGNyZWF0ZSBhIFBsYXRmb3JtRGlzcGxheUxpYldQRSBhcyBhIGZhbGxi YWNrIHdoZW4gdXNpbmcKKyAgICAgICAgV2F5bGFuZCBvciBYMTEuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxh dGZvcm1EaXNwbGF5OjpjcmVhdGVQbGF0Zm9ybURpc3BsYXkpOgorCiAyMDIwLTA0LTI3ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBjb21waWxlLXdhcm5pbmcgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKaW5kZXggOGJiNDdjYTJiNzdhLi5mOTU0N2Iz YWY2OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRm b3JtRGlzcGxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxh dGZvcm1EaXNwbGF5LmNwcApAQCAtOTgsMTIgKzk4LDYgQEAgc3RkOjp1bmlxdWVfcHRyPFBsYXRm b3JtRGlzcGxheT4gUGxhdGZvcm1EaXNwbGF5OjpjcmVhdGVQbGF0Zm9ybURpc3BsYXkoKQogICAg IH0KICNlbmRpZiAvLyBQTEFURk9STShHVEspCiAKLSNpZiBVU0UoV1BFX1JFTkRFUkVSKQotICAg IHJldHVybiBQbGF0Zm9ybURpc3BsYXlMaWJXUEU6OmNyZWF0ZSgpOwotI2VsaWYgUExBVEZPUk0o V0lOKQotICAgIHJldHVybiBQbGF0Zm9ybURpc3BsYXlXaW46OmNyZWF0ZSgpOwotI2VuZGlmCi0K ICNpZiBQTEFURk9STShXQVlMQU5EKQogICAgIGlmIChhdXRvIHBsYXRmb3JtRGlzcGxheSA9IFBs YXRmb3JtRGlzcGxheVdheWxhbmQ6OmNyZWF0ZSgpKQogICAgICAgICByZXR1cm4gcGxhdGZvcm1E aXNwbGF5OwpAQCAtMTIxLDYgKzExNSwxMiBAQCBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1EaXNw bGF5PiBQbGF0Zm9ybURpc3BsYXk6OmNyZWF0ZVBsYXRmb3JtRGlzcGxheSgpCiAgICAgcmV0dXJu IFBsYXRmb3JtRGlzcGxheVgxMTo6Y3JlYXRlKG51bGxwdHIpOwogI2VuZGlmCiAKKyNpZiBVU0Uo V1BFX1JFTkRFUkVSKQorICAgIHJldHVybiBQbGF0Zm9ybURpc3BsYXlMaWJXUEU6OmNyZWF0ZSgp OworI2VsaWYgUExBVEZPUk0oV0lOKQorICAgIHJldHVybiBQbGF0Zm9ybURpc3BsYXlXaW46OmNy ZWF0ZSgpOworI2VuZGlmCisKICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQog Cg==