20943 2008-09-19 11:19:11 -0700 REGRESSION (r36631?): Assertion failure in RefCountedLeakCounter::cancelMessageSuppression() when closing a window 2008-09-19 11:47:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P1 Normal --- 1 mitz darin darin oldest_to_newest 91785 0 mitz 2008-09-19 11:19:11 -0700 I hit an assertion in RefCountedLeakCounter::cancelMessageSuppression() twice today when closing a Safari window. I cannot reliably reproduce it, though. ASSERTION FAILED: leakMessageSuppressionReasons->contains(reason) 91786 1 darin 2008-09-19 11:23:34 -0700 I see what's wrong. I forgot to add some code to initWithCoder: that is in initWithFrame:. I'll fix it now. 91789 2 23574 darin 2008-09-19 11:25:27 -0700 Created attachment 23574 patch 91792 3 23574 mitz 2008-09-19 11:44:56 -0700 Comment on attachment 23574 patch r=me 91793 4 darin 2008-09-19 11:47:21 -0700 http://trac.webkit.org/changeset/36668 23574 2008-09-19 11:25:27 -0700 2008-09-19 11:44:56 -0700 patch LeakMessagePatch.txt text/plain 1741 darin SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiAzNjY2NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMTkgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIC0gc3BlY3VsYXRpdmUgZml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5NDMKKyAgICAgICAgICBBc3NlcnRpb24gZmFpbHVyZSBpbiBSZWZDb3VudGVk TGVha0NvdW50ZXI6OmNhbmNlbE1lc3NhZ2VTdXBwcmVzc2lvbigpIHdoZW4gY2xvc2luZyBhIHdp bmRvdworCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3 IF9jb21tb25Jbml0aWFsaXphdGlvbldpdGhGcmFtZU5hbWU6Z3JvdXBOYW1lOl0pOiBNb3ZlZCBj YWxsIHRvCisgICAgICAgIFJlZkNvdW50ZWRMZWFrQ291bnRlcjo6c3VwcHJlc3NNZXNzYWdlcyBp biBoZXJlLgorICAgICAgICAoLVtXZWJWaWV3IGluaXRXaXRoRnJhbWU6ZnJhbWVOYW1lOmdyb3Vw TmFtZTpdKTogTW92ZWQgaXQgb3V0IG9mIGhlcmUuCisKIDIwMDgtMDktMTggIE1hcmsgUm93ZSAg PG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJ bmRleDogV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlzaW9uIDM2NjYwKQorKysgV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5MjIsNiArMTkyMiwxMCBAQCBz dGF0aWMgdm9pZCBXZWJLaXRJbml0aWFsaXplQXBwbGljYXRpb25DCiAKIC0gKHZvaWQpX2NvbW1v bkluaXRpYWxpemF0aW9uV2l0aEZyYW1lTmFtZTooTlNTdHJpbmcgKilmcmFtZU5hbWUgZ3JvdXBO YW1lOihOU1N0cmluZyAqKWdyb3VwTmFtZQogeworI2lmbmRlZiBOREVCVUcKKyAgICBXVEY6OlJl ZkNvdW50ZWRMZWFrQ291bnRlcjo6c3VwcHJlc3NNZXNzYWdlcyh3ZWJWaWV3SXNPcGVuKTsKKyNl bmRpZgorICAgIAogICAgIFdlYlByZWZlcmVuY2VzICpzdGFuZGFyZFByZWZlcmVuY2VzID0gW1dl YlByZWZlcmVuY2VzIHN0YW5kYXJkUHJlZmVyZW5jZXNdOwogICAgIFtzdGFuZGFyZFByZWZlcmVu Y2VzIHdpbGxBZGRUb1dlYlZpZXddOwogCkBAIC0yMDEzLDEwICsyMDE3LDYgQEAgc3RhdGljIHZv aWQgV2ViS2l0SW5pdGlhbGl6ZUFwcGxpY2F0aW9uQwogICAgIH0KICNlbmRpZgogCi0jaWZuZGVm IE5ERUJVRwotICAgIFdURjo6UmVmQ291bnRlZExlYWtDb3VudGVyOjpzdXBwcmVzc01lc3NhZ2Vz KHdlYlZpZXdJc09wZW4pOwotI2VuZGlmCi0gICAgCiAgICAgX3ByaXZhdGUgPSBbW1dlYlZpZXdQ cml2YXRlIGFsbG9jXSBpbml0XTsKICAgICBbc2VsZiBfY29tbW9uSW5pdGlhbGl6YXRpb25XaXRo RnJhbWVOYW1lOmZyYW1lTmFtZSBncm91cE5hbWU6Z3JvdXBOYW1lXTsKICAgICBbc2VsZiBzZXRN YWludGFpbnNCYWNrRm9yd2FyZExpc3Q6IFlFU107Cg==