209422 2020-03-23 06:08:23 -0700 RemoteAudioSession should listen to GPUProcess messages 2020-03-25 18:52:19 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209575 InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble mkwst philipj rniwa sergio webkit-bug-importer youennf oldest_to_newest 1632810 0 youennf 2020-03-23 06:08:23 -0700 RemoteAudioSession should listen to GPUProcess messages 1632813 1 394258 youennf 2020-03-23 06:12:56 -0700 Created attachment 394258 Patch 1632833 2 ews-feeder 2020-03-23 07:26:39 -0700 Committed r258838: <https://trac.webkit.org/changeset/258838> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394258. 1632835 3 webkit-bug-importer 2020-03-23 07:27:12 -0700 <rdar://problem/60774066> 1634150 4 394258 rniwa 2020-03-25 18:52:19 -0700 Comment on attachment 394258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394258&action=review > Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:52 > + m_process.ensureGPUProcessConnection().messageReceiverMap().addMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 0, *this); Ugh... we shouldn't be using the destination ID of 0. That'll immediately hit an assertion failure: https://bugs.webkit.org/show_bug.cgi?id=209575 394258 2020-03-23 06:12:56 -0700 2020-03-23 07:26:39 -0700 Patch bug-209422-20200323141254.patch text/plain 2141 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhNDcwZDI3M2M5MGFiMDg3 OGJlY2M2ZTdmNWNkYTI1ZDU4OTgyMzUuLjJlMDZiYzMxOWI1YjY3YmIzY2YwMjc2YTU0Y2FhYzY5 YWMzOTQ2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW90ZUF1ZGlvU2Vzc2lvbiBz aG91bGQgbGlzdGVuIHRvIEdQVVByb2Nlc3MgbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTQyMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3VyZSBSZW1vdGVBdWRpb1Nlc3Npb24g aXMgcmVnaXN0ZXJlZCBhcyBhIGxpc3RlbmVyIHRvIEdQVVByb2Nlc3MgbWVzc2FnZXMuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVBdWRpb1Nlc3Npb24uY3BwOgorICAg ICAgICAoV2ViS2l0OjpSZW1vdGVBdWRpb1Nlc3Npb246OlJlbW90ZUF1ZGlvU2Vzc2lvbik6Cisg ICAgICAgIChXZWJLaXQ6OlJlbW90ZUF1ZGlvU2Vzc2lvbjo6flJlbW90ZUF1ZGlvU2Vzc2lvbik6 CisKIDIwMjAtMDMtMTkgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIE9uIFBTT04sIFdlYlBhZ2VQcm94eSBsaXN0ZW5zIHRvIHR3byBEcmF3QXJlYVByb3h5IGF0 IHRoZSBzYW1lIHRpbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUv bWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvbWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uLmNwcAppbmRleCBhMzYzMTM5OTU5YTFhZGI5NTQy MzNiZGNlZjBmOGJlZTE1Mjc3MWU5Li5kOTNjMzdkMzBiY2U4NjA0YzMzZDYwZmQ0MWNlYzRmOTZl MWM0YWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1Jl bW90ZUF1ZGlvU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9t ZWRpYS9SZW1vdGVBdWRpb1Nlc3Npb24uY3BwCkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRl ICJHUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzTWVzc2FnZXMuaCIKICNpbmNsdWRlICJHUFVQcm9j ZXNzUHJveHkuaCIKKyNpbmNsdWRlICJSZW1vdGVBdWRpb1Nlc3Npb25NZXNzYWdlcy5oIgogI2lu Y2x1ZGUgIlJlbW90ZUF1ZGlvU2Vzc2lvblByb3h5TWVzc2FnZXMuaCIKICNpbmNsdWRlIDxXZWJD b3JlL1BsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5oPgogCkBAIC00OCw5ICs0OSwxNCBAQCBS ZW1vdGVBdWRpb1Nlc3Npb246OlJlbW90ZUF1ZGlvU2Vzc2lvbihXZWJQcm9jZXNzJiBwcm9jZXNz LCBSZW1vdGVBdWRpb1Nlc3Npb25DbwogICAgIDogbV9wcm9jZXNzKHByb2Nlc3MpCiAgICAgLCBt X2NvbmZpZ3VyYXRpb24oV1RGTW92ZShjb25maWd1cmF0aW9uKSkKIHsKKyAgICBtX3Byb2Nlc3Mu ZW5zdXJlR1BVUHJvY2Vzc0Nvbm5lY3Rpb24oKS5tZXNzYWdlUmVjZWl2ZXJNYXAoKS5hZGRNZXNz YWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZUF1ZGlvU2Vzc2lvbjo6bWVzc2FnZVJlY2VpdmVy TmFtZSgpLCAwLCAqdGhpcyk7CiB9CiAKLVJlbW90ZUF1ZGlvU2Vzc2lvbjo6flJlbW90ZUF1ZGlv U2Vzc2lvbigpID0gZGVmYXVsdDsKK1JlbW90ZUF1ZGlvU2Vzc2lvbjo6flJlbW90ZUF1ZGlvU2Vz c2lvbigpCit7CisgICAgaWYgKGF1dG8qIGNvbm5lY3Rpb24gPSBtX3Byb2Nlc3MuZXhpc3RpbmdH UFVQcm9jZXNzQ29ubmVjdGlvbigpKQorICAgICAgICBjb25uZWN0aW9uLT5tZXNzYWdlUmVjZWl2 ZXJNYXAoKS5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZUF1ZGlvU2Vzc2lv bjo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCAwKTsKK30KIAogSVBDOjpDb25uZWN0aW9uJiBSZW1v dGVBdWRpb1Nlc3Npb246OmNvbm5lY3Rpb24oKQogewo=