20940 2008-09-19 09:57:03 -0700 [GTK] use of confirm dialog (yes/no) causes segfault 2009-03-15 12:49:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 lkcl webkit-unassigned christian oldest_to_newest 91773 0 lkcl 2008-09-19 09:57:03 -0700 the gboolean pointer into which the yes/no result is to be placed appears to be corrupt - see attached gdb typescript. 91775 1 23570 lkcl 2008-09-19 09:57:57 -0700 Created attachment 23570 gdb trace, disas and $rip 113157 2 28472 jmalonzo 2009-03-11 04:13:42 -0700 Created attachment 28472 we marshal the didConfirm parameter to a boolean not to a pointer 113176 3 zecke 2009-03-11 06:41:07 -0700 aeh, didConfirm looks like an out pointer (on first sight), are you sure about this change vs. changing the marshaling? 113202 4 christian 2009-03-11 11:31:10 -0700 > -static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean* didConfirm, gpointer data) > +static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean didConfirm, gpointer data) > { > fprintf(stdout, "CONFIRM: %s\n", message); > - *didConfirm = TRUE; > + didConfirm = TRUE; > return TRUE; > } This is bogus if I may say that. Assigning a value to a local variable doesn't do anything at all. If anything, the marshaller must be wrong. didConfirm represents the action of the user, ie. did confirm or did not confirm. 113211 5 28487 jmalonzo 2009-03-11 12:26:41 -0700 Created attachment 28487 change the marshaller instead 113788 6 jmalonzo 2009-03-14 16:15:14 -0700 Landed in r41706. Thanks! 113842 7 johan 2009-03-15 12:02:48 -0700 (In reply to comment #4) > > -static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean* didConfirm, gpointer data) > > +static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean didConfirm, gpointer data) > > { > > fprintf(stdout, "CONFIRM: %s\n", message); > > - *didConfirm = TRUE; > > + didConfirm = TRUE; > > return TRUE; > > } > > This is bogus if I may say that. Assigning a value to a local variable doesn't > do anything at all. If anything, the marshaller must be wrong. > > didConfirm represents the action of the user, ie. did confirm or did not > confirm. > This doesn't look quite right. It won't be possible to support this pattern in language bindings. Why not just use the return value and remove the third argument to the callbacks instead of always returning TRUE? 113844 8 christian 2009-03-15 12:49:34 -0700 (In reply to comment #7) > (In reply to comment #4) > > > -static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean* didConfirm, gpointer data) > > > +static gboolean webViewScriptConfirm(WebKitWebView* view, WebKitWebFrame* frame, const gchar* > message, gboolean didConfirm, gpointer data) > > > { > > > fprintf(stdout, "CONFIRM: %s\n", message); > > > - *didConfirm = TRUE; > > > + didConfirm = TRUE; > > > return TRUE; > > > } > > > > This is bogus if I may say that. Assigning a value to a local variable doesn't > > do anything at all. If anything, the marshaller must be wrong. > > > > didConfirm represents the action of the user, ie. did confirm or did not > > confirm. > > > > This doesn't look quite right. It won't be possible to support this pattern in > language bindings. Why not just use the return value and remove the third > argument to the callbacks instead of always returning TRUE? Because the return value determines whether the signal was handled or not. 23570 2008-09-19 09:57:57 -0700 2008-09-19 09:57:57 -0700 gdb trace, disas and $rip typescript text/plain 12315 lkcl U2NyaXB0IHN0YXJ0ZWQgb24gRnJpIDE5IFNlcCAyMDA4IDE3OjUxOjI4IEJTVApsa2NsQGdvbnph bGV6Oi92YXIvc3JjL1dlYktpdC9idWlsZCQgLi9saWJ0b29sIGdkYiBQcm9ncmFtcy9HdGtMYXVu Y2hlciAKKioqIFdhcm5pbmc6IGluZmVycmluZyB0aGUgbW9kZSBvZiBvcGVyYXRpb24gaXMgZGVw cmVjYXRlZC4KKioqIEZ1dHVyZSB2ZXJzaW9ucyBvZiBMaWJ0b29sIHdpbGwgcmVxdWlyZSAtLW1v ZGU9TU9ERSBiZSBzcGVjaWZpZWQuCkdOVSBnZGIgNi43LjEtZGViaWFuCkNvcHlyaWdodCAoQykg MjAwNyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KTGljZW5zZSBHUEx2Mys6IEdOVSBH UEwgdmVyc2lvbiAzIG9yIGxhdGVyIDxodHRwOi8vZ251Lm9yZy9saWNlbnNlcy9ncGwuaHRtbD4K VGhpcyBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgYXJlIGZyZWUgdG8gY2hhbmdlIGFuZCByZWRpc3Ry aWJ1dGUgaXQuClRoZXJlIGlzIE5PIFdBUlJBTlRZLCB0byB0aGUgZXh0ZW50IHBlcm1pdHRlZCBi eSBsYXcuICBUeXBlICJzaG93IGNvcHlpbmciCmFuZCAic2hvdyB3YXJyYW50eSIgZm9yIGRldGFp bHMuClRoaXMgR0RCIHdhcyBjb25maWd1cmVkIGFzICJ4ODZfNjQtbGludXgtZ251Ii4uLgpVc2lu ZyBob3N0IGxpYnRocmVhZF9kYiBsaWJyYXJ5ICIvbGliL2xpYnRocmVhZF9kYi5zby4xIi4KKGdk YikgcnVuClN0YXJ0aW5nIHByb2dyYW06IC92YXIvc3JjL1dlYktpdC9idWlsZC9Qcm9ncmFtcy8u bGlicy9sdC1HdGtMYXVuY2hlciAKW1RocmVhZCBkZWJ1Z2dpbmcgdXNpbmcgbGlidGhyZWFkX2Ri IGVuYWJsZWRdCndhcm5pbmc6IExvd2VzdCBzZWN0aW9uIGluIC91c3IvbGliL2xpYmljdWRhdGEu c28uMzYgaXMgLmhhc2ggYXQgMDAwMDAwMDAwMDAwMDEyMApbTmV3IFRocmVhZCAweDJhYjJlZTY2 ZDA0MCAoTFdQIDIyNjA2KV0KRVJST1I6IGxkLnNvOiBvYmplY3QgJy91c3IvbGliL2xpYmFydHNk c3Auc28uMCcgZnJvbSBMRF9QUkVMT0FEIGNhbm5vdCBiZSBwcmVsb2FkZWQ6IGlnbm9yZWQuCkVS Uk9SOiBsZC5zbzogb2JqZWN0ICcvdXNyL2xpYi9saWJhcnRzYy5zby4wJyBmcm9tIExEX1BSRUxP QUQgY2Fubm90IGJlIHByZWxvYWRlZDogaWdub3JlZC4KRVJST1I6IGxkLnNvOiBvYmplY3QgJy91 c3IvbGliL2xpYmFydHNkc3Auc28uMCcgZnJvbSBMRF9QUkVMT0FEIGNhbm5vdCBiZSBwcmVsb2Fk ZWQ6IGlnbm9yZWQuCkVSUk9SOiBsZC5zbzogb2JqZWN0ICcvdXNyL2xpYi9saWJhcnRzYy5zby4w JyBmcm9tIExEX1BSRUxPQUQgY2Fubm90IGJlIHByZWxvYWRlZDogaWdub3JlZC4Kc2g6IGFjcm9y ZWFkOiBjb21tYW5kIG5vdCBmb3VuZAoKUHJvZ3JhbSByZWNlaXZlZCBzaWduYWwgU0lHU0VHViwg U2VnbWVudGF0aW9uIGZhdWx0LgpbU3dpdGNoaW5nIHRvIFRocmVhZCAweDJhYjJlZTY2ZDA0MCAo TFdQIDIyNjA2KV0KMHgwMDAwMmFiMmU4NmVlYTQ0IGluIHdlYmtpdF93ZWJfdmlld19yZWFsX3Nj cmlwdF9jb25maXJtICgKICAgIHdlYlZpZXc9PHZhbHVlIG9wdGltaXplZCBvdXQ+LCBmcmFtZT08 dmFsdWUgb3B0aW1pemVkIG91dD4sIAogICAgbWVzc2FnZT08dmFsdWUgb3B0aW1pemVkIG91dD4s IGRpZENvbmZpcm09MHhjMjYyYjRmOCkKICAgIGF0IC4uL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwOjY3MAo2NzAJICAgICpkaWRDb25maXJtID0gd2Via2l0X3dlYl92aWV3X3Nj cmlwdF9kaWFsb2cod2ViVmlldywgZnJhbWUsIG1lc3NhZ2UsIFdFQktJVF9TQ1JJUFRfRElBTE9H X0NPTkZJUk0sIDAsIDApOwpDdXJyZW50IGxhbmd1YWdlOiAgYXV0bzsgY3VycmVudGx5IGMrKwoo Z2RiKSB3aGVyZQgbW0sIG1tLCBtbSwgbW0sIG1tLBwcHbGlzdAo2NjUJICAgIHJldHVybiBUUlVF Owo2NjYJfQo2NjcJCjY2OAlzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X3JlYWxfc2Ny aXB0X2NvbmZpcm0oV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0V2ViRnJhbWUqIGZyYW1l LCBjb25zdCBnY2hhciogbWVzc2FnZSwgZ2Jvb2xlYW4qIGRpZENvbmZpcm0pCjY2OQl7CjY3MAkg ICAgKmRpZENvbmZpcm0gPSB3ZWJraXRfd2ViX3ZpZXdfc2NyaXB0X2RpYWxvZyh3ZWJWaWV3LCBm cmFtZSwgbWVzc2FnZSwgV0VCS0lUX1NDUklQVF9ESUFMT0dfQ09ORklSTSwgMCwgMCk7CjY3MQkg ICAgcmV0dXJuIFRSVUU7CjY3Mgl9CjY3MwkKNjc0CXN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2Vi X3ZpZXdfcmVhbF9zY3JpcHRfcHJvbXB0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFdl YkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIG1lc3NhZ2UsIGNvbnN0IGdjaGFyKiBkZWZhdWx0 VmFsdWUsIGdjaGFyKiogdmFsdWUpCihnZGIpIHdoZXJlCiMwICAweDAwMDAyYWIyZTg2ZWVhNDQg aW4gd2Via2l0X3dlYl92aWV3X3JlYWxfc2NyaXB0X2NvbmZpcm0gKAogICAgd2ViVmlldz08dmFs dWUgb3B0aW1pemVkIG91dD4sIGZyYW1lPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PiwgCiAgICBtZXNz YWdlPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PiwgZGlkQ29uZmlybT0weGMyNjJiNGY4KQogICAgYXQg Li4vV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6NjcwCiMxICAweDAwMDAyYWIy ZTg2ZjM5ZTUgaW4gd2Via2l0X21hcnNoYWxfQk9PTEVBTl9fT0JKRUNUX1NUUklOR19CT09MRUFO ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xpYndlYmtpdC0xLjAuc28u MQojMiAgMHgwMDAwMmFiMmU5ODgzZWJkIGluIElBX19nX2Nsb3N1cmVfaW52b2tlIChjbG9zdXJl PTB4NjdmZmEwLCAKICAgIHJldHVybl92YWx1ZT0weDdmZmZjMjYyYjA5MCwgbl9wYXJhbV92YWx1 ZXM9NCwgcGFyYW1fdmFsdWVzPTB4N2ZmZmMyNjJiMTUwLCAKICAgIGludm9jYXRpb25faGludD0w eDdmZmZjMjYyYjA1MCkKICAgIGF0IC9idWlsZC9idWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ29iamVj dC9nY2xvc3VyZS5jOjQ5MAojMyAgMHgwMDAwMmFiMmU5ODk2OGZjIGluIHNpZ25hbF9lbWl0X3Vu bG9ja2VkX1IgKG5vZGU9MHg2ODAwMTAsIGRldGFpbD0wLCAKICAgIGluc3RhbmNlPTB4NjUyMTIw LCBlbWlzc2lvbl9yZXR1cm49MHg3ZmZmYzI2MmIzNTAsIAogICAgaW5zdGFuY2VfYW5kX3BhcmFt cz0weDdmZmZjMjYyYjE1MCkKICAgIGF0IC9idWlsZC9idWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ29i amVjdC9nc2lnbmFsLmM6MjQ3OAojNCAgMHgwMDAwMmFiMmU5ODk3Zjk5IGluIElBX19nX3NpZ25h bF9lbWl0X3ZhbGlzdCAoaW5zdGFuY2U9MHg2NTIxMjAsIAogICAgc2lnbmFsX2lkPTx2YWx1ZSBv cHRpbWl6ZWQgb3V0PiwgZGV0YWlsPTAsIHZhcl9hcmdzPTB4N2ZmZmMyNjJiM2UwKQogICAgYXQg L2J1aWxkL2J1aWxkZC9nbGliMi4wLTIuMTYuNS9nb2JqZWN0L2dzaWduYWwuYzoyMjA5CiM1ICAw eDAwMDAyYWIyZTk4OTg0ODIgaW4gSUFfX2dfc2lnbmFsX2VtaXRfYnlfbmFtZSAoaW5zdGFuY2U9 MHg2NTIxMjAsIAogICAgZGV0YWlsZWRfc2lnbmFsPTB4MmFiMmU4ZTAxOWExICJzY3JpcHQtY29u ZmlybSIpCiAgICBhdCAvYnVpbGQvYnVpbGRkL2dsaWIyLjAtMi4xNi41L2dvYmplY3QvZ3NpZ25h bC5jOjIyNjcKIzYgIDB4MDAwMDJhYjJlODZlMjQ5OSBpbiBXZWJLaXQ6OkNocm9tZUNsaWVudDo6 cnVuSmF2YVNjcmlwdENvbmZpcm0gKCkKICAgZnJvbSAvdmFyL3NyYy9XZWJLaXQvYnVpbGQvLmxp YnMvbGlid2Via2l0LTEuMC5zby4xCiM3ICAweDAwMDAyYWIyZThjYzlhMjIgaW4gV2ViQ29yZTo6 Q2hyb21lOjpydW5KYXZhU2NyaXB0Q29uZmlybSAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9i dWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzggIDB4MDAwMDJhYjJlOGIyNmYxYyBpbiBX ZWJDb3JlOjpET01XaW5kb3c6OmNvbmZpcm0gKCkKICAgZnJvbSAvdmFyL3NyYy9XZWJLaXQvYnVp bGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiM5ICAweDAwMDAyYWIyZTg5MDcwN2EgaW4gV2Vi Q29yZTo6anNET01XaW5kb3dQcm90b3R5cGVGdW5jdGlvbkNvbmZpcm0gKCkKICAgZnJvbSAvdmFy L3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiMxMCAweDAwMDAyYWIy ZTg3YWZkNjMgaW4gSlNDOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSAoKQogICBmcm9tIC92YXIv c3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzExIDB4MDAwMDJhYjJl ODdiNzEzYiBpbiBKU0M6Ok1hY2hpbmU6OmV4ZWN1dGUgKCkKICAgZnJvbSAvdmFyL3NyYy9XZWJL aXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiMxMiAweDAwMDAyYWIyZThhYTMyYzMg aW4gSlNDOjpKU0Z1bmN0aW9uOjpjYWxsICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxk Ly5saWJzL2xpYndlYmtpdC0xLjAuc28uMQojMTMgMHgwMDAwMmFiMmU4YmRiMDhmIGluIFdlYkNv cmU6OkpTQWJzdHJhY3RFdmVudExpc3RlbmVyOjpoYW5kbGVFdmVudCAoKQogICBmcm9tIC92YXIv c3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzE0IDB4MDAwMDJhYjJl ODdjNGRmNSBpbiBXZWJDb3JlOjpFdmVudFRhcmdldDo6aGFuZGxlTG9jYWxFdmVudHMgKCkKICAg ZnJvbSAvdmFyL3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiMxNSAw eDAwMDAyYWIyZTg3YzRjMzcgaW4gV2ViQ29yZTo6RXZlbnRUYXJnZXQ6OmRpc3BhdGNoR2VuZXJp Y0V2ZW50ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xpYndlYmtpdC0x LjAuc28uMQojMTYgMHgwMDAwMmFiMmU4ZDA4MzYzIGluIFdlYkNvcmU6OkV2ZW50VGFyZ2V0Tm9k ZTo6ZGlzcGF0Y2hFdmVudCAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9s aWJ3ZWJraXQtMS4wLnNvLjEKIzE3IDB4MDAwMDJhYjJlOGQwNzY3NyBpbiBXZWJDb3JlOjpFdmVu dFRhcmdldE5vZGU6OmRpc3BhdGNoTW91c2VFdmVudCAoKQogICBmcm9tIC92YXIvc3JjL1dlYktp dC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzE4IDB4MDAwMDJhYjJlOGQwN2YzOCBp biBXZWJDb3JlOjpFdmVudFRhcmdldE5vZGU6OmRpc3BhdGNoTW91c2VFdmVudCAoKQogICBmcm9t IC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzE5IDB4MDAw MDJhYjJlOGNlNjI2MiBpbiBXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmRpc3BhdGNoTW91c2VFdmVu dCAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNv LjEKIzIwIDB4MDAwMDJhYjJlOGNlYTA4YyBpbiBXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRs ZU1vdXNlUmVsZWFzZUV2ZW50ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJz L2xpYndlYmtpdC0xLjAuc28uMQojMjEgMHgwMDAwMmFiMmU4NmVmYjU3IGluIHdlYmtpdF93ZWJf dmlld19idXR0b25fcmVsZWFzZV9ldmVudCAoCiAgICB3aWRnZXQ9PHZhbHVlIG9wdGltaXplZCBv dXQ+LCBldmVudD0weDdkMmYzMCkKLS0tVHlwZSA8cmV0dXJuPiB0byBjb250aW51ZSwgb3IgcSA8 cmV0dXJuPiB0byBxdWl0LS0tIAgbW0sKICAgIGF0IC4uL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwOjQwNQojMjIgMHgwMDAwMmFiMmU5M2ZhNWE4IGluID8/ICgpIGZyb20gL3Vz ci9saWIvbGliZ3RrLXgxMS0yLjAuc28uMAojMjMgMHgwMDAwMmFiMmU5ODgzZWJkIGluIElBX19n X2Nsb3N1cmVfaW52b2tlIChjbG9zdXJlPTB4NjMyZWUwLCAKICAgIHJldHVybl92YWx1ZT0weDdm ZmZjMjYyZDkyMCwgbl9wYXJhbV92YWx1ZXM9MiwgcGFyYW1fdmFsdWVzPTB4N2ZmZmMyNjJkOWUw LCAKICAgIGludm9jYXRpb25faGludD0weDdmZmZjMjYyZDhlMCkKICAgIGF0IC9idWlsZC9idWls ZGQvZ2xpYjIuMC0yLjE2LjUvZ29iamVjdC9nY2xvc3VyZS5jOjQ5MAojMjQgMHgwMDAwMmFiMmU5 ODk2OGZjIGluIHNpZ25hbF9lbWl0X3VubG9ja2VkX1IgKG5vZGU9MHg2MzMxMzAsIGRldGFpbD0w LCAKICAgIGluc3RhbmNlPTB4NjUyMTIwLCBlbWlzc2lvbl9yZXR1cm49MHg3ZmZmYzI2MmRiZTAs IAogICAgaW5zdGFuY2VfYW5kX3BhcmFtcz0weDdmZmZjMjYyZDllMCkKICAgIGF0IC9idWlsZC9i dWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ29iamVjdC9nc2lnbmFsLmM6MjQ3OAojMjUgMHgwMDAwMmFi MmU5ODk3Zjk5IGluIElBX19nX3NpZ25hbF9lbWl0X3ZhbGlzdCAoaW5zdGFuY2U9MHg2NTIxMjAs IAogICAgc2lnbmFsX2lkPTx2YWx1ZSBvcHRpbWl6ZWQgb3V0PiwgZGV0YWlsPTAsIHZhcl9hcmdz PTB4N2ZmZmMyNjJkYzQwKQogICAgYXQgL2J1aWxkL2J1aWxkZC9nbGliMi4wLTIuMTYuNS9nb2Jq ZWN0L2dzaWduYWwuYzoyMjA5CiMyNiAweDAwMDAyYWIyZTk4OTg2MjMgaW4gSUFfX2dfc2lnbmFs X2VtaXQgKGluc3RhbmNlPTB4MmFiMmU5YWJhY2E4LCAKICAgIHNpZ25hbF9pZD0wLCBkZXRhaWw9 MzMzMDM0NDIwMCkKICAgIGF0IC9idWlsZC9idWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ29iamVjdC9n c2lnbmFsLmM6MjI0MwojMjcgMHgwMDAwMmFiMmU5NTBlZWRlIGluID8/ICgpIGZyb20gL3Vzci9s aWIvbGliZ3RrLXgxMS0yLjAuc28uMAojMjggMHgwMDAwMmFiMmU5M2YzMTIzIGluIGd0a19wcm9w YWdhdGVfZXZlbnQgKCkKICAgZnJvbSAvdXNyL2xpYi9saWJndGsteDExLTIuMC5zby4wCiMyOSAw eDAwMDAyYWIyZTkzZjQxNmIgaW4gZ3RrX21haW5fZG9fZXZlbnQgKCkgZnJvbSAvdXNyL2xpYi9s aWJndGsteDExLTIuMC5zby4wCiMzMCAweDAwMDAyYWIyZTlmY2RmNmMgaW4gPz8gKCkgZnJvbSAv dXNyL2xpYi9saWJnZGsteDExLTIuMC5zby4wCiMzMSAweDAwMDAyYWIyZTlhZjQ4OTIgaW4gSUFf X2dfbWFpbl9jb250ZXh0X2Rpc3BhdGNoIChjb250ZXh0PTB4NjJiMmIwKQogICAgYXQgL2J1aWxk L2J1aWxkZC9nbGliMi4wLTIuMTYuNS9nbGliL2dtYWluLmM6MjAxMgojMzIgMHgwMDAwMmFiMmU5 YWY4MDFkIGluIGdfbWFpbl9jb250ZXh0X2l0ZXJhdGUgKGNvbnRleHQ9MHg2MmIyYjAsIGJsb2Nr PTEsIAogICAgZGlzcGF0Y2g9MSwgc2VsZj08dmFsdWUgb3B0aW1pemVkIG91dD4pCiAgICBhdCAv YnVpbGQvYnVpbGRkL2dsaWIyLjAtMi4xNi41L2dsaWIvZ21haW4uYzoyNjQ1CiMzMyAweDAwMDAy YWIyZTlhZjg1NGQgaW4gSUFfX2dfbWFpbl9sb29wX3J1biAobG9vcD0weDg3NzRkMCkKICAgIGF0 IC9idWlsZC9idWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ2xpYi9nbWFpbi5jOjI4NTMKIzM0IDB4MDAw MDJhYjJlOTNmNDU4NyBpbiBndGtfbWFpbiAoKSBmcm9tIC91c3IvbGliL2xpYmd0ay14MTEtMi4w LnNvLjAKIzM1IDB4MDAwMDAwMDAwMDQwMWVhYiBpbiBtYWluICgpCihnZGIpIHByaW50ICp0aGlz OwpObyBzeW1ib2wgInRoaXMiIGluIGN1cnJlbnQgY29udGV4dC4KKGdkYikgcHJpbnQgd2ViVmll dzsIG1tLCiQxID0gPHZhbHVlIG9wdGltaXplZCBvdXQ+CihnZGIpIHByaW50IGZyb2FtCBtbSwgb W0sIG1tLYW1lCiQyID0gPHZhbHVlIG9wdGltaXplZCBvdXQ+CihnZGIpIAokMyA9IDx2YWx1ZSBv cHRpbWl6ZWQgb3V0PgooZ2RiKSBwcmludCBkaWRDb25maXJtCiQ0ID0gKGdib29sZWFuICopIDB4 YzI2MmI0ZjgKKGdkYikgYnQKIzAgIDB4MDAwMDJhYjJlODZlZWE0NCBpbiB3ZWJraXRfd2ViX3Zp ZXdfcmVhbF9zY3JpcHRfY29uZmlybSAoCiAgICB3ZWJWaWV3PTx2YWx1ZSBvcHRpbWl6ZWQgb3V0 PiwgZnJhbWU9PHZhbHVlIG9wdGltaXplZCBvdXQ+LCAKICAgIG1lc3NhZ2U9PHZhbHVlIG9wdGlt aXplZCBvdXQ+LCBkaWRDb25maXJtPTB4YzI2MmI0ZjgpCiAgICBhdCAuLi9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDo2NzAKIzEgIDB4MDAwMDJhYjJlODZmMzllNSBpbiB3ZWJr aXRfbWFyc2hhbF9CT09MRUFOX19PQkpFQ1RfU1RSSU5HX0JPT0xFQU4gKCkKICAgZnJvbSAvdmFy L3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiMyICAweDAwMDAyYWIy ZTk4ODNlYmQgaW4gSUFfX2dfY2xvc3VyZV9pbnZva2UgKGNsb3N1cmU9MHg2N2ZmYTAsIAogICAg cmV0dXJuX3ZhbHVlPTB4N2ZmZmMyNjJiMDkwLCBuX3BhcmFtX3ZhbHVlcz00LCBwYXJhbV92YWx1 ZXM9MHg3ZmZmYzI2MmIxNTAsIAogICAgaW52b2NhdGlvbl9oaW50PTB4N2ZmZmMyNjJiMDUwKQog ICAgYXQgL2J1aWxkL2J1aWxkZC9nbGliMi4wLTIuMTYuNS9nb2JqZWN0L2djbG9zdXJlLmM6NDkw CiMzICAweDAwMDAyYWIyZTk4OTY4ZmMgaW4gc2lnbmFsX2VtaXRfdW5sb2NrZWRfUiAobm9kZT0w eDY4MDAxMCwgZGV0YWlsPTAsIAogICAgaW5zdGFuY2U9MHg2NTIxMjAsIGVtaXNzaW9uX3JldHVy bj0weDdmZmZjMjYyYjM1MCwgCiAgICBpbnN0YW5jZV9hbmRfcGFyYW1zPTB4N2ZmZmMyNjJiMTUw KQogICAgYXQgL2J1aWxkL2J1aWxkZC9nbGliMi4wLTIuMTYuNS9nb2JqZWN0L2dzaWduYWwuYzoy NDc4CiM0ICAweDAwMDAyYWIyZTk4OTdmOTkgaW4gSUFfX2dfc2lnbmFsX2VtaXRfdmFsaXN0IChp bnN0YW5jZT0weDY1MjEyMCwgCiAgICBzaWduYWxfaWQ9PHZhbHVlIG9wdGltaXplZCBvdXQ+LCBk ZXRhaWw9MCwgdmFyX2FyZ3M9MHg3ZmZmYzI2MmIzZTApCiAgICBhdCAvYnVpbGQvYnVpbGRkL2ds aWIyLjAtMi4xNi41L2dvYmplY3QvZ3NpZ25hbC5jOjIyMDkKIzUgIDB4MDAwMDJhYjJlOTg5ODQ4 MiBpbiBJQV9fZ19zaWduYWxfZW1pdF9ieV9uYW1lIChpbnN0YW5jZT0weDY1MjEyMCwgCiAgICBk ZXRhaWxlZF9zaWduYWw9MHgyYWIyZThlMDE5YTEgInNjcmlwdC1jb25maXJtIikKICAgIGF0IC9i dWlsZC9idWlsZGQvZ2xpYjIuMC0yLjE2LjUvZ29iamVjdC9nc2lnbmFsLmM6MjI2NwojNiAgMHgw MDAwMmFiMmU4NmUyNDk5IGluIFdlYktpdDo6Q2hyb21lQ2xpZW50OjpydW5KYXZhU2NyaXB0Q29u ZmlybSAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4w LnNvLjEKIzcgIDB4MDAwMDJhYjJlOGNjOWEyMiBpbiBXZWJDb3JlOjpDaHJvbWU6OnJ1bkphdmFT Y3JpcHRDb25maXJtICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xpYndl YmtpdC0xLjAuc28uMQojOCAgMHgwMDAwMmFiMmU4YjI2ZjFjIGluIFdlYkNvcmU6OkRPTVdpbmRv dzo6Y29uZmlybSAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9saWJ3ZWJr aXQtMS4wLnNvLjEKIzkgIDB4MDAwMDJhYjJlODkwNzA3YSBpbiBXZWJDb3JlOjpqc0RPTVdpbmRv d1Byb3RvdHlwZUZ1bmN0aW9uQ29uZmlybSAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWls ZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzEwIDB4MDAwMDJhYjJlODdhZmQ2MyBpbiBKU0M6 Ok1hY2hpbmU6OnByaXZhdGVFeGVjdXRlICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxk Ly5saWJzL2xpYndlYmtpdC0xLjAuc28uMQojMTEgMHgwMDAwMmFiMmU4N2I3MTNiIGluIEpTQzo6 TWFjaGluZTo6ZXhlY3V0ZSAoKQogICBmcm9tIC92YXIvc3JjL1dlYktpdC9idWlsZC8ubGlicy9s aWJ3ZWJraXQtMS4wLnNvLjEKIzEyIDB4MDAwMDJhYjJlOGFhMzJjMyBpbiBKU0M6OkpTRnVuY3Rp b246OmNhbGwgKCkKICAgZnJvbSAvdmFyL3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0 LTEuMC5zby4xCiMxMyAweDAwMDAyYWIyZThiZGIwOGYgaW4gV2ViQ29yZTo6SlNBYnN0cmFjdEV2 ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxk Ly5saWJzL2xpYndlYmtpdC0xLjAuc28uMQojMTQgMHgwMDAwMmFiMmU4N2M0ZGY1IGluIFdlYkNv cmU6OkV2ZW50VGFyZ2V0OjpoYW5kbGVMb2NhbEV2ZW50cyAoKQogICBmcm9tIC92YXIvc3JjL1dl YktpdC9idWlsZC8ubGlicy9saWJ3ZWJraXQtMS4wLnNvLjEKIzE1IDB4MDAwMDJhYjJlODdjNGMz NyBpbiBXZWJDb3JlOjpFdmVudFRhcmdldDo6ZGlzcGF0Y2hHZW5lcmljRXZlbnQgKCkKICAgZnJv bSAvdmFyL3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5zby4xCiMxNiAweDAw MDAyYWIyZThkMDgzNjMgaW4gV2ViQ29yZTo6RXZlbnRUYXJnZXROb2RlOjpkaXNwYXRjaEV2ZW50 ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xpYndlYmtpdC0xLjAuc28u MQojMTcgMHgwMDAwMmFiMmU4ZDA3Njc3IGluIFdlYkNvcmU6OkV2ZW50VGFyZ2V0Tm9kZTo6ZGlz cGF0Y2hNb3VzZUV2ZW50ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xp YndlYmtpdC0xLjAuc28uMQojMTggMHgwMDAwMmFiMmU4ZDA3ZjM4IGluIFdlYkNvcmU6OkV2ZW50 VGFyZ2V0Tm9kZTo6ZGlzcGF0Y2hNb3VzZUV2ZW50ICgpCiAgIGZyb20gL3Zhci9zcmMvV2ViS2l0 L2J1aWxkLy5saWJzL2xpYndlYmtpdC0xLjAuc28uMQojMTkgMHgwMDAwMmFiMmU4Y2U2MjYyIGlu IFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGlzcGF0Y2hNb3VzZUV2ZW50ICgpCiAgIGZyb20gL3Zh ci9zcmMvV2ViS2l0L2J1aWxkLy5saWJzL2xpYndlYmtpdC0xLjAuc28uMQojMjAgMHgwMDAwMmFi MmU4Y2VhMDhjIGluIFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VSZWxlYXNlRXZl bnQgKCkKICAgZnJvbSAvdmFyL3NyYy9XZWJLaXQvYnVpbGQvLmxpYnMvbGlid2Via2l0LTEuMC5z by4xCiMyMSAweDAwMDAyYWIyZTg2ZWZiNTcgaW4gd2Via2l0X3dlYl92aWV3X2J1dHRvbl9yZWxl YXNlX2V2ZW50ICgKICAgIHdpZGdldD08dmFsdWUgb3B0aW1pemVkIG91dD4sIGV2ZW50PTB4N2Qy ZjMwKQotLS1UeXBlIDxyZXR1cm4+IHRvIGNvbnRpbnVlLCBvciBxIDxyZXR1cm4+IHRvIHF1aXQt LS1xCiBhdCAuLi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3UXVpdAooZ2RiKSBkaXNhcyAnd2Vi a2l0X3dlYl92aWV3X3JlYWxfc2NyaXB0X2NvbmZpcm0nCkR1bXAgb2YgYXNzZW1ibGVyIGNvZGUg Zm9yIGZ1bmN0aW9uIHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9jb25maXJtOgoweDAwMDAy YWIyZTg2ZWVhMzAgPHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9jb25maXJtKzA+OglwdXNo ICAgJXJieAoweDAwMDAyYWIyZTg2ZWVhMzEgPHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9j b25maXJtKzE+Ogl4b3IgICAgJXI5ZCwlcjlkCjB4MDAwMDJhYjJlODZlZWEzNCA8d2Via2l0X3dl Yl92aWV3X3JlYWxfc2NyaXB0X2NvbmZpcm0rND46CW1vdiAgICAlcmN4LCVyYngKMHgwMDAwMmFi MmU4NmVlYTM3IDx3ZWJraXRfd2ViX3ZpZXdfcmVhbF9zY3JpcHRfY29uZmlybSs3PjoJeG9yICAg ICVyOGQsJXI4ZAoweDAwMDAyYWIyZTg2ZWVhM2EgPHdlYmtpdF93ZWJfdmlld19yZWFsX3Njcmlw dF9jb25maXJtKzEwPjoJbW92ICAgICQweDEsJWVjeAoweDAwMDAyYWIyZTg2ZWVhM2YgPHdlYmtp dF93ZWJfdmlld19yZWFsX3NjcmlwdF9jb25maXJtKzE1PjoJY2FsbHEgIDB4MmFiMmU4NmVlNzEw IDx3ZWJraXRfd2ViX3ZpZXdfc2NyaXB0X2RpYWxvZz4KMHgwMDAwMmFiMmU4NmVlYTQ0IDx3ZWJr aXRfd2ViX3ZpZXdfcmVhbF9zY3JpcHRfY29uZmlybSsyMD46CW1vdiAgICAlZWF4LCglcmJ4KQow eDAwMDAyYWIyZTg2ZWVhNDYgPHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9jb25maXJtKzIy PjoJbW92ICAgICQweDEsJWVheAoweDAwMDAyYWIyZTg2ZWVhNGIgPHdlYmtpdF93ZWJfdmlld19y ZWFsX3NjcmlwdF9jb25maXJtKzI3PjoJcG9wICAgICVyYngKMHgwMDAwMmFiMmU4NmVlYTRjIDx3 ZWJraXRfd2ViX3ZpZXdfcmVhbF9zY3JpcHRfY29uZmlybSsyOD46CXJldHEgICAKRW5kIG9mIGFz c2VtYmxlciBkdW1wLgooZ2RiKSBwcmludCAkcmlwCiQ1ID0gKHZvaWQgKCopKHZvaWQpKSAweDJh YjJlODZlZWE0NCA8d2Via2l0X3dlYl92aWV3X3JlYWxfc2NyaXB0X2NvbmZpcm0rMjA+CihnZGIp IHByaW50ICRlYXgKJDYgPSB2b2lkCihnZGIpIHByaW50IHIIG1tLZWF4Ck5vIHN5bWJvbCAiZWF4 IiBpbiBjdXJyZW50IGNvbnRleHQuCihnZGIpIHByaW50ICRyYngKJDcgPSAzMjYxMjQ4NzYwCihn ZGIpIHByaW50IDB4YzI2MmI0ZjgKJDggPSAzMjYxMjQ4NzYwCihnZGIpIHByaW50IG1lc3NhZ2UK JDkgPSA8dmFsdWUgb3B0aW1pemVkIG91dD4KKGdkYikgcXVpdApUaGUgcHJvZ3JhbSBpcyBydW5u aW5nLiAgRXhpdCBhbnl3YXk/ICh5IG9yIG4pIHkKbGtjbEBnb256YWxlejovdmFyL3NyYy9XZWJL aXQvYnVpbGQkIGV4aXQKClNjcmlwdCBkb25lIG9uIEZyaSAxOSBTZXAgMjAwOCAxNzo1ODoyMiBC U1QK 28472 2009-03-11 04:13:42 -0700 2009-03-11 12:26:41 -0700 we marshal the didConfirm parameter to a boolean not to a pointer webkigtk-20940.patch text/plain 3785 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZmM5Mjc0My4uMzcyZGJlMyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMy0xMSAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB1c2Ugb2YgY29uZmlybSBkaWFsb2cg KHllcy9ubykgY2F1c2VzIHNlZ2ZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDk0MAorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwOgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3Lmg6CisKIDIwMDktMDMtMTAgIFhh biBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhl eSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGNlYWRm YTkuLjZhOGQ0MDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC03ODksOSAr Nzg5LDkgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9hbGVy dChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXQKICAgICByZXR1cm4gVFJVRTsKIH0KIAot c3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19yZWFsX3NjcmlwdF9jb25maXJtKFdlYktp dFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIG1l c3NhZ2UsIGdib29sZWFuKiBkaWRDb25maXJtKQorc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJf dmlld19yZWFsX3NjcmlwdF9jb25maXJtKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFdl YkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIG1lc3NhZ2UsIGdib29sZWFuIGRpZENvbmZpcm0p CiB7Ci0gICAgKmRpZENvbmZpcm0gPSB3ZWJraXRfd2ViX3ZpZXdfc2NyaXB0X2RpYWxvZyh3ZWJW aWV3LCBmcmFtZSwgbWVzc2FnZSwgV0VCS0lUX1NDUklQVF9ESUFMT0dfQ09ORklSTSwgMCwgMCk7 CisgICAgZGlkQ29uZmlybSA9IHdlYmtpdF93ZWJfdmlld19zY3JpcHRfZGlhbG9nKHdlYlZpZXcs IGZyYW1lLCBtZXNzYWdlLCBXRUJLSVRfU0NSSVBUX0RJQUxPR19DT05GSVJNLCAwLCAwKTsKICAg ICByZXR1cm4gVFJVRTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5oIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oCmluZGV4IDU0M2M3 NzcuLjAyNjA1MGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu aAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmgKQEAgLTg5LDcgKzg5LDcg QEAgc3RydWN0IF9XZWJLaXRXZWJWaWV3Q2xhc3MgewogICAgIGdib29sZWFuICAgICAgICAgICAg ICAgICAgICgqIHNjcmlwdF9jb25maXJtKSAgICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAq d2ViX3ZpZXcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFdlYktpdFdlYkZyYW1lICAgICAgICpmcmFtZSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgZ2NoYXIg ICAgICAgICAgKmNvbmZpcm1fbWVzc2FnZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAgICAgICAgICAgKmRpZF9j b25maXJtKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZ2Jvb2xlYW4gICAgICAgICAgICAgZGlkX2NvbmZpcm0pOwogICAgIGdib29s ZWFuICAgICAgICAgICAgICAgICAgICgqIHNjcmlwdF9wcm9tcHQpICAgICAgICAgIChXZWJLaXRX ZWJWaWV3ICAgICAgICAqd2ViX3ZpZXcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYktpdFdlYkZyYW1lICAgICAgICpmcmFtZSwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3QgZ2NoYXIgICAgICAgICAgKm1lc3NhZ2UsCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggODYxNzFhOC4uYWMxYzAw NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTAzLTExICBKYW4gTWljaGFlbCBBbG9uem8g IDxqbWFsb256b0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIHVzZSBvZiBjb25maXJtIGRpYWxvZyAoeWVzL25vKSBjYXVzZXMgc2Vn ZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTQwCisKKyAgICAgICAgUGFzc2VzIHRoZSB0ZXN0IExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRv dy9hbGVydC11bmRlZmluZWQuaHRtbAorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHdlYlZpZXdTY3JpcHRDb25maXJtKToKKwogMjAw OS0wMy0wOCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBhYzg2NTc5Li5hMmNiZGM0 IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRy ZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJl ZS5jcHAKQEAgLTQzMywxMCArNDMzLDEwIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJWaWV3U2NyaXB0 UHJvbXB0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFdlYkZyYW1lKiBmcmFtCiAgICAg cmV0dXJuIFRSVUU7CiB9CiAKLXN0YXRpYyBnYm9vbGVhbiB3ZWJWaWV3U2NyaXB0Q29uZmlybShX ZWJLaXRXZWJWaWV3KiB2aWV3LCBXZWJLaXRXZWJGcmFtZSogZnJhbWUsIGNvbnN0IGdjaGFyKiBt ZXNzYWdlLCBnYm9vbGVhbiogZGlkQ29uZmlybSwgZ3BvaW50ZXIgZGF0YSkKK3N0YXRpYyBnYm9v bGVhbiB3ZWJWaWV3U2NyaXB0Q29uZmlybShXZWJLaXRXZWJWaWV3KiB2aWV3LCBXZWJLaXRXZWJG cmFtZSogZnJhbWUsIGNvbnN0IGdjaGFyKiBtZXNzYWdlLCBnYm9vbGVhbiBkaWRDb25maXJtLCBn cG9pbnRlciBkYXRhKQogewogICAgIGZwcmludGYoc3Rkb3V0LCAiQ09ORklSTTogJXNcbiIsIG1l c3NhZ2UpOwotICAgICpkaWRDb25maXJtID0gVFJVRTsKKyAgICBkaWRDb25maXJtID0gVFJVRTsK ICAgICByZXR1cm4gVFJVRTsKIH0KIAo= 28487 2009-03-11 12:26:41 -0700 2009-03-14 05:45:37 -0700 change the marshaller instead 20940.patch text/plain 1935 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNWNkMDhjZi4uMjA1ZDljYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wMy0xMSAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1c2Ugb2YgY29uZmlybSBk aWFsb2cgKHllcy9ubykgY2F1c2VzIHNlZ2ZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk0MAorCisgICAgICAgIENoYW5nZSB0aGUgc2NyaXB0 LWNvbmZpcm0gbWFyc2hhbGxlciBmcm9tIE9CSkVDVCxTVFJJTkcsQk9PTEVBTiB0bworICAgICAg ICBPQkpFQ1QsU1RSSU5HLFBPSU5URVIKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcDoKKyAgICAgICAgKiB3ZWJraXRtYXJzaGFsLmxpc3Q6CisKKzIwMDktMDMtMTEgIEphbiBN aWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgSG9sZ2VyIEZyZXl0aGVyLgogCiAgICAgICAgIEd0a10gSW1wbGVtZW50IExheW91dFRlc3RD b250cm9sbGVyR3RrOjpzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCmluZGV4IGQ4NzYzNWYuLjgwMzgxNTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCkBAIC0xMzM5LDkgKzEzMzksOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAg ICAgICAgIEdfU1RSVUNUX09GRlNFVChXZWJLaXRXZWJWaWV3Q2xhc3MsIHNjcmlwdF9jb25maXJt KSwKICAgICAgICAgICAgIGdfc2lnbmFsX2FjY3VtdWxhdG9yX3RydWVfaGFuZGxlZCwKICAgICAg ICAgICAgIE5VTEwsCi0gICAgICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19PQkpFQ1Rf U1RSSU5HX0JPT0xFQU4sCisgICAgICAgICAgICB3ZWJraXRfbWFyc2hhbF9CT09MRUFOX19PQkpF Q1RfU1RSSU5HX1BPSU5URVIsCiAgICAgICAgICAgICBHX1RZUEVfQk9PTEVBTiwgMywKLSAgICAg ICAgICAgIFdFQktJVF9UWVBFX1dFQl9GUkFNRSwgR19UWVBFX1NUUklORywgR19UWVBFX0JPT0xF QU4pOworICAgICAgICAgICAgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FLCBHX1RZUEVfU1RSSU5HLCBH X1RZUEVfUE9JTlRFUik7CiAKICAgICAvKioKICAgICAgKiBXZWJLaXRXZWJWaWV3OjpzY3JpcHQt cHJvbXB0OgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXRtYXJzaGFsLmxpc3QgYi9XZWJL aXQvZ3RrL3dlYmtpdG1hcnNoYWwubGlzdAppbmRleCAzYWFmMzEzLi5iNzE0YTdjIDEwMDY0NAot LS0gYS9XZWJLaXQvZ3RrL3dlYmtpdG1hcnNoYWwubGlzdAorKysgYi9XZWJLaXQvZ3RrL3dlYmtp dG1hcnNoYWwubGlzdApAQCAtMyw3ICszLDcgQEAgQk9PTEVBTjpPQkpFQ1QKIEJPT0xFQU46T0JK RUNULE9CSkVDVCxPQkpFQ1QsT0JKRUNUCiBCT09MRUFOOk9CSkVDVCxPQkpFQ1QsU1RSSU5HLE9C SkVDVAogQk9PTEVBTjpPQkpFQ1QsU1RSSU5HCi1CT09MRUFOOk9CSkVDVCxTVFJJTkcsQk9PTEVB TgorQk9PTEVBTjpPQkpFQ1QsU1RSSU5HLFBPSU5URVIKIEJPT0xFQU46T0JKRUNULFNUUklORyxT VFJJTkcsU1RSSU5HCiBCT09MRUFOOlNUUklORyxJTlQsU1RSSU5HCiBCT09MRUFOOlZPSUQK