209390 2020-03-21 21:52:35 -0700 [LFC] Box::establishesBlockFormattingContext should check isInitialContainingBlock 2020-03-23 07:22:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1632580 0 zalan 2020-03-21 21:52:35 -0700 and not !parent(). 1632581 1 webkit-bug-importer 2020-03-21 21:53:35 -0700 <rdar://problem/60735021> 1632583 2 394193 zalan 2020-03-21 22:00:24 -0700 Created attachment 394193 Patch 1632629 3 394193 koivisto 2020-03-22 06:50:29 -0700 Comment on attachment 394193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394193&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:74 > + if (isInitialContainingBlock()) > return true; Maybe ASSERT(parent()) after? 1632630 4 zalan 2020-03-22 07:02:31 -0700 (In reply to Antti Koivisto from comment #3) > Comment on attachment 394193 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394193&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:74 > > + if (isInitialContainingBlock()) > > return true; > > Maybe ASSERT(parent()) after? In the upcoming patch, parent() is going to return const Container&. 1632831 5 ews-feeder 2020-03-23 07:22:10 -0700 Committed r258836: <https://trac.webkit.org/changeset/258836> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394193. 394193 2020-03-21 22:00:24 -0700 2020-03-23 07:22:11 -0700 Patch bug-209390-20200321220023.patch text/plain 2150 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzM0OTM3NWRjM2QyYzBk MGVjYzc0MjZjMmZkYzc3MDdlZjU5ODVmZC4uYTk1NWNkZDIyZDk5MDdlMTRmNmNmZmVmMDkxYmE0 Y2VmMmUxODMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQm94Ojplc3RhYmxp c2hlc0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQgc2hvdWxkIGNoZWNrIGlzSW5pdGlhbENvbnRhaW5p bmdCbG9jaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA5MzkwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MDczNTAyMT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIG1vcmUgY29ycmVjdCB0byBj YWxsIGlzSW5pdGlhbENvbnRhaW5pbmdCbG9jaygpIHRvIGNoZWNrIGlmIHRoZSBjdXJyZW50IGJv eCBpcyB0aGUgSUNCLgorCisgICAgICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Qm94Ojplc3RhYmxpc2hlc0Jsb2NrRm9ybWF0 dGluZ0NvbnRleHQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCb3g6OmluaXRp YWxDb250YWluaW5nQmxvY2sgY29uc3QpOgorCiAyMDIwLTAzLTIxICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gTGF5b3V0OjpCb3g6OmNvbnRhaW5pbmdC bG9jayBzaG91bGQgcmV0dXJuIGEgY29uc3QgQ29udGFpbmVyQm94JgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKaW5kZXggMTE4Y2M1MzUxMTEwMTA2 NjA0YjczNGJkOWZlYmEyMmVkOGQ1ZjhlZC4uNDc5YTc5M2E1ZTc2NTI1ZWQ0M2I5Nzg3YTY3MTkz Yjg4OTczMmNmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUv TGF5b3V0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlv dXRCb3guY3BwCkBAIC02OSw4ICs2OSw4IEBAIGJvb2wgQm94Ojplc3RhYmxpc2hlc0Zvcm1hdHRp bmdDb250ZXh0KCkgY29uc3QKIAogYm9vbCBCb3g6OmVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5n Q29udGV4dCgpIGNvbnN0CiB7Ci0gICAgLy8gSW5pdGlhbCBDb250YWluaW5nIEJsb2NrIGFsd2F5 cyBjcmVhdGVzIGEgbmV3IChpbml0YWwpIGJsb2NrIGZvcm1hdHRpbmcgY29udGV4dC4KLSAgICBp ZiAoIXBhcmVudCgpKQorICAgIC8vIElDQiBhbHdheXMgY3JlYXRlcyBhIG5ldyAoaW5pdGFsKSBi bG9jayBmb3JtYXR0aW5nIGNvbnRleHQuCisgICAgaWYgKGlzSW5pdGlhbENvbnRhaW5pbmdCbG9j aygpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIGlmIChpc1RhYmxlV3JhcHBlckJveCgp KQpAQCAtMjQ1LDEwICsyNDUsMTAgQEAgY29uc3QgQ29udGFpbmVyQm94JiBCb3g6OmluaXRpYWxD b250YWluaW5nQmxvY2soKSBjb25zdAogICAgIGlmIChpc0luaXRpYWxDb250YWluaW5nQmxvY2so KSkKICAgICAgICAgcmV0dXJuIGRvd25jYXN0PENvbnRhaW5lckJveD4oKnRoaXMpOwogCi0gICAg YXV0byogcGFyZW50ID0gdGhpcy0+cGFyZW50KCk7Ci0gICAgZm9yICg7IHBhcmVudC0+cGFyZW50 KCk7IHBhcmVudCA9IHBhcmVudC0+cGFyZW50KCkpIHsgfQorICAgIGF1dG8qIGFuY2VzdG9yID0g cGFyZW50KCk7CisgICAgZm9yICg7IGFuY2VzdG9yLT5wYXJlbnQoKTsgYW5jZXN0b3IgPSBhbmNl c3Rvci0+cGFyZW50KCkpIHsgfQogCi0gICAgcmV0dXJuICpwYXJlbnQ7CisgICAgcmV0dXJuICph bmNlc3RvcjsKIH0KIAogYm9vbCBCb3g6OmlzSW5Gb3JtYXR0aW5nQ29udGV4dE9mKGNvbnN0IENv bnRhaW5lckJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290KSBjb25zdAo=