209384 2020-03-21 18:36:05 -0700 Set INSTALLHDRS_SCRIPT_PHASE in ANGLE builds 2020-03-21 19:57:41 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=121370 InRadar P2 Normal --- 1 krollin krollin ap ddkilzer dino ews-watchlist graouts kondapallykalyan mitz webkit-bug-importer oldest_to_newest 1632554 0 krollin 2020-03-21 18:36:05 -0700 Production ANGLE builds are technically non-compliant. During the installhdrs build action, ANGLE headers are exported but are not post-processed. This differs from the install build action, where the exported headers *are* post-processed. The headers need to be treated identically under both actions. The post-processing is enabled by setting the INSTALLHDRS_SCRIPT_PHASE build setting to YES. Most other WebKit projects already set this setting (see, for example, https://trac.webkit.org/changeset/155787, https://trac.webkit.org/changeset/110327, and https://trac.webkit.org/changeset/41417). 1632555 1 krollin 2020-03-21 18:36:20 -0700 <rdar://problem/59513380> 1632556 2 394187 krollin 2020-03-21 18:38:29 -0700 Created attachment 394187 Patch 1632558 3 ews-watchlist 2020-03-21 18:39:41 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1632560 4 394187 mitz 2020-03-21 18:41:19 -0700 Comment on attachment 394187 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394187&action=review > Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig:7 > APPLY_RULES_IN_COPY_HEADERS = $(USE_NEW_BUILD_SYSTEM); Doesn’t this (also) need to change to YES? It appears as if at least some of the processing is done by the "Files '*.h' using Script" build rule that runs the “adjust-angle-include-paths-rule” script. 1632570 5 krollin 2020-03-21 19:52:09 -0700 No, it doesn't need to change. There are two ways of post-processing the headers. One way is XCBuild compatible, the other is backward compatible with older Xcode's. The former is supported by the adjust-angle-include-paths-rule script and selected by APPLY_RULES_IN_COPY_HEADERS=YES, as you noted. The latter continues to be supported by adjust-angle-include-paths.sh, which is executed if APPLY_RULES_IN_COPY_HEADERS is not YES. 1632575 6 ews-feeder 2020-03-21 19:57:40 -0700 Committed r258815: <https://trac.webkit.org/changeset/258815> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394187. 394187 2020-03-21 18:38:29 -0700 2020-03-21 19:57:41 -0700 Patch bug-209384-20200321183829.patch text/plain 2003 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZmM4YjdlMjA4MWNjNTY1YTUwYTZjYmZiOGYyZTI2YzdmN2Y4MTg5NS4uMTViNTdmMGEyOWQ3 MTZiNDExNDJiNWYwMjQzYTNiZjQ0ZjRlMjdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAzLTIxICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFw cGxlLmNvbT4KKworICAgICAgICBTZXQgSU5TVEFMTEhEUlNfU0NSSVBUX1BIQVNFIGluIEFOR0xF IGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA5Mzg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81OTUxMzM4MD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9kdWN0aW9uIEFOR0xFIGJ1aWxk cyBhcmUgdGVjaG5pY2FsbHkgbm9uLWNvbXBsaWFudC4gRHVyaW5nIHRoZQorICAgICAgICBpbnN0 YWxsaGRycyBidWlsZCBhY3Rpb24sIEFOR0xFIGhlYWRlcnMgYXJlIGV4cG9ydGVkIGJ1dCBhcmUg bm90CisgICAgICAgIHBvc3QtcHJvY2Vzc2VkLiBUaGlzIGRpZmZlcnMgZnJvbSB0aGUgaW5zdGFs bCBidWlsZCBhY3Rpb24sIHdoZXJlIHRoZQorICAgICAgICBleHBvcnRlZCBoZWFkZXJzICphcmUq IHBvc3QtcHJvY2Vzc2VkLiBUaGUgaGVhZGVycyBuZWVkIHRvIGJlIHRyZWF0ZWQKKyAgICAgICAg aWRlbnRpY2FsbHkgdW5kZXIgYm90aCBhY3Rpb25zLiBUaGUgcG9zdC1wcm9jZXNzaW5nIGlzIGVu YWJsZWQgYnkKKyAgICAgICAgc2V0dGluZyB0aGUgSU5TVEFMTEhEUlNfU0NSSVBUX1BIQVNFIGJ1 aWxkIHNldHRpbmcgdG8gWUVTLiBNb3N0IG90aGVyCisgICAgICAgIFdlYktpdCBwcm9qZWN0cyBh bHJlYWR5IHNldCB0aGlzIHNldHRpbmcgKHNlZSwgZm9yIGV4YW1wbGUsCisgICAgICAgIGh0dHBz Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNTU3ODcsCisgICAgICAgIGh0dHBzOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTAzMjcsIGFuZAorICAgICAgICBodHRwczovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvNDE0MTcpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMv QU5HTEUueGNjb25maWc6CisKIDIwMjAtMDMtMTUgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW0FOR0xFXSBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9zcmMvY29tbW9uL3V0aWxpdGllcy5jcHA6MTA6IHdhcm5pbmc6IGlnbm9yaW5nICNwcmFnbWEg Y2xhbmcgZGlhZ25vc3RpYyBbLVd1bmtub3duLXByYWdtYXNdCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9BTkdMRS54Y2NvbmZpZyBiL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0FOR0xFLnhjY29uZmlnCmluZGV4IGQ0MDU0 NzEzYTg2MzIwZjhlNzhhMzYyNmQ5MjY0NzMwYjJkODgzY2EuLjdjYzE5NTFkMDU1OTQ4MDNlYzkx MmU0OTczMzc1NDUwMGUwZTNkNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0NvbmZpZ3VyYXRpb25zL0FOR0xFLnhjY29uZmlnCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL0NvbmZpZ3VyYXRpb25zL0FOR0xFLnhjY29uZmlnCkBAIC0zLDYgKzMsNyBAQAogCiBQUk9E VUNUX05BTUUgPSBBTkdMRTsKIAorSU5TVEFMTEhEUlNfU0NSSVBUX1BIQVNFID0gWUVTOwogQVBQ TFlfUlVMRVNfSU5fQ09QWV9IRUFERVJTID0gJChVU0VfTkVXX0JVSUxEX1NZU1RFTSk7CiBDTEFO R19XQVJOX0JPT0xfQ09OVkVSU0lPTiA9IFlFUzsKIENMQU5HX1dBUk5fRU5VTV9DT05WRVJTSU9O ID0gWUVTOwo=