209363 2020-03-20 15:09:01 -0700 hasObservableSideEffectsForRegExpSplit doesn't check for @@match override 2020-03-24 17:15:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209524 InRadar P2 Normal --- 1 ross.kirsling ross.kirsling ews-watchlist joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1632311 0 ross.kirsling 2020-03-20 15:09:01 -0700 hasObservableSideEffectsForRegExpSplit doesn't check for @@match override 1632314 1 394136 ross.kirsling 2020-03-20 15:15:59 -0700 Created attachment 394136 Patch 1632322 2 webkit-bug-importer 2020-03-20 15:31:52 -0700 <rdar://problem/60707365> 1632343 3 394136 msaboff 2020-03-20 15:57:11 -0700 Comment on attachment 394136 Patch r=me. Looks good. 1632352 4 ross.kirsling 2020-03-20 16:06:04 -0700 (In reply to Michael Saboff from comment #3) > Comment on attachment 394136 [details] > Patch > > r=me. Looks good. Thanks, Michael! 1632402 5 ews-feeder 2020-03-20 17:38:52 -0700 Committed r258801: <https://trac.webkit.org/changeset/258801> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394136. 1632715 6 394136 ysuzuki 2020-03-22 18:08:52 -0700 Comment on attachment 394136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394136&action=review > Source/JavaScriptCore/builtins/RegExpPrototype.js:467 > + if (regexp.@@match !== @regExpPrototypeSymbolMatch) > + return true; Why don't we use @tryGetById for this access? 1632720 7 ross.kirsling 2020-03-22 19:01:03 -0700 (In reply to Yusuke Suzuki from comment #6) > Comment on attachment 394136 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394136&action=review > > > Source/JavaScriptCore/builtins/RegExpPrototype.js:467 > > + if (regexp.@@match !== @regExpPrototypeSymbolMatch) > > + return true; > > Why don't we use @tryGetById for this access? I was just mimicking this: https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/builtins/StringPrototype.js#L222 https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/builtins/StringPrototype.js#L249 I didn't realize @tryGetById worked with symbols, but I can make an update if you prefer. 1632721 8 ysuzuki 2020-03-22 19:10:04 -0700 (In reply to Ross Kirsling from comment #7) > (In reply to Yusuke Suzuki from comment #6) > > Comment on attachment 394136 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=394136&action=review > > > > > Source/JavaScriptCore/builtins/RegExpPrototype.js:467 > > > + if (regexp.@@match !== @regExpPrototypeSymbolMatch) > > > + return true; > > > > Why don't we use @tryGetById for this access? > > I was just mimicking this: > https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/builtins/ > StringPrototype.js#L222 > https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/builtins/ > StringPrototype.js#L249 > > I didn't realize @tryGetById worked with symbols, but I can make an update > if you prefer. While @tryGetById is not observable to users, usual get can be observable by setting a getter here. So if this check is not observable to users, we need to use @tryGetById. For example, String#replace is accessing @@replace explicitly in an observable way in https://tc39.es/ecma262/#sec-string.prototype.replace. So, xxx.@@replace is fine. On the other hand, I think hasObservableSideEffectsForRegExpSplit should not be observable to users. So we need to use @tryGetById. 1632722 9 ross.kirsling 2020-03-22 19:15:45 -0700 (In reply to Yusuke Suzuki from comment #8) > While @tryGetById is not observable to users, usual get can be observable by > setting a getter here. > So if this check is not observable to users, we need to use @tryGetById. > > For example, String#replace is accessing @@replace explicitly in an > observable way in https://tc39.es/ecma262/#sec-string.prototype.replace. So, > xxx.@@replace is fine. > > On the other hand, I think hasObservableSideEffectsForRegExpSplit should not > be observable to users. > So we need to use @tryGetById. Oh! You're quite right, thanks for that explanation. Will fix. 1632964 10 ross.kirsling 2020-03-23 12:05:38 -0700 (In reply to Ross Kirsling from comment #9) > Oh! You're quite right, thanks for that explanation. Will fix. Committed r258865: <https://trac.webkit.org/changeset/258865> 1633594 11 saam 2020-03-24 15:45:37 -0700 (In reply to Ross Kirsling from comment #10) > (In reply to Ross Kirsling from comment #9) > > Oh! You're quite right, thanks for that explanation. Will fix. > > Committed r258865: <https://trac.webkit.org/changeset/258865> In your fix, it feels like the else in your ternary should assert it's looking at a symbol. 1633633 12 ysuzuki 2020-03-24 16:12:38 -0700 (In reply to Saam Barati from comment #11) > (In reply to Ross Kirsling from comment #10) > > (In reply to Ross Kirsling from comment #9) > > > Oh! You're quite right, thanks for that explanation. Will fix. > > > > Committed r258865: <https://trac.webkit.org/changeset/258865> > > In your fix, it feels like the else in your ternary should assert it's > looking at a symbol. Yeah, I think this is not good. Super easiest way to fix this problem is having @tryGetByIdWellKnownSymbol(..., "match"), and emit try_get_by_id with well-known symbol. 1633636 13 ross.kirsling 2020-03-24 16:15:43 -0700 (In reply to Yusuke Suzuki from comment #12) > (In reply to Saam Barati from comment #11) > > (In reply to Ross Kirsling from comment #10) > > > (In reply to Ross Kirsling from comment #9) > > > > Oh! You're quite right, thanks for that explanation. Will fix. > > > > > > Committed r258865: <https://trac.webkit.org/changeset/258865> > > > > In your fix, it feels like the else in your ternary should assert it's > > looking at a symbol. > > Yeah, I think this is not good. Super easiest way to fix this problem is > having @tryGetByIdWellKnownSymbol(..., "match"), and emit try_get_by_id with > well-known symbol. Is this better than asserting identifier().isPrivateName() for the ResolveNode case? 1633655 14 ysuzuki 2020-03-24 16:45:17 -0700 Discussed with Ross in slack, we will open a bug to fix the above issue. 1633682 15 ross.kirsling 2020-03-24 17:15:09 -0700 (In reply to Yusuke Suzuki from comment #14) > Discussed with Ross in slack, we will open a bug to fix the above issue. Opened bug 209524. 394136 2020-03-20 15:15:59 -0700 2020-03-20 17:38:52 -0700 Patch bug-209363-20200320151558.patch text/plain 6539 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZDg1OWY1NDQyNzFiOTMzZDJmNzY3NmQxMzFiYjhlMDg2YTY0YmI3Li45MGM4OGZkZTgxMTZjOGRm OTdiYzU3MDE3ZDA2NWZlZTgyNTI5NjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wMy0yMCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgaGFzT2JzZXJ2YWJsZVNpZGVFZmZlY3RzRm9yUmVnRXhwU3BsaXQg ZG9lc24ndCBjaGVjayBmb3IgQEBtYXRjaCBvdmVycmlkZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3VyIFJlZ0V4cC5wcm90b3R5cGVbQEBzcGxpdF0g aW1wbGVtZW50YXRpb24gaGFzIGEgZmFzdCBwYXRoIGZvciB1bmFkdWx0ZXJlZCBSZWdFeHAgb2Jq ZWN0cywKKyAgICAgICAgYnV0IHdlJ3JlIHVzaW5nIHRoYXQgZmFzdCBwYXRoIGV2ZW4gd2hlbiBA QG1hdGNoIGhhcyBiZWVuIG92ZXJyaWRkZW4uCisKKyAgICAgICAgVGhpcyBpcyBpbGxlZ2l0aW1h dGUgYmVjYXVzZSB0aGUgUmVnRXhwIHNwZWNpZXMgY29uc3RydWN0b3IgY2FsbHMgSXNSZWdFeHAs IHdoaWNoIGhpdHMgdGhlIEBAbWF0Y2ggZ2V0dGVyLgorCisgICAgICAgICogYnVpbHRpbnMvQnVp bHRpbk5hbWVzLmg6CisgICAgICAgICogYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzOgorICAg ICAgICAoZ2xvYmFsUHJpdmF0ZS5oYXNPYnNlcnZhYmxlU2lkZUVmZmVjdHNGb3JSZWdFeHBTcGxp dCk6CisgICAgICAgICogYnl0ZWNvZGUvTGlua1RpbWVDb25zdGFudC5oOgorICAgICAgICAqIHJ1 bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6 aW5pdCk6CisKIDIwMjAtMDMtMjAgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnku Y29tPgogCiAgICAgICAgIFJlZ0V4cC5wcm90b3R5cGVbQEByZXBsYWNlXSBkb2Vzbid0IGNvZXJj ZSByZXN1bHQgaW5kZXggdG8gaW50ZWdlcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2J1aWx0aW5zL0J1aWx0aW5OYW1lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL0J1aWx0aW5OYW1lcy5oCmluZGV4IDA2M2M3M2Q1MmNmOGM4NzFiMDliMjg2MmRiNDQ5ZWIw MGYzZDc2YzAuLjE2ZmYxZjk2YmFkZmFlMzQ3Y2Y3YmZiMzI1NTcyMmY5MGExZDk2MDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9CdWlsdGluTmFtZXMuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQnVpbHRpbk5hbWVzLmgKQEAgLTE0OCw2 ICsxNDgsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICBtYWNybyhyZWdFeHBQcm90b1NvdXJjZUdl dHRlcikgXAogICAgIG1hY3JvKHJlZ0V4cFByb3RvU3RpY2t5R2V0dGVyKSBcCiAgICAgbWFjcm8o cmVnRXhwUHJvdG9Vbmljb2RlR2V0dGVyKSBcCisgICAgbWFjcm8ocmVnRXhwUHJvdG90eXBlU3lt Ym9sTWF0Y2gpIFwKICAgICBtYWNybyhyZWdFeHBQcm90b3R5cGVTeW1ib2xSZXBsYWNlKSBcCiAg ICAgbWFjcm8ocmVnRXhwU2VhcmNoRmFzdCkgXAogICAgIG1hY3JvKHJlZ0V4cFNwbGl0RmFzdCkg XApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3Rv dHlwZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9SZWdFeHBQcm90b3R5cGUu anMKaW5kZXggY2RkMGE5NzViOTU1MjcwMDczZTAxOGY2Mzc0NmQxNmQ3OWJlYTNmZC4uZWUyN2Y2 ZjAxNTA5Yzk3MmMyNDBkNjE4MTk3NDQyOGJiNDIxMTVhYyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3RvdHlwZS5qcworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzCkBAIC00NTksMTAgKzQ1OSwx MiBAQCBmdW5jdGlvbiBoYXNPYnNlcnZhYmxlU2lkZUVmZmVjdHNGb3JSZWdFeHBTcGxpdChyZWdl eHApCiAgICAgaWYgKHJlZ2V4cFVuaWNvZGUgIT09IEByZWdFeHBQcm90b1VuaWNvZGVHZXR0ZXIp CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIAotICAgIC8vIFRoaXMgaXMgYWNjZXNzZWQgYnkg dGhlIFJlZ0V4cCBzcGVjaWVzIGNvbnN0cnVjdG9yLgorICAgIC8vIFRoZXNlIGFyZSBhY2Nlc3Nl ZCBieSB0aGUgUmVnRXhwIHNwZWNpZXMgY29uc3RydWN0b3IuCiAgICAgdmFyIHJlZ2V4cFNvdXJj ZSA9IEB0cnlHZXRCeUlkKHJlZ2V4cCwgInNvdXJjZSIpOwogICAgIGlmIChyZWdleHBTb3VyY2Ug IT09IEByZWdFeHBQcm90b1NvdXJjZUdldHRlcikKICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg aWYgKHJlZ2V4cC5AQG1hdGNoICE9PSBAcmVnRXhwUHJvdG90eXBlU3ltYm9sTWF0Y2gpCisgICAg ICAgIHJldHVybiB0cnVlOwogCiAgICAgcmV0dXJuIHR5cGVvZiByZWdleHAubGFzdEluZGV4ICE9 PSAibnVtYmVyIjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9MaW5rVGltZUNvbnN0YW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTGlu a1RpbWVDb25zdGFudC5oCmluZGV4IDFiNmU3MjYyNDA5Yzg1NzQzMmQ0YjJmY2ZhY2YxN2M3NjBk MTdiNjQuLjkwMWRmMGIxYTAyNmUyNmZmZjU0YzIwMDgxOWZjNGRiYzM2NmY1NTAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9MaW5rVGltZUNvbnN0YW50LmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xpbmtUaW1lQ29uc3RhbnQuaApAQCAt ODYsNiArODYsNyBAQCBjbGFzcyBKU0dsb2JhbE9iamVjdDsKICAgICB2KHJlZ0V4cE1hdGNoRmFz dCwgbnVsbHB0cikgXAogICAgIHYocmVnRXhwU2VhcmNoRmFzdCwgbnVsbHB0cikgXAogICAgIHYo cmVnRXhwU3BsaXRGYXN0LCBudWxscHRyKSBcCisgICAgdihyZWdFeHBQcm90b3R5cGVTeW1ib2xN YXRjaCwgbnVsbHB0cikgXAogICAgIHYocmVnRXhwUHJvdG90eXBlU3ltYm9sUmVwbGFjZSwgbnVs bHB0cikgXAogICAgIHYocmVnRXhwVGVzdEZhc3QsIG51bGxwdHIpIFwKICAgICB2KHN0cmluZ0lu Y2x1ZGVzSW50ZXJuYWwsIG51bGxwdHIpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAppbmRleCBjOTZjMDEzY2QzYjNiYjBhZjE1NjgxNDkz YWU5NDIyMWI0ZWRjNzcwLi45MjE4NGYwMTMyZmU1MTQxY2I5OGFhNTYxOTU3NWI1YjYzMjA1NzQ2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVj dC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3Qu Y3BwCkBAIC05ODYsNiArOTg2LDcgQEAgY2FwaXRhbE5hbWUgIyMgQ29uc3RydWN0b3IqIGxvd2Vy TmFtZSAjIyBDb25zdHJ1Y3RvciA9IGZlYXR1cmVGbGFnID8gY2FwaXRhbE5hbWUKICAgICBKU0Z1 bmN0aW9uKiByZWdFeHBTeW1ib2xSZXBsYWNlID0ganNDYXN0PEpTRnVuY3Rpb24qPihtX3JlZ0V4 cFByb3RvdHlwZS0+Z2V0RGlyZWN0KHZtLCB2bS5wcm9wZXJ0eU5hbWVzLT5yZXBsYWNlU3ltYm9s KSk7CiAgICAgbV9yZWdFeHBQcm90b1N5bWJvbFJlcGxhY2Uuc2V0KHZtLCB0aGlzLCByZWdFeHBT eW1ib2xSZXBsYWNlKTsKICAgICBtX2xpbmtUaW1lQ29uc3RhbnRzW3N0YXRpY19jYXN0PHVuc2ln bmVkPihMaW5rVGltZUNvbnN0YW50OjpyZWdFeHBCdWlsdGluRXhlYyldLnNldCh2bSwgdGhpcywg anNDYXN0PEpTRnVuY3Rpb24qPihtX3JlZ0V4cFByb3RvdHlwZS0+Z2V0RGlyZWN0KHZtLCB2bS5w cm9wZXJ0eU5hbWVzLT5leGVjKSkpOworICAgIG1fbGlua1RpbWVDb25zdGFudHNbc3RhdGljX2Nh c3Q8dW5zaWduZWQ+KExpbmtUaW1lQ29uc3RhbnQ6OnJlZ0V4cFByb3RvdHlwZVN5bWJvbE1hdGNo KV0uc2V0KHZtLCB0aGlzLCBtX3JlZ0V4cFByb3RvdHlwZS0+Z2V0RGlyZWN0KHZtLCB2bS5wcm9w ZXJ0eU5hbWVzLT5tYXRjaFN5bWJvbCkuYXNDZWxsKCkpOwogICAgIG1fbGlua1RpbWVDb25zdGFu dHNbc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KExpbmtUaW1lQ29uc3RhbnQ6OnJlZ0V4cFByb3RvdHlw ZVN5bWJvbFJlcGxhY2UpXS5zZXQodm0sIHRoaXMsIG1fcmVnRXhwUHJvdG90eXBlLT5nZXREaXJl Y3Qodm0sIHZtLnByb3BlcnR5TmFtZXMtPnJlcGxhY2VTeW1ib2wpLmFzQ2VsbCgpKTsKIAogICAg IG1fbGlua1RpbWVDb25zdGFudHNbc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KExpbmtUaW1lQ29uc3Rh bnQ6OmlzQXJyYXkpXS5zZXQodm0sIHRoaXMsIGFycmF5Q29uc3RydWN0b3ItPmdldERpcmVjdCh2 bSwgdm0ucHJvcGVydHlOYW1lcy0+aXNBcnJheSkuYXNDZWxsKCkpOwpkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBiYmM3ZDM4MDYzZWI0NTE0 ZDZhNmJhM2NjZDUwY2QzNTQ0MjI5NjhjLi5kMDI1ZDcwMGYxMDcxNThjM2MwY2I5NDZmNTU2ODE4 NzdjNWMyYTYwIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIwICBSb3NzIEtpcnNsaW5nICA8cm9z cy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBoYXNPYnNlcnZhYmxlU2lkZUVmZmVjdHNG b3JSZWdFeHBTcGxpdCBkb2Vzbid0IGNoZWNrIGZvciBAQG1hdGNoIG92ZXJyaWRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzNjMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3QyNjIvZXhwZWN0 YXRpb25zLnlhbWw6CisgICAgICAgIE1hcmsgdHdvIHRlc3QgY2FzZXMgYXMgcGFzc2luZy4KKwog MjAyMC0wMy0yMCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAg ICAgICAgUmVnRXhwLnByb3RvdHlwZVtAQHJlcGxhY2VdIGRvZXNuJ3QgY29lcmNlIHJlc3VsdCBp bmRleCB0byBpbnRlZ2VyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25z LnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKaW5kZXggMzBhMzRmZTlm MTM0N2VlMWZmMmM3YmU4MzVkNmFiZTY5MmVhOThmNS4uNWIyYmVmYThjZWZiZTM3NmYyZDM1NTM2 ODBmZTg4NjhhOTVkOTY1MCAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9u cy55YW1sCisrKyBiL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbApAQCAtOCw5ICs4 LDYgQEAgdGVzdC9hbm5leEIvYnVpbHQtaW5zL0Z1bmN0aW9uL2NyZWF0ZWR5bmZuLWh0bWwtb3Bl bi1jb21tZW50LXBhcmFtcy5qczoKIHRlc3QvYW5uZXhCL2J1aWx0LWlucy9GdW5jdGlvbi9jcmVh dGVkeW5mbi1uby1saW5lLXRlcm1pbmF0b3ItaHRtbC1jbG9zZS1jb21tZW50LWJvZHkuanM6CiAg IGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIGEgU3ludGF4RXJyb3IgdG8gYmUgdGhy b3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCiAgIHN0cmljdCBtb2RlOiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBhIFN5bnRheEVycm9yIHRvIGJlIHRocm93biBidXQgbm8g ZXhjZXB0aW9uIHdhcyB0aHJvd24gYXQgYWxsJwotdGVzdC9hbm5leEIvYnVpbHQtaW5zL1JlZ0V4 cC9wcm90b3R5cGUvU3ltYm9sLnNwbGl0L1N5bWJvbC5tYXRjaC1nZXR0ZXItcmVjb21waWxlcy1z b3VyY2UuanM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjC q8K7LCDCq2HCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6IEV4 cGVjdGVkIFNhbWVWYWx1ZSjCq8K7LCDCq2HCuykgdG8gYmUgdHJ1ZScKIHRlc3QvYW5uZXhCL2xh bmd1YWdlL2V2YWwtY29kZS9kaXJlY3QvZnVuYy1ibG9jay1kZWNsLWV2YWwtZnVuYy1za2lwLWVh cmx5LWVyci1ibG9jay5qczoKICAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogQW4gaW5pdGlhbGl6 ZWQgYmluZGluZyBpcyBub3QgY3JlYXRlZCBwcmlvciB0byBldmFsdWF0aW9uIEV4cGVjdGVkIGEg UmVmZXJlbmNlRXJyb3IgdG8gYmUgdGhyb3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBh dCBhbGwnCiB0ZXN0L2FubmV4Qi9sYW5ndWFnZS9ldmFsLWNvZGUvZGlyZWN0L2Z1bmMtYmxvY2st ZGVjbC1ldmFsLWZ1bmMtc2tpcC1lYXJseS1lcnItZm9yLWluLmpzOgo=