209343 2020-03-20 09:22:11 -0700 Fix JSCOnly build without unified sources 2020-03-20 11:40:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin justin_michaud ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1632118 0 justin 2020-03-20 09:22:11 -0700 I managed to get clangd to work for code completion using the following command: ./Tools/Scripts/build-webkit --jsc-only --cmakeargs="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_UNIFIED_BUILDS=OFF" && compdb -p WebKitBuild/Release/ list > compile_commands.json This patch fixes the build for non-unified sources, and adds some extra clangd files to .gitignore. 1632123 1 394092 justin 2020-03-20 09:28:27 -0700 Created attachment 394092 Patch 1632156 2 394092 keith_miller 2020-03-20 10:22:32 -0700 Comment on attachment 394092 Patch r=me 1632187 3 ews-feeder 2020-03-20 11:39:41 -0700 Committed r258774: <https://trac.webkit.org/changeset/258774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394092. 1632188 4 webkit-bug-importer 2020-03-20 11:40:12 -0700 <rdar://problem/60696207> 394092 2020-03-20 09:28:27 -0700 2020-03-20 11:39:41 -0700 Patch bug-209343-20200320122826.patch text/plain 2980 justin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 YzEwZWU4YTQ2YmVlOTEzZWIxMTI5ZTVhMzNiY2UwYjk3ZGRiYmQ0Li5iNGIyNDVlMTYxZGQyY2Yy NDY5MDc1NzAyMzBmYjhlMmRkZWNlZDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0wMy0yMCAgSnVzdGluIE1pY2hhdWQgIDxqdXN0aW5AanVzdGlubWlj aGF1ZC5jb20+CisKKyAgICAgICAgRml4IEpTQ09ubHkgYnVpbGQgd2l0aG91dCB1bmlmaWVkIHNv dXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTM0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkg bWFuYWdlZCB0byBnZXQgY2xhbmdkIHRvIHdvcmsgZm9yIGNvZGUgY29tcGxldGlvbiB1c2luZyB0 aGUgZm9sbG93aW5nIGNvbW1hbmQ6CisKKyAgICAgICAgLi9Ub29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdCAtLWpzYy1vbmx5IC0tY21ha2VhcmdzPSItRENNQUtFX0VYUE9SVF9DT01QSUxFX0NPTU1B TkRTPU9OIC1ERU5BQkxFX1VOSUZJRURfQlVJTERTPU9GRiIgJiYgY29tcGRiIC1wIFdlYktpdEJ1 aWxkL1JlbGVhc2UvIGxpc3QgPiBjb21waWxlX2NvbW1hbmRzLmpzb24KKworICAgICAgICBUaGlz IHBhdGNoIGZpeGVzIHRoZSBidWlsZCBmb3Igbm9uLXVuaWZpZWQgc291cmNlcywgYW5kIGFkZHMg c29tZSBleHRyYSBjbGFuZ2QgZmlsZXMgdG8gLmdpdGlnbm9yZS4KKworICAgICAgICAqIEFQSS9N YXJrZWRKU1ZhbHVlUmVmQXJyYXkuaDoKKyAgICAgICAgKiBqaXQvSklUUHJvcGVydHlBY2Nlc3Mu Y3BwOgorCiAyMDIwLTAzLTE5ICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4K IAogICAgICAgICBGaXggbWFueSB3YXJuaW5ncyB3aXRoIENsYW5nIDcuMCBvbiBHVEsgeDg2LTY0 IGluIERlYnVnLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9NYXJrZWRK U1ZhbHVlUmVmQXJyYXkuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvTWFya2VkSlNWYWx1 ZVJlZkFycmF5LmgKaW5kZXggMWFkZTUwZTIwODI3OTcwNmY0NmE4YTNlMmI1ZDE2YWVhYTc0NzMz Yy4uODE1ODc5NTIyYWRjY2IxZTViODk3NjVjNWMwOTdkN2M4M2MxYjc3NCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9NYXJrZWRKU1ZhbHVlUmVmQXJyYXkuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL01hcmtlZEpTVmFsdWVSZWZBcnJheS5oCkBAIC0yNSw3 ICsyNSw5IEBACiAKICNwcmFnbWEgb25jZQogCisjaW5jbHVkZSAiQVBJQ2FzdC5oIgogI2luY2x1 ZGUgIkFyZ0xpc3QuaCIKKyNpbmNsdWRlIDx3dGYvQ2FnZWRVbmlxdWVQdHIuaD4KICNpbmNsdWRl IDx3dGYvRm9yYmlkSGVhcEFsbG9jYXRpb24uaD4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUu aD4KICNpbmNsdWRlIDx3dGYvTm9ubW92YWJsZS5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAppbmRleCBiNTNhNDkwZjVkZmIwOWZmNzJiM2U3 YWUwNzQ3YzQxMjk1NWU1ZmY0Li5mMDdkNmRjMDY0MzhiZjY3MDFjNDBhZDYzY2I0NTViYTQwN2U2 MmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNj ZXNzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNz LmNwcApAQCAtMjgsNiArMjgsNyBAQAogI2lmIEVOQUJMRShKSVQpCiAjaW5jbHVkZSAiSklULmgi CiAKKyNpbmNsdWRlICJDYWNoZWFibGVJZGVudGlmaWVySW5saW5lcy5oIgogI2luY2x1ZGUgIkNv ZGVCbG9jay5oIgogI2luY2x1ZGUgIkRpcmVjdEFyZ3VtZW50cy5oIgogI2luY2x1ZGUgIkdDQXdh cmVKSVRTdHViUm91dGluZS5oIgpkaWZmIC0tZ2l0IGEvLmdpdGlnbm9yZSBiLy5naXRpZ25vcmUK aW5kZXggYjA2MTAzNWFhYWFkMWY3ZmRhN2NlYTY1MjFkZTZmMjEzYTFhZDc3NC4uZjBjMjVmYTI2 MDJjMjA5OWEyMzBiNGMxYjFhN2RjNDAzZGMzZTYwMiAxMDA2NDQKLS0tIGEvLmdpdGlnbm9yZQor KysgYi8uZ2l0aWdub3JlCkBAIC0yNiw2ICsyNiw4IEBAIHhjdXNlcmRhdGEKIHRhZ3MKICp+CiAu Ki5zd1thLXBdCisuY2xhbmdkCitjb21waWxlX2NvbW1hbmRzLmpzb24KIAogIyBJZ25vcmUgQ01h a2UgY2FjaGVzIG91dHNpZGUgb2YgdGhlIGJ1aWxkIGRpcmVjdG9yeS4KIF9fY21ha2Vfc3lzdGVt aW5mb3JtYXRpb24vCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWRj ZjE5NmU1ZWIzN2EwYzE3NjFkZTEwMTJhOGYyM2JlNTYzZjlhNC4uZmMxZjM4ODFhYTFjYTg5MWY4 YThhMGVjMjVmNWNlNmJkZjEyYzFkZCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAzLTIwICBKdXN0aW4gTWljaGF1ZCAgPGp1c3Rp bkBqdXN0aW5taWNoYXVkLmNvbT4KKworICAgICAgICBGaXggSlNDT25seSBidWlsZCB3aXRob3V0 IHVuaWZpZWQgc291cmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiAuZ2l0aWdub3JlOgorCiAyMDIwLTAzLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8 cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUxFQVNFX0xPRyBzaG91bGQgbm90IGJl IENvY29hIHNwZWNpZmljCg==