209338 2020-03-20 08:06:43 -0700 Ensure base cache path exists before calculating disk cache capacity 2020-04-08 03:30:17 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura aperez benjamin bugs-noreply cdumez cgarcia cmarcelo dpino ews-watchlist webkit-bug-importer zan oldest_to_newest 1632082 0 lmoura 2020-03-20 08:06:43 -0700 The EWS bot is using `--skip-failing-tests` to give faster feedback about the patche being tested, but this flag is causing some disk-cache tests to fail: Regressions: Unexpected text-only failures (15) http/tests/cache/disk-cache/disk-cache-media.html [ Failure ] http/tests/cache/disk-cache/disk-cache-range.html [ Failure ] http/tests/cache/disk-cache/disk-cache-redirect.html [ Failure ] http/tests/cache/disk-cache/disk-cache-request-headers.html [ Failure ] http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Failure ] http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html [ Failure ] http/tests/cache/disk-cache/disk-cache-validation-attachment.html [ Failure ] http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Failure ] http/tests/cache/disk-cache/disk-cache-validation-no-body.html [ Failure ] http/tests/cache/disk-cache/disk-cache-validation.html [ Failure ] http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Failure ] http/tests/cache/disk-cache/disk-cache-vary.html [ Failure ] http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html [ Failure ] http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure ] http/tests/cache/disk-cache/resource-becomes-uncacheable.html [ Failure ] Sample failure from disk-cache-media: +++ /home/lauro/dev/WebKit/layout-test-results-1/http/tests/cache/disk-cache/disk-cache-media-actual.txt @@ -10,7 +10,7 @@ response source: Network response headers: {"Cache-control":"max-age=100","Content-Type":"text/plain"} -response source: Disk cache +response source: Network response headers: {"Cache-control":"max-age=0","Content-Type":"video/mp4"} response source: Network Maybe there is some dependency among the tests, and not running the ones marked as failure is causing the others to fail. 1632246 1 lmoura 2020-03-20 13:31:34 -0700 These failures are triggered when http/tests/cache/disk-cache/disk-cache-disable.html is not run. For example, running http/tests/cache/disk-cache/disk-cache-media.html after the disk-cache-disable.html causes it to work. But running disk-cache-media.html alone (or before disk-cache-disable) fails. To make it work alone, I have to call `testRunner.SetCacheModel(0); testRunner.SetCacheModel(1);` before `runTests()` in the media tests. Calling it once with `1` is not enough. 1632907 2 dpino 2020-03-23 10:16:50 -0700 The test disk-cache-disable.html leaves the cache as DocumentBrowser. ``` debug("Default (cache enabled)"); runTests(tests, function () { debug("Disabling cache"); testRunner.setCacheModel(0); // DocumentViewer runTests(tests, function () { debug("Re-enabling cache"); testRunner.setCacheModel(1); // DocumentBrowser runTests(tests); }); }); ``` If I run the test http/tests/cache/disk-cache/redirect-chain-limits.html alone, it fails. However, if I run disk-cache-disable.html before this test, it passes. If I edit http/tests/cache/disk-cache/redirect-chain-limits.html, and do the same steps as disk-cache-disable.html before running the test, the test passes too: ``` testRunner.setCacheModel(0); testRunner.setCacheModel(1); testRedirectChain(1, () => { testRedirectChain(5, () => { testRedirectChain(6, () => { testRedirectChain(20, () => { testRedirectChain(40, () => { finishJSTest(); }); }); }); }); }); ``` If I simply do `testRunner.setCacheModel(1)` before running the test, it doesn't work. It seems is necessary to do `testRunner.setCacheModel(0)`. It seems that whether disk-cache-disable.html is run before or after the other tests have an effect on the result of the tests. According to Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:webkit_web_context_set_cache_model the default cache model is DocumentBrowser, so the additional steps in `redirect-chain-limits.html` shouldn't be necessary. Regarding the connection with --skip-failing-tests, this flag doesn't run the tests marked as failure in TestExpectations. Since disk-cache-disable.html is in gtk/TestExpectactions, the test is run and the cache is never set to DocumentBrowser, and all the other disk-cache tests fail. 1633232 3 394351 lmoura 2020-03-23 21:23:09 -0700 Created attachment 394351 Retry getting cache capacity with glib 1633233 4 lmoura 2020-03-23 21:26:59 -0700 The cache creation code tries to get the cache capacity from the cache file location. The problem is that glib's FileSystem::getVolumeFreeSpace does not work for non-existing files (as is the case when initializing the NetworkProcess). I've added a glib-specific patch that tries to get the capacity again after opening the cache if the first try resulted in zero-capacity. With it the currently passing disk-cache files work normally without this unset/set cache model (for example, with skip-failing-tests). 1633291 5 394351 zan 2020-03-24 06:57:59 -0700 Comment on attachment 394351 Retry getting cache capacity with glib View in context: https://bugs.webkit.org/attachment.cgi?id=394351&action=review > Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:97 > +#if PLATFORM(GTK) || PLATFORM(WPE) > + // GLIB's getVolumeFreeSpace requires the file to exist to work correctly. > + // As this may not be the case when initializing the NetworkProcess, the first call > + // to computeCapacity may fail and we must try again after the file is created. > + if (!capacity) { > + capacity = computeCapacity(networkProcess.cacheModel(), cachePath); > + storage->setCapacity(capacity); > + } > +#endif It would be better to amend FileSystem::getVolumeFreeSpace() to walk up the cache path to find the first existing file, and query for the free-space information through that. 1633464 6 394406 lmoura 2020-03-24 13:50:12 -0700 Created attachment 394406 Updated patch fixing getVolumeFreeSpace instead 1633813 7 394406 cgarcia 2020-03-25 02:23:43 -0700 Comment on attachment 394406 Updated patch fixing getVolumeFreeSpace instead View in context: https://bugs.webkit.org/attachment.cgi?id=394406&action=review > Source/WTF/ChangeLog:10 > + In some scenarios getVolumeFreeSpace can be called with a not yet > + existing path, which would make the file stat query to fail. For > + example, the NetworkProcess initializing a new cache file. I'm not sure about this. FileSystem::getVolumeFreeSpace() is only called by network cache. I think other implementations in WTF also fail if the file doesn't exist, so I think the problem is not the implementation of getVolumeFreeSpace(), but the caller expecting the file exists. I suspect that for some reason the cache dir is created already at the point computeCapacity() si called for other ports. 1633814 8 394406 cgarcia 2020-03-25 02:25:02 -0700 Comment on attachment 394406 Updated patch fixing getVolumeFreeSpace instead View in context: https://bugs.webkit.org/attachment.cgi?id=394406&action=review > Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp:160 > +TEST_F(FileSystemTest, getVolumeFreeSpace) > +{ > + String home = FileSystem::homeDirectoryPath(); > + String path = FileSystem::pathByAppendingComponent(home, "ThisFileShouldNotExist"); > + uint64_t freeSpace = 0; > + EXPECT_TRUE(FileSystem::getVolumeFreeSpace(path, freeSpace)); > + EXPECT_GT(freeSpace, 0); Build failed in other ports in EWS, it would be interesting to see if this test passes... 1633816 9 cgarcia 2020-03-25 02:31:04 -0700 So, this is what I would try: - Change Storage::open() to receive the CacheModel instead of the capacity. - Move computeCapacity() from NetworkCache.cpp to NetworkCacheStorage.cpp - In Storage::open() call computeCapacity() right before creating the instance, after readOrMakeSalt(). 1634247 10 zan 2020-03-26 02:53:44 -0700 (In reply to Carlos Garcia Campos from comment #7) > Comment on attachment 394406 [details] > Updated patch fixing getVolumeFreeSpace instead > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394406&action=review > > > Source/WTF/ChangeLog:10 > > + In some scenarios getVolumeFreeSpace can be called with a not yet > > + existing path, which would make the file stat query to fail. For > > + example, the NetworkProcess initializing a new cache file. > > I'm not sure about this. FileSystem::getVolumeFreeSpace() is only called by > network cache. I think other implementations in WTF also fail if the file > doesn't exist, so I think the problem is not the implementation of > getVolumeFreeSpace(), but the caller expecting the file exists. I think we should then find a place where we guarantee that the directory specified to NetworkCache::Cache::open() exists. After all the directory specified here is only the parent directory to the directory that Storage::open() spawns. 1634695 11 394691 lmoura 2020-03-26 18:46:48 -0700 Created attachment 394691 Fix sign-compare in testcase 1634773 12 cgarcia 2020-03-27 02:42:13 -0700 And the new api test is failing in other ports as expected, which confirms this is not he way to go. Let's keep the expected behavior of getVolumeFreeSpace() and fix the caller to ensure the directory exists. 1638986 13 395783 cgarcia 2020-04-08 02:46:00 -0700 Created attachment 395783 Patch 1638994 14 cgarcia 2020-04-08 03:29:57 -0700 Committed r259712: <https://trac.webkit.org/changeset/259712> 1638995 15 webkit-bug-importer 2020-04-08 03:30:17 -0700 <rdar://problem/61444602> 394351 2020-03-23 21:23:09 -0700 2020-03-24 13:50:07 -0700 Retry getting cache capacity with glib bug-209338-20200324012306.patch text/plain 2370 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2YmRhMzEyYTQ3NmVhYzc1 OGQwYTQ0MjNlNGI5OGExMDNhNzZkYTIuLjFmYzg4OTBiMzM1OGQ3Mjk1OWJlZjA1MWRhOWZlZmUy NzVmYmU4ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDMtMjMgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNpbmcgLS1za2lwLWZh aWxpbmctdGVzdHMgY2F1c2Ugc29tZSBkaXNrLWNhY2hlIHRlc3RzIHRvIGZhaWwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTMzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdMSUIncyBnZXRWb2x1bWVG cmVlU3BhY2UgaW1wbGVtZW50YXRpb24gcmVxdWlyZXMgdGhlIGZpbGUgdG8gZXhpc3QgdG8KKyAg ICAgICAgcmV0dXJuIHRoZSBjb3JyZWN0IHNpemUuIER1cmluZyB0aGUgTmV0d29ya1Byb2Nlc3Mg aW5pdGlhbGl6YXRpb24gaXQKKyAgICAgICAgY2F1c2VkIHRoZSBjYWNoZSBzdG9yYWdlIHRvIGJl IGluaXRpYWxseSBkZWZpbmVkIHdpdGggemVybyBjYXBhY2l0eS4KKyAgICAgICAgRnVydGhlciBj YWxscyB0byBOZXR3b3JrUHJvY2Vzcy5zZXRDYWNoZU1vZGVsIHdvcmtlZCBhcyBleHBlY3RlZCBk dWUKKyAgICAgICAgdG8gdGhlIGZpbGUgYWxyZWFkeSBleGlzdGluZywgdXBkYXRpbmcgdGhlIGNh cGFjaXR5IGNvcnJlY3RseS4KKworICAgICAgICBUaGlzIGlzc3VlIHdhcyBpbml0aWFsbHkgaGlk ZGVuIGR1ZSB0bworICAgICAgICBkaXNrLWNhY2hlL2Rpc2stY2FjaGUtZGlzYWJsZS5odG1sIGJl aW5nIG9uZSBvZiB0aGUgZmlyc3QgY2FjaGUgdGVzdHMKKyAgICAgICAgcnVuLCBhcyBpdCB3b3Vs ZCBkaXNhYmxlL2VuYWJsZSB0aGUgY2FjaGUsIG92ZXJyaWRpbmcgdGhlIGluaXRpYWwgemVybwor ICAgICAgICBjYXBhY2l0eS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6Q2FjaGU6Om9wZW4p OgorCiAyMDIwLTAzLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAg ICAgICAgSVBDOjpEZWNvZGVyOjpkZWNvZGVGaXhlZExlbmd0aERhdGEoKSBzaG91bGQgYmUgbWFy a2VkIFdBUk5fVU5VU0VEX1JFVFVSTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4IDcyYmE2YmZmM2RhZTMwZGM5MGMxNTM0 MTA5ZWY3YjZhNDc3YzI0NTEuLmJiYWE4OTY3YjJmYWRhMjE4ZTI2OTNkYmMwZWVkYjM3MjYyOTRl MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29y a0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZS5jcHAKQEAgLTg2LDYgKzg2LDE2IEBAIFJlZlB0cjxDYWNoZT4gQ2FjaGU6Om9wZW4o TmV0d29ya1Byb2Nlc3MmIG5ldHdvcmtQcm9jZXNzLCBjb25zdCBTdHJpbmcmIGNhY2hlUGF0CiAg ICAgaWYgKCFzdG9yYWdlKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAorI2lmIFBMQVRGT1JN KEdUSykgfHwgUExBVEZPUk0oV1BFKQorICAgIC8vIEdMSUIncyBnZXRWb2x1bWVGcmVlU3BhY2Ug cmVxdWlyZXMgdGhlIGZpbGUgdG8gZXhpc3QgdG8gd29yayBjb3JyZWN0bHkuCisgICAgLy8gQXMg dGhpcyBtYXkgbm90IGJlIHRoZSBjYXNlIHdoZW4gaW5pdGlhbGl6aW5nIHRoZSBOZXR3b3JrUHJv Y2VzcywgdGhlIGZpcnN0IGNhbGwKKyAgICAvLyB0byBjb21wdXRlQ2FwYWNpdHkgbWF5IGZhaWwg YW5kIHdlIG11c3QgdHJ5IGFnYWluIGFmdGVyIHRoZSBmaWxlIGlzIGNyZWF0ZWQuCisgICAgaWYg KCFjYXBhY2l0eSkgeworICAgICAgICBjYXBhY2l0eSA9IGNvbXB1dGVDYXBhY2l0eShuZXR3b3Jr UHJvY2Vzcy5jYWNoZU1vZGVsKCksIGNhY2hlUGF0aCk7CisgICAgICAgIHN0b3JhZ2UtPnNldENh cGFjaXR5KGNhcGFjaXR5KTsKKyAgICB9CisjZW5kaWYKKwogICAgIHJldHVybiBhZG9wdFJlZigq bmV3IENhY2hlKG5ldHdvcmtQcm9jZXNzLCBjYWNoZVBhdGgsIHN0b3JhZ2UucmVsZWFzZU5vbk51 bGwoKSwgb3B0aW9ucywgc2Vzc2lvbklEKSk7CiB9CiAK 394406 2020-03-24 13:50:12 -0700 2020-03-26 18:46:44 -0700 Updated patch fixing getVolumeFreeSpace instead bug-209338-20200324175010.patch text/plain 3258 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY4MGQyMGU3MTA0ODE1NmE1MjAxYzU3 MmRhYjhkMTI1NzM3ZDhjY2QuLjZhM2U0NTQxZjFkZmRkMTYwMjg1MTEzYjQ5NTc1ZThkYWU0NDA0 MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMjQgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZpeCBGaWxlU3lzdGVtOjpnZXRWb2x1bWVG cmVlU3BhY2UgZm9yIG5vbi1leGlzdGluZyBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gc29tZSBzY2VuYXJpb3MgZ2V0Vm9sdW1lRnJlZVNw YWNlIGNhbiBiZSBjYWxsZWQgd2l0aCBhIG5vdCB5ZXQKKyAgICAgICAgZXhpc3RpbmcgcGF0aCwg d2hpY2ggd291bGQgbWFrZSB0aGUgZmlsZSBzdGF0IHF1ZXJ5IHRvIGZhaWwuIEZvcgorICAgICAg ICBleGFtcGxlLCB0aGUgTmV0d29ya1Byb2Nlc3MgaW5pdGlhbGl6aW5nIGEgbmV3IGNhY2hlIGZp bGUuCisKKyAgICAgICAgSW5zdGVhZCwgd2Ugc2hvdWxkIHVzZSB0aGUgbG93ZXN0IGV4aXN0aW5n IGNvbXBvbmVudCBvZiB0aGUgcGF0aC4KKyAgICAgICAgKiB3dGYvZ2xpYi9GaWxlU3lzdGVtR2xp Yi5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpnZXRWb2x1bWVGcmVlU3BhY2Up OgorCiAyMDIwLTAzLTIzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI1ODg5MS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL2dsaWIvRmlsZVN5c3RlbUdsaWIuY3BwIGIvU291cmNlL1dURi93dGYvZ2xp Yi9GaWxlU3lzdGVtR2xpYi5jcHAKaW5kZXggZTRhYjAwZmJkYWQ5ZmZiNzFiNTAyMmNjZWM0MWMx MGI1Y2EwZjVkZi4uMGQ4MjE5MTJiNGQyOGJiZTcwYWUyYmExMDc3OGU0NzA4ZmIyOTAxNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAKQEAgLTI4NCw2ICsyODQsMTMgQEAg Ym9vbCBnZXRWb2x1bWVGcmVlU3BhY2UoY29uc3QgU3RyaW5nJiBwYXRoLCB1aW50NjRfdCYgZnJl ZVNwYWNlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBHUmVmUHRyPEdGaWxlPiBmaWxl ID0gYWRvcHRHUmVmKGdfZmlsZV9uZXdfZm9yX3BhdGgoZmlsZW5hbWUuZGF0YSgpKSk7CisKKyAg ICB3aGlsZSAoIWdfZmlsZV9xdWVyeV9leGlzdHMoZmlsZS5nZXQoKSwgbnVsbHB0cikpIHsKKyAg ICAgICAgZmlsZSA9IGFkb3B0R1JlZihnX2ZpbGVfZ2V0X3BhcmVudChmaWxlLmdldCgpKSk7Cisg ICAgICAgIGlmICghZmlsZS5nZXQoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9 CisKICAgICBHUmVmUHRyPEdGaWxlSW5mbz4gZmlsZUluZm8gPSBhZG9wdEdSZWYoZ19maWxlX3F1 ZXJ5X2ZpbGVzeXN0ZW1faW5mbyhmaWxlLmdldCgpLCBHX0ZJTEVfQVRUUklCVVRFX0ZJTEVTWVNU RU1fRlJFRSwgbnVsbHB0ciwgbnVsbHB0cikpOwogICAgIGlmICghZmlsZUluZm8pCiAgICAgICAg IHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA0Y2JkMjJhYTYwMGZiZjJkYjhjYWZhZGU0NWNmOWI4ZmMxZGNmMDM4Li4wNzc4 MWFlMGYwNzYxNjg2ZWJkYTU4Y2MzZTY4NDZmNGYyNThjYzY2IDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMt MjQgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZp eCBGaWxlU3lzdGVtOjpnZXRWb2x1bWVGcmVlU3BhY2UgZm9yIG5vbi1leGlzdGluZyBwYXRocwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3Qg Zm9yIEZpbGVTeXN0ZW06OmdldFZvbHVtZUZyZWVTcGFjZSB3aXRoIG5vbiBleGlzdGluZyBwYXRo cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwOgor ICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVF9GKToKKwogMjAyMC0wMy0yNCAgQ2hyaXMgTG9y ZCAgPGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBXRUJfUFJPQ0VTU19D TURfUFJFRklYIGFuZCBvdGhlcnMgaGF2ZSBzdG9wcGVkIHdvcmtpbmcKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5jcHAKaW5kZXggNzZjYWYyYWQ0MzcyNjYzZDJi ZTMxMWJjZmI2M2EwNGQwYzBkMDFmNi4uM2Y5YTk4NTVkYjFiYjVlNDRkMDg3MjZmYWRjNGJkMzU5 MjgzNTU3MiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5 c3RlbS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRmlsZVN5c3RlbS5j cHAKQEAgLTE1MSw0ICsxNTEsMTMgQEAgVEVTVF9GKEZpbGVTeXN0ZW1UZXN0LCBvcGVuRXhpc3Rp bmdGaWxlQW5kRmFpbElmRmlsZUV4aXN0cykKICAgICBFWFBFQ1RfRkFMU0UoRmlsZVN5c3RlbTo6 aXNIYW5kbGVWYWxpZChoYW5kbGUpKTsKIH0KIAorVEVTVF9GKEZpbGVTeXN0ZW1UZXN0LCBnZXRW b2x1bWVGcmVlU3BhY2UpCit7CisgICAgU3RyaW5nIGhvbWUgPSBGaWxlU3lzdGVtOjpob21lRGly ZWN0b3J5UGF0aCgpOworICAgIFN0cmluZyBwYXRoID0gRmlsZVN5c3RlbTo6cGF0aEJ5QXBwZW5k aW5nQ29tcG9uZW50KGhvbWUsICJUaGlzRmlsZVNob3VsZE5vdEV4aXN0Iik7CisgICAgdWludDY0 X3QgZnJlZVNwYWNlID0gMDsKKyAgICBFWFBFQ1RfVFJVRShGaWxlU3lzdGVtOjpnZXRWb2x1bWVG cmVlU3BhY2UocGF0aCwgZnJlZVNwYWNlKSk7CisgICAgRVhQRUNUX0dUKGZyZWVTcGFjZSwgMCk7 Cit9CisKIH0K 394691 2020-03-26 18:46:48 -0700 2020-04-08 02:46:00 -0700 Fix sign-compare in testcase bug-209338-20200326224647.patch text/plain 3312 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDljMmRmYWU4NmY1NTk1YzNhMTI3NDA4 NGYwNDM3Y2U3OGNjYWFjMzIuLjRjOWNmODc5YzZkMDNmYWMwYjQyZTEyNmUyMDg5YTc5ZTU3Nzhh OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMjQgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEZpeCBGaWxlU3lzdGVtOjpnZXRWb2x1bWVG cmVlU3BhY2UgZm9yIG5vbi1leGlzdGluZyBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gc29tZSBzY2VuYXJpb3MgZ2V0Vm9sdW1lRnJlZVNw YWNlIGNhbiBiZSBjYWxsZWQgd2l0aCBhIG5vdCB5ZXQKKyAgICAgICAgZXhpc3RpbmcgcGF0aCwg d2hpY2ggd291bGQgbWFrZSB0aGUgZmlsZSBzdGF0IHF1ZXJ5IHRvIGZhaWwuIEZvcgorICAgICAg ICBleGFtcGxlLCB0aGUgTmV0d29ya1Byb2Nlc3MgaW5pdGlhbGl6aW5nIGEgbmV3IGNhY2hlIGZp bGUuCisKKyAgICAgICAgSW5zdGVhZCwgd2Ugc2hvdWxkIHVzZSB0aGUgbG93ZXN0IGV4aXN0aW5n IGNvbXBvbmVudCBvZiB0aGUgcGF0aC4KKyAgICAgICAgKiB3dGYvZ2xpYi9GaWxlU3lzdGVtR2xp Yi5jcHA6CisgICAgICAgIChXVEY6OkZpbGVTeXN0ZW1JbXBsOjpnZXRWb2x1bWVGcmVlU3BhY2Up OgorCiAyMDIwLTAzLTI1ICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4K IAogICAgICAgICBbUGxheVN0YXRpb25dIFNwZWNpZnkgYSAxNiBLQiBtaW5pbXVtIHBhZ2Ugc2l6 ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvZ2xpYi9GaWxlU3lzdGVtR2xpYi5jcHAgYi9T b3VyY2UvV1RGL3d0Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcAppbmRleCBlNGFiMDBmYmRhZDlm ZmI3MWI1MDIyY2NlYzQxYzEwYjVjYTBmNWRmLi4wZDgyMTkxMmI0ZDI4YmJlNzBhZTJiYTEwNzc4 ZTQ3MDhmYjI5MDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nbGliL0ZpbGVTeXN0ZW1H bGliLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcApAQCAt Mjg0LDYgKzI4NCwxMyBAQCBib29sIGdldFZvbHVtZUZyZWVTcGFjZShjb25zdCBTdHJpbmcmIHBh dGgsIHVpbnQ2NF90JiBmcmVlU3BhY2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIEdS ZWZQdHI8R0ZpbGU+IGZpbGUgPSBhZG9wdEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChmaWxlbmFt ZS5kYXRhKCkpKTsKKworICAgIHdoaWxlICghZ19maWxlX3F1ZXJ5X2V4aXN0cyhmaWxlLmdldCgp LCBudWxscHRyKSkgeworICAgICAgICBmaWxlID0gYWRvcHRHUmVmKGdfZmlsZV9nZXRfcGFyZW50 KGZpbGUuZ2V0KCkpKTsKKyAgICAgICAgaWYgKCFmaWxlLmdldCgpKQorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KKwogICAgIEdSZWZQdHI8R0ZpbGVJbmZvPiBmaWxlSW5mbyA9IGFk b3B0R1JlZihnX2ZpbGVfcXVlcnlfZmlsZXN5c3RlbV9pbmZvKGZpbGUuZ2V0KCksIEdfRklMRV9B VFRSSUJVVEVfRklMRVNZU1RFTV9GUkVFLCBudWxscHRyLCBudWxscHRyKSk7CiAgICAgaWYgKCFm aWxlSW5mbykKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDdhNTExZDU3Y2IwZDA2MmRjNGIyMjczMzgyMTQ1 MWVhNDIzNTYwNTUuLmNkZjFhNjgxNTU2YzNhZGJhMmU4YzU0ODhmZGIyNzdiNmNlZDZjNjQgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAyMC0wMy0yNCAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR0xJQl0gRml4IEZpbGVTeXN0ZW06OmdldFZvbHVtZUZyZWVTcGFjZSBmb3Igbm9u LWV4aXN0aW5nIHBhdGhzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDkzMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgdGVzdCBmb3IgRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlIHdpdGgg bm9uIGV4aXN0aW5nIHBhdGhzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv RmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUX0YpOgorCiAyMDIw LTAzLTI2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbRmxhdHBhayBTREtdIFBhc3MgYWxsIHRoZSBhcmd1bWVudHMgb2YgYnVpbGQtd2Via2l0IHRv IHdlYmtpdC1mbGF0cGFrCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9GaWxlU3lzdGVtLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0 ZW0uY3BwCmluZGV4IDc2Y2FmMmFkNDM3MjY2M2QyYmUzMTFiY2ZiNjNhMDRkMGMwZDAxZjYuLmQ4 MmI4YjEwNjY5NGI2MTljODYzOGY3YTRlNGIxNWY1YmFhYzhmYzkgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCisrKyBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV1RGL0ZpbGVTeXN0ZW0uY3BwCkBAIC0xNTEsNCArMTUxLDEzIEBAIFRF U1RfRihGaWxlU3lzdGVtVGVzdCwgb3BlbkV4aXN0aW5nRmlsZUFuZEZhaWxJZkZpbGVFeGlzdHMp CiAgICAgRVhQRUNUX0ZBTFNFKEZpbGVTeXN0ZW06OmlzSGFuZGxlVmFsaWQoaGFuZGxlKSk7CiB9 CiAKK1RFU1RfRihGaWxlU3lzdGVtVGVzdCwgZ2V0Vm9sdW1lRnJlZVNwYWNlKQoreworICAgIFN0 cmluZyBob21lID0gRmlsZVN5c3RlbTo6aG9tZURpcmVjdG9yeVBhdGgoKTsKKyAgICBTdHJpbmcg cGF0aCA9IEZpbGVTeXN0ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChob21lLCAiVGhpc0Zp bGVTaG91bGROb3RFeGlzdCIpOworICAgIHVpbnQ2NF90IGZyZWVTcGFjZSA9IDA7CisgICAgRVhQ RUNUX1RSVUUoRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlKHBhdGgsIGZyZWVTcGFjZSkp OworICAgIEVYUEVDVF9HVChmcmVlU3BhY2UsIHN0YXRpY19jYXN0PHVpbnQ2NF90PigwKSk7Cit9 CisKIH0K 395783 2020-04-08 02:46:00 -0700 2020-04-08 03:08:19 -0700 Patch wk2-disk-cache-capacity.diff text/plain 1754 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZjMxYWI2OWIwYmI1Li4zMTQ3N2U4OTQwNzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDQtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIEVuc3VyZSBiYXNlIGNhY2hlIHBhdGggZXhpc3RzIGJlZm9yZSBj YWxjdWxhdGluZyBkaXNrIGNhY2hlIGNhcGFjaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYmFzZSBjYWNoZSBwYXRoIG1pZ2h0IG5vdCBleGlz dCB5ZXQgaW4gQ2FjaGU6Om9wZW4oKSBzaW5jZSBpdCdzIFN0b3JhZ2U6Om9wZW4oKSB0aGUgb25l IGNhbGxpbmcKKyAgICAgICAgRmlsZVN5c3RlbTo6bWFrZUFsbERpcmVjdG9yaWVzKCkgd2l0aCB0 aGUgZmluYWwgY2FjaGUgZGlyZWN0b3J5LiBJbiBzdWNoIGNhc2UsIGNvbXB1dGVDYXBhY2l0eSgp IGZhaWxzIGJlY2F1c2UKKyAgICAgICAgRmlsZVN5c3RlbTo6Z2V0Vm9sdW1lRnJlZVNwYWNlKCkg bmVlZHMgYW4gZXhpc3RpbmcgZmlsZS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6Q2FjaGU6 Om9wZW4pOgorCiAyMDIwLTA0LTA4ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgdGhlIHVzZSBvZiBYQ0J1aWxkIGJ5IGRlZmF1bHQgaW4gQXBwbGUg YnVpbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05l dHdvcmtDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv cmtDYWNoZS5jcHAKaW5kZXggNzJiYTZiZmYzZGFlLi42YWU3OGEyYzc1ZTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKQEAg LTc4LDYgKzc4LDkgQEAgc3RhdGljIHNpemVfdCBjb21wdXRlQ2FwYWNpdHkoQ2FjaGVNb2RlbCBj YWNoZU1vZGVsLCBjb25zdCBTdHJpbmcmIGNhY2hlUGF0aCkKIAogUmVmUHRyPENhY2hlPiBDYWNo ZTo6b3BlbihOZXR3b3JrUHJvY2VzcyYgbmV0d29ya1Byb2Nlc3MsIGNvbnN0IFN0cmluZyYgY2Fj aGVQYXRoLCBPcHRpb25TZXQ8Q2FjaGVPcHRpb24+IG9wdGlvbnMsIFBBTDo6U2Vzc2lvbklEIHNl c3Npb25JRCkKIHsKKyAgICBpZiAoIUZpbGVTeXN0ZW06Om1ha2VBbGxEaXJlY3RvcmllcyhjYWNo ZVBhdGgpKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIGF1dG8gY2FwYWNpdHkgPSBj b21wdXRlQ2FwYWNpdHkobmV0d29ya1Byb2Nlc3MuY2FjaGVNb2RlbCgpLCBjYWNoZVBhdGgpOwog ICAgIGF1dG8gc3RvcmFnZSA9IFN0b3JhZ2U6Om9wZW4oY2FjaGVQYXRoLCBvcHRpb25zLmNvbnRh aW5zKENhY2hlT3B0aW9uOjpUZXN0aW5nTW9kZSkgPyBTdG9yYWdlOjpNb2RlOjpBdm9pZFJhbmRv bW5lc3MgOiBTdG9yYWdlOjpNb2RlOjpOb3JtYWwsIGNhcGFjaXR5KTsKIAo=