209335 2020-03-20 06:10:13 -0700 [MSE][GStreamer] Clean and explain first sample PTS hack 2020-03-23 08:27:45 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1632061 0 aboya 2020-03-20 06:10:13 -0700 MediaSample::applyPtsOffset() had a rather confusing name, so it has been changed to something more descriptive of its actual function: extendToTheBeginning(). Also, its only argument has been removed, as it's always zero. An explanation of the hack has also been added. This patch introduces no behavior changes. 1632165 1 394101 aboya 2020-03-20 10:40:21 -0700 Created attachment 394101 Patch 1632853 2 ews-feeder 2020-03-23 08:27:43 -0700 Committed r258844: <https://trac.webkit.org/changeset/258844> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394101. 394101 2020-03-20 10:40:21 -0700 2020-03-23 08:27:44 -0700 Patch bug-209335-20200320184020.patch text/plain 5673 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3OTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg4YWI5N2ZhZjM1YTc0 NWJjYTRkMDM4OWEyMDlmOTQwNmRmNzI5OS4uZDFkNWI4ODNhZDE0YmU0NjQ0NDkwYzRjY2I2NjY5 ZDNlZjZkMjc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTAzLTIwICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIENsZWFuIGFuZCBleHBsYWluIGZpcnN0IHNhbXBsZSBQVFMgaGFjaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVkaWFTYW1wbGU6OmFwcGx5 UHRzT2Zmc2V0KCkgaGFkIGEgcmF0aGVyIGNvbmZ1c2luZyBuYW1lLCBzbyBpdCBoYXMKKyAgICAg ICAgYmVlbiBjaGFuZ2VkIHRvIHNvbWV0aGluZyBtb3JlIGRlc2NyaXB0aXZlIG9mIGl0cyBhY3R1 YWwgZnVuY3Rpb246CisgICAgICAgIGV4dGVuZFRvVGhlQmVnaW5uaW5nKCkuCisKKyAgICAgICAg QWxzbywgaXRzIG9ubHkgYXJndW1lbnQgaGFzIGJlZW4gcmVtb3ZlZCwgYXMgaXQncyBhbHdheXMg emVyby4KKworICAgICAgICBBbiBleHBsYW5hdGlvbiBvZiB0aGUgaGFjayBoYXMgYWxzbyBiZWVu IGFkZGVkLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBubyBiZWhhdmlvciBjaGFu Z2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU2FtcGxl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2FtcGxlR1N0cmVhbWVyOjpl eHRlbmRUb1RoZUJlZ2lubmluZyk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNhbXBsZUdTdHJl YW1lcjo6YXBwbHlQdHNPZmZzZXQpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QXBwZW5kUGlwZWxpbmU6OmFwcHNpbmtOZXdTYW1wbGUpOgorCiAyMDIwLTAzLTA2ICBF bnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dTdHJlYW1lcl0gU3RyZWFtaW5nIGFhYy9tcDMgYXVkaW8gZG9lc24ndCBhbHdheXMgd29yawpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01l ZGlhU2FtcGxlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5jcHAKaW5kZXggZjVhN2RkNjZkMjE4ZTQ3 ZmJkNTlhMjM5NGE5MThjNTBkMjhhNTQyNC4uNzlhNWNiMTBmMTE4ZDkyYzQ3NzViNDRkZWU5MjNj OTVhZThiOTZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhU2FtcGxlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuY3BwCkBAIC05 NSwxMiArOTUsMTMgQEAgUmVmPE1lZGlhU2FtcGxlR1N0cmVhbWVyPiBNZWRpYVNhbXBsZUdTdHJl YW1lcjo6Y3JlYXRlRmFrZVNhbXBsZShHc3RDYXBzKiwgTWVkaWEKICAgICByZXR1cm4gYWRvcHRS ZWYoKmdzdHJlYW1lck1lZGlhU2FtcGxlKTsKIH0KIAotdm9pZCBNZWRpYVNhbXBsZUdTdHJlYW1l cjo6YXBwbHlQdHNPZmZzZXQoTWVkaWFUaW1lIHRpbWVzdGFtcE9mZnNldCkKK3ZvaWQgTWVkaWFT YW1wbGVHU3RyZWFtZXI6OmV4dGVuZFRvVGhlQmVnaW5uaW5nKCkKIHsKLSAgICBpZiAobV9wdHMg PiB0aW1lc3RhbXBPZmZzZXQpIHsKLSAgICAgICAgbV9kdXJhdGlvbiA9IG1fZHVyYXRpb24gKyAo bV9wdHMgLSB0aW1lc3RhbXBPZmZzZXQpOwotICAgICAgICBtX3B0cyA9IHRpbWVzdGFtcE9mZnNl dDsKLSAgICB9CisgICAgLy8gT25seSB0byBiZSB1c2VkIHdpdGggdGhlIGZpcnN0IHNhbXBsZSwg YXMgYSBoYWNrIGZvciBsYWNrIG9mIHN1cHBvcnQgZm9yIGVkaXQgbGlzdHMuCisgICAgLy8gU2Vl IEFwcGVuZFBpcGVsaW5lOjphcHBzaW5rTmV3U2FtcGxlKCkKKyAgICBBU1NFUlQobV9kdHMgPT0g TWVkaWFUaW1lOjp6ZXJvVGltZSgpKTsKKyAgICBtX2R1cmF0aW9uICs9IG1fcHRzOworICAgIG1f cHRzID0gTWVkaWFUaW1lOjp6ZXJvVGltZSgpOwogfQogCiB2b2lkIE1lZGlhU2FtcGxlR1N0cmVh bWVyOjpvZmZzZXRUaW1lc3RhbXBzQnkoY29uc3QgTWVkaWFUaW1lJiB0aW1lc3RhbXBPZmZzZXQp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFTYW1wbGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCmluZGV4IDFkZjQ0MzVhNzkzZjhkMGI5 MzU3YjRlYzY3M2UzOTc3YzZkZTVkNmMuLmVkMzE2NmQzYTBjYzc4MTE5ZmRhZjllNWIxZWRiM2Fi ZTliNDAyYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5oCkBAIC0zOCw3ICsz OCw3IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBSZWY8TWVkaWFTYW1wbGVHU3RyZWFtZXI+IGNy ZWF0ZUZha2VTYW1wbGUoR3N0Q2FwcyosIE1lZGlhVGltZSBwdHMsIE1lZGlhVGltZSBkdHMsIE1l ZGlhVGltZSBkdXJhdGlvbiwgY29uc3QgRmxvYXRTaXplJiBwcmVzZW50YXRpb25TaXplLCBjb25z dCBBdG9tU3RyaW5nJiB0cmFja0lkKTsKIAotICAgIHZvaWQgYXBwbHlQdHNPZmZzZXQoTWVkaWFU aW1lKTsKKyAgICB2b2lkIGV4dGVuZFRvVGhlQmVnaW5uaW5nKCk7CiAgICAgTWVkaWFUaW1lIHBy ZXNlbnRhdGlvblRpbWUoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX3B0czsgfQogICAgIE1l ZGlhVGltZSBkZWNvZGVUaW1lKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gbV9kdHM7IH0KICAg ICBNZWRpYVRpbWUgZHVyYXRpb24oKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX2R1cmF0aW9u OyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCmluZGV4IDVhMmJkZWRhMWI4N2Ex ZGVhOGM2YmJmNWY2OTg0MWQ3ZTlmNjZjMGIuLmZhZTQ5NjgyMjIwOTEyNDBjNTQwYzA1ZDI0OTZh NWVjYmFmODIyODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCkBAIC00NzQs MTAgKzQ3NCwyMyBAQCB2b2lkIEFwcGVuZFBpcGVsaW5lOjphcHBzaW5rTmV3U2FtcGxlKEdSZWZQ dHI8R3N0U2FtcGxlPiYmIHNhbXBsZSkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIC8v IEFkZCBhIGdhcCBzYW1wbGUgaWYgYSBnYXAgaXMgZGV0ZWN0ZWQgYmVmb3JlIHRoZSBmaXJzdCBz YW1wbGUuCisgICAgLy8gSGFjaywgcmV3b3JrIHdoZW4gR1N0cmVhbWVyID49IDEuMTYgYmVjb21l cyBhIHJlcXVpcmVtZW50OgorICAgIC8vIFdlJ3JlIG5vdCBhcHBseWluZyBlZGl0IGxpc3RzLiBH U3RyZWFtZXIgPCAxLjE2IGRvZXNuJ3QgZW1pdCB0aGUgY29ycmVjdCBzZWdtZW50cyB0byBkbyBz by4KKyAgICAvLyBHU3RyZWFtZXIgZml4IGluIGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9y Zy9nc3RyZWFtZXIvZ3N0LXBsdWdpbnMtZ29vZC8tL2NvbW1pdC9jMmEwZGE4MDk2MDA5ZjBmOTk5 NDNmNzhkYzE4MDY2OTY1YmU2MGY5CisgICAgLy8gQWxzbywgaW4gb3JkZXIgdG8gYXBwbHkgdGhl bSB3ZSB3b3VsZCBuZWVkIHRvIGNvbnZlcnQgdGhlIHRpbWVzdGFtcHMgdG8gc3RyZWFtIHRpbWUs IHdoaWNoIHdlJ3JlIG5vdCBjdXJyZW50bHkKKyAgICAvLyBkb2luZyBmb3IgY29uc2lzdGVuY3kg YmV0d2VlbiBHU3RyZWFtZXIgdmVyc2lvbnMuCisgICAgLy8KKyAgICAvLyBJbiBjb25zZXF1ZW5j ZSwgdGhlIHRpbWVzdGFtcHMgd2UncmUgaGFuZGxpbmcgaGVyZSBhcmUgdW5lZGl0ZWQgdHJhY2sg dGltZS4gSW4gdHJhY2sgdGltZSwgdGhlIGZpcnN0IHNhbXBsZSBpcworICAgIC8vIGd1YXJhbnRl ZWQgdG8gaGF2ZSBEVFMgPT0gMCwgYnV0IGluIHRoZSBjYXNlIG9mIHN0cmVhbXMgd2l0aCBCLWZy YW1lcywgb2Z0ZW4gUFRTID4gMC4gRWRpdCBsaXN0cyBmaXggdGhpcyBieQorICAgIC8vIG9mZnNl dHRpbmcgYWxsIHRpbWVzdGFtcHMgYnkgdGhhdCBhbW91bnQgaW4gbW92aWUgdGltZSwgYnV0IHdl IGNhbid0IGRvIHRoYXQgaWYgd2UgZG9uJ3QgaGF2ZSBhY2Nlc3MgdG8gdGhlbS4KKyAgICAvLyAo V2UgY291bGQgYXNzdW1lIHRoZSB0cmFjayBQVFMgb2YgdGhlIHNhbXBsZSB3aXRoIHRyYWNrIERU UyA9IDAgaXMgdGhlIG9mZnNldCwgYnV0IHdlIGRvbid0IGhhdmUgYW55IGd1YXJhbnRlZQorICAg IC8vIHdlIHdpbGwgZ2V0IGFwcGVuZGVkIHRoYXQgc2FtcGxlIGZpcnN0LCBvciBldmVyKS4KKyAg ICAvLworICAgIC8vIEJlY2F1c2UgYSB0cmFjayBwcmVzZW50YXRpb24gdGltZSBzdGFydGluZyBh dCBzb21lIGNsb3NlIHRvIHplcm8sIGJ1dCBub3QgZXhhY3RseSB6ZXJvIHRpbWUgY2FuIGNhdXNl IHVuZXhwZWN0ZWQKKyAgICAvLyByZXN1bHRzIGZvciBhcHBsaWNhdGlvbnMsIHdlIGV4dGVuZCB0 aGUgZHVyYXRpb24gb2YgdGhpcyBmaXJzdCBzYW1wbGUgdG8gdGhlIGxlZnQgc28gdGhhdCBpdCBz dGFydHMgYXQgemVyby4KICAgICBpZiAobWVkaWFTYW1wbGUtPmRlY29kZVRpbWUoKSA9PSBNZWRp YVRpbWU6Onplcm9UaW1lKCkgJiYgbWVkaWFTYW1wbGUtPnByZXNlbnRhdGlvblRpbWUoKSA+IE1l ZGlhVGltZTo6emVyb1RpbWUoKSAmJiBtZWRpYVNhbXBsZS0+cHJlc2VudGF0aW9uVGltZSgpIDw9 IE1lZGlhVGltZSgxLCAxMCkpIHsKLSAgICAgICAgR1NUX0RFQlVHKCJBZGRpbmcgZ2FwIG9mZnNl dCIpOwotICAgICAgICBtZWRpYVNhbXBsZS0+YXBwbHlQdHNPZmZzZXQoTWVkaWFUaW1lOjp6ZXJv VGltZSgpKTsKKyAgICAgICAgR1NUX0RFQlVHKCJFeHRlbmRpbmcgZmlyc3Qgc2FtcGxlIHRvIG1h a2UgaXQgc3RhcnQgYXQgUFRTPTAiKTsKKyAgICAgICAgbWVkaWFTYW1wbGUtPmV4dGVuZFRvVGhl QmVnaW5uaW5nKCk7CiAgICAgfQogCiAgICAgbV9zb3VyY2VCdWZmZXJQcml2YXRlLT5kaWRSZWNl aXZlU2FtcGxlKG1lZGlhU2FtcGxlLmdldCgpKTsK