209323 2020-03-19 18:13:11 -0700 RegExp.prototype[@@replace] doesn't coerce result index to integer 2020-03-25 13:08:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173867 InRadar P2 Normal --- 1 ross.kirsling ross.kirsling ews-watchlist joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1631940 0 ross.kirsling 2020-03-19 18:13:11 -0700 RegExp.prototype[@@replace] doesn't coerce result index to integer 1631942 1 394052 ross.kirsling 2020-03-19 18:21:14 -0700 Created attachment 394052 Patch 1631977 2 394052 ysuzuki 2020-03-19 20:23:10 -0700 Comment on attachment 394052 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394052&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + From https://tc39.es/ecma262/#sec-regexp.prototype-@@replace: > + 21.2.5.10 RegExp.prototype [ @@replace ] ( string, replaceValue ) > + ... > + 14. For each result in results, do > + ... > + e. Let position be ? ToInteger(? Get(result, "index")). > + f. Set position to max(min(position, lengthS), 0). Can you ensure that we do not need to change DFG / FTL too? 1632221 3 ross.kirsling 2020-03-20 12:39:16 -0700 (In reply to Yusuke Suzuki from comment #2) > Can you ensure that we do not need to change DFG / FTL too? Confirmed that this issue is limited to the @@replace built-in. 1632238 4 ews-feeder 2020-03-20 13:20:03 -0700 Committed r258783: <https://trac.webkit.org/changeset/258783> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394052. 1632239 5 webkit-bug-importer 2020-03-20 13:21:16 -0700 <rdar://problem/60701752> 394052 2020-03-19 18:21:14 -0700 2020-03-20 13:20:03 -0700 Patch bug-209323-20200319182114.patch text/plain 4012 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl YjIxMGZlY2IzY2E4ZTY1YTY3ODU2NjY3YmI0MzBlNDhkZWNkY2I5Li42YTg3OWIwNDhhYjU1Yzdm MDg0OGY2YWRmNDlmYTczMWZmNzYyNmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wMy0xOSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgUmVnRXhwLnByb3RvdHlwZVtAQHJlcGxhY2VdIGRvZXNuJ3QgY29l cmNlIHJlc3VsdCBpbmRleCB0byBpbnRlZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGcm9tIGh0dHBzOi8vdGMzOS5lcy9lY21hMjYyLyNzZWMtcmVn ZXhwLnByb3RvdHlwZS1AQHJlcGxhY2U6CisgICAgICAgICAgMjEuMi41LjEwIFJlZ0V4cC5wcm90 b3R5cGUgWyBAQHJlcGxhY2UgXSAoIHN0cmluZywgcmVwbGFjZVZhbHVlICkKKyAgICAgICAgICAg IC4uLgorICAgICAgICAgICAgMTQuIEZvciBlYWNoIHJlc3VsdCBpbiByZXN1bHRzLCBkbworICAg ICAgICAgICAgICAuLi4KKyAgICAgICAgICAgICAgZS4gTGV0IHBvc2l0aW9uIGJlID8gVG9JbnRl Z2VyKD8gR2V0KHJlc3VsdCwgImluZGV4IikpLgorICAgICAgICAgICAgICBmLiBTZXQgcG9zaXRp b24gdG8gbWF4KG1pbihwb3NpdGlvbiwgbGVuZ3RoUyksIDApLgorCisgICAgICAgIHJlc3VsdC5p bmRleCBtYXkgYmUgdW5kZWZpbmVkLCBzbyBpdCBkb2Vzbid0IHN1ZmZpY2UgdG8gY29lcmNlIGl0 IHdpdGggY29tcGFyaXNvbiBvcGVyYXRvcnMuCisKKyAgICAgICAgKiBidWlsdGlucy9SZWdFeHBQ cm90b3R5cGUuanM6CisKIDIwMjAtMDMtMTkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXggYWZ0ZXIgcjI1ODcxNwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3RvdHlwZS5q cyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9SZWdFeHBQcm90b3R5cGUuanMKaW5k ZXggMDA0NmJlYWYxMjg4YTgzOWYxMTE2ZjM4ZTAwZDQwMjE3NTljNjBjYS4uY2RkMGE5NzViOTU1 MjcwMDczZTAxOGY2Mzc0NmQxNmQ3OWJlYTNmZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2J1aWx0aW5zL1JlZ0V4cFByb3RvdHlwZS5qcworKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnVpbHRpbnMvUmVnRXhwUHJvdG90eXBlLmpzCkBAIC0zMzAsNyArMzMwLDcgQEAgZnVu Y3Rpb24gcmVwbGFjZShzdHJBcmcsIHJlcGxhY2UpCiAgICAgICAgICAgICBuQ2FwdHVyZXMgPSAw OwogICAgICAgICB2YXIgbWF0Y2hlZCA9IEB0b1N0cmluZyhyZXN1bHRbMF0pOwogICAgICAgICB2 YXIgbWF0Y2hMZW5ndGggPSBtYXRjaGVkLmxlbmd0aDsKLSAgICAgICAgdmFyIHBvc2l0aW9uID0g cmVzdWx0LmluZGV4OworICAgICAgICB2YXIgcG9zaXRpb24gPSBAdG9JbnRlZ2VyKHJlc3VsdC5p bmRleCk7CiAgICAgICAgIHBvc2l0aW9uID0gKHBvc2l0aW9uID4gc3RyaW5nTGVuZ3RoKSA/IHN0 cmluZ0xlbmd0aCA6IHBvc2l0aW9uOwogICAgICAgICBwb3NpdGlvbiA9IChwb3NpdGlvbiA8IDAp ID8gMCA6IHBvc2l0aW9uOwogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVz dHMvQ2hhbmdlTG9nCmluZGV4IDkxNzVjYjVkZGZjNDVmOWVhNjY5ODIzOTU2OGZkZDViOTEyNzIz MzUuLjVlMzM2MjA5YjdmNjRkZGNlYTBkNjEyOTY5OGE0NDc5NTU5NDAxYzcgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMjAtMDMtMTkgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgor CisgICAgICAgIFJlZ0V4cC5wcm90b3R5cGVbQEByZXBsYWNlXSBkb2Vzbid0IGNvZXJjZSByZXN1 bHQgaW5kZXggdG8gaW50ZWdlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA5MzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOgorICAgICAgICBNYXJrIHNp eCB0ZXN0IGNhc2VzIGFzIHBhc3NpbmcuCisKIDIwMjAtMDMtMTkgIFRvbWFzIFBvcGVsYSAgPHRw b3BlbGFAcmVkaGF0LmNvbT4KIAogICAgICAgICBbSlNDXVtCaWdFbmRpYW5zXSBTZXZlcmFsIEpT QyBzdHJlc3MgdGVzdHMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVj dGF0aW9ucy55YW1sIGIvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCmluZGV4IDU5 ODU4MDQwNmMxN2M1YWRmZTNhMzQxOGM1YmQ4MTljNzVjODVjYmEuLjMwYTM0ZmU5ZjEzNDdlZTFm ZjJjN2JlODM1ZDZhYmU2OTJlYTk4ZjUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvdGVzdDI2Mi9leHBl Y3RhdGlvbnMueWFtbAorKysgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKQEAg LTE0ODYsMTUgKzE0ODYsNiBAQCB0ZXN0L2J1aWx0LWlucy9SZWdFeHAvcHJvdG8tZnJvbS1jdG9y LXJlYWxtLmpzOgogdGVzdC9idWlsdC1pbnMvUmVnRXhwL3Byb3RvdHlwZS9TeW1ib2wubWF0Y2gv YnVpbHRpbi1pbmZlci11bmljb2RlLmpzOgogICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBl Y3RlZCBTYW1lVmFsdWUowqvvv73CuywgwqtudWxswrspIHRvIGJlIHRydWUnCiAgIHN0cmljdCBt b2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqvvv73CuywgwqtudWxswrsp IHRvIGJlIHRydWUnCi10ZXN0L2J1aWx0LWlucy9SZWdFeHAvcHJvdG90eXBlL1N5bWJvbC5yZXBs YWNlL3Jlc3VsdC1jb2VyY2UtY2FwdHVyZS5qczoKLSAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjog RXhwZWN0ZWQgU2FtZVZhbHVlKMKrwrssIMKrZm9vW3RvU3RyaW5nIHZhbHVlXWJhcsK7KSB0byBi ZSB0cnVlJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVl KMKrwrssIMKrZm9vW3RvU3RyaW5nIHZhbHVlXWJhcsK7KSB0byBiZSB0cnVlJwotdGVzdC9idWls dC1pbnMvUmVnRXhwL3Byb3RvdHlwZS9TeW1ib2wucmVwbGFjZS9yZXN1bHQtY29lcmNlLWxlbmd0 aC5qczoKLSAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMKrwrss IMKrZm9vYmFyJDPCuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6 IEV4cGVjdGVkIFNhbWVWYWx1ZSjCq8K7LCDCq2Zvb2JhciQzwrspIHRvIGJlIHRydWUnCi10ZXN0 L2J1aWx0LWlucy9SZWdFeHAvcHJvdG90eXBlL1N5bWJvbC5yZXBsYWNlL3Jlc3VsdC1jb2VyY2Ut bWF0Y2hlZC5qczoKLSAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVl KMKrwrssIMKrZm9vW3RvU3RyaW5nIHZhbHVlXWJhcsK7KSB0byBiZSB0cnVlJwotICBzdHJpY3Qg bW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMKrwrssIMKrZm9vW3RvU3Ry aW5nIHZhbHVlXWJhcsK7KSB0byBiZSB0cnVlJwogdGVzdC9idWlsdC1pbnMvUmVnRXhwL3Byb3Rv dHlwZS9TeW1ib2wuc2VhcmNoL3UtbGFzdGluZGV4LWFkdmFuY2UuanM6CiAgIGRlZmF1bHQ6ICdU ZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqzHCuywgwqstMcK7KSB0byBiZSB0cnVl JwogICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMKrMcK7 LCDCqy0xwrspIHRvIGJlIHRydWUnCg==