209322 2020-03-19 17:12:49 -0700 Update check for aarch64 2020-04-01 11:25:09 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin cdumez cmarcelo ddkilzer ews-watchlist mark.lam mcatanzaro saam webkit-bug-importer oldest_to_newest 1631924 0 mcatanzaro 2020-03-19 17:12:49 -0700 /* CPU(ARM64) - Apple */ #if (defined(__arm64__) && defined(__APPLE__)) || defined(__aarch64__) #define WTF_CPU_ARM64 1 #define WTF_CPU_KNOWN 1 #if defined(__arm64e__) #define WTF_CPU_ARM64E 1 #endif #endif /* CPU(ARM64) - Apple */ is clearly a stale comment, since we're using CPU(ARM64) for Linux aarch64. Looks like the __APPLE__ check is obsolete. Let's see if removing it breaks anything? 1631925 1 394048 mcatanzaro 2020-03-19 17:15:00 -0700 Created attachment 394048 Patch 1636345 2 394048 ddkilzer 2020-03-31 18:09:00 -0700 Comment on attachment 394048 Patch I seem to recall there were competing 64-bit ARM instruction sets when it originally came out--I'm not sure whether those got resolved, or if they're close enough that both of these can be defined as CPU(ARM64). I'll CC Mark Lam as he might remember. 1636349 3 mark.lam 2020-03-31 18:42:15 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Comment on attachment 394048 [details] > Patch > > I seem to recall there were competing 64-bit ARM instruction sets when it > originally came out--I'm not sure whether those got resolved, or if they're > close enough that both of these can be defined as CPU(ARM64). > > I'll CC Mark Lam as he might remember. I don't remember such a difference. On Apple's side, I believe this change is fine. I tested on all relevant build targets. If this also works for linux, I'm fine with the change. 1636350 4 394048 mark.lam 2020-03-31 18:42:36 -0700 Comment on attachment 394048 Patch r=me 1636359 5 ews-feeder 2020-03-31 19:06:55 -0700 Committed r259332: <https://trac.webkit.org/changeset/259332> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394048. 1636360 6 webkit-bug-importer 2020-03-31 19:07:11 -0700 <rdar://problem/61135818> 1636371 7 394048 saam 2020-03-31 21:08:00 -0700 Comment on attachment 394048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394048&action=review > Source/WTF/wtf/PlatformCPU.h:116 > +#if defined(__arm64__) || defined(__aarch64__) Doesn’t this also need to be done in bmalloc? 1636474 8 mcatanzaro 2020-04-01 07:25:17 -0700 Yeah... but without a warning comment that the files need to be synced, how are devs to know? :( 1636476 9 mcatanzaro 2020-04-01 07:27:32 -0700 (In reply to Mark Lam from comment #3) > I don't remember such a difference. On Apple's side, I believe this change > is fine. I tested on all relevant build targets. If this also works for > linux, I'm fine with the change. This won't change anything on Linux. It's just cleaning up a condition that doesn't seem to be doing anything. 1636477 10 395165 mcatanzaro 2020-04-01 07:27:41 -0700 Created attachment 395165 Patch 1636479 11 394048 mark.lam 2020-04-01 07:37:46 -0700 Comment on attachment 394048 Patch Let’s not obsolete this first patch since it was landed, and not replaced. 1636501 12 ews-feeder 2020-04-01 08:28:42 -0700 Committed r259344: <https://trac.webkit.org/changeset/259344> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395165. 1636583 13 saam 2020-04-01 11:25:09 -0700 (In reply to Michael Catanzaro from comment #8) > Yeah... but without a warning comment that the files need to be synced, how > are devs to know? :( Yeah it’s not great, but a lot of things in bmalloc and WTF need to be synced. 394048 2020-03-19 17:15:00 -0700 2020-04-01 07:37:46 -0700 Patch bug-209322-20200319191500.patch text/plain 1295 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYzMjFmODhlNjMwOWViNGUzYmU3Mjcx Y2RhOWE1OTQwNTdhNDEyYjYuLjhkNWM2ZTNiYTE0NzhkNjllM2YyMzM1OGIyZDAwMmQ0ZDUyMjAw NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgVXBkYXRlIGNoZWNrIGZvciBhYXJjaDY0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzMjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDUFUoQVJN NjQpIGlzIHVzZWQgb24gTGludXgsIHNvIGNoZWNraW5nIHRvIGF2b2lkIEFwcGxlIHBsYXRmb3Jt cyBkb2Vzbid0IG1ha2UgbXVjaCBzZW5zZS4KKyAgICAgICAgVGhlIGNvbW1lbnQgaW1wbHlpbmcg dGhhdCB0aGlzIGlzIGFuIEFwcGxlIGFyY2hpdGVjdHVyZSBhbHNvIG5vIGxvbmdlciBtYWtlcyBz ZW5zZS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybUNQVS5oOgorCiAyMDIwLTAzLTE5ICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggbWFueSB3YXJu aW5ncyB3aXRoIENsYW5nIDcuMCBvbiBHVEsgeDg2LTY0IGluIERlYnVnLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvUGxhdGZvcm1DUFUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtQ1BV LmgKaW5kZXggYmNlMjNlMDM0NmQ1NDNkZWQ2OWRjMmE1Yzg1ZjBlOGI0MjhkYmUyYi4uMTRkNDll NDcwOWQyNjFiNDA5ZTBmYmRiOWEzMWJlZjE5MjJlODMzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvUGxhdGZvcm1DUFUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUNQVS5oCkBA IC0xMTIsOCArMTEyLDggQEAKICNkZWZpbmUgV1RGX0NQVV9LTk9XTiAxCiAjZW5kaWYKIAotLyog Q1BVKEFSTTY0KSAtIEFwcGxlICovCi0jaWYgKGRlZmluZWQoX19hcm02NF9fKSAmJiBkZWZpbmVk KF9fQVBQTEVfXykpIHx8IGRlZmluZWQoX19hYXJjaDY0X18pCisvKiBDUFUoQVJNNjQpICovCisj aWYgZGVmaW5lZChfX2FybTY0X18pIHx8IGRlZmluZWQoX19hYXJjaDY0X18pCiAjZGVmaW5lIFdU Rl9DUFVfQVJNNjQgMQogI2RlZmluZSBXVEZfQ1BVX0tOT1dOIDEKIAo= 395165 2020-04-01 07:27:41 -0700 2020-04-01 08:28:44 -0700 Patch bug-209322-20200401092740.patch text/plain 1230 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZTAyMzViNGQ5ZjZhYjMy NzU5YWVjOTEwZGZhNzIzNmY0MTI5N2RiZi4uY2M0ZDJmNTkzNzkwMGUxODg4NmYyMzBjNGViNzY1 MDgxYWMwMGNjZCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTAxICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVwZGF0ZSBj aGVjayBmb3IgYWFyY2g2NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA5MzIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTEzNTgxOD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgQlBsYXRm b3JtLmggdG8gZm9sbG93IHRoZSBjb3JyZXNwb25kaW5nIGNoYW5nZSBpbiBXVEYncyBQbGF0Zm9y bUNQVS5oLgorCisgICAgICAgICogYm1hbGxvYy9CUGxhdGZvcm0uaDoKKwogMjAyMC0wMy0xNSAg WXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFNob3VsZCBub3Qg dXNlIHZhcmlhYmxlLWxlbmd0aC1hcnJheSAoVkxBKQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxs b2MvYm1hbGxvYy9CUGxhdGZvcm0uaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3Jt LmgKaW5kZXggZWJhZmUwM2Q3N2RjOGIzM2ZlYjU1OTY1MmNjMzliYzhkNDYwYzA5Zi4uMzJiZmYw YWE1ZTY5OWIyOWI3YWYwMGE1ZTJkNTE3YjFmNjcxZjY5YSAxMDA2NDQKLS0tIGEvU291cmNlL2Jt YWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQ bGF0Zm9ybS5oCkBAIC0xMjMsOCArMTIzLDggQEAKICNkZWZpbmUgQkNQVV9YODZfNjQgMQogI2Vu ZGlmCiAKLS8qIEJDUFUoQVJNNjQpIC0gQXBwbGUgKi8KLSNpZiAoZGVmaW5lZChfX2FybTY0X18p ICYmIGRlZmluZWQoX19BUFBMRV9fKSkgfHwgZGVmaW5lZChfX2FhcmNoNjRfXykKKy8qIEJDUFUo QVJNNjQpICovCisjaWYgZGVmaW5lZChfX2FybTY0X18pIHx8IGRlZmluZWQoX19hYXJjaDY0X18p CiAjZGVmaW5lIEJDUFVfQVJNNjQgMQogI2VuZGlmCiAK