209318 2020-03-19 15:47:14 -0700 REGRESSION (r258707): storage/indexeddb/cursor-leak.html is flaky timing out 2020-03-20 17:18:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209256 InRadar P2 Normal --- 1 jacob_uphoff sihui_liu alecflett beidson cdumez ews-watchlist jsbell rniwa sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1631887 0 jacob_uphoff 2020-03-19 15:47:14 -0700 storage/indexeddb/cursor-leak.html This test started to flaky timeout after commit r258707 for wk2. History: https://results.webkit.org/?suite=layout-tests&test=storage%2Findexeddb%2Fcursor-leak.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-actual.txt @@ -1,15 +1,5 @@ -Verify that that cursors weakly hold script value properties +#PID UNRESPONSIVE - WebKitTestRunner (pid 75029) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB; - -indexedDB.deleteDatabase(dbname) -indexedDB.open(dbname) -PASS cursorObservers.length is 10000 -PASS anyCollected is true -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF 1631889 1 webkit-bug-importer 2020-03-19 15:47:52 -0700 <rdar://problem/60657081> 1631902 2 jacob_uphoff 2020-03-19 16:27:13 -0700 Set expectations here: https://bugs.webkit.org/show_bug.cgi?id=209318 1631903 3 jacob_uphoff 2020-03-19 16:29:51 -0700 I don't think this is worth rolling out the commit because it did fix one of the two tests, and the other test is no longer flaky but it is timing out now. 1631906 4 jacob_uphoff 2020-03-19 16:39:18 -0700 Looks like this is also timing out on wk1. SO set new expectations here: https://trac.webkit.org/changeset/258742/webkit 1631922 5 rniwa 2020-03-19 17:06:16 -0700 Maybe 10,000 is a bit too high of a number. Maybe try 1000? 1631999 6 394067 sihui_liu 2020-03-19 21:42:10 -0700 Created attachment 394067 Patch 1632158 7 ews-feeder 2020-03-20 10:27:04 -0700 Committed r258768: <https://trac.webkit.org/changeset/258768> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394067. 1632325 8 sihui_liu 2020-03-20 15:33:55 -0700 Reopening to attach new patch. 1632326 9 394138 sihui_liu 2020-03-20 15:33:56 -0700 Created attachment 394138 Patch for landing 1632341 10 ews-feeder 2020-03-20 15:56:15 -0700 Committed r258797: <https://trac.webkit.org/changeset/258797> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394138. 1632391 11 rniwa 2020-03-20 17:18:08 -0700 Woot! Looks like the flakiness is gone! 394067 2020-03-19 21:42:10 -0700 2020-03-20 15:33:53 -0700 Patch bug-209318-20200319214209.patch text/plain 3165 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzQ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODU4YjQxMTQ2MDliMTBlZTU3ZTQy YjY1ZDBiMGQyM2EzYzc4OTFhNi4uYzUzMmIzZDZjNTM5NGY2NzMzNjcxOTdkMjFlYTI1NGQ4ODMx Y2U4YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTE5ICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTg3MDcpOiBzdG9yYWdl L2luZGV4ZWRkYi9jdXJzb3ItbGVhay5odG1sIGlzIGZsYWt5IHRpbWluZyBvdXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTMxOAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNjA2NTcwODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT3BlbiBmZXdlciBjdXJzb3JzIHRvIG1ha2UgdGhlIHRlc3QgZmFz dGVyLgorCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLWxlYWstZXhwZWN0ZWQu dHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci1sZWFrLXByaXZhdGUtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9jdXJzb3It bGVhay5qczoKKyAgICAgICAgKG9uT3Blbi50eC5vbmNvbXBsZXRlKToKKwogMjAyMC0wMy0xOSAg SmFjb2IgVXBob2ZmICA8amFjb2JfdXBob2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMjU4NzA3KTogc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLWxlYWsuaHRtbCBpcyBmbGFr eSB0aW1pbmcgb3V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9j dXJzb3ItbGVhay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9j dXJzb3ItbGVhay1leHBlY3RlZC50eHQKaW5kZXggN2RmYzEzNmYzODI1MjliNTk2MDM1MmU4MzMw NWRmZTRlZjVjNjA5My4uOGYxN2M3NWRhMWQyMWY0NzZjNjAzOGYxNWM5YWRiYzE1ODgwNjA2OCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLWxlYWstZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci1sZWFr LWV4cGVjdGVkLnR4dApAQCAtNyw3ICs3LDcgQEAgaW5kZXhlZERCID0gc2VsZi5pbmRleGVkREIg fHwgc2VsZi53ZWJraXRJbmRleGVkREIgfHwgc2VsZi5tb3pJbmRleGVkREIgfHwgc2VsZi4KIAog aW5kZXhlZERCLmRlbGV0ZURhdGFiYXNlKGRibmFtZSkKIGluZGV4ZWREQi5vcGVuKGRibmFtZSkK LVBBU1MgY3Vyc29yT2JzZXJ2ZXJzLmxlbmd0aCBpcyAxMDAwMAorUEFTUyBjdXJzb3JPYnNlcnZl cnMubGVuZ3RoIGlzIDEwMDAKIFBBU1MgYW55Q29sbGVjdGVkIGlzIHRydWUKIFBBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvY3Vyc29yLWxlYWstcHJpdmF0ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItbGVhay1wcml2YXRlLWV4cGVjdGVkLnR4dAppbmRleCA3 ZGZjMTM2ZjM4MjUyOWI1OTYwMzUyZTgzMzA1ZGZlNGVmNWM2MDkzLi44ZjE3Yzc1ZGExZDIxZjQ3 NmM2MDM4ZjE1YzlhZGJjMTU4ODA2MDY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9jdXJzb3ItbGVhay1wcml2YXRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItbGVhay1wcml2YXRlLWV4cGVjdGVkLnR4dApA QCAtNyw3ICs3LDcgQEAgaW5kZXhlZERCID0gc2VsZi5pbmRleGVkREIgfHwgc2VsZi53ZWJraXRJ bmRleGVkREIgfHwgc2VsZi5tb3pJbmRleGVkREIgfHwgc2VsZi4KIAogaW5kZXhlZERCLmRlbGV0 ZURhdGFiYXNlKGRibmFtZSkKIGluZGV4ZWREQi5vcGVuKGRibmFtZSkKLVBBU1MgY3Vyc29yT2Jz ZXJ2ZXJzLmxlbmd0aCBpcyAxMDAwMAorUEFTUyBjdXJzb3JPYnNlcnZlcnMubGVuZ3RoIGlzIDEw MDAKIFBBU1MgYW55Q29sbGVjdGVkIGlzIHRydWUKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3Vy Y2VzL2N1cnNvci1sZWFrLmpzIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3Vy Y2VzL2N1cnNvci1sZWFrLmpzCmluZGV4IDA2ZGQ4ZTcxYWZkY2FlMGNlMzJmYTU0YTJjNzE5MDI4 NDUzMDc3ZGQuLjEyY2VhNWM0MjA1NjA0NGNhMWQzNzg2MDRiMjYzMWM5MjRhNDRhNmEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9jdXJzb3ItbGVh ay5qcworKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvY3Vyc29y LWxlYWsuanMKQEAgLTI3LDcgKzI3LDcgQEAgZnVuY3Rpb24gb25PcGVuKGV2dCkKICAgICB0eCA9 IGRiLnRyYW5zYWN0aW9uKCdzdG9yZScsICdyZWFkb25seScpOwogICAgIHN0b3JlID0gdHgub2Jq ZWN0U3RvcmUoJ3N0b3JlJyk7CiAgICAgY3Vyc29yT2JzZXJ2ZXJzID0gW107Ci0gICAgZm9yIChs ZXQgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAw OyArK2kpIHsKICAgICAgICAgc3RvcmUub3BlbkN1cnNvcigpLm9uc3VjY2VzcyA9IChldmVudCkg PT4gewogICAgICAgICAgICAgY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdAogICAgICAgICAg ICAgY3Vyc29yLmtleS5jdXJzb3IgPSBjdXJzb3I7CkBAIC0zOSw3ICszOSw3IEBAIGZ1bmN0aW9u IG9uT3BlbihldnQpCiAgICAgfQogICAgIHR4Lm9uY29tcGxldGUgPSBmdW5jdGlvbigpIHsKICAg ICAgICAgZGIuY2xvc2UoKTsKLSAgICAgICAgc2hvdWxkQmUoJ2N1cnNvck9ic2VydmVycy5sZW5n dGgnLCAnMTAwMDAnKTsKKyAgICAgICAgc2hvdWxkQmUoJ2N1cnNvck9ic2VydmVycy5sZW5ndGgn LCAnMTAwMCcpOwogCiAgICAgICAgIGdjKCk7CiAK 394138 2020-03-20 15:33:56 -0700 2020-03-20 15:56:16 -0700 Patch for landing bug-209318-20200320153355.patch text/plain 2414 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzY2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTZmNjRmMzUxMWMyYmZlMzFiNzFj ZTljZDNjNjNkNzM3NTRiYzZmMS4uMmY1ZTA2MWFiZmZhNjdmNjYwNTc2NjIxMDk3ZWJhNmM1ZDU5 MWQxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAzLTIwICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTg3MDcpOiBzdG9yYWdl L2luZGV4ZWRkYi9jdXJzb3ItbGVhay5odG1sIGlzIGZsYWt5IHRpbWluZyBvdXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTMxOAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNjA2NTcwODE+CisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRl bmluZyBhZnRlciByMjU4NzY4LgorCisgICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhw ZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDIwLTAzLTIwICBFbnJpcXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gTGF5b3V0IFRlc3QgbWVkaWEvdHJhY2svdHJhY2stbGVnYWN5YXBp LXdpdGgtYXV0b21hdGljLW1vZGUuaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYThmOGM2YTkxYzkzYTYzN2IzMDAz NzQxMzZiZDViODZlN2UzMWU3MC4uNzdiMWFjM2U0M2ZlOTI0YWQ5ZjJiNWM0ODU4NGM4NTg1NTE1 OTQ1YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9u cwpAQCAtMTQyMCw4ICsxNDIwLDYgQEAgd2Via2l0Lm9yZy9iLzIwODU5MCBbIERlYnVnIF0gZmFz dC9ldmVudHMvYmVmb3JldW5sb2FkLXByb21wdC5odG1sIFsgUGFzcyBDcmFzaAogCiB3ZWJraXQu b3JnL2IvMjA4NjU2IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi90cmFuc2FjdGlvbnMtc3RvcC1v bi1uYXZpZ2F0aW9uLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjA5MzE4 IHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNvci1sZWFrLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQotCiB3 ZWJraXQub3JnL2IvMjA4NjYyIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9s aWN5L2phdmFzY3JpcHQtdXJsLWJsb2NrZWQtYnktZGVmYXVsdC1zcmMtc3Rhci5odG1sIFsgUGFz cyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzIwODcxOCBbIERlYnVnIF0gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9pbnRlcmZhY2VzL0FuaW1hdGlvbi9j b21taXRTdHlsZXMuaHRtbCBbIFBhc3MgQ3Jhc2ggXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucwppbmRleCBhMjBhMzEwNGE2ZDlmYmY5NTEzYjMxMmE0MjgyOWRkNDNm MzJlM2RmLi43NWU1MzA0NDdlN2QxNDE5NDA1YTdmNjcwZjMwNTEzMmVhOWE0NGYxIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTExNiw4ICsxMTE2LDYg QEAgd2Via2l0Lm9yZy9iLzE1NjExMiBbIFNpZXJyYSsgXSBtZWRpYS9jb250cm9scy13aXRob3V0 LXByZWxvYWQuaHRtbCBbIFBhc3MgRmFpbHUKIAogd2Via2l0Lm9yZy9iLzE1NjM1MSBzdG9yYWdl L2luZGV4ZWRkYi9tb2Rlcm4vYXV0b2luY3JlbWVudC1hYm9ydC1wcml2YXRlLmh0bWwgWyBQYXNz IFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMjA5MzE4IHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNv ci1sZWFrLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQotCiB3ZWJraXQub3JnL2IvMTU2OTgzIG1lZGlh L3ZpZGVvLWZ1bGxzY3JlZW4tcmVzdHJpY3Rpb24tcmVtb3ZlZC5odG1sIFsgUGFzcyBGYWlsdXJl IF0KIAogd2Via2l0Lm9yZy9iLzE1NTE5NiBzZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kv dmlkZW8td2l0aC1maWxlLXVybC1hbGxvd2VkLWJ5LW1lZGlhLXNyYy1zdGFyLmh0bWwgWyBQYXNz IEltYWdlT25seUZhaWx1cmUgXQo=