209299 2020-03-19 12:43:43 -0700 REGRESSION (r258679): [ Mac ] fast/scrolling/arrow-key-scroll-in-rtl-document.html is failing and timing out 2020-03-23 10:06:47 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209427 InRadar P2 Normal --- 1 tsavell simon.fraser cmarcelo dbates ddkilzer ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1631777 0 tsavell 2020-03-19 12:43:43 -0700 fast/scrolling/arrow-key-scroll-in-rtl-document.html This test became a frequent flaky failure and timeout after the changes in https://trac.webkit.org/changeset/258679/webkit I am able to reproduce this issue on 258679 but not 258678 using command: run-webkit-tests --iterations 2000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f fast/scrolling/arrow-key-scroll-in-rtl-document.html History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Farrow-key-scroll-in-rtl-document.html Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-actual.txt @@ -1 +1 @@ -PASS: scrollLeft is -120 +FAIL: scrollLeft is 0, expected -120 1631778 1 webkit-bug-importer 2020-03-19 12:44:01 -0700 <rdar://problem/60646111> 1632121 2 simon.fraser 2020-03-20 09:25:41 -0700 I can reproduce. 1632410 3 simon.fraser 2020-03-20 18:10:55 -0700 We don't have WheelEventTestMonitor reasons for the key-scrolling behavior, which is that WebEditorClient::handleKeyboardEvent()calls down into WebPage::scroll() which ends up in FrameView::requestScrollPositionUpdate() and bounces to the scrolling thread, and then back to the main thread. 1632413 4 394154 simon.fraser 2020-03-20 19:12:47 -0700 Created attachment 394154 Patch 1632441 5 ews-feeder 2020-03-20 22:54:57 -0700 Committed r258805: <https://trac.webkit.org/changeset/258805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394154. 394154 2020-03-20 19:12:47 -0700 2020-03-20 22:54:58 -0700 Patch bug-209299-20200320191247.patch text/plain 5822 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGYxOTBjZjQwZjIzMTE4 MTkyZjM0MWI2YzZhZTRkZDQ4M2Y1N2I4YS4uNDk1YTU3NWM3YmFmYmE0YTBkYTYwMDJkYTU1MTI0 MDJmY2EwMjUyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTAzLTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyNTg2NzkpOiBbIE1hYyBdIGZhc3Qvc2Nyb2xsaW5nL2Fycm93LWtleS1zY3JvbGwtaW4tcnRs LWRvY3VtZW50Lmh0bWwgaXMgZmFpbGluZyBhbmQgdGltaW5nIG91dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5Mjk5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9zY3JvbGxpbmcvYXJyb3cta2V5 LXNjcm9sbC1pbi1ydGwtZG9jdW1lbnQuaHRtbCBpcyB1bnVzdWFsIGluIHRoYXQgaXQgdXNlcyBt b25pdG9yV2hlZWxFdmVudHMoKQorICAgICAgICBidXQgdGhlbiBpc3N1ZXMgYXJyb3cga2V5IHBy ZXNzZXMuCisKKyAgICAgICAgV2ViQ29yZSByZXNwb25kcyB0byBhcnJvdyBrZXlzIHZpYSBXZWJF ZGl0b3JDbGllbnQ6OmhhbmRsZUtleWJvYXJkRXZlbnQoKSBjYWxsaW5nIGRvd24gaW50bworICAg ICAgICBXZWJQYWdlOjpzY3JvbGwoKSB3aGljaCBlbmRzIHVwIGluIEZyYW1lVmlldzo6cmVxdWVz dFNjcm9sbFBvc2l0aW9uVXBkYXRlKCkgYW5kIGJvdW5jZXMgdG8gdGhlCisgICAgICAgIHNjcm9s bGluZyB0aHJlYWQuIFRoaXMgaXNuJ3QgdHJhY2tlZCBieSBleGlzdGluZyAnZGVmZXInIHJlYXNv bnMgb24gV2hlZWxFdmVudFRlc3RNb25pdG9yLCBzbyBhZGQgYQorICAgICAgICBuZXcgZGVmZXIg cmVhc29uIHRoYXQgY292ZXJzIHRoZSBwZXJpb2QgZm9yIGFkZGluZyB0aGUgcmVxdWVzdGVkIHNj cm9sbCBnbyB0aGUgc2Nyb2xsaW5nIHN0YXRlIHRyZWUsCisgICAgICAgIGFuZCByZXNwb25kaW5n IHRvIGl0IGluIHRoZSBzY3JvbGxpbmcgdGhyZWFkLgorCisgICAgICAgICogcGFnZS9XaGVlbEV2 ZW50VGVzdE1vbml0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3BlcmF0b3I8PCk6CisgICAg ICAgICogcGFnZS9XaGVlbEV2ZW50VGVzdE1vbml0b3IuaDoKKyAgICAgICAgKiBwYWdlL3Njcm9s bGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFz eW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnJlcXVlc3RTY3JvbGxQb3NpdGlvblVwZGF0ZSk6Cisg ICAgICAgICogcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6c2Nyb2xsaW5nVHJlZU5vZGVSZXF1 ZXN0c1Njcm9sbCk6CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdU cmVlLmg6CisKIDIwMjAtMDMtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIEF2b2lkIGluZmluaXRlIGxvb3Agd2hlbiBzdHVjayBvbiBwYXJ0 aWFsIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2hlZWxFdmVudFRl c3RNb25pdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2hlZWxFdmVudFRlc3RNb25pdG9y LmNwcAppbmRleCA4NmVmNjI1YTBkNTQwNzUyYWU5ZDgwNTgyOTc0NGQ5ZTc5MmNmOGQ4Li43MDNj YWJiNzc5MWY2NjEyMTViMTcyYmExMTg2OTRlMWViOTU1ZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1doZWVsRXZlbnRUZXN0TW9uaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9XaGVlbEV2ZW50VGVzdE1vbml0b3IuY3BwCkBAIC0xNzIsNiArMTcyLDcgQEAgVGV4 dFN0cmVhbSYgb3BlcmF0b3I8PChUZXh0U3RyZWFtJiB0cywgV2hlZWxFdmVudFRlc3RNb25pdG9y OjpEZWZlclJlYXNvbiByZWFzb24KICAgICBjYXNlIFdoZWVsRXZlbnRUZXN0TW9uaXRvcjo6U2Ny b2xsU25hcEluUHJvZ3Jlc3M6IHRzIDw8ICJzY3JvbGwtc25hcHBpbmciOyBicmVhazsKICAgICBj YXNlIFdoZWVsRXZlbnRUZXN0TW9uaXRvcjo6U2Nyb2xsaW5nVGhyZWFkU3luY05lZWRlZDogdHMg PDwgInNjcm9sbGluZyB0aHJlYWQgc3luYyBuZWVkZWQiOyBicmVhazsKICAgICBjYXNlIFdoZWVs RXZlbnRUZXN0TW9uaXRvcjo6Q29udGVudFNjcm9sbEluUHJvZ3Jlc3M6IHRzIDw8ICJjb250ZW50 IHNjcm9sbGluZyI7IGJyZWFrOworICAgIGNhc2UgV2hlZWxFdmVudFRlc3RNb25pdG9yOjpSZXF1 ZXN0ZWRTY3JvbGxQb3NpdGlvbjogdHMgPDwgInJlcXVlc3RlZCBzY3JvbGwgcG9zaXRpb24iOyBi cmVhazsKICAgICB9CiAgICAgcmV0dXJuIHRzOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9XaGVlbEV2ZW50VGVzdE1vbml0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2hl ZWxFdmVudFRlc3RNb25pdG9yLmgKaW5kZXggZWVmYzA5OTMwMDczMTRmZWI0NDRhMWVkNGYwYmM2 NTViODBmODMxZS4uMDI2MTAzZjRlYzgzZWIyNjg5ZmEyYjNlYzEyMjVmMDUwYWU2MzhlZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9XaGVlbEV2ZW50VGVzdE1vbml0b3IuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1doZWVsRXZlbnRUZXN0TW9uaXRvci5oCkBAIC01NCw2ICs1 NCw3IEBAIHB1YmxpYzoKICAgICAgICAgU2Nyb2xsU25hcEluUHJvZ3Jlc3MgICAgICAgICAgICA9 IDEgPDwgMywKICAgICAgICAgU2Nyb2xsaW5nVGhyZWFkU3luY05lZWRlZCAgICAgICA9IDEgPDwg NCwKICAgICAgICAgQ29udGVudFNjcm9sbEluUHJvZ3Jlc3MgICAgICAgICA9IDEgPDwgNSwKKyAg ICAgICAgUmVxdWVzdGVkU2Nyb2xsUG9zaXRpb24gICAgICAgICA9IDEgPDwgNiwKICAgICB9Owog ICAgIHR5cGVkZWYgY29uc3Qgdm9pZCogU2Nyb2xsYWJsZUFyZWFJZGVudGlmaWVyOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3Jk aW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3IuY3BwCmluZGV4IGQ0ZDA1ODAzZmRjOGRlMDNmM2ZhNmQ5MDEzMjdiOGYwYTBh MWFiZDkuLmUwNDJiZDJhYzJhNGVlYmUyYmY5YzZhNzk1ZTlhNjEwNzUzOTY3OGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0 b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3IuY3BwCkBAIC0yNjAsNiArMjYwLDEyIEBAIGJvb2wgQXN5bmNTY3JvbGxpbmdD b29yZGluYXRvcjo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlKFNjcm9sbGFibGVBcmVhJiBz Y3JvCiAgICAgaWYgKCFzdGF0ZU5vZGUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorI2lmIFBM QVRGT1JNKE1BQykKKyAgICBpZiAobV9wYWdlICYmIG1fcGFnZS0+aXNNb25pdG9yaW5nV2hlZWxF dmVudHMoKSkgeworICAgICAgICBMT0dfV0lUSF9TVFJFQU0oV2hlZWxFdmVudFRlc3RNb25pdG9y LCBzdHJlYW0gPDwgIiAgICAoISkgQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6cmVxdWVzdFNj cm9sbFBvc2l0aW9uVXBkYXRlOiBBZGRpbmcgZGVmZXJyYWwgb24gIiA8PCBzY3JvbGxpbmdOb2Rl SUQgPDwgIiBmb3IgcmVhc29uICIgPDwgV2hlZWxFdmVudFRlc3RNb25pdG9yOjpSZXF1ZXN0ZWRT Y3JvbGxQb3NpdGlvbik7CisgICAgICAgIG1fcGFnZS0+d2hlZWxFdmVudFRlc3RNb25pdG9yKCkt PmRlZmVyRm9yUmVhc29uKHJlaW50ZXJwcmV0X2Nhc3Q8V2hlZWxFdmVudFRlc3RNb25pdG9yOjpT Y3JvbGxhYmxlQXJlYUlkZW50aWZpZXI+KHNjcm9sbGluZ05vZGVJRCksIFdoZWVsRXZlbnRUZXN0 TW9uaXRvcjo6UmVxdWVzdGVkU2Nyb2xsUG9zaXRpb24pOworICAgIH0KKyNlbmRpZgogICAgIHN0 YXRlTm9kZS0+c2V0UmVxdWVzdGVkU2Nyb2xsRGF0YSh7IHNjcm9sbFBvc2l0aW9uLCBzY3JvbGxU eXBlLCBjbGFtcGluZyB9KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCmluZGV4 IDc2ODY0OWM2OGMxNzQ1NDY2OWNmMGExMzY4NDM1ZTRmZWI4NzlmZTAuLjcyOGFiMDk4ZTYzY2Uz OTUxMjM1YjUxZDk3YTU1YTE5NjcxM2FkZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcApAQCAtMTk3LDYgKzE5 NywxMCBAQCB2b2lkIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6c2V0QWN0aXZlU2Nyb2xsU25hcElu ZGljZXMoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCwgdQogICAgIH0pOwogfQogCit2b2lkIFRocmVh ZGVkU2Nyb2xsaW5nVHJlZTo6c2Nyb2xsaW5nVHJlZU5vZGVSZXF1ZXN0c1Njcm9sbChTY3JvbGxp bmdOb2RlSUQgbm9kZUlELCBjb25zdCBGbG9hdFBvaW50JiAvKnNjcm9sbFBvc2l0aW9uKi8sIFNj cm9sbFR5cGUsIFNjcm9sbENsYW1waW5nKQoreworICAgIHJlbW92ZVdoZWVsRXZlbnRUZXN0Q29t cGxldGlvbkRlZmVycmFsRm9yUmVhc29uKHJlaW50ZXJwcmV0X2Nhc3Q8V2hlZWxFdmVudFRlc3RN b25pdG9yOjpTY3JvbGxhYmxlQXJlYUlkZW50aWZpZXI+KG5vZGVJRCksIFdoZWVsRXZlbnRUZXN0 TW9uaXRvcjo6UmVxdWVzdGVkU2Nyb2xsUG9zaXRpb24pOworfQogI2VuZGlmCiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv VGhyZWFkZWRTY3JvbGxpbmdUcmVlLmgKaW5kZXggODIzMmUxYjc3MzkzZTc2MTUyNDEyYWQ3OTUz ZDE0YmZhN2VkMzM2MS4uNDE1MDYyMmViY2IzZTIxZTVhNmYyY2I5N2UyNWRmYjVhNDQ1MDE4MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxp bmdUcmVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3Jv bGxpbmdUcmVlLmgKQEAgLTY1LDYgKzY1LDcgQEAgcHJvdGVjdGVkOgogI2lmIFBMQVRGT1JNKE1B QykKICAgICB2b2lkIGhhbmRsZVdoZWVsRXZlbnRQaGFzZShQbGF0Zm9ybVdoZWVsRXZlbnRQaGFz ZSkgb3ZlcnJpZGU7CiAgICAgdm9pZCBzZXRBY3RpdmVTY3JvbGxTbmFwSW5kaWNlcyhTY3JvbGxp bmdOb2RlSUQsIHVuc2lnbmVkIGhvcml6b250YWxJbmRleCwgdW5zaWduZWQgdmVydGljYWxJbmRl eCkgb3ZlcnJpZGU7CisgICAgdm9pZCBzY3JvbGxpbmdUcmVlTm9kZVJlcXVlc3RzU2Nyb2xsKFNj cm9sbGluZ05vZGVJRCwgY29uc3QgRmxvYXRQb2ludCYgLypzY3JvbGxQb3NpdGlvbiovLCBTY3Jv bGxUeXBlLCBTY3JvbGxDbGFtcGluZykgb3ZlcnJpZGU7CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JN KENPQ09BKQo=