20926 2008-09-18 17:07:31 -0700 Reload of page with an iframe does not refresh iframe content, even if iframe src url changed 2008-12-02 12:36:29 -0800 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://asargent.com/tests/iframe.php HasReduction, InRadar P2 Normal --- 1 antony webkit-unassigned ap aroben bdakin erikkay mike.tsao mmoss ojan oldest_to_newest 91698 0 antony 2008-09-18 17:07:31 -0700 Navigate to an html page with some content followed by an iframe tag. Now make a change to the contents and make the iframe src attribute point to a different url. Hit browser reload button, notice that the "outer" content is refreshed but the iframe content still points to the content at the old url. This problem happens with Safari 3.1.2 (525.21), the latest WebKit nightly build (36446), and Chrome 0.2.149.30. It does not happen in Firefox 3.0.1 or IE 7.0.7530.13. Here is the source to two example php files to reproduce the problem: iframe.php ---------- <?php $ts = date('U'); ?> <html> <body> <p> Timestamp is <?= $ts ?> </p> <iframe src="report_url.php?foo=<?= $ts ?>" width="75%" frameborder="1"></iframe> </body> </html> report_url.php -------------- <html> <body> <?php echo $_SERVER['REQUEST_URI'] . "\n"; ?> </body> </html> While this example just changes the value of the foo get parameter, the problem also happens if you change the iframe src url to another path on the same server or another server alltogether. 91711 1 hyatt 2008-09-18 18:29:55 -0700 Can you put those on a server and give us a test URL? 91713 2 antony 2008-09-18 19:53:03 -0700 (In reply to comment #1) > Can you put those on a server and give us a test URL? > http://asargent.com/tests/iframe.php Hit reload a few times in firefox/ie and then in a webkit browser and you should see the difference in behavior. 91751 3 mrowe 2008-09-19 03:11:26 -0700 As far as I can tell this works correctly in the latest nightly of WebKit on Mac OS X at this time: r36640. It definitely fails with Safari 3.1.2 on Mac OS X. 91752 4 mrowe 2008-09-19 03:15:09 -0700 On Windows with the latest nightly (r36647), reloading the page via Ctrl-R shows the bug while loading the page again via Ctrl-L, Return does not. 91753 5 mrowe 2008-09-19 03:15:45 -0700 <rdar://problem/6231953> 92342 6 mike.tsao 2008-09-23 10:08:48 -0700 This affects iframe-based social networking applications, particularly those using either Facebook or OAuth authentication schemes. The credentials are contained in the iframe src URL, and by their own terms they expire after some number of minutes. Upshot is many social-networking applications die after a few minutes, and for some users it's a hard state for them to get out of (F5 and "just clicking around") don't fix the problem. 93787 7 bdakin 2008-10-02 13:17:24 -0700 So, let me get this straight. This is fixed on TOT on the Mac, but on Windows TOT we only do the right thing with a Ctrl-L and not Ctrl-R. And so the remaining bug is that we want this behavior with Ctrl-R as well as Ctrl-L on Windows? Or is our current behavior correct? 97485 8 24861 mmoss 2008-11-03 12:27:58 -0800 Created attachment 24861 proposed fix (sync with related Mac code) 100335 9 24861 eric 2008-11-25 16:52:58 -0800 Comment on attachment 24861 proposed fix (sync with related Mac code) You should consider setting the CHANGE_LOG_NAME environment variable to your full name. It seems on google systems the prepare-ChangeLog code is picking up teh username instead: my $name = $ENV{CHANGE_LOG_NAME} || $ENV{REAL_NAME} || gitConfig("user.name") || (split /\s*,\s*/, (getpwuid $<)[6])[0] || "set REAL_NAME environment variable"; This looks identical to http://trac.webkit.org/changeset/31264 which would suggest to me it's right. I'm going to r+ this, but I don't have a working tree on this box atm, so I can't land it immediately. 101046 10 24861 eric 2008-12-02 12:35:25 -0800 Comment on attachment 24861 proposed fix (sync with related Mac code) About to land. ChangeLog entries should also include a link to the original bugzilla bug as well. 101047 11 eric 2008-12-02 12:36:29 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/win/Skipped M WebKit/win/ChangeLog M WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp Committed r38912 24861 2008-11-03 12:27:58 -0800 2008-11-25 16:52:58 -0800 proposed fix (sync with related Mac code) Bug20926.patch text/plain 2487 mmoss SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiAzODA3NSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMDMgIG1tb3NzICA8bW1vc3NAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IC0gRml4IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxvYWQtc3ViZnJhbWUtKmZyYW1lLmh0bWwg b24gV2luZG93cy4KKworICAgICAgICBDaGFuZ2UgMzEyNjQgZml4ZWQgdGhpcyBvbiBNYWMgKHNp bmNlIG1vdmVkIHRvIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCksIGJ1dCB3YXMgbmV2 ZXIgcG9ydGVkIHRvIFdpbmRvd3MuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJGcmFtZUxvYWRlckNsaWVudDo6bG9hZFVS TEludG9DaGlsZCk6CisKIDIwMDgtMTAtMzEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2ViS2l0L3dp bi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJKHJldmlz aW9uIDM4MDcyKQorKysgV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNs aWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3MSw3ICs1NzEsNiBAQCB2b2lkIFdlYkZyYW1l TG9hZGVyQ2xpZW50Ojpsb2FkVVJMSW50b0NoCiAgICAgLy8gUmVsb2FkIHdpbGwgbWFpbnRhaW4g dGhlIGZyYW1lIGNvbnRlbnRzLCBMb2FkU2FtZSB3aWxsIG5vdC4KICAgICBpZiAocGFyZW50SXRl bSAmJiBwYXJlbnRJdGVtLT5jaGlsZHJlbigpLnNpemUoKSAmJgogICAgICAgICAoaXNCYWNrRm9y d2FyZExvYWRUeXBlKGxvYWRUeXBlKQotICAgICAgICAgfHwgbG9hZFR5cGUgPT0gRnJhbWVMb2Fk VHlwZVJlbG9hZAogICAgICAgICAgfHwgbG9hZFR5cGUgPT0gRnJhbWVMb2FkVHlwZVJlbG9hZEFs bG93aW5nU3RhbGVEYXRhKSkKICAgICB7CiAgICAgICAgIGlmIChIaXN0b3J5SXRlbSogY2hpbGRJ dGVtID0gcGFyZW50SXRlbS0+Y2hpbGRJdGVtV2l0aE5hbWUoY29yZShjaGlsZEZyYW1lKS0+dHJl ZSgpLT5uYW1lKCkpKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODA3NSkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDA4LTExLTAzICBt bW9zcyAgPG1tb3NzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbmFibGUgaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3JlbG9hZC1z dWJmcmFtZS0qZnJhbWUuaHRtbCBvbiBXaW5kb3dzLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L1NraXBwZWQ6CisKIDIwMDgtMTEtMDEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2luL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu L1NraXBwZWQJKHJldmlzaW9uIDM4MDcyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Nr aXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTMxNiw4ICszMTYsNiBAQCBzdmcvY3VzdG9tL2FjaWQz LXRlc3QtNzcuaHRtbAogZmFzdC9jYW52YXMvdG9EYXRhVVJMLXN1cHBvcnRlZFR5cGVzLmh0bWwK IAogIzxyZGFyOi8vcHJvYmxlbS81ODI5MjAyPiBuZXcgc3ViZnJhbWUgcmVsb2FkIHRlc3RzIGZh aWwgb24gV2luZG93cwotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3JlbG9hZC1zdWJmcmFtZS1mcmFt ZS5odG1sIAotaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3JlbG9hZC1zdWJmcmFtZS1pZnJhbWUuaHRt bCAKIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxvYWQtc3ViZnJhbWUtb2JqZWN0Lmh0bWwKIAog IzxyZGFyOi8vcHJvYmxlbS81ODI5MjYwPiBSRUdSRVNTSU9OOiBmcmFtZS1kZWZhdWx0LWVuYyB0 ZXN0cyBmYWlsIG9uIFdpbmRvd3MgaW50ZXJtaXR0ZW50bHkK