209231 2020-03-18 08:02:32 -0700 commit-queue should allow patches which are reviewed by patch author 2020-03-18 10:03:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208138 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1631138 0 aakash_jain 2020-03-18 08:02:32 -0700 commit-queue should allow patches which are reviewed by patch author. Most of the times it is because patch author is uploading the patch on behalf of someone else, e.g.: https://bugs.webkit.org/show_bug.cgi?id=208893 (patch 393196), https://bugs.webkit.org/show_bug.cgi?id=208387. Reviewers anyways have the ability to land the patch manually, we shouldn't make it harder for them to use commit-queue. 1631141 1 393855 aakash_jain 2020-03-18 08:08:10 -0700 Created attachment 393855 Patch 1631216 2 aakash_jain 2020-03-18 10:02:30 -0700 Committed r258642: <https://trac.webkit.org/changeset/258642> 1631218 3 webkit-bug-importer 2020-03-18 10:03:13 -0700 <rdar://problem/60588465> 393855 2020-03-18 08:08:10 -0700 2020-03-18 09:46:11 -0700 Patch bug-209231-20200318110809.patch text/plain 1568 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODYzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAzLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBjb21taXQtcXVldWUgc2hvdWxkIGFsbG93IHBhdGNoZXMgd2hpY2ggYXJl IHJldmlld2VkIGJ5IHBhdGNoIGF1dGhvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6 CisgICAgICAgIChCdWd6aWxsYU1peGluLl9kb2VzX3BhdGNoX2hhdmVfYWNjZXB0YWJsZV9yZXZp ZXdfZmxhZyk6CisKIDIwMjAtMDMtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gTWlncmF0ZSB0byBGbGF0cGFrLWJhc2VkIGRl diBTREsKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJ KHJldmlzaW9uIDI1ODYzMSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNDUwLDkgKzQ1MCw2IEBAIGNsYXNzIEJ1Z3ppbGxh TWl4aW4ob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0 Y2hfcmV2aWV3ZXInLCBwYXRjaF9yZXZpZXdlcikKICAgICAgICAgICAgICAgICAgICAgaWYgc2Vs Zi5hZGRVUkxzOgogICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5hZGRVUkwoJ1Jldmlld2Vk IGJ5OiB7fScuZm9ybWF0KHBhdGNoX3Jldmlld2VyKSwgJycpCi0gICAgICAgICAgICAgICAgICAg IGlmIHBhdGNoX3Jldmlld2VyID09IHBhdGNoX2pzb24uZ2V0KCdjcmVhdG9yJyk6Ci0gICAgICAg ICAgICAgICAgICAgICAgICBzZWxmLl9hZGRUb0xvZygnc3RkaW8nLCAnUGF0Y2gge30gaXMgcisg YnkgdGhlIHBhdGNoIGF1dGhvciB7fSBpdHNlbGYuIFRoaXMgc2VlbXMgbGlrZSBhIG1pc3Rha2Uu XG4nLmZvcm1hdChwYXRjaF9pZCwgcGF0Y2hfcmV2aWV3ZXIpKQotICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIDAKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDEKICAgICAgICAgICAg ICAgICBpZiByZXZpZXdfc3RhdHVzIGluIFsnLScsICc/J106CiAgICAgICAgICAgICAgICAgICAg IHNlbGYuX2FkZFRvTG9nKCdzdGRpbycsICdQYXRjaCB7fSBpcyBtYXJrZWQgcnt9LlxuJy5mb3Jt YXQocGF0Y2hfaWQsIHJldmlld19zdGF0dXMpKQo=