209224 2020-03-18 06:12:20 -0700 CrossOriginPreflightResultCacheItem::allows methods should not use out parameters 2020-03-18 12:41:15 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson webkit-bug-importer oldest_to_newest 1631096 0 youennf 2020-03-18 06:12:20 -0700 CrossOriginPreflightResultCacheItem::allows methods should not use out parameters 1631103 1 393844 youennf 2020-03-18 06:48:29 -0700 Created attachment 393844 Patch 1631309 2 ews-feeder 2020-03-18 12:40:30 -0700 Committed r258660: <https://trac.webkit.org/changeset/258660> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393844. 1631310 3 webkit-bug-importer 2020-03-18 12:41:15 -0700 <rdar://problem/60597352> 393844 2020-03-18 06:48:29 -0700 2020-03-18 12:40:31 -0700 Patch bug-209224-20200318144828.patch text/plain 6438 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdlMGI1NmExZjExNDU2 MTU0Y2UyNjYyZThhYzAzYzc0OWZmYTExMC4uNzMzN2Y3NTk1Y2M4MjAzMmY0NWJiMzlhYTg3OWY2 ZWRjMTg5MGRlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAzLTE4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDcm9zc09yaWdpblByZWZs aWdodFJlc3VsdENhY2hlSXRlbTo6YWxsb3dzIG1ldGhvZHMgc2hvdWxkIG5vdCB1c2Ugb3V0IHBh cmFtZXRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwOTIyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluc3RlYWQgb2YgaGF2aW5nIGFuIG91dCBwYXJhbWV0ZXIgZm9yIHRoZSBlcnJvciBkZXNjcmlw dGlvbiwgZWl0aGVyIHJldHVybiB3aGV0aGVyIHRoZXJlIGlzIGFuIGVycm9yIG9yIG5vdC4KKyAg ICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGxvYWRlci9Dcm9z c09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNyb3Nz T3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGVJdGVtOjp2YWxpZGF0ZU1ldGhvZEFuZEhlYWRlcnMg Y29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6Q3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNo ZUl0ZW06OmFsbG93c0Nyb3NzT3JpZ2luTWV0aG9kIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6 OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGVJdGVtOjp2YWxpZGF0ZUNyb3NzT3JpZ2lu SGVhZGVycyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpDcm9zc09yaWdpblByZWZsaWdodFJl c3VsdENhY2hlSXRlbTo6YWxsb3dzUmVxdWVzdCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpD cm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlSXRlbTo6YWxsb3dzQ3Jvc3NPcmlnaW5IZWFk ZXJzIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBsb2FkZXIvQ3Jvc3NPcmlnaW5QcmVmbGln aHRSZXN1bHRDYWNoZS5oOgorCiAyMDIwLTAzLTE4ICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgYSBwcmVmbGlnaHQgZmFpbHMgaWYgcmVzcG9u c2UgaGVhZGVycyBhcmUgaW52YWxpZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0Nyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0Nyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUuY3BwCmluZGV4IDQ5NzBlYmQ5MmRm ZjM5YmMwYTQ1ZDRkODdjZGQ2NTBkOTc0N2IzZGUuLmE2NDA2ZGIyNjU4NTZkNzU0ODhjMmZjM2Nk OGViZDQwMGMxYmMxNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09y aWdpblByZWZsaWdodFJlc3VsdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv Q3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5jcHAKQEAgLTc0LDQ3ICs3NCw0MCBAQCBF eHBlY3RlZDxVbmlxdWVSZWY8Q3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZUl0ZW0+LCBT dHJpbmc+IENyb3NzT3JpZ2luUHJlZgogCiBPcHRpb25hbDxTdHJpbmc+IENyb3NzT3JpZ2luUHJl ZmxpZ2h0UmVzdWx0Q2FjaGVJdGVtOjp2YWxpZGF0ZU1ldGhvZEFuZEhlYWRlcnMoY29uc3QgU3Ry aW5nJiBtZXRob2QsIGNvbnN0IEhUVFBIZWFkZXJNYXAmIHJlcXVlc3RIZWFkZXJzKSBjb25zdAog ewotICAgIFN0cmluZyBlcnJvckRlc2NyaXB0aW9uOwotICAgIGlmICghYWxsb3dzQ3Jvc3NPcmln aW5NZXRob2QobWV0aG9kLCBtX3N0b3JlZENyZWRlbnRpYWxzUG9saWN5LCBlcnJvckRlc2NyaXB0 aW9uKSkKLSAgICAgICAgcmV0dXJuIFdURk1vdmUoZXJyb3JEZXNjcmlwdGlvbik7Ci0gICAgaWYg KCFhbGxvd3NDcm9zc09yaWdpbkhlYWRlcnMocmVxdWVzdEhlYWRlcnMsIG1fc3RvcmVkQ3JlZGVu dGlhbHNQb2xpY3ksIGVycm9yRGVzY3JpcHRpb24pKQotICAgICAgICByZXR1cm4gV1RGTW92ZShl cnJvckRlc2NyaXB0aW9uKTsKKyAgICBpZiAoIWFsbG93c0Nyb3NzT3JpZ2luTWV0aG9kKG1ldGhv ZCwgbV9zdG9yZWRDcmVkZW50aWFsc1BvbGljeSkpCisgICAgICAgIHJldHVybiBtYWtlU3RyaW5n KCJNZXRob2QgIiwgbWV0aG9kLCAiIGlzIG5vdCBhbGxvd2VkIGJ5IEFjY2Vzcy1Db250cm9sLUFs bG93LU1ldGhvZHMuIik7CisKKyAgICBpZiAoYXV0byBiYWRIZWFkZXIgPSB2YWxpZGF0ZUNyb3Nz T3JpZ2luSGVhZGVycyhyZXF1ZXN0SGVhZGVycywgbV9zdG9yZWRDcmVkZW50aWFsc1BvbGljeSkp CisgICAgICAgIHJldHVybiBtYWtlU3RyaW5nKCJSZXF1ZXN0IGhlYWRlciBmaWVsZCAiLCAqYmFk SGVhZGVyLCAiIGlzIG5vdCBhbGxvd2VkIGJ5IEFjY2Vzcy1Db250cm9sLUFsbG93LUhlYWRlcnMu Iik7CiAgICAgcmV0dXJuIHsgfTsKIH0KIAotYm9vbCBDcm9zc09yaWdpblByZWZsaWdodFJlc3Vs dENhY2hlSXRlbTo6YWxsb3dzQ3Jvc3NPcmlnaW5NZXRob2QoY29uc3QgU3RyaW5nJiBtZXRob2Qs IFN0b3JlZENyZWRlbnRpYWxzUG9saWN5IHN0b3JlZENyZWRlbnRpYWxzUG9saWN5LCBTdHJpbmcm IGVycm9yRGVzY3JpcHRpb24pIGNvbnN0Citib29sIENyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0 Q2FjaGVJdGVtOjphbGxvd3NDcm9zc09yaWdpbk1ldGhvZChjb25zdCBTdHJpbmcmIG1ldGhvZCwg U3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kgc3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kpIGNvbnN0CiB7 Ci0gICAgaWYgKG1fbWV0aG9kcy5jb250YWlucyhtZXRob2QpIHx8IChtX21ldGhvZHMuY29udGFp bnMoIioiKSAmJiBzdG9yZWRDcmVkZW50aWFsc1BvbGljeSAhPSBTdG9yZWRDcmVkZW50aWFsc1Bv bGljeTo6VXNlKSB8fCBpc09uQWNjZXNzQ29udHJvbFNpbXBsZVJlcXVlc3RNZXRob2RXaGl0ZWxp c3QobWV0aG9kKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICBlcnJvckRlc2NyaXB0aW9u ID0gIk1ldGhvZCAiICsgbWV0aG9kICsgIiBpcyBub3QgYWxsb3dlZCBieSBBY2Nlc3MtQ29udHJv bC1BbGxvdy1NZXRob2RzLiI7Ci0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBtX21ldGhv ZHMuY29udGFpbnMobWV0aG9kKSB8fCAobV9tZXRob2RzLmNvbnRhaW5zKCIqIikgJiYgc3RvcmVk Q3JlZGVudGlhbHNQb2xpY3kgIT0gU3RvcmVkQ3JlZGVudGlhbHNQb2xpY3k6OlVzZSkgfHwgaXNP bkFjY2Vzc0NvbnRyb2xTaW1wbGVSZXF1ZXN0TWV0aG9kV2hpdGVsaXN0KG1ldGhvZCk7CiB9CiAK LWJvb2wgQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZUl0ZW06OmFsbG93c0Nyb3NzT3Jp Z2luSGVhZGVycyhjb25zdCBIVFRQSGVhZGVyTWFwJiByZXF1ZXN0SGVhZGVycywgU3RvcmVkQ3Jl ZGVudGlhbHNQb2xpY3kgc3RvcmVkQ3JlZGVudGlhbHNQb2xpY3ksIFN0cmluZyYgZXJyb3JEZXNj cmlwdGlvbikgY29uc3QKK09wdGlvbmFsPFN0cmluZz4gQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1 bHRDYWNoZUl0ZW06OnZhbGlkYXRlQ3Jvc3NPcmlnaW5IZWFkZXJzKGNvbnN0IEhUVFBIZWFkZXJN YXAmIHJlcXVlc3RIZWFkZXJzLCBTdG9yZWRDcmVkZW50aWFsc1BvbGljeSBzdG9yZWRDcmVkZW50 aWFsc1BvbGljeSkgY29uc3QKIHsKICAgICBib29sIHZhbGlkV2lsZGNhcmQgPSBtX2hlYWRlcnMu Y29udGFpbnMoIioiKSAmJiBzdG9yZWRDcmVkZW50aWFsc1BvbGljeSAhPSBTdG9yZWRDcmVkZW50 aWFsc1BvbGljeTo6VXNlOwogICAgIGZvciAoY29uc3QgYXV0byYgaGVhZGVyIDogcmVxdWVzdEhl YWRlcnMpIHsKICAgICAgICAgaWYgKGhlYWRlci5rZXlBc0hUVFBIZWFkZXJOYW1lICYmIGlzQ3Jv c3NPcmlnaW5TYWZlUmVxdWVzdEhlYWRlcihoZWFkZXIua2V5QXNIVFRQSGVhZGVyTmFtZS52YWx1 ZSgpLCBoZWFkZXIudmFsdWUpKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlmICgh bV9oZWFkZXJzLmNvbnRhaW5zKGhlYWRlci5rZXkpICYmICF2YWxpZFdpbGRjYXJkKSB7Ci0gICAg ICAgICAgICBlcnJvckRlc2NyaXB0aW9uID0gIlJlcXVlc3QgaGVhZGVyIGZpZWxkICIgKyBoZWFk ZXIua2V5ICsgIiBpcyBub3QgYWxsb3dlZCBieSBBY2Nlc3MtQ29udHJvbC1BbGxvdy1IZWFkZXJz LiI7Ci0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIH0KKyAgICAgICAgaWYgKCFt X2hlYWRlcnMuY29udGFpbnMoaGVhZGVyLmtleSkgJiYgIXZhbGlkV2lsZGNhcmQpCisgICAgICAg ICAgICByZXR1cm4gaGVhZGVyLmtleTsKICAgICB9Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0 dXJuIHsgfTsKIH0KIAogYm9vbCBDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlSXRlbTo6 YWxsb3dzUmVxdWVzdChTdG9yZWRDcmVkZW50aWFsc1BvbGljeSBzdG9yZWRDcmVkZW50aWFsc1Bv bGljeSwgY29uc3QgU3RyaW5nJiBtZXRob2QsIGNvbnN0IEhUVFBIZWFkZXJNYXAmIHJlcXVlc3RI ZWFkZXJzKSBjb25zdAogewotICAgIFN0cmluZyBpZ25vcmVkRXhwbGFuYXRpb247CiAgICAgaWYg KG1fYWJzb2x1dGVFeHBpcnlUaW1lIDwgTW9ub3RvbmljVGltZTo6bm93KCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICBpZiAoc3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kgPT0gU3RvcmVkQ3Jl ZGVudGlhbHNQb2xpY3k6OlVzZSAmJiBtX3N0b3JlZENyZWRlbnRpYWxzUG9saWN5ID09IFN0b3Jl ZENyZWRlbnRpYWxzUG9saWN5OjpEb05vdFVzZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAg IGlmICghYWxsb3dzQ3Jvc3NPcmlnaW5NZXRob2QobWV0aG9kLCBzdG9yZWRDcmVkZW50aWFsc1Bv bGljeSwgaWdub3JlZEV4cGxhbmF0aW9uKSkKKyAgICBpZiAoIWFsbG93c0Nyb3NzT3JpZ2luTWV0 aG9kKG1ldGhvZCwgc3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kpKQogICAgICAgICByZXR1cm4gZmFs c2U7Ci0gICAgaWYgKCFhbGxvd3NDcm9zc09yaWdpbkhlYWRlcnMocmVxdWVzdEhlYWRlcnMsIHN0 b3JlZENyZWRlbnRpYWxzUG9saWN5LCBpZ25vcmVkRXhwbGFuYXRpb24pKQorICAgIGlmIChhdXRv IGJhZEhlYWRlciA9IHZhbGlkYXRlQ3Jvc3NPcmlnaW5IZWFkZXJzKHJlcXVlc3RIZWFkZXJzLCBz dG9yZWRDcmVkZW50aWFsc1BvbGljeSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICByZXR1 cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09yaWdp blByZWZsaWdodFJlc3VsdENhY2hlLmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmln aW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5oCmluZGV4IDBmODY0ODViOGQ5Nzk1NzU1ZjQ5Nzc4NmY5 MTMwZjAyOTRjNTk2MWMuLjU2NGNlN2FhMzAxMWRiMDY5NWYyNmJjZTE1N2IxYjg3OTI1ZjRjYzQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09yaWdpblByZWZsaWdodFJl c3VsdENhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2luUHJlZmxp Z2h0UmVzdWx0Q2FjaGUuaApAQCAtNTAsOCArNTAsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCBhbGxv d3NSZXF1ZXN0KFN0b3JlZENyZWRlbnRpYWxzUG9saWN5LCBjb25zdCBTdHJpbmcmIG1ldGhvZCwg Y29uc3QgSFRUUEhlYWRlck1hcCYpIGNvbnN0OwogCiBwcml2YXRlOgotICAgIGJvb2wgYWxsb3dz Q3Jvc3NPcmlnaW5NZXRob2QoY29uc3QgU3RyaW5nJiwgU3RvcmVkQ3JlZGVudGlhbHNQb2xpY3ks IFN0cmluZyYgZXJyb3JEZXNjcmlwdGlvbikgY29uc3Q7Ci0gICAgYm9vbCBhbGxvd3NDcm9zc09y aWdpbkhlYWRlcnMoY29uc3QgSFRUUEhlYWRlck1hcCYsIFN0b3JlZENyZWRlbnRpYWxzUG9saWN5 LCBTdHJpbmcmIGVycm9yRGVzY3JpcHRpb24pIGNvbnN0OworICAgIGJvb2wgYWxsb3dzQ3Jvc3NP cmlnaW5NZXRob2QoY29uc3QgU3RyaW5nJiwgU3RvcmVkQ3JlZGVudGlhbHNQb2xpY3kpIGNvbnN0 OworICAgIE9wdGlvbmFsPFN0cmluZz4gdmFsaWRhdGVDcm9zc09yaWdpbkhlYWRlcnMoY29uc3Qg SFRUUEhlYWRlck1hcCYsIFN0b3JlZENyZWRlbnRpYWxzUG9saWN5KSBjb25zdDsKIAogICAgIC8v IEZJWE1FOiBBIGJldHRlciBzb2x1dGlvbiB0byBob2xkaW5nIG9udG8gdGhlIGFic29sdXRlIGV4 cGlyYXRpb24gdGltZSBtaWdodCBiZQogICAgIC8vIHRvIHN0YXJ0IGEgdGltZXIgZm9yIHRoZSBl eHBpcmF0aW9uIGRlbHRhIHRoYXQgcmVtb3ZlcyB0aGlzIGZyb20gdGhlIGNhY2hlIHdoZW4K