209210 2020-03-17 19:27:15 -0700 Default attachment icon is not necessarily the same as the file attachment icon whose extension is ".dat" 2020-03-18 09:07:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176769 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1630992 0 sabouhallawa 2020-03-17 19:27:15 -0700 The goal is to make fast/attachment/attachment-default-icon.html more reliable. The test page has a default attachment while the expected page has a file attachment. The extension of this file is ".dat". The icon for this file attachment is not necessarily the same as the icon for the default attachment. 1630994 1 393813 sabouhallawa 2020-03-17 19:31:41 -0700 Created attachment 393813 Patch 1630995 2 sabouhallawa 2020-03-17 19:32:47 -0700 <rdar://problem/59606671> 1631009 3 393813 dbates 2020-03-17 19:52:56 -0700 Comment on attachment 393813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review This patch looks good. > LayoutTests/ChangeLog:9 > + returns for “public.data” icon. Ok as-is. No change needed. There are some fancy quotes here. 1631017 4 393813 dbates 2020-03-17 20:11:28 -0700 Comment on attachment 393813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review > LayoutTests/fast/attachment/attachment-default-icon-expected.html:4 > +<attachment id="attachment" title=" " type="public.data"></attachment> After looking at other attachment tests, I think I understand what this test was going for....it's trying to test the code path for the file attribute matches the code path for the missing type attribute (which yields the default icon). The implicit assumption this test makes is that a .dat file yields the default icon. For this test (and only this test as I haven't studied the others enough,yet) this patch seems reasonable because: 1. There are other tests that actually check that the file attribute affects the icon 2. Because of (1) this test just needs to focus on testing that the icon is for the missing type attribute is equivalent to the icon for a .dat file. 1631021 5 393813 dbates 2020-03-17 20:14:05 -0700 Comment on attachment 393813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review > LayoutTests/ChangeLog:5 > + Ok as-is. No change needed. The optimal ChangeLog includes the radar URL here because: 1. Convenient for Apple engineers 1631132 6 393854 sabouhallawa 2020-03-18 07:53:37 -0700 Created attachment 393854 Patch 1631184 7 commit-queue 2020-03-18 09:06:56 -0700 The commit-queue encountered the following flaky tests while processing attachment 393854: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849 The commit-queue is continuing to process your patch. 1631185 8 393854 commit-queue 2020-03-18 09:07:30 -0700 Comment on attachment 393854 Patch Clearing flags on attachment: 393854 Committed r258640: <https://trac.webkit.org/changeset/258640> 1631186 9 commit-queue 2020-03-18 09:07:32 -0700 All reviewed patches have been landed. Closing bug. 393813 2020-03-17 19:31:41 -0700 2020-03-18 07:53:36 -0700 Patch bug-209210-20200317193140.patch text/plain 1700 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTY2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTQzMDM2ZGY4MWE5MzExZGRiNzQ5 ZjZlYjJjMmYwMmNhMDIwN2ZjZS4uNjQxMTZjOGI0NzljMGQ1ZDAxNzYxOTM5ZjA3NTMyNTYwMzM0 NjYzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE3ICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmYXVsdCBhdHRhY2htZW50 IGljb24gaXMgbm90IG5lY2Vzc2FyaWx5IHRoZSBzYW1lIGFzIHRoZSBmaWxlIGF0dGFjaG1lbnQg aWNvbiB3aG9zZSBleHRlbnNpb24gaXMgIi5kYXQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkyMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgdGhhdCB0aGUgZGVmYXVsdCBhdHRhY2htZW50 IGljb24gaXMgdGhlIG9uZSB3aGljaCBpY29uRm9yRmlsZVR5cGUKKyAgICAgICAgcmV0dXJucyBm b3Ig4oCccHVibGljLmRhdGHigJ0gaWNvbi4KKworICAgICAgICAqIGZhc3QvYXR0YWNobWVudC9h dHRhY2htZW50LWRlZmF1bHQtaWNvbi1leHBlY3RlZC5odG1sOgorCiAyMDIwLTAzLTE3ICBKYXNv biBMYXdyZW5jZSAgPGxhd3JlbmNlLmpAYXBwbGUuY29tPgogCiAgICAgICAgIFsgbWFjT1Mgd2sx IF0gcGxhdGZvcm0vbWFjL3dlYnJ0Yy9jYXB0dXJlQ2FudmFzLXdlYnJ0Yy1zb2Z0d2FyZS1lbmNv ZGVyLmh0bWwgaXMgZmxha3kgZmFpbGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9h dHRhY2htZW50L2F0dGFjaG1lbnQtZGVmYXVsdC1pY29uLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1kZWZhdWx0LWljb24tZXhwZWN0ZWQuaHRt bAppbmRleCA5M2ViNDc3OWVkYzY0MDA2OGZmNGMzMzZhNzE0NDc0ZTdlNmMxOTk0Li5mZDBhMjAy YzFkMzY4ZDgxNTcxOTU3NGU3ZTAzZjk1ODRmYzMwZTMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1kZWZhdWx0LWljb24tZXhwZWN0ZWQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1kZWZhdWx0LWljb24t ZXhwZWN0ZWQuaHRtbApAQCAtMSwxMyArMSw2IEBACiA8IURPQ1RZUEUgaHRtbD48IS0tIHdlYmtp dC10ZXN0LXJ1bm5lciBbIGVuYWJsZUF0dGFjaG1lbnRFbGVtZW50PXRydWUgXSAtLT4KIDxodG1s PgogPGJvZHk+Ci08YXR0YWNobWVudCBpZD0iYXR0YWNobWVudCIgdGl0bGU9IiAgIj48L2F0dGFj aG1lbnQ+Ci08c2NyaXB0PgotdmFyIGZpbGU7Ci1pZiAod2luZG93LmludGVybmFscykKLSAgICBm aWxlID0gd2luZG93LmludGVybmFscy5jcmVhdGVGaWxlKCJyZXNvdXJjZXMvdGVzdC1maWxlLmRh dCIpOwotCi1kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYXR0YWNobWVudCIpLmZpbGUgPSBmaWxl OwotPC9zY3JpcHQ+Cis8YXR0YWNobWVudCBpZD0iYXR0YWNobWVudCIgdGl0bGU9IiAgIiB0eXBl PSJwdWJsaWMuZGF0YSI+PC9hdHRhY2htZW50PgogPC9ib2R5PgogPC9odG1sPgo= 393854 2020-03-18 07:53:37 -0700 2020-03-18 09:07:30 -0700 Patch bug-209210-20200318075336.patch text/plain 1729 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTY2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTQzMDM2ZGY4MWE5MzExZGRiNzQ5 ZjZlYjJjMmYwMmNhMDIwN2ZjZS4uY2VhMTYyOWY4NjI1NWJmODg0MGFkYmExOWRjNWQ1YTNiMDc5 OGU2ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTE3ICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmYXVsdCBhdHRhY2htZW50 IGljb24gaXMgbm90IG5lY2Vzc2FyaWx5IHRoZSBzYW1lIGFzIHRoZSBmaWxlIGF0dGFjaG1lbnQg aWNvbiB3aG9zZSBleHRlbnNpb24gaXMgIi5kYXQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkyMTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5 NjA2NjcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4KKworICAgICAgICBF bnN1cmUgdGhhdCB0aGUgZGVmYXVsdCBhdHRhY2htZW50IGljb24gaXMgdGhlIG9uZSB3aGljaCBp Y29uRm9yRmlsZVR5cGUKKyAgICAgICAgcmV0dXJucyBmb3IgInB1YmxpYy5kYXRhIiBpY29uLgor CisgICAgICAgICogZmFzdC9hdHRhY2htZW50L2F0dGFjaG1lbnQtZGVmYXVsdC1pY29uLWV4cGVj dGVkLmh0bWw6CisKIDIwMjAtMDMtMTcgIEphc29uIExhd3JlbmNlICA8bGF3cmVuY2UuakBhcHBs ZS5jb20+CiAKICAgICAgICAgWyBtYWNPUyB3azEgXSBwbGF0Zm9ybS9tYWMvd2VicnRjL2NhcHR1 cmVDYW52YXMtd2VicnRjLXNvZnR3YXJlLWVuY29kZXIuaHRtbCBpcyBmbGFreSBmYWlsaW5nCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1kZWZhdWx0 LWljb24tZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYXR0YWNobWVudC9hdHRhY2ht ZW50LWRlZmF1bHQtaWNvbi1leHBlY3RlZC5odG1sCmluZGV4IDkzZWI0Nzc5ZWRjNjQwMDY4ZmY0 YzMzNmE3MTQ0NzRlN2U2YzE5OTQuLmZkMGEyMDJjMWQzNjhkODE1NzE5NTc0ZTdlMDNmOTU4NGZj MzBlMzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvYXR0YWNobWVudC9hdHRhY2htZW50 LWRlZmF1bHQtaWNvbi1leHBlY3RlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYXR0YWNo bWVudC9hdHRhY2htZW50LWRlZmF1bHQtaWNvbi1leHBlY3RlZC5odG1sCkBAIC0xLDEzICsxLDYg QEAKIDwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZW5hYmxlQXR0YWNo bWVudEVsZW1lbnQ9dHJ1ZSBdIC0tPgogPGh0bWw+CiA8Ym9keT4KLTxhdHRhY2htZW50IGlkPSJh dHRhY2htZW50IiB0aXRsZT0iICAiPjwvYXR0YWNobWVudD4KLTxzY3JpcHQ+Ci12YXIgZmlsZTsK LWlmICh3aW5kb3cuaW50ZXJuYWxzKQotICAgIGZpbGUgPSB3aW5kb3cuaW50ZXJuYWxzLmNyZWF0 ZUZpbGUoInJlc291cmNlcy90ZXN0LWZpbGUuZGF0Iik7Ci0KLWRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJhdHRhY2htZW50IikuZmlsZSA9IGZpbGU7Ci08L3NjcmlwdD4KKzxhdHRhY2htZW50IGlk PSJhdHRhY2htZW50IiB0aXRsZT0iICAiIHR5cGU9InB1YmxpYy5kYXRhIj48L2F0dGFjaG1lbnQ+ CiA8L2JvZHk+CiA8L2h0bWw+Cg==