209209 2020-03-17 19:01:37 -0700 [CMake] libopus 1.1 its enough for building WebKitGTK with ENABLE_WEB_RTC 2020-03-17 21:46:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208948 P2 Normal --- 1 clopez clopez annulen bugs-noreply commit-queue eric.carlson ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1630986 0 clopez 2020-03-17 19:01:37 -0700 Building WebKitGTK with -DENABLE_WEB_RTC=ON on Ubuntu 18.04 its not longer possible since r258412 This failure happens: [...] -- Using platform-specific CMakeLists: /opt/webkitgtk/nightly/build/Source/JavaScriptCore/shell/PlatformGTK.cmake -- Using source list file: Sources.txt -- Using source list file: SourcesGTK.txt -- Using platform-specific CMakeLists: /opt/webkitgtk/nightly/build/Source/ThirdParty/ANGLE/PlatformGTK.cmake -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format - Success -- Platform-specific CMakeLists not found: /opt/webkitgtk/nightly/build/Source/ThirdParty/gtest/PlatformGTK.cmake -- Could NOT find LibOpus: Found unsuitable version "1.1.2", but required is at least "1.3" (found /usr/lib/x86_64-linux-gnu/libopus.so) CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:21 (message): libopus is needed for USE_LIBWEBRTC. libopus 1.1.2 (what ubuntu 18.04 ships) its enough for -DENABLE_WEB_RTC and it was working before r237174 because the check was not working as expected. 1630989 1 393811 clopez 2020-03-17 19:19:48 -0700 Created attachment 393811 Patch 1630990 2 393812 clopez 2020-03-17 19:23:49 -0700 Created attachment 393812 Patch 1631010 3 annulen 2020-03-17 19:54:46 -0700 Did you actually test it? 1631024 4 clopez 2020-03-17 20:25:08 -0700 (In reply to Konstantin Tokarev from comment #3) > Did you actually test it? I tested that it builds and that WebRTC WPT related tests pass. Check: https://wpt.fyi/results/webrtc?label=master&label=experimental&product=chrome&product=firefox&product=safari&product=webkitgtk&aligned The version of WebKitGTK that its tested on the WPT CI its built for Ubuntu 18.04 in this bot https://build-webkit.igalia.com/builders/GTK%20Linux%2064-bit%20WPT%20Packaging%20%28nightly%20channel%29 And it started to fail building after r258412 Once that bot finish building correctly it uploads the built product to https://webkitgtk.org/built-products/ for later consuming on the WPT CI (taskcluster) that runs currently on Ubuntu 18.04 and runs all the WPT tests. Beyond that, I did not tested it further. If you know a specific test to try, let me know. 1631025 5 393812 annulen 2020-03-17 20:28:11 -0700 Comment on attachment 393812 Patch I've actually meant something like running WebRTC on some real site, but I guess passing WPT should be enough. 1631043 6 393812 commit-queue 2020-03-17 21:46:01 -0700 Comment on attachment 393812 Patch Clearing flags on attachment: 393812 Committed r258624: <https://trac.webkit.org/changeset/258624> 1631044 7 commit-queue 2020-03-17 21:46:03 -0700 All reviewed patches have been landed. Closing bug. 393811 2020-03-17 19:19:48 -0700 2020-03-17 19:21:08 -0700 Patch bug-209209-20200318031946.patch text/plain 1401 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBiMmNiNTVjYjgwZWRlZjM1NmMyNWZiNDE3M2M4MzM3ODg4NjRjNWZiLi45NWI1 YWMwMDZmMDEyNzQyMGY1ZGQ5ZTVkNWEzZWVmNzAxYTUxNTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMy0xNyAgQ2FybG9zIEFs YmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2Vd IGxpYm9wdXMgMS4xIGl0cyBlbm91Z2ggZm9yIGJ1aWxkaW5nIFdlYktpdEdUSyB3aXRoIEVOQUJM RV9XRUJfUlRDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDkyMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVYnVudHUgMTguMDQgc2hpcHMgbGlib3B1cyAxLjEuMiB3aGljaCBpdHMgZW5vdWdoIGZvciBi dWlsZGluZyB3aXRoIC1ERU5BQkxFX1dFQl9SVEM9T04KKworICAgICAgICAqIENNYWtlTGlzdHMu dHh0OgorCiAyMDIwLTAzLTEzICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5y dT4KIAogICAgICAgICBbQ01ha2VdIEVsZW1pbmF0ZSBtaXNtYXRjaGVzIGJldHdlZW4gRmluZCog bW9kdWxlIG5hbWVzIGFuZCB2YXJpYWJsZXMgdGhleSBzZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9U aGlyZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DTWFrZUxpc3RzLnR4dAppbmRleCA0NjVhZDUxMGEyYmNhZmYyM2ZhNWNhNTc1MmRl MjhlMzAyMDNiNTA1Li5iOWI2YjVhYzZhMzllOTJlZjdkMzE2NTRkMDI0ODIzZGE0YzBjMGIzIDEw MDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ01ha2VMaXN0cy50eHQKKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NNYWtlTGlzdHMudHh0CkBAIC0xNiw3ICsx Niw3IEBAIGlmIChOT1QgQUxTQUxJQl9GT1VORCkKICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJh bHNhLWxpYiBpcyBuZWVkZWQgZm9yIFVTRV9MSUJXRUJSVEMuIikKIGVuZGlmICgpCiAKLWZpbmRf cGFja2FnZShMaWJPcHVzIDEuMykKK2ZpbmRfcGFja2FnZShMaWJPcHVzIDEuMSkKIGlmIChOT1Qg TElCT1BVU19GT1VORCkKICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJvcHVzIGlzIG5lZWRl ZCBmb3IgVVNFX0xJQldFQlJUQy4iKQogZW5kaWYgKCkK 393812 2020-03-17 19:23:49 -0700 2020-03-17 21:46:01 -0700 Patch bug-209209-20200318032348.patch text/plain 1401 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBiMmNiNTVjYjgwZWRlZjM1NmMyNWZiNDE3M2M4MzM3ODg4NjRjNWZiLi45NWI1 YWMwMDZmMDEyNzQyMGY1ZGQ5ZTVkNWEzZWVmNzAxYTUxNTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMy0xNyAgQ2FybG9zIEFs YmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2Vd IGxpYm9wdXMgMS4xIGl0cyBlbm91Z2ggZm9yIGJ1aWxkaW5nIFdlYktpdEdUSyB3aXRoIEVOQUJM RV9XRUJfUlRDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDkyMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVYnVudHUgMTguMDQgc2hpcHMgbGlib3B1cyAxLjEuMiB3aGljaCBpdHMgZW5vdWdoIGZvciBi dWlsZGluZyB3aXRoIC1ERU5BQkxFX1dFQl9SVEM9T04KKworICAgICAgICAqIENNYWtlTGlzdHMu dHh0OgorCiAyMDIwLTAzLTEzICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5y dT4KIAogICAgICAgICBbQ01ha2VdIEVsZW1pbmF0ZSBtaXNtYXRjaGVzIGJldHdlZW4gRmluZCog bW9kdWxlIG5hbWVzIGFuZCB2YXJpYWJsZXMgdGhleSBzZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9U aGlyZFBhcnR5L2xpYndlYnJ0Yy9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DTWFrZUxpc3RzLnR4dAppbmRleCA0NjVhZDUxMGEyYmNhZmYyM2ZhNWNhNTc1MmRl MjhlMzAyMDNiNTA1Li5iOWI2YjVhYzZhMzllOTJlZjdkMzE2NTRkMDI0ODIzZGE0YzBjMGIzIDEw MDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ01ha2VMaXN0cy50eHQKKysr IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NNYWtlTGlzdHMudHh0CkBAIC0xNiw3ICsx Niw3IEBAIGlmIChOT1QgQUxTQUxJQl9GT1VORCkKICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJh bHNhLWxpYiBpcyBuZWVkZWQgZm9yIFVTRV9MSUJXRUJSVEMuIikKIGVuZGlmICgpCiAKLWZpbmRf cGFja2FnZShMaWJPcHVzIDEuMykKK2ZpbmRfcGFja2FnZShMaWJPcHVzIDEuMSkKIGlmIChOT1Qg TElCT1BVU19GT1VORCkKICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJvcHVzIGlzIG5lZWRl ZCBmb3IgVVNFX0xJQldFQlJUQy4iKQogZW5kaWYgKCkK