209200 2020-03-17 15:20:08 -0700 Web Inspector: the width of `WI.TabBarItem` can change if the detached window is resized 2020-03-17 21:31:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204627 InRadar P2 Normal --- 208603 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1630921 0 hi 2020-03-17 15:20:08 -0700 From my comment <https://webkit.org/b/204627#c56>: > We shouldn't need to worry about the value stored in `[WI.TabBar.CachedWidthSymbol]` changing anymore (meaning we don't need to reset it), as we no longer hide icons, meaning that the width of every `WI.TabBarItem` should be constant. This isn't completely accurate, as we don't shrink `WI.TabBarItem` to their minimum width when detached. 1630932 1 393797 hi 2020-03-17 15:39:58 -0700 Created attachment 393797 Patch 1631036 2 393797 commit-queue 2020-03-17 21:30:27 -0700 Comment on attachment 393797 Patch Clearing flags on attachment: 393797 Committed r258623: <https://trac.webkit.org/changeset/258623> 1631037 3 commit-queue 2020-03-17 21:30:28 -0700 All reviewed patches have been landed. Closing bug. 1631038 4 webkit-bug-importer 2020-03-17 21:31:15 -0700 <rdar://problem/60569940> 393797 2020-03-17 15:39:58 -0700 2020-03-17 21:30:27 -0700 Patch 209200.diff text/plain 4643 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIzZGI3OGIwMmNjLi45YzUyMzY5YmQ5MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMTcgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRo ZSB3aWR0aCBvZiBgV0kuVGFiQmFySXRlbWAgY2FuIGNoYW5nZSBpZiB0aGUgZGV0YWNoZWQgd2lu ZG93IGlzIHJlc2l6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwOTIwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanM6CisgICAgICAgIChXSS5UYWJC YXIucHJvdG90eXBlLmxheW91dCk6CisgICAgICAgIChXSS5UYWJCYXIucHJvdG90eXBlLmxheW91 dC5tZWFzdXJlV2lkdGgpOiBSZW5hbWVkIGZyb20gYG1lYXN1cmVJdGVtV2lkdGhgLgorICAgICAg ICBXaGVuIHVuZG9ja2VkLCBgV0kuVGFiQmFySXRlbWAgZ3JvdyB0byBmaWxsIGFueSBhdmFpbGFi bGUgc3BhY2UuIEFzIGEgcmVzdWx0LCBpZiBhCisgICAgICAgIGBXSS5UYWJCYXJJdGVtYCBpcyBh ZGRlZCBvciByZW1vdmVkLCB0aGUgd2lkdGggb2YgYWxsIGBXSS5UYWJCYXJJdGVtYCB3aWxsIGNo YW5nZS4KKyAgICAgICAgV2FpdCB0byBtZWFzdXJlIHdpZHRocyB1bnRpbCBhbGwgYFdJLlRhYkJh ckl0ZW1gIGFyZSB1bi1oaWRkZW4gZm9yIHRoZSByZWFzb24gYWJvdmUuCisKIDIwMjAtMDMtMTcg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04o cjI1Nzc1OSk6IFdlYiBJbnNwZWN0b3I6IFNldHRpbmdzIGljb24gc29tZXRpbWVzIHBsYWNlZCBi ZWxvdyB0aGUgdGFiIGJhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGFiQmFyLmpzCmluZGV4IGU5Y2NhNzFmZmJlLi40MGUyZjU0MjE0NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJh ci5qcwpAQCAtNDM1LDIwICs0MzUsMjIgQEAgV0kuVGFiQmFyID0gY2xhc3MgVGFiQmFyIGV4dGVu ZHMgV0kuVmlldwogICAgICAgICBjb25zdCB0YWJCYXJIb3Jpem9udGFsUGFkZGluZyA9IFdJLlRh YkJhci5ob3Jpem9udGFsUGFkZGluZzsKICAgICAgICAgY29uc3QgdGFiQmFySXRlbUhvcml6b250 YWxNYXJnaW4gPSBXSS5UYWJCYXJJdGVtLmhvcml6b250YWxNYXJnaW47CiAKLSAgICAgICAgZnVu Y3Rpb24gbWVhc3VyZUl0ZW1XaWR0aChpdGVtKSB7Ci0gICAgICAgICAgICBpZiAoIWl0ZW1bV0ku VGFiQmFyLkNhY2hlZFdpZHRoU3ltYm9sXSkKLSAgICAgICAgICAgICAgICBpdGVtW1dJLlRhYkJh ci5DYWNoZWRXaWR0aFN5bWJvbF0gPSBpdGVtLmVsZW1lbnQucmVhbE9mZnNldFdpZHRoICsgdGFi QmFySXRlbUhvcml6b250YWxNYXJnaW47Ci0gICAgICAgICAgICByZXR1cm4gaXRlbVtXSS5UYWJC YXIuQ2FjaGVkV2lkdGhTeW1ib2xdOworICAgICAgICBsZXQgdW5kb2NrZWQgPSBXSS5kb2NrQ29u ZmlndXJhdGlvbiA9PT0gV0kuRG9ja0NvbmZpZ3VyYXRpb24uVW5kb2NrZWQ7CisKKyAgICAgICAg ZnVuY3Rpb24gbWVhc3VyZVdpZHRoKHRhYkJhckl0ZW0pIHsKKyAgICAgICAgICAgIGlmICghdGFi QmFySXRlbVtXSS5UYWJCYXIuQ2FjaGVkV2lkdGhTeW1ib2xdKQorICAgICAgICAgICAgICAgIHRh YkJhckl0ZW1bV0kuVGFiQmFyLkNhY2hlZFdpZHRoU3ltYm9sXSA9IHRhYkJhckl0ZW0uZWxlbWVu dC5yZWFsT2Zmc2V0V2lkdGggKyB0YWJCYXJJdGVtSG9yaXpvbnRhbE1hcmdpbjsKKyAgICAgICAg ICAgIHJldHVybiB0YWJCYXJJdGVtW1dJLlRhYkJhci5DYWNoZWRXaWR0aFN5bWJvbF07CiAgICAg ICAgIH0KIAotICAgICAgICBsZXQgYXZhaWxhYmxlU3BhY2UgPSB0aGlzLl90YWJDb250YWluZXIu cmVhbE9mZnNldFdpZHRoIC0gdGFiQmFySG9yaXpvbnRhbFBhZGRpbmc7CisgICAgICAgIC8vIEFk ZCBvbmUgdG8gYWxsb3cgZm9yIHBvc3NpYmxlIHN1Yi1weCB3aWR0aHMuCisgICAgICAgIGxldCBh dmFpbGFibGVTcGFjZSA9IHRoaXMuX3RhYkNvbnRhaW5lci5yZWFsT2Zmc2V0V2lkdGggLSB0YWJC YXJIb3Jpem9udGFsUGFkZGluZyArIDE7CiAKICAgICAgICAgdGhpcy5fdGFiQ29udGFpbmVyLmNs YXNzTGlzdC5hZGQoImNhbGN1bGF0ZS13aWR0aCIpOwogCiAgICAgICAgIHRoaXMuX2hpZGRlblRh YkJhckl0ZW1zID0gW107CiAKICAgICAgICAgbGV0IG5vcm1hbFRhYkJhckl0ZW1zID0gW107Ci0g ICAgICAgIGxldCBub3JtYWxUYWJCYXJJdGVtc1dpZHRoID0gMDsKICAgICAgICAgZm9yIChsZXQg dGFiQmFySXRlbSBvZiB0aGlzLl90YWJCYXJJdGVtc0Zyb21MZWZ0VG9SaWdodCgpKSB7CiAgICAg ICAgICAgICBpZiAodGFiQmFySXRlbSA9PT0gdGhpcy5fdGFiUGlja2VyVGFiQmFySXRlbSkgewog ICAgICAgICAgICAgICAgIHRhYkJhckl0ZW0uaGlkZGVuID0gdHJ1ZTsKQEAgLTQ1NywxNyArNDU5 LDI0IEBAIFdJLlRhYkJhciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdJLlZpZXcKIAogICAgICAg ICAgICAgdGFiQmFySXRlbS5oaWRkZW4gPSBmYWxzZTsKIAotICAgICAgICAgICAgaWYgKHRhYkJh ckl0ZW0gaW5zdGFuY2VvZiBXSS5QaW5uZWRUYWJCYXJJdGVtKQotICAgICAgICAgICAgICAgIGF2 YWlsYWJsZVNwYWNlIC09IG1lYXN1cmVJdGVtV2lkdGgodGFiQmFySXRlbSk7Ci0gICAgICAgICAg ICBlbHNlIHsKLSAgICAgICAgICAgICAgICBub3JtYWxUYWJCYXJJdGVtcy5wdXNoKHRhYkJhckl0 ZW0pOwotICAgICAgICAgICAgICAgIG5vcm1hbFRhYkJhckl0ZW1zV2lkdGggKz0gbWVhc3VyZUl0 ZW1XaWR0aCh0YWJCYXJJdGVtKTsKKyAgICAgICAgICAgIGlmICh0YWJCYXJJdGVtIGluc3RhbmNl b2YgV0kuUGlubmVkVGFiQmFySXRlbSkgeworICAgICAgICAgICAgICAgIGF2YWlsYWJsZVNwYWNl IC09IG1lYXN1cmVXaWR0aCh0YWJCYXJJdGVtKTsKKyAgICAgICAgICAgICAgICBjb250aW51ZTsK ICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgbm9ybWFsVGFiQmFySXRlbXMucHVzaCh0YWJC YXJJdGVtKTsKKworICAgICAgICAgICAgLy8gV2hlbiB1bmRvY2tlZCwgYFdJLlRhYkJhckl0ZW1g IGdyb3cgdG8gZmlsbCBhbnkgYXZhaWxhYmxlIHNwYWNlLiBBcyBhIHJlc3VsdCwgaWYgYQorICAg ICAgICAgICAgLy8gYFdJLlRhYkJhckl0ZW1gIGlzIGFkZGVkIG9yIHJlbW92ZWQsIHRoZSB3aWR0 aCBvZiBhbGwgYFdJLlRhYkJhckl0ZW1gIHdpbGwgY2hhbmdlLgorICAgICAgICAgICAgaWYgKHVu ZG9ja2VkKQorICAgICAgICAgICAgICAgIHRhYkJhckl0ZW1bV0kuVGFiQmFyLkNhY2hlZFdpZHRo U3ltYm9sXSA9IDA7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBXYWl0IHRvIG1lYXN1cmUgd2lk dGhzIHVudGlsIGFsbCBgV0kuVGFiQmFySXRlbWAgYXJlIHVuLWhpZGRlbiBmb3IgdGhlIHJlYXNv biBhYm92ZS4KKyAgICAgICAgbGV0IG5vcm1hbFRhYkJhckl0ZW1zV2lkdGggPSBub3JtYWxUYWJC YXJJdGVtcy5yZWR1Y2UoKGFjY3VtdWxhdG9yLCB0YWJCYXJJdGVtKSA9PiBhY2N1bXVsYXRvciAr IG1lYXN1cmVXaWR0aCh0YWJCYXJJdGVtKSwgMCk7CiAgICAgICAgIGlmIChub3JtYWxUYWJCYXJJ dGVtc1dpZHRoID4gYXZhaWxhYmxlU3BhY2UpIHsKICAgICAgICAgICAgIHRoaXMuX3RhYlBpY2tl clRhYkJhckl0ZW0uaGlkZGVuID0gZmFsc2U7Ci0gICAgICAgICAgICBhdmFpbGFibGVTcGFjZSAt PSBtZWFzdXJlSXRlbVdpZHRoKHRoaXMuX3RhYlBpY2tlclRhYkJhckl0ZW0pOworICAgICAgICAg ICAgYXZhaWxhYmxlU3BhY2UgLT0gbWVhc3VyZVdpZHRoKHRoaXMuX3RhYlBpY2tlclRhYkJhckl0 ZW0pOwogCiAgICAgICAgICAgICBsZXQgaW5kZXggPSBub3JtYWxUYWJCYXJJdGVtcy5sZW5ndGgg LSAxOwogICAgICAgICAgICAgZG8gewpAQCAtNDc1LDcgKzQ4NCw3IEBAIFdJLlRhYkJhciA9IGNs YXNzIFRhYkJhciBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgICAgICAgICBpZiAodGFiQmFySXRl bSA9PT0gdGhpcy5fc2VsZWN0ZWRUYWJCYXJJdGVtKQogICAgICAgICAgICAgICAgICAgICBjb250 aW51ZTsKIAotICAgICAgICAgICAgICAgIG5vcm1hbFRhYkJhckl0ZW1zV2lkdGggLT0gbWVhc3Vy ZUl0ZW1XaWR0aCh0YWJCYXJJdGVtKTsKKyAgICAgICAgICAgICAgICBub3JtYWxUYWJCYXJJdGVt c1dpZHRoIC09IG1lYXN1cmVXaWR0aCh0YWJCYXJJdGVtKTsKIAogICAgICAgICAgICAgICAgIHRh YkJhckl0ZW0uaGlkZGVuID0gdHJ1ZTsKICAgICAgICAgICAgICAgICB0aGlzLl9oaWRkZW5UYWJC YXJJdGVtcy5wdXNoKHRhYkJhckl0ZW0pOwo=