209199 2020-03-17 15:10:45 -0700 Web Inspector: Network: we should prefer showing "Preserve Log" over "Group Media Requests" 2020-03-17 21:15:11 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1630917 0 hi 2020-03-17 15:10:45 -0700 Right now, all of the buttons on the right are hidden before we hide "Group Media Requests". That seems backwards. 1630919 1 393795 hi 2020-03-17 15:17:58 -0700 Created attachment 393795 Patch 1631033 2 393795 commit-queue 2020-03-17 21:14:57 -0700 Comment on attachment 393795 Patch Clearing flags on attachment: 393795 Committed r258622: <https://trac.webkit.org/changeset/258622> 1631034 3 commit-queue 2020-03-17 21:14:59 -0700 All reviewed patches have been landed. Closing bug. 1631035 4 webkit-bug-importer 2020-03-17 21:15:11 -0700 <rdar://problem/60569593> 393795 2020-03-17 15:17:58 -0700 2020-03-17 21:14:57 -0700 Patch 209199.diff text/plain 5329 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIzZGI3OGIwMmNjLi40NzdmM2RlZGQ0NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDMtMTcgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5l dHdvcms6IHdlIHNob3VsZCBwcmVmZXIgc2hvd2luZyAiUHJlc2VydmUgTG9nIiBvdmVyICJHcm91 cCBNZWRpYSBSZXF1ZXN0cyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwOTE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5q czoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3KToKKyAgICAgICAgQ2hhbmdl IHRoZSBgV0kuTmF2aWdhdGlvbkl0ZW0uVmlzaWJpbGl0eVByaW9yaXR5YCBvZiB0aGUgdmFyaW91 cyBgV0kuTmF2aWdhdGlvbkl0ZW1gOgorICAgICAgICAgIEhpZ2g6CisgICAgICAgICAgIC0gVVJM IGZpbHRlcgorICAgICAgICAgICAtIHJlc291cmNlIHR5cGUgZmlsdGVyCisgICAgICAgICAgIC0g bGl2ZS9IQVIgdmlldyBzd2l0Y2hlcgorICAgICAgICAgICAtIGRpc2FibGUgcmVzb3VyY2UgY2Fj aGluZyB0b2dnbGUKKyAgICAgICAgICBOb3JtYWw6CisgICAgICAgICAgIC0gUHJlc2VydmUgTG9n IGNoZWNrYm94CisgICAgICAgICAgIC0gY2xlYXIgYnV0dG9uCisgICAgICAgICAgTG93OgorICAg ICAgICAgICAtIEdyb3VwIE1lZGlhIFJlcXVlc3RzIGNoZWNrYm94CisgICAgICAgICAgIC0gSEFS IGltcG9ydC9leHBvcnQgYnV0dG9ucworICAgICAgICBUaGlzIHdheSwgaXRlbXMgdGhhdCBoYXZl IGFsdGVybmF0ZSB3YXlzIG9mIGJlaW5nIHRyaWdnZXJlZCAoZS5nLiBrZXlib2FyZCBzaG9ydGN1 dHMpIGFyZQorICAgICAgICBoaWRkZW4gZmlyc3QsIGFuZCB2aWNhIHZlcnNhLgorCiAyMDIwLTAz LTE3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OKHIyNTc3NTkpOiBXZWIgSW5zcGVjdG9yOiBTZXR0aW5ncyBpY29uIHNvbWV0aW1lcyBwbGFj ZWQgYmVsb3cgdGhlIHRhYiBiYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcu anMKaW5kZXggNGU4MzdmYTBhYzQuLjkwNmM5NGY5YzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3Jr VGFibGVDb250ZW50Vmlldy5qcwpAQCAtODgsMTAgKzg4LDEyIEBAIFdJLk5ldHdvcmtUYWJsZUNv bnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250 ZW50VmllCiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl90eXBlRmlsdGVyU2NvcGVCYXIgPSBu ZXcgV0kuU2NvcGVCYXIoIm5ldHdvcmstdHlwZS1maWx0ZXItc2NvcGUtYmFyIiwgdHlwZUZpbHRl clNjb3BlQmFySXRlbXMsIHR5cGVGaWx0ZXJTY29wZUJhckl0ZW1zWzBdKTsKKyAgICAgICAgdGhp cy5fdHlwZUZpbHRlclNjb3BlQmFyLnZpc2liaWxpdHlQcmlvcml0eSA9IFdJLk5hdmlnYXRpb25J dGVtLlZpc2liaWxpdHlQcmlvcml0eS5IaWdoOwogICAgICAgICB0aGlzLl90eXBlRmlsdGVyU2Nv cGVCYXIuYWRkRXZlbnRMaXN0ZW5lcihXSS5TY29wZUJhci5FdmVudC5TZWxlY3Rpb25DaGFuZ2Vk LCB0aGlzLl90eXBlRmlsdGVyU2NvcGVCYXJTZWxlY3Rpb25DaGFuZ2VkLCB0aGlzKTsKIAogICAg ICAgICBpZiAoV0kuTWVkaWFJbnN0cnVtZW50LnN1cHBvcnRlZCgpKSB7CiAgICAgICAgICAgICB0 aGlzLl9ncm91cE1lZGlhUmVxdWVzdHNCeURPTU5vZGVOYXZpZ2F0aW9uSXRlbSA9IG5ldyBXSS5D aGVja2JveE5hdmlnYXRpb25JdGVtKCJncm91cC1tZWRpYS1yZXF1ZXN0cyIsIFdJLlVJU3RyaW5n KCJHcm91cCBNZWRpYSBSZXF1ZXN0cyIpLCBXSS5zZXR0aW5ncy5ncm91cE1lZGlhUmVxdWVzdHNC eURPTU5vZGUudmFsdWUpOworICAgICAgICAgICAgdGhpcy5fZ3JvdXBNZWRpYVJlcXVlc3RzQnlE T01Ob2RlTmF2aWdhdGlvbkl0ZW0udmlzaWJpbGl0eVByaW9yaXR5ID0gV0kuTmF2aWdhdGlvbkl0 ZW0uVmlzaWJpbGl0eVByaW9yaXR5LkxvdzsKICAgICAgICAgICAgIHRoaXMuX2dyb3VwTWVkaWFS ZXF1ZXN0c0J5RE9NTm9kZU5hdmlnYXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ2hlY2ti b3hOYXZpZ2F0aW9uSXRlbS5FdmVudC5DaGVja2VkRGlkQ2hhbmdlLCB0aGlzLl9oYW5kbGVHcm91 cE1lZGlhUmVxdWVzdHNCeURPTU5vZGVDaGVja2VkRGlkQ2hhbmdlLCB0aGlzKTsKICAgICAgICAg fSBlbHNlCiAgICAgICAgICAgICBXSS5zZXR0aW5ncy5ncm91cE1lZGlhUmVxdWVzdHNCeURPTU5v ZGUudmFsdWUgPSBmYWxzZTsKQEAgLTEwMSw2ICsxMDMsNyBAQCBXSS5OZXR3b3JrVGFibGVDb250 ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVu dFZpZQogICAgICAgICB0aGlzLl91cmxGaWx0ZXJJc0FjdGl2ZSA9IGZhbHNlOwogCiAgICAgICAg IHRoaXMuX3VybEZpbHRlck5hdmlnYXRpb25JdGVtID0gbmV3IFdJLkZpbHRlckJhck5hdmlnYXRp b25JdGVtOworICAgICAgICB0aGlzLl91cmxGaWx0ZXJOYXZpZ2F0aW9uSXRlbS52aXNpYmlsaXR5 UHJpb3JpdHkgPSBXSS5OYXZpZ2F0aW9uSXRlbS5WaXNpYmlsaXR5UHJpb3JpdHkuSGlnaDsKICAg ICAgICAgdGhpcy5fdXJsRmlsdGVyTmF2aWdhdGlvbkl0ZW0uZmlsdGVyQmFyLmFkZEV2ZW50TGlz dGVuZXIoV0kuRmlsdGVyQmFyLkV2ZW50LkZpbHRlckRpZENoYW5nZSwgdGhpcy5fdXJsRmlsdGVy RGlkQ2hhbmdlLCB0aGlzKTsKICAgICAgICAgdGhpcy5fdXJsRmlsdGVyTmF2aWdhdGlvbkl0ZW0u ZmlsdGVyQmFyLnBsYWNlaG9sZGVyID0gV0kuVUlTdHJpbmcoIkZpbHRlciBGdWxsIFVSTCIpOwog CkBAIC0xMzcsMTAgKzE0MCw5IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xhc3Mg TmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAgICAgICAgIHRo aXMuX2NvbGxlY3Rpb25zUGF0aE5hdmlnYXRpb25JdGVtLmNvbXBvbmVudHMgPSBbcGF0aENvbXBv bmVudF07CiAKICAgICAgICAgdGhpcy5fY2hlY2tib3hlc05hdmlnYXRpb25JdGVtR3JvdXAgPSBu ZXcgV0kuR3JvdXBOYXZpZ2F0aW9uSXRlbShbdGhpcy5fY2xlYXJPbkxvYWROYXZpZ2F0aW9uSXRl bSwgbmV3IFdJLkRpdmlkZXJOYXZpZ2F0aW9uSXRlbV0pOwotICAgICAgICB0aGlzLl9jaGVja2Jv eGVzTmF2aWdhdGlvbkl0ZW1Hcm91cC52aXNpYmlsaXR5UHJpb3JpdHkgPSBXSS5OYXZpZ2F0aW9u SXRlbS5WaXNpYmlsaXR5UHJpb3JpdHkuTG93OwogCiAgICAgICAgIHRoaXMuX3BhdGhDb21wb25l bnRzTmF2aWdhdGlvbkl0ZW1Hcm91cCA9IG5ldyBXSS5Hcm91cE5hdmlnYXRpb25JdGVtKFt0aGlz Ll9jb2xsZWN0aW9uc1BhdGhOYXZpZ2F0aW9uSXRlbSwgbmV3IFdJLkRpdmlkZXJOYXZpZ2F0aW9u SXRlbV0pOwotICAgICAgICB0aGlzLl9wYXRoQ29tcG9uZW50c05hdmlnYXRpb25JdGVtR3JvdXAu dmlzaWJpbGl0eVByaW9yaXR5ID0gV0kuTmF2aWdhdGlvbkl0ZW0uVmlzaWJpbGl0eVByaW9yaXR5 LkxvdzsKKyAgICAgICAgdGhpcy5fcGF0aENvbXBvbmVudHNOYXZpZ2F0aW9uSXRlbUdyb3VwLnZp c2liaWxpdHlQcmlvcml0eSA9IFdJLk5hdmlnYXRpb25JdGVtLlZpc2liaWxpdHlQcmlvcml0eS5I aWdoOwogICAgICAgICB0aGlzLl9wYXRoQ29tcG9uZW50c05hdmlnYXRpb25JdGVtR3JvdXAuaGlk ZGVuID0gdHJ1ZTsKIAogICAgICAgICB0aGlzLl9idXR0b25zTmF2aWdhdGlvbkl0ZW1Hcm91cCA9 IG5ldyBXSS5Hcm91cE5hdmlnYXRpb25JdGVtKFt0aGlzLl9oYXJJbXBvcnROYXZpZ2F0aW9uSXRl bSwgdGhpcy5faGFyRXhwb3J0TmF2aWdhdGlvbkl0ZW0sIG5ldyBXSS5EaXZpZGVyTmF2aWdhdGlv bkl0ZW1dKTsKQEAgLTE1Miw4ICsxNTQsOSBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9 IGNsYXNzIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAg ICAgICAgICAgbGV0IGFjdGl2YXRlZFRvb2xUaXBGb3JEaXNhYmxlUmVzb3VyY2VDYWNoZSA9IFdJ LlVJU3RyaW5nKCJVc2UgdGhlIHJlc291cmNlIGNhY2hlIHdoZW4gbG9hZGluZyByZXNvdXJjZXMi KTsKICAgICAgICAgICAgIHRoaXMuX2Rpc2FibGVSZXNvdXJjZUNhY2hlTmF2aWdhdGlvbkl0ZW0g PSBuZXcgV0kuQWN0aXZhdGVCdXR0b25OYXZpZ2F0aW9uSXRlbSgiZGlzYWJsZS1yZXNvdXJjZS1j YWNoZSIsIHRvb2xUaXBGb3JEaXNhYmxlUmVzb3VyY2VDYWNoZSwgYWN0aXZhdGVkVG9vbFRpcEZv ckRpc2FibGVSZXNvdXJjZUNhY2hlLCAiSW1hZ2VzL0lnbm9yZUNhY2hlcy5zdmciLCAxNiwgMTYp OwogICAgICAgICAgICAgdGhpcy5fZGlzYWJsZVJlc291cmNlQ2FjaGVOYXZpZ2F0aW9uSXRlbS5h Y3RpdmF0ZWQgPSBXSS5zZXR0aW5ncy5yZXNvdXJjZUNhY2hpbmdEaXNhYmxlZC52YWx1ZTsKLQor ICAgICAgICAgICAgdGhpcy5fZGlzYWJsZVJlc291cmNlQ2FjaGVOYXZpZ2F0aW9uSXRlbS52aXNp YmlsaXR5UHJpb3JpdHkgPSBXSS5OYXZpZ2F0aW9uSXRlbS5WaXNpYmlsaXR5UHJpb3JpdHkuSGln aDsKICAgICAgICAgICAgIHRoaXMuX2Rpc2FibGVSZXNvdXJjZUNhY2hlTmF2aWdhdGlvbkl0ZW0u YWRkRXZlbnRMaXN0ZW5lcihXSS5CdXR0b25OYXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0 aGlzLl90b2dnbGVEaXNhYmxlUmVzb3VyY2VDYWNoZSwgdGhpcyk7CisKICAgICAgICAgICAgIFdJ LnNldHRpbmdzLnJlc291cmNlQ2FjaGluZ0Rpc2FibGVkLmFkZEV2ZW50TGlzdGVuZXIoV0kuU2V0 dGluZy5FdmVudC5DaGFuZ2VkLCB0aGlzLl9yZXNvdXJjZUNhY2hpbmdEaXNhYmxlZFNldHRpbmdD aGFuZ2VkLCB0aGlzKTsKICAgICAgICAgfQogCg==