209165 2020-03-16 19:16:44 -0700 ScriptDisallowedScope should disable isEventAllowedInMainThread and isEventDispatchAllowedInSubtree asserts in WebKit1 2020-03-19 16:48:25 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sunny_he webkit-unassigned achristensen cdumez esprehn+autocc ews-watchlist kangil.han rniwa webkit-bug-importer oldest_to_newest 1630603 0 sunny_he 2020-03-16 19:16:44 -0700 rdar://59575816 1630608 1 393721 sunny_he 2020-03-16 19:25:08 -0700 Created attachment 393721 Patch 1631053 2 achristensen 2020-03-17 23:12:51 -0700 Could you or Ryosuke elaborate on what these problematic design decisions are? On non-Cocoa platforms, isInWebProcess returns a constant. That is problematic. Maybe the time is come for them to implement this. 1631308 3 rniwa 2020-03-18 12:39:29 -0700 (In reply to Alex Christensen from comment #2) > Could you or Ryosuke elaborate on what these problematic design decisions > are? Sync delegate callbacks. > On non-Cocoa platforms, isInWebProcess returns a constant. That is > problematic. Maybe the time is come for them to implement this. Why would it be? Nobody ships WK1 other than macOS, iOS, and Windows ports these days. 1631311 4 rniwa 2020-03-18 12:41:21 -0700 Hm... looks like GTK+ build is failing for an unrelated reason? Let's re-try them. 1631451 5 393721 rniwa 2020-03-18 17:51:19 -0700 Comment on attachment 393721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393721&action=review > Source/WebCore/dom/ScriptDisallowedScope.h:27 > +#include <WebCore/RuntimeApplicationChecks.h> Oh, wait, this is not the right way to include this header. Should be: #icnlude "RuntimeApplicationChecks.h" This is probably why the build failure is happening on GTK+ etc... 1631475 6 393930 sunny_he 2020-03-18 18:27:42 -0700 Created attachment 393930 Patch 1631916 7 ews-feeder 2020-03-19 16:48:24 -0700 Committed r258744: <https://trac.webkit.org/changeset/258744> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393930. 393721 2020-03-16 19:25:08 -0700 2020-03-18 18:27:41 -0700 Patch bug-209165-20200316192507.patch text/plain 2346 sunny_he U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFiYjliMjhlZGUyMjRk MDZkODI4YTc5NzczNjY0MDc3ZDBhYTZmNS4uNTIzOTU5MGM2ZjViOTg2NTg0N2ZhOGFjYjcwNDA2 OWQ5NDc0ZGQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTAzLTE2ICBTdW5u eSBIZSAgPHN1bm55X2hlQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHREaXNhbGxvd2VkU2Nv cGUgc2hvdWxkIGRpc2FibGUgaXNFdmVudEFsbG93ZWRJbk1haW5UaHJlYWQgYW5kIGlzRXZlbnRE aXNwYXRjaEFsbG93ZWRJblN1YnRyZWUgYXNzZXJ0cyBpbiBXZWJLaXQxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkxNjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmRlciB2ZXJ5IGludHJpY2F0ZSBz ZXF1ZW5jZXMgb2YgZXZlbnQgZGlzcGF0Y2ggaW4gV2ViS2l0MSwgaXQgaXMKKyAgICAgICAgcG9z c2libGUgZm9yIHNlY3VyaXR5IGFzc2VydHMgdG8gYmUgdHJpZ2dlcmVkIGV2ZW4gaWYgdGhlcmUg aXMgbm8KKyAgICAgICAgdW5kZXJseWluZyBzZWN1cml0eSBpc3N1ZSBzb2xleSBkdWUgdG8gdGhl IGRlc2lnbiBwYXR0ZXJucyBvZgorICAgICAgICBXZWJLaXQxLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBzaW5jZSB0aGUgY29uZGl0aW9ucyBmb3IgcmVwcm9kdWN0aW9uIGFyZSB2ZXJ5IGRlbGlj YXRlCisgICAgICAgIGFuZCBkaWZmaWN1bHQgdG8gcmVsaWFibHkgY2FwdHVyZSBpbiBhIHRlc3Qg Y2FzZS4KKworICAgICAgICAqIGRvbS9TY3JpcHREaXNhbGxvd2VkU2NvcGUuaDoKKyAgICAgICAg KFdlYkNvcmU6OlNjcmlwdERpc2FsbG93ZWRTY29wZTo6aXNFdmVudEFsbG93ZWRJbk1haW5UaHJl YWQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJl YWQ6OmlzRXZlbnREaXNwYXRjaEFsbG93ZWRJblN1YnRyZWUpOgorCiAyMDIwLTAzLTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBBIGNoYW5nZSBldmVu dCBnZXRzIGRpc3BhdGNoZWQgd2hlbiB0ZXh0YXJlYSBnZXRzIGNoYW5nZWQgd2l0aG91dCBmb2N1 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdERpc2FsbG93ZWRTY29wZS5o IGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdERpc2FsbG93ZWRTY29wZS5oCmluZGV4IGI4Mjg5 YjU5N2UzM2IyNmM3Yjk4NzFkMmFjNWE4M2Y2YjExZjY4MjMuLjc0OWY3ZTA4MzA0NTY2M2VlM2Zi YWU0NmM2Yzg4ZTkzMGRhNzE5YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3Jp cHREaXNhbGxvd2VkU2NvcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RGlzYWxs b3dlZFNjb3BlLmgKQEAgLTI0LDYgKzI0LDcgQEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSAi Q29udGFpbmVyTm9kZS5oIgorI2luY2x1ZGUgPFdlYkNvcmUvUnVudGltZUFwcGxpY2F0aW9uQ2hl Y2tzLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KIAogI2lmIFBMQVRGT1JNKElPU19G QU1JTFkpCkBAIC02Miw3ICs2Myw3IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBib29sIGlzRXZl bnRBbGxvd2VkSW5NYWluVGhyZWFkKCkKICAgICB7Ci0gICAgICAgIHJldHVybiAhaXNNYWluVGhy ZWFkKCkgfHwgIXNfY291bnQ7CisgICAgICAgIHJldHVybiAhaXNJbldlYlByb2Nlc3MoKSB8fCAh aXNNYWluVGhyZWFkKCkgfHwgIXNfY291bnQ7CiAgICAgfQogCiAgICAgY2xhc3MgSW5NYWluVGhy ZWFkIHsKQEAgLTg1LDcgKzg2LDcgQEAgcHVibGljOgogICAgICAgICBzdGF0aWMgYm9vbCBpc0V2 ZW50RGlzcGF0Y2hBbGxvd2VkSW5TdWJ0cmVlKE5vZGUmIG5vZGUpCiAgICAgICAgIHsKICNpZiBB U1NFUlRfRU5BQkxFRCB8fCBFTkFCTEUoU0VDVVJJVFlfQVNTRVJUSU9OUykKLSAgICAgICAgICAg IHJldHVybiBpc1NjcmlwdEFsbG93ZWQoKSB8fCBFdmVudEFsbG93ZWRTY29wZTo6aXNBbGxvd2Vk Tm9kZShub2RlKTsKKyAgICAgICAgICAgIHJldHVybiAhaXNJbldlYlByb2Nlc3MoKSB8fCBpc1Nj cmlwdEFsbG93ZWQoKSB8fCBFdmVudEFsbG93ZWRTY29wZTo6aXNBbGxvd2VkTm9kZShub2RlKTsK ICNlbHNlCiAgICAgICAgICAgICBVTlVTRURfUEFSQU0obm9kZSk7CiAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsK 393930 2020-03-18 18:27:42 -0700 2020-03-19 16:48:25 -0700 Patch bug-209165-20200318182742.patch text/plain 2338 sunny_he U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFiYjliMjhlZGUyMjRk MDZkODI4YTc5NzczNjY0MDc3ZDBhYTZmNS4uNTIzOTU5MGM2ZjViOTg2NTg0N2ZhOGFjYjcwNDA2 OWQ5NDc0ZGQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTAzLTE2ICBTdW5u eSBIZSAgPHN1bm55X2hlQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHREaXNhbGxvd2VkU2Nv cGUgc2hvdWxkIGRpc2FibGUgaXNFdmVudEFsbG93ZWRJbk1haW5UaHJlYWQgYW5kIGlzRXZlbnRE aXNwYXRjaEFsbG93ZWRJblN1YnRyZWUgYXNzZXJ0cyBpbiBXZWJLaXQxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkxNjUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmRlciB2ZXJ5IGludHJpY2F0ZSBz ZXF1ZW5jZXMgb2YgZXZlbnQgZGlzcGF0Y2ggaW4gV2ViS2l0MSwgaXQgaXMKKyAgICAgICAgcG9z c2libGUgZm9yIHNlY3VyaXR5IGFzc2VydHMgdG8gYmUgdHJpZ2dlcmVkIGV2ZW4gaWYgdGhlcmUg aXMgbm8KKyAgICAgICAgdW5kZXJseWluZyBzZWN1cml0eSBpc3N1ZSBzb2xleSBkdWUgdG8gdGhl IGRlc2lnbiBwYXR0ZXJucyBvZgorICAgICAgICBXZWJLaXQxLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBzaW5jZSB0aGUgY29uZGl0aW9ucyBmb3IgcmVwcm9kdWN0aW9uIGFyZSB2ZXJ5IGRlbGlj YXRlCisgICAgICAgIGFuZCBkaWZmaWN1bHQgdG8gcmVsaWFibHkgY2FwdHVyZSBpbiBhIHRlc3Qg Y2FzZS4KKworICAgICAgICAqIGRvbS9TY3JpcHREaXNhbGxvd2VkU2NvcGUuaDoKKyAgICAgICAg KFdlYkNvcmU6OlNjcmlwdERpc2FsbG93ZWRTY29wZTo6aXNFdmVudEFsbG93ZWRJbk1haW5UaHJl YWQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpJbk1haW5UaHJl YWQ6OmlzRXZlbnREaXNwYXRjaEFsbG93ZWRJblN1YnRyZWUpOgorCiAyMDIwLTAzLTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBBIGNoYW5nZSBldmVu dCBnZXRzIGRpc3BhdGNoZWQgd2hlbiB0ZXh0YXJlYSBnZXRzIGNoYW5nZWQgd2l0aG91dCBmb2N1 cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdERpc2FsbG93ZWRTY29wZS5o IGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdERpc2FsbG93ZWRTY29wZS5oCmluZGV4IGI4Mjg5 YjU5N2UzM2IyNmM3Yjk4NzFkMmFjNWE4M2Y2YjExZjY4MjMuLjMzZDQzMjdmNGFiZmZiODFkYThi OWI3NzM4ZTVmZmEzNTJkYzM1MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3Jp cHREaXNhbGxvd2VkU2NvcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RGlzYWxs b3dlZFNjb3BlLmgKQEAgLTI0LDYgKzI0LDcgQEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSAi Q29udGFpbmVyTm9kZS5oIgorI2luY2x1ZGUgIlJ1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5oIgog I2luY2x1ZGUgPHd0Zi9NYWluVGhyZWFkLmg+CiAKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQpA QCAtNjIsNyArNjMsNyBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgYm9vbCBpc0V2ZW50QWxsb3dl ZEluTWFpblRocmVhZCgpCiAgICAgewotICAgICAgICByZXR1cm4gIWlzTWFpblRocmVhZCgpIHx8 ICFzX2NvdW50OworICAgICAgICByZXR1cm4gIWlzSW5XZWJQcm9jZXNzKCkgfHwgIWlzTWFpblRo cmVhZCgpIHx8ICFzX2NvdW50OwogICAgIH0KIAogICAgIGNsYXNzIEluTWFpblRocmVhZCB7CkBA IC04NSw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICAgICAgc3RhdGljIGJvb2wgaXNFdmVudERpc3Bh dGNoQWxsb3dlZEluU3VidHJlZShOb2RlJiBub2RlKQogICAgICAgICB7CiAjaWYgQVNTRVJUX0VO QUJMRUQgfHwgRU5BQkxFKFNFQ1VSSVRZX0FTU0VSVElPTlMpCi0gICAgICAgICAgICByZXR1cm4g aXNTY3JpcHRBbGxvd2VkKCkgfHwgRXZlbnRBbGxvd2VkU2NvcGU6OmlzQWxsb3dlZE5vZGUobm9k ZSk7CisgICAgICAgICAgICByZXR1cm4gIWlzSW5XZWJQcm9jZXNzKCkgfHwgaXNTY3JpcHRBbGxv d2VkKCkgfHwgRXZlbnRBbGxvd2VkU2NvcGU6OmlzQWxsb3dlZE5vZGUobm9kZSk7CiAjZWxzZQog ICAgICAgICAgICAgVU5VU0VEX1BBUkFNKG5vZGUpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7 Cg==