209155 2020-03-16 16:13:19 -0700 REGRESSION (r257472): Can't start old Safari with new WebKit (dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess) 2024-10-15 10:27:14 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208238 InRadar P2 Normal --- 1 ziadrb youennf aneuttermost526 commit-queue darin eric.carlson webkit-bug-importer youennf oldest_to_newest 1630523 0 ziadrb 2020-03-16 16:13:19 -0700 Not able to start Safari on Catalina (10.15.3) $ svn info Path: . Working Copy Root Path: /Users/user/webkit URL: https://svn.webkit.org/repository/webkit/trunk Relative URL: ^/trunk Repository Root: https://svn.webkit.org/repository/webkit Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc Revision: 258497 Node Kind: directory Schedule: normal Last Changed Author: commit-queue@webkit.org Last Changed Rev: 258497 Last Changed Date: 2020-03-16 10:27:05 -0500 (Mon, 16 Mar 2020) Configured as $ Tools/Scripts/set-webkit-configuration --asan --release Built as $ Tools/Scripts/build-webkit Run $ Tools/Scripts/run-safari Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/user/webkit/WebKitBuild/Release. dyld: Symbol not found: _WKContextConfigurationSetShouldCaptureAudioInUIProcess Referenced from: /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari Expected in: /Users/user/webkit/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit in /System/Library/PrivateFrameworks/Safari.framework/Versions/A/Safari 1630579 1 darin 2020-03-16 17:20:10 -0700 Caused by <https://trac.webkit.org/changeset/257472>. Need to leave a stub behind to keep old Safari working. We should fix this so people outside Apple can continue to work on WebKit. 1630661 2 393735 youennf 2020-03-17 01:22:34 -0700 Created attachment 393735 Patch 1630746 3 393735 eric.carlson 2020-03-17 09:19:57 -0700 Comment on attachment 393735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393735&action=review > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:75 > +// FIXME: https://bugs.webkit.org/show_bug.cgi?id=209155. Remove this function once no longer useful torun latest WebKit with older Safari. s/torun/to run/ 1630851 4 393735 darin 2020-03-17 12:50:28 -0700 Comment on attachment 393735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393735&action=review > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:76 > +WK_EXPORT void WKContextConfigurationSetShouldCaptureAudioInUIProcess(WKContextConfigurationRef configuration, bool allowed); In past cases like this one we left the thing out of the header file and put it in the .cpp file with a comment like the one above. We should put it at the top of the .cpp file instead of here. 1631083 5 393834 youennf 2020-03-18 05:29:20 -0700 Created attachment 393834 Patch for landing 1631115 6 393834 commit-queue 2020-03-18 07:24:24 -0700 Comment on attachment 393834 Patch for landing Clearing flags on attachment: 393834 Committed r258629: <https://trac.webkit.org/changeset/258629> 1631116 7 commit-queue 2020-03-18 07:24:25 -0700 All reviewed patches have been landed. Closing bug. 1631117 8 webkit-bug-importer 2020-03-18 07:25:15 -0700 <rdar://problem/60583675> 393735 2020-03-17 01:22:34 -0700 2020-03-18 05:29:16 -0700 Patch bug-209155-20200317092233.patch text/plain 2978 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQxN2Y2OTBjY2FjY2Y4NTBm N2FkMGEzM2JlMWRkMTg1YzM1NWE3YWYuLjY0NjlmZDJiMWUyMDdlYjg3MzA4MjI2ZDQyMmQ4YzAz NjNkZGJhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMTcgIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTc0NzIp OiBDYW4ndCBzdGFydCBvbGQgU2FmYXJpIHdpdGggbmV3IFdlYktpdCAoZHlsZDogU3ltYm9sIG5v dCBmb3VuZDogX1dLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRTaG91bGRDYXB0dXJlQXVkaW9JblVJ UHJvY2VzcykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwOTE1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhIG5vLW9wIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRTaG91bGRDYXB0dXJlQXVkaW9J blVJUHJvY2VzcyB0byBhbGxvdyBsYXRlc3QgV2ViS2l0IGJlaW5nIHJ1biBvbiBvbGRlciBTYWZh cmkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmlndXJhdGlvblJl Zi5jcHA6CisgICAgICAgIChXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0U2hvdWxkQ2FwdHVyZUF1 ZGlvSW5VSVByb2Nlc3MpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25m aWd1cmF0aW9uUmVmLmg6CisKIDIwMjAtMDMtMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgYml0IG1vcmUgVUlIaXRUZXN0aW5nIGxvZ2dp bmcsIGFuZCBtYWtlIGl0IHBvc3NpYmxlIHRvIGR1bXAgRXZlbnRSZWdpb25zIGZyb20gV2ViS2l0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25m aWd1cmF0aW9uUmVmLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4 dENvbmZpZ3VyYXRpb25SZWYuY3BwCmluZGV4IDJhYzZhNWQ3NDM4MTFmYmY1YTQxMmIzZDRjNzg0 MTg5NzczZGE5MzIuLjZkZWUyOGJlNWY2NmY4ZTBhZDkxMDUwYmM1NTk4OWQzN2FlNTI5NDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dENvbmZpZ3Vy YXRpb25SZWYuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4 dENvbmZpZ3VyYXRpb25SZWYuY3BwCkBAIC0yMTQsNiArMjE0LDEwIEBAIHZvaWQgV0tDb250ZXh0 Q29uZmlndXJhdGlvblNldERpc2tDYWNoZVNpemVPdmVycmlkZShXS0NvbnRleHRDb25maWd1cmF0 aW9uUmVmIGNvCiB7CiB9CiAKK3ZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldFNob3VsZENh cHR1cmVBdWRpb0luVUlQcm9jZXNzKFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYsIGJvb2wpCit7 Cit9CisKIHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldFNob3VsZENvbmZpZ3VyZUpTQ0Zv clRlc3RpbmcoV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uLCBib29sIHZh bHVlKQogewogICAgIHRvSW1wbChjb25maWd1cmF0aW9uKS0+c2V0U2hvdWxkQ29uZmlndXJlSlND Rm9yVGVzdGluZyh2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQy9XS0NvbnRleHRDb25maWd1cmF0aW9uUmVmLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQy9XS0NvbnRleHRDb25maWd1cmF0aW9uUmVmLmgKaW5kZXggZmEyZmVjNjJiM2QzYWY1 YzMyNmM1NzFkZGRiYjc1YWZlNWNlM2E0MS4uNzNjZGQ5MDA4MmU4M2Y4NWRmMWYyNDBhNGE3MDg3 NjJiYTIwZDhlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tD b250ZXh0Q29uZmlndXJhdGlvblJlZi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYuaApAQCAtNzIsNiArNzIsOSBAQCBXS19FWFBP UlQgdm9pZCBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0SWdub3JlU3luY2hyb25vdXNNZXNzYWdp bmdUaW1lb3V0c0ZvclRlcwogV0tfRVhQT1JUIFdLQXJyYXlSZWYgV0tDb250ZXh0Q29uZmlndXJh dGlvbkNvcHlPdmVycmlkZUxhbmd1YWdlcyhXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbmZp Z3VyYXRpb24pOwogV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldE92ZXJy aWRlTGFuZ3VhZ2VzKFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYgY29uZmlndXJhdGlvbiwgV0tB cnJheVJlZiBvdmVycmlkZUxhbmd1YWdlcyk7CiAKKy8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MTU1LiBSZW1vdmUgdGhpcyBmdW5jdGlvbiBvbmNl IG5vIGxvbmdlciB1c2VmdWwgdG9ydW4gbGF0ZXN0IFdlYktpdCB3aXRoIG9sZGVyIFNhZmFyaS4K K1dLX0VYUE9SVCB2b2lkIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRTaG91bGRDYXB0dXJlQXVk aW9JblVJUHJvY2VzcyhXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24sIGJv b2wgYWxsb3dlZCk7CisKIFdLX0VYUE9SVCBib29sIFdLQ29udGV4dENvbmZpZ3VyYXRpb25Qcm9j ZXNzU3dhcHNPbk5hdmlnYXRpb24oV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0 aW9uKTsKIFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRQcm9jZXNzU3dh cHNPbk5hdmlnYXRpb24oV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uLCBi b29sIHN3YXBzKTsKIAo= 393834 2020-03-18 05:29:20 -0700 2020-03-18 07:24:24 -0700 Patch for landing bug-209155-20200318132918.patch text/plain 2937 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjODk0OTA5YmQ3OTZiYTA3 NjlmMGI1YzYzMDY4ODk1MDA0ZjBhOTMuLmY4ODhiMzQ3OTRlYzU0YmU1NjEyMjA0ZmVkOTYzMzQw NmU1OWI2NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMTggIHlvdWVubiBm YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNTc0NzIp OiBDYW4ndCBzdGFydCBvbGQgU2FmYXJpIHdpdGggbmV3IFdlYktpdCAoZHlsZDogU3ltYm9sIG5v dCBmb3VuZDogX1dLQ29udGV4dENvbmZpZ3VyYXRpb25TZXRTaG91bGRDYXB0dXJlQXVkaW9JblVJ UHJvY2VzcykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwOTE1NQorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBB ZGQgYSBuby1vcCBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0U2hvdWxkQ2FwdHVyZUF1ZGlvSW5V SVByb2Nlc3MgdG8gYWxsb3cgbGF0ZXN0IFdlYktpdCBiZWluZyBydW4gb24gb2xkZXIgU2FmYXJp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYu Y3BwOgorICAgICAgICAoV0tDb250ZXh0Q29uZmlndXJhdGlvblNldFNob3VsZENhcHR1cmVBdWRp b0luVUlQcm9jZXNzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmln dXJhdGlvblJlZi5oOgorCiAyMDIwLTAzLTE3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBs ZS5jb20+CiAKICAgICAgICAgU2hhcmVkTWVtb3J5OjpIYW5kbGU6Om1fc2l6ZSBzaG91bGQgYmUg bW9yZSBjb25zaXN0ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Qy9XS0NvbnRleHRDb25maWd1cmF0aW9uUmVmLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYuY3BwCmluZGV4IDJhYzZhNWQ3NDM4MTFm YmY1YTQxMmIzZDRjNzg0MTg5NzczZGE5MzIuLjZkZWUyOGJlNWY2NmY4ZTBhZDkxMDUwYmM1NTk4 OWQzN2FlNTI5NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dL Q29udGV4dENvbmZpZ3VyYXRpb25SZWYuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYuY3BwCkBAIC0yMTQsNiArMjE0LDEwIEBA IHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldERpc2tDYWNoZVNpemVPdmVycmlkZShXS0Nv bnRleHRDb25maWd1cmF0aW9uUmVmIGNvCiB7CiB9CiAKK3ZvaWQgV0tDb250ZXh0Q29uZmlndXJh dGlvblNldFNob3VsZENhcHR1cmVBdWRpb0luVUlQcm9jZXNzKFdLQ29udGV4dENvbmZpZ3VyYXRp b25SZWYsIGJvb2wpCit7Cit9CisKIHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldFNob3Vs ZENvbmZpZ3VyZUpTQ0ZvclRlc3RpbmcoV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1 cmF0aW9uLCBib29sIHZhbHVlKQogewogICAgIHRvSW1wbChjb25maWd1cmF0aW9uKS0+c2V0U2hv dWxkQ29uZmlndXJlSlNDRm9yVGVzdGluZyh2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25maWd1cmF0aW9uUmVmLmggYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25maWd1cmF0aW9uUmVmLmgKaW5kZXgg ZmEyZmVjNjJiM2QzYWY1YzMyNmM1NzFkZGRiYjc1YWZlNWNlM2E0MS4uMGQxYjE2NDYwMzRiMTQ3 N2I4MzNhZWM2YzI2NDNkMjFmODAxMTQ5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZi5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYuaApAQCAtNzIsNiAr NzIsOSBAQCBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0SWdub3JlU3lu Y2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0c0ZvclRlcwogV0tfRVhQT1JUIFdLQXJyYXlSZWYgV0tD b250ZXh0Q29uZmlndXJhdGlvbkNvcHlPdmVycmlkZUxhbmd1YWdlcyhXS0NvbnRleHRDb25maWd1 cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24pOwogV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0Q29uZmln dXJhdGlvblNldE92ZXJyaWRlTGFuZ3VhZ2VzKFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYgY29u ZmlndXJhdGlvbiwgV0tBcnJheVJlZiBvdmVycmlkZUxhbmd1YWdlcyk7CiAKKy8vIEZJWE1FOiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MTU1LiBSZW1vdmUgdGhp cyBmdW5jdGlvbiBvbmNlIG5vIGxvbmdlciB1c2VmdWwgdG8gcnVuIGxhdGVzdCBXZWJLaXQgd2l0 aCBvbGRlciBTYWZhcmkuCitXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0 U2hvdWxkQ2FwdHVyZUF1ZGlvSW5VSVByb2Nlc3MoV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBj b25maWd1cmF0aW9uLCBib29sIGFsbG93ZWQpOworCiBXS19FWFBPUlQgYm9vbCBXS0NvbnRleHRD b25maWd1cmF0aW9uUHJvY2Vzc1N3YXBzT25OYXZpZ2F0aW9uKFdLQ29udGV4dENvbmZpZ3VyYXRp b25SZWYgY29uZmlndXJhdGlvbik7CiBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRDb25maWd1cmF0 aW9uU2V0UHJvY2Vzc1N3YXBzT25OYXZpZ2F0aW9uKFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYg Y29uZmlndXJhdGlvbiwgYm9vbCBzd2Fwcyk7CiAK