209127 2020-03-15 11:34:34 -0700 Remove addHTTPOriginIfNeeded calls 2020-03-29 10:34:23 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez commit-queue darin ews-watchlist japhet webkit-bug-importer oldest_to_newest 1630190 0 rbuis 2020-03-15 11:34:34 -0700 Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1] indicates that the Origin header should not be written out, making these calls no-ops. [1] https://fetch.spec.whatwg.org/#append-a-request-origin-header 1630191 1 393620 rbuis 2020-03-15 11:35:55 -0700 Created attachment 393620 Patch 1630260 2 393620 commit-queue 2020-03-16 01:11:31 -0700 Comment on attachment 393620 Patch Clearing flags on attachment: 393620 Committed r258488: <https://trac.webkit.org/changeset/258488> 1630261 3 commit-queue 2020-03-16 01:11:33 -0700 All reviewed patches have been landed. Closing bug. 1630262 4 webkit-bug-importer 2020-03-16 01:12:12 -0700 <rdar://problem/60486281> 1635331 5 rbuis 2020-03-29 06:10:35 -0700 Reopening to attach new patch. 1635332 6 394865 rbuis 2020-03-29 06:10:38 -0700 Created attachment 394865 Patch 1635344 7 394865 darin 2020-03-29 09:21:06 -0700 Comment on attachment 394865 Patch Looks fine. Next time I suggest using a new bug report. I don’t think reopening is a good way to handle follow up even though I see a lot of people doing it. I think reopening is a good way to handle trying again rolling out or trying again if the first try did not successfully fix the bug. 1635348 8 rbuis 2020-03-29 10:28:07 -0700 Point taken! 1635351 9 ews-feeder 2020-03-29 10:34:22 -0700 Committed r259182: <https://trac.webkit.org/changeset/259182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394865. 393620 2020-03-15 11:35:55 -0700 2020-03-29 06:10:31 -0700 Patch bug-209127-20200315193553.patch text/plain 4435 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBiYmE4NDY5YTkzNWIx ZDgzMGVjYzdhYzNkYWE3MDkxZDA1NGE4Ni4uMDRjNGQwOGZjMTZhNDlmY2I5OGI1ZDAxOTBiOGFk NzdlZmVmM2JiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTE0ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFkZEhUVFBPcmlnaW5J Zk5lZWRlZCBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA5MTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIGFkZEhUVFBPcmlnaW5JZk5lZWRlZCBjYWxscyBzaW5jZSB0aGV5IGFyZSBn ZXQgcmVxdWVzdHMgYW5kIG5hdmlnYXRpb25zIGFuZCB0aGUgc3BlYyBbMV0KKyAgICAgICAgaW5k aWNhdGVzIHRoYXQgdGhlIE9yaWdpbiBoZWFkZXIgc2hvdWxkIG5vdCBiZSB3cml0dGVuIG91dCwg bWFraW5nIHRoZXNlIGNhbGxzIG5vLW9wcy4KKworICAgICAgIFsxXSBodHRwczovL2ZldGNoLnNw ZWMud2hhdHdnLm9yZy8jYXBwZW5kLWEtcmVxdWVzdC1vcmlnaW4taGVhZGVyCisKKyAgICAgICAg KiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmNoYW5nZUxvY2F0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkVVJM KToKKwogMjAyMC0wMy0xNCAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAg ICAgIENsZWFudXAgUmVuZGVyTWVkaWFDb250cm9scy5jcHAgYW5kIFJlbmRlck1lZGlhQ29udHJv bEVsZW1lbnRzLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggZDQz NDgwNWI2NGNmZWU5NjdmNDA2MjA5ODIwMWNmMjQ1ZjA2ZDQ0Zi4uZTczYjMwZTI4MTQ3MDRlOWI1 NzBmODdlOTJkMjUyMDQ3OTA5NjQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCkBAIC00MjYsNiArNDI2LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2hhbmdlTG9jYXRpb24o Y29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgcGFzc2VkVGFyZ2V0LCBFdmUKIHZvaWQgRnJh bWVMb2FkZXI6OmNoYW5nZUxvY2F0aW9uKEZyYW1lTG9hZFJlcXVlc3QmJiBmcmFtZVJlcXVlc3Qs IEV2ZW50KiB0cmlnZ2VyaW5nRXZlbnQsIE9wdGlvbmFsPEFkQ2xpY2tBdHRyaWJ1dGlvbj4mJiBh ZENsaWNrQXR0cmlidXRpb24pCiB7CiAgICAgRlJBTUVMT0FERVJfUkVMRUFTRV9MT0dfSUZfQUxM T1dFRChSZXNvdXJjZUxvYWRpbmcsICJjaGFuZ2VMb2NhdGlvbjogZnJhbWUgbG9hZCBzdGFydGVk Iik7CisgICAgQVNTRVJUKGZyYW1lUmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS5odHRwTWV0aG9k KCkgPT0gIkdFVCIpOwogCiAgICAgUmVmPEZyYW1lPiBwcm90ZWN0KG1fZnJhbWUpOwogCkBAIC00 MzcsNyArNDM4LDYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2hhbmdlTG9jYXRpb24oRnJhbWVMb2Fk UmVxdWVzdCYmIGZyYW1lUmVxdWVzdCwgRXZlbnQqIHRyaWdnZXIKICAgICBpZiAoZnJhbWVSZXF1 ZXN0LmZyYW1lTmFtZSgpLmlzRW1wdHkoKSkKICAgICAgICAgZnJhbWVSZXF1ZXN0LnNldEZyYW1l TmFtZShtX2ZyYW1lLmRvY3VtZW50KCktPmJhc2VUYXJnZXQoKSk7CiAKLSAgICBhZGRIVFRQT3Jp Z2luSWZOZWVkZWQoZnJhbWVSZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLCBvdXRnb2luZ09yaWdp bigpKTsKICAgICBtX2ZyYW1lLmRvY3VtZW50KCktPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpLT51 cGdyYWRlSW5zZWN1cmVSZXF1ZXN0SWZOZWVkZWQoZnJhbWVSZXF1ZXN0LnJlc291cmNlUmVxdWVz dCgpLCBDb250ZW50U2VjdXJpdHlQb2xpY3k6Okluc2VjdXJlUmVxdWVzdFR5cGU6Ok5hdmlnYXRp b24pOwogCiAgICAgbG9hZEZyYW1lUmVxdWVzdChXVEZNb3ZlKGZyYW1lUmVxdWVzdCksIHRyaWdn ZXJpbmdFdmVudCwgeyB9LCBXVEZNb3ZlKGFkQ2xpY2tBdHRyaWJ1dGlvbikpOwpAQCAtMTMzNyw2 ICsxMzM3LDcgQEAgYm9vbCBGcmFtZUxvYWRlcjo6aXNTdG9wTG9hZGluZ0FsbG93ZWQoKSBjb25z dAogdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFVSTChGcmFtZUxvYWRSZXF1ZXN0JiYgZnJhbWVMb2Fk UmVxdWVzdCwgY29uc3QgU3RyaW5nJiByZWZlcnJlciwgRnJhbWVMb2FkVHlwZSBuZXdMb2FkVHlw ZSwgRXZlbnQqIGV2ZW50LCBSZWZQdHI8Rm9ybVN0YXRlPiYmIGZvcm1TdGF0ZSwgT3B0aW9uYWw8 QWRDbGlja0F0dHJpYnV0aW9uPiYmIGFkQ2xpY2tBdHRyaWJ1dGlvbiwgQ29tcGxldGlvbkhhbmRs ZXI8dm9pZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQogewogICAgIEZSQU1FTE9BREVSX1JFTEVB U0VfTE9HX0lGX0FMTE9XRUQoUmVzb3VyY2VMb2FkaW5nLCAibG9hZFVSTDogZnJhbWUgbG9hZCBz dGFydGVkIik7CisgICAgQVNTRVJUKGZyYW1lTG9hZFJlcXVlc3QucmVzb3VyY2VSZXF1ZXN0KCku aHR0cE1ldGhvZCgpID09ICJHRVQiKTsKIAogICAgIENvbXBsZXRpb25IYW5kbGVyQ2FsbGluZ1Nj b3BlIGNvbXBsZXRpb25IYW5kbGVyQ2FsbGVyKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsK ICAgICBpZiAobV9pblN0b3BBbGxMb2FkZXJzIHx8IG1faW5DbGVhclByb3Zpc2lvbmFsTG9hZEZv clBvbGljeUNoZWNrKQpAQCAtMTM1Niw3ICsxMzU3LDYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9h ZFVSTChGcmFtZUxvYWRSZXF1ZXN0JiYgZnJhbWVMb2FkUmVxdWVzdCwgY29uc3QgU3RyaW5nJiBy ZWYKICAgICBpZiAoIXJlZmVycmVyLmlzRW1wdHkoKSkgewogICAgICAgICByZXF1ZXN0LnNldEhU VFBSZWZlcnJlcihyZWZlcnJlcik7CiAgICAgICAgIGF1dG8gcmVmZXJyZXJPcmlnaW4gPSBTZWN1 cml0eU9yaWdpbjo6Y3JlYXRlRnJvbVN0cmluZyhyZWZlcnJlcik7Ci0gICAgICAgIGFkZEhUVFBP cmlnaW5JZk5lZWRlZChyZXF1ZXN0LCByZWZlcnJlck9yaWdpbi0+dG9TdHJpbmcoKSk7CiAgICAg fQogICAgIGlmICgmbV9mcmFtZS50cmVlKCkudG9wKCkgIT0gJm1fZnJhbWUpCiAgICAgICAgIHJl cXVlc3Quc2V0RG9tYWluRm9yQ2FjaGVQYXJ0aXRpb24obV9mcmFtZS50cmVlKCkudG9wKCkuZG9j dW1lbnQoKS0+ZG9tYWluRm9yQ2FjaGVQYXJ0aXRpb24oKSk7CkBAIC00MTAwLDYgKzQxMDAsNyBA QCBib29sIEZyYW1lTG9hZGVyQ2xpZW50OjpoYXNIVE1MVmlldygpIGNvbnN0CiBSZWZQdHI8RnJh bWU+IGNyZWF0ZVdpbmRvdyhGcmFtZSYgb3BlbmVyRnJhbWUsIEZyYW1lJiBsb29rdXBGcmFtZSwg RnJhbWVMb2FkUmVxdWVzdCYmIHJlcXVlc3QsIGNvbnN0IFdpbmRvd0ZlYXR1cmVzJiBmZWF0dXJl cywgYm9vbCYgY3JlYXRlZCkKIHsKICAgICBBU1NFUlQoIWZlYXR1cmVzLmRpYWxvZyB8fCByZXF1 ZXN0LmZyYW1lTmFtZSgpLmlzRW1wdHkoKSk7CisgICAgQVNTRVJUKHJlcXVlc3QucmVzb3VyY2VS ZXF1ZXN0KCkuaHR0cE1ldGhvZCgpID09ICJHRVQiKTsKIAogICAgIGNyZWF0ZWQgPSBmYWxzZTsK IApAQCAtNDEyOCw3ICs0MTI5LDYgQEAgUmVmUHRyPEZyYW1lPiBjcmVhdGVXaW5kb3coRnJhbWUm IG9wZW5lckZyYW1lLCBGcmFtZSYgbG9va3VwRnJhbWUsIEZyYW1lTG9hZFJlcXUKICAgICBTdHJp bmcgcmVmZXJyZXIgPSBTZWN1cml0eVBvbGljeTo6Z2VuZXJhdGVSZWZlcnJlckhlYWRlcihvcGVu ZXJGcmFtZS5kb2N1bWVudCgpLT5yZWZlcnJlclBvbGljeSgpLCByZXF1ZXN0LnJlc291cmNlUmVx dWVzdCgpLnVybCgpLCBvcGVuZXJGcmFtZS5sb2FkZXIoKS5vdXRnb2luZ1JlZmVycmVyKCkpOwog ICAgIGlmICghcmVmZXJyZXIuaXNFbXB0eSgpKQogICAgICAgICByZXF1ZXN0LnJlc291cmNlUmVx dWVzdCgpLnNldEhUVFBSZWZlcnJlcihyZWZlcnJlcik7Ci0gICAgRnJhbWVMb2FkZXI6OmFkZEhU VFBPcmlnaW5JZk5lZWRlZChyZXF1ZXN0LnJlc291cmNlUmVxdWVzdCgpLCBvcGVuZXJGcmFtZS5s b2FkZXIoKS5vdXRnb2luZ09yaWdpbigpKTsKICAgICBGcmFtZUxvYWRlcjo6YWRkSFRUUFVwZ3Jh ZGVJbnNlY3VyZVJlcXVlc3RzSWZOZWVkZWQocmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKSk7CiAg ICAgRnJhbWVMb2FkZXI6OmFkZFNhbWVTaXRlSW5mb1RvUmVxdWVzdElmTmVlZGVkKHJlcXVlc3Qu cmVzb3VyY2VSZXF1ZXN0KCksIG9wZW5lckZyYW1lLmRvY3VtZW50KCkpOwogCg== 394865 2020-03-29 06:10:38 -0700 2020-03-29 10:34:23 -0700 Patch bug-209127-20200329151037.patch text/plain 1532 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y1YTg5YjA2NThjZWJj YTA3Y2Y0ZjgyNzJmZTNkYTJmZjI0MTFmMi4uMGJiOWQwZDZhYTM1OTE2YTE3NmQ0MDhjZjAyNmUx MTdlZjNjYjBjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTI5ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFkZEhUVFBPcmlnaW5J Zk5lZWRlZCBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA5MTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIHVudXNlZCBjb2RlLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkVVJMKToKKwogMjAyMC0w My0yOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdpbmRv d3MgYnVpbGQgZml4OiBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IGVkaXRpbmcgY29va2llIGtleS92 YWx1ZXMgZnJvbSBpbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmlu ZGV4IDZlYmRlNTBkZjlmOTI3OTNmMzY2MjJmODU2MjY1M2JkNTVjOTAwZmYuLmVlODQzMGJlM2Y1 MWVlNTZhN2I5M2Q0OWQ2YThkOThkMDljOWUyYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1l TG9hZGVyLmNwcApAQCAtMTM1NCwxMCArMTM1NCw5IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmxvYWRV UkwoRnJhbWVMb2FkUmVxdWVzdCYmIGZyYW1lTG9hZFJlcXVlc3QsIGNvbnN0IFN0cmluZyYgcmVm CiAKICAgICBjb25zdCBVUkwmIG5ld1VSTCA9IGZyYW1lTG9hZFJlcXVlc3QucmVzb3VyY2VSZXF1 ZXN0KCkudXJsKCk7CiAgICAgUmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QobmV3VVJMKTsKLSAgICBp ZiAoIXJlZmVycmVyLmlzRW1wdHkoKSkgeworICAgIGlmICghcmVmZXJyZXIuaXNFbXB0eSgpKQog ICAgICAgICByZXF1ZXN0LnNldEhUVFBSZWZlcnJlcihyZWZlcnJlcik7Ci0gICAgICAgIGF1dG8g cmVmZXJyZXJPcmlnaW4gPSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbVN0cmluZyhyZWZlcnJl cik7Ci0gICAgfQorCiAgICAgaWYgKCZtX2ZyYW1lLnRyZWUoKS50b3AoKSAhPSAmbV9mcmFtZSkK ICAgICAgICAgcmVxdWVzdC5zZXREb21haW5Gb3JDYWNoZVBhcnRpdGlvbihtX2ZyYW1lLnRyZWUo KS50b3AoKS5kb2N1bWVudCgpLT5kb21haW5Gb3JDYWNoZVBhcnRpdGlvbigpKTsKIAo=