20912 2008-09-18 04:02:36 -0700 Use simple int32 multiplication on op_mul if it is possible 2008-10-15 02:36:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 1 loki webkit-unassigned abarth zwarich oldest_to_newest 91617 0 loki 2008-09-18 04:02:36 -0700 We can use int32 multiplication instead of double one on op_mul if both operands are immediate and they are between 0 - 0x7FFFF. 91619 1 23525 loki 2008-09-18 04:04:42 -0700 Created attachment 23525 int32 multiplication on op_mul 91620 2 23526 loki 2008-09-18 04:09:49 -0700 Created attachment 23526 SunSpider, V8 results (rev 36540) The progression is 2.5% on SunSpider, and 7.8% on V8. Would someone be so kind to measure it on Mac (without CTI)? 91725 3 23525 mjs 2008-09-18 23:23:51 -0700 Comment on attachment 23525 int32 multiplication on op_mul r=me 92901 4 23846 loki 2008-09-26 03:52:11 -0700 Created attachment 23846 int32 multiplication on op_mul (v2) The previous patch has a review+ flag for a week, but nobody landed. So, I have did a small tweak and updated the patch. The current results are the followings: SunSpider: 1.5% speedup, V8: 8.7% speedup 92937 5 23846 mjs 2008-09-26 09:20:28 -0700 Comment on attachment 23846 int32 multiplication on op_mul (v2) r=me (again) 95261 6 abarth 2008-10-14 01:30:03 -0700 Will land v2. This is a bit outside of my area of expertise but looks self-contained. Please stop me if I'm overstepping. 95273 7 abarth 2008-10-14 03:01:06 -0700 My Mac Mini died in the middle of testing this patch. I'm going to take it into the store tomorrow. 95333 8 abarth 2008-10-14 12:27:48 -0700 It's going to be a week before I get my Mac Mini back. Unassigning. This patch needs to be tweaked before landing, but the changes are obvious. 95348 9 23846 zwarich 2008-10-14 13:30:14 -0700 Comment on attachment 23846 int32 multiplication on op_mul (v2) If I try this patch on ToT (with r and exec changed to callFrame), I get 168 JSC test regressions. 95349 10 zwarich 2008-10-14 13:31:48 -0700 Any new version of this patch should also use C++ style casts instead of C style casts. 95387 11 loki 2008-10-15 01:30:43 -0700 > If I try this patch on ToT (with r and exec changed to callFrame), I get 168 > JSC test regressions. It can't be. I guess you forgot to update VPC's statement. I will send the updated patch and its results on Qt-linux soon. 95388 12 24354 loki 2008-10-15 02:13:30 -0700 Created attachment 24354 int32 multiplication on op_mul (v3) Here is the updated patch on ToT. No new regression in JSC tests. 95389 13 24355 loki 2008-10-15 02:15:48 -0700 Created attachment 24355 SunSpider, V8 results (rev 37601) The progression is 3.1% on SunSpider, and 10.6% on V8 (on Qt-linux). 95390 14 24354 zwarich 2008-10-15 02:24:21 -0700 Comment on attachment 24354 int32 multiplication on op_mul (v3) r=me 95391 15 zwarich 2008-10-15 02:36:47 -0700 Landed in r37602. Sorry about that, I should have been able to restructure the patch myself. 23525 2008-09-18 04:04:42 -0700 2008-10-14 13:29:44 -0700 int32 multiplication on op_mul op_mul_int32.patch text/plain 1628 loki SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2NjEzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDktMTggIEdhYm9yIExv a2kgIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwOTEyPgorICAgICAgICBVc2Ugc2ltcGxlIHVpbnQzMl90IG11bHRpcGxpY2F0aW9uIG9u IG9wX211bCBpZiBib3RoIG9wZXJhbmRzIGFyZQorICAgICAgICBpbW1lZGlhdGUgbnVtYmVyIGFu ZCB0aGV5IGFyZSBiZXR3ZWVuIHplcm8gYW5kIDB4N0ZGRi4KKworICAgICAgICAqIFZNL01hY2hp bmUuY3BwOgorICAgICAgICAoSlNDOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6CisKIDIwMDgt MDktMTggIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9W TS9NYWNoaW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9WTS9NYWNoaW5lLmNw cAkocmV2aXNpb24gMzY1NDApCisrKyBKYXZhU2NyaXB0Q29yZS9WTS9NYWNoaW5lLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTgxNCw2ICsxODE0LDE2IEBAIEpTVmFsdWUqIE1hY2hpbmU6OnByaXZh dGVFeGVjdXRlKEV4ZWN1dGkKICAgICAgICAgSlNWYWx1ZSogc3JjMiA9IHJbKCsrdlBDKS0+dS5v cGVyYW5kXS5qc1ZhbHVlKGV4ZWMpOwogICAgICAgICBkb3VibGUgbGVmdDsKICAgICAgICAgZG91 YmxlIHJpZ2h0OworICAgICAgICBpZiAoSlNJbW1lZGlhdGU6OmFyZUJvdGhJbW1lZGlhdGVOdW1i ZXJzKHNyYzEsIHNyYzIpKSB7CisgICAgICAgICAgICBpbnQzMl90IGxlZnQgPSBKU0ltbWVkaWF0 ZTo6Z2V0VHJ1bmNhdGVkSW50MzIoc3JjMSk7CisgICAgICAgICAgICBpbnQzMl90IHJpZ2h0ID0g SlNJbW1lZGlhdGU6OmdldFRydW5jYXRlZEludDMyKHNyYzIpOworICAgICAgICAgICAgaWYgKGxl ZnQgPj4gMTUgPT0gMCAmJiByaWdodCA+PiAxNSA9PSAwKQorICAgICAgICAgICAgICAgIHJbZHN0 XSA9IGpzTnVtYmVyKGV4ZWMsIGxlZnQgKiByaWdodCk7CisgICAgICAgICAgICBlbHNlCisgICAg ICAgICAgICAgICAgcltkc3RdID0ganNOdW1iZXIoZXhlYywgKGRvdWJsZSlsZWZ0ICogKGRvdWJs ZSlyaWdodCk7CisgICAgICAgICAgICArK3ZQQzsKKyAgICAgICAgICAgIE5FWFRfT1BDT0RFOwor ICAgICAgICB9CiAgICAgICAgIGlmIChmYXN0SXNOdW1iZXIoc3JjMSwgbGVmdCkgJiYgZmFzdElz TnVtYmVyKHNyYzIsIHJpZ2h0KSkKICAgICAgICAgICAgIHJbZHN0XSA9IGpzTnVtYmVyKGV4ZWMs IGxlZnQgKiByaWdodCk7CiAgICAgICAgIGVsc2Ugewo= 23526 2008-09-18 04:09:49 -0700 2008-10-15 02:13:30 -0700 SunSpider, V8 results (rev 36540) SunSpider_op_mul_36540.txt text/plain 4538 loki ClRFU1QgICAgICAgICAgICAgICAgICAgQ09NUEFSSVNPTiAgICAgICAgICAgIEZST00gICAgICAg ICAgICAgICAgIFRPICAgICAgICAgICAgIERFVEFJTFMKCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Cgoq KiBUT1RBTCAqKjogICAgICAgICAgIDEuMDI1eCBhcyBmYXN0ICAgIDIyNDEuNm1zICsvLSAwLjIl ICAgMjE4Ny4wbXMgKy8tIDAuNCUgICAgIHNpZ25pZmljYW50Cgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQoKICAzZDogICAgICAgICAgICAgICAgICAxLjA1OHggYXMgZmFzdCAgICAgMzY2LjVtcyArLy0g MC40JSAgICAzNDYuM21zICsvLSAwLjQlICAgICBzaWduaWZpY2FudAogICAgY3ViZTogICAgICAg ICAgICAgIC0gICAgICAgICAgICAgICAgICAxMTIuNW1zICsvLSAwLjclICAgIDExMS45bXMgKy8t IDAuOCUgCiAgICBtb3JwaDogICAgICAgICAgICAgMS4xNDl4IGFzIGZhc3QgICAgIDE0OC43bXMg Ky8tIDAuOSUgICAgMTI5LjRtcyArLy0gMC45JSAgICAgc2lnbmlmaWNhbnQKICAgIHJheXRyYWNl OiAgICAgICAgICAtICAgICAgICAgICAgICAgICAgMTA1LjNtcyArLy0gMC4zJSAgICAxMDUuMG1z ICsvLSAwLjMlIAoKICBhY2Nlc3M6ICAgICAgICAgICAgICAxLjAyOHggYXMgZmFzdCAgICAgMjg0 LjNtcyArLy0gMC45JSAgICAyNzYuNW1zICsvLSAwLjMlICAgICBzaWduaWZpY2FudAogICAgYmlu YXJ5LXRyZWVzOiAgICAgIDEuMDY5eCBhcyBmYXN0ICAgICAgMzEuMW1zICsvLSAxLjclICAgICAy OS4xbXMgKy8tIDAuOCUgICAgIHNpZ25pZmljYW50CiAgICBmYW5ua3VjaDogICAgICAgICAgMS4w MTN4IGFzIGZhc3QgICAgICA5MC44bXMgKy8tIDAuMyUgICAgIDg5LjZtcyArLy0gMC40JSAgICAg c2lnbmlmaWNhbnQKICAgIG5ib2R5OiAgICAgICAgICAgICAxLjAzMnggYXMgZmFzdCAgICAgMTM3 LjRtcyArLy0gMS45JSAgICAxMzMuMW1zICsvLSAwLjIlICAgICBzaWduaWZpY2FudAogICAgbnNp ZXZlOiAgICAgICAgICAgIDEuMDEyeCBhcyBmYXN0ICAgICAgMjUuMG1zICsvLSAwLjAlICAgICAy NC43bXMgKy8tIDIuMCUgICAgIHNpZ25pZmljYW50CgogIGJpdG9wczogICAgICAgICAgICAgIDEu MDIzeCBhcyBmYXN0ICAgICAxNTguN21zICsvLSAwLjQlICAgIDE1NS4xbXMgKy8tIDAuNiUgICAg IHNpZ25pZmljYW50CiAgICAzYml0LWJpdHMtaW4tYnl0ZTogLSAgICAgICAgICAgICAgICAgICAy OS4ybXMgKy8tIDEuMCUgICAgIDI4LjltcyArLy0gMS40JSAKICAgIGJpdHMtaW4tYnl0ZTogICAg ICA/PyAgICAgICAgICAgICAgICAgIDM0LjVtcyArLy0gMS4xJSAgICAgMzQuNm1zICsvLSAxLjQl ICAgICBub3QgY29uY2x1c2l2ZTogbWlnaHQgYmUgKjEuMDAzeCBhcyBzbG93KgogICAgYml0d2lz ZS1hbmQ6ICAgICAgIC0gICAgICAgICAgICAgICAgICAgMjkuMm1zICsvLSAxLjAlICAgICAyOS4y bXMgKy8tIDMuNCUgCiAgICBuc2lldmUtYml0czogICAgICAgMS4wNTR4IGFzIGZhc3QgICAgICA2 NS44bXMgKy8tIDAuNSUgICAgIDYyLjRtcyArLy0gMC42JSAgICAgc2lnbmlmaWNhbnQKCiAgY29u dHJvbGZsb3c6ICAgICAgICAgKjEuMDIweCBhcyBzbG93KiAgICAyNC44bXMgKy8tIDEuMiUgICAg IDI1LjNtcyArLy0gMS40JSAgICAgc2lnbmlmaWNhbnQKICAgIHJlY3Vyc2l2ZTogICAgICAgICAq MS4wMjB4IGFzIHNsb3cqICAgIDI0LjhtcyArLy0gMS4yJSAgICAgMjUuM21zICsvLSAxLjQlICAg ICBzaWduaWZpY2FudAoKICBjcnlwdG86ICAgICAgICAgICAgICAxLjAyM3ggYXMgZmFzdCAgICAg MTQwLjFtcyArLy0gMC42JSAgICAxMzYuOW1zICsvLSAwLjQlICAgICBzaWduaWZpY2FudAogICAg YWVzOiAgICAgICAgICAgICAgIDEuMDQ4eCBhcyBmYXN0ICAgICAgNDYuM21zICsvLSAwLjclICAg ICA0NC4ybXMgKy8tIDAuNyUgICAgIHNpZ25pZmljYW50CiAgICBtZDU6ICAgICAgICAgICAgICAg MS4wMTV4IGFzIGZhc3QgICAgICA0Ny4ybXMgKy8tIDEuMCUgICAgIDQ2LjVtcyArLy0gMC44JSAg ICAgc2lnbmlmaWNhbnQKICAgIHNoYTE6ICAgICAgICAgICAgICAtICAgICAgICAgICAgICAgICAg IDQ2LjZtcyArLy0gMS4xJSAgICAgNDYuMm1zICsvLSAwLjclIAoKICBkYXRlOiAgICAgICAgICAg ICAgICAxLjAyNXggYXMgZmFzdCAgICAgMTYyLjNtcyArLy0gMC40JSAgICAxNTguNG1zICsvLSAw LjYlICAgICBzaWduaWZpY2FudAogICAgZm9ybWF0LXRvZnRlOiAgICAgIC0gICAgICAgICAgICAg ICAgICAgNjkuNW1zICsvLSAwLjUlICAgICA2OS4wbXMgKy8tIDAuNyUgCiAgICBmb3JtYXQteHBh cmI6ICAgICAgMS4wMzh4IGFzIGZhc3QgICAgICA5Mi44bXMgKy8tIDAuOSUgICAgIDg5LjRtcyAr Ly0gMC45JSAgICAgc2lnbmlmaWNhbnQKCiAgbWF0aDogICAgICAgICAgICAgICAgMS4wNTJ4IGFz IGZhc3QgICAgIDI4OC4zbXMgKy8tIDAuMyUgICAgMjc0LjBtcyArLy0gMC41JSAgICAgc2lnbmlm aWNhbnQKICAgIGNvcmRpYzogICAgICAgICAgICAxLjAxMnggYXMgZmFzdCAgICAgMTAwLjFtcyAr Ly0gMC43JSAgICAgOTguOW1zICsvLSAwLjUlICAgICBzaWduaWZpY2FudAogICAgcGFydGlhbC1z dW1zOiAgICAgIDEuMDI2eCBhcyBmYXN0ICAgICAxMTkuOW1zICsvLSAwLjMlICAgIDExNi45bXMg Ky8tIDAuOSUgICAgIHNpZ25pZmljYW50CiAgICBzcGVjdHJhbC1ub3JtOiAgICAgMS4xNzR4IGFz IGZhc3QgICAgICA2OC4zbXMgKy8tIDAuNSUgICAgIDU4LjJtcyArLy0gMC41JSAgICAgc2lnbmlm aWNhbnQKCiAgcmVnZXhwOiAgICAgICAgICAgICAgPz8gICAgICAgICAgICAgICAgIDMwNS42bXMg Ky8tIDAuMyUgICAgMzA2LjhtcyArLy0gMS4zJSAgICAgbm90IGNvbmNsdXNpdmU6IG1pZ2h0IGJl ICoxLjAwNHggYXMgc2xvdyoKICAgIGRuYTogICAgICAgICAgICAgICA/PyAgICAgICAgICAgICAg ICAgMzA1LjZtcyArLy0gMC4zJSAgICAzMDYuOG1zICsvLSAxLjMlICAgICBub3QgY29uY2x1c2l2 ZTogbWlnaHQgYmUgKjEuMDA0eCBhcyBzbG93KgoKICBzdHJpbmc6ICAgICAgICAgICAgICAtICAg ICAgICAgICAgICAgICAgNTExLjBtcyArLy0gMC42JSAgICA1MDcuN21zICsvLSAwLjglIAogICAg YmFzZTY0OiAgICAgICAgICAgID8/ICAgICAgICAgICAgICAgICAgNDYuOG1zICsvLSAxLjAlICAg ICA0Ny4xbXMgKy8tIDEuMSUgICAgIG5vdCBjb25jbHVzaXZlOiBtaWdodCBiZSAqMS4wMDZ4IGFz IHNsb3cqCiAgICBmYXN0YTogICAgICAgICAgICAgMS4wMTV4IGFzIGZhc3QgICAgICA5Mi40bXMg Ky8tIDAuNyUgICAgIDkxLjBtcyArLy0gMC42JSAgICAgc2lnbmlmaWNhbnQKICAgIHRhZ2Nsb3Vk OiAgICAgICAgICAtICAgICAgICAgICAgICAgICAgMTY0LjFtcyArLy0gMC45JSAgICAxNjMuMW1z ICsvLSAxLjIlIAogICAgdW5wYWNrLWNvZGU6ICAgICAgIC0gICAgICAgICAgICAgICAgICAxMjgu NW1zICsvLSAwLjclICAgIDEyNy4zbXMgKy8tIDAuOSUgCiAgICB2YWxpZGF0ZS1pbnB1dDogICAg LSAgICAgICAgICAgICAgICAgICA3OS4ybXMgKy8tIDEuMyUgICAgIDc5LjJtcyArLy0gMS4xJSAK CgpURVNUICAgICAgICAgICAgICBDT01QQVJJU09OICAgICAgICAgICAgRlJPTSAgICAgICAgICAg ICAgICAgVE8gICAgICAgICAgICAgREVUQUlMUwoKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KCioqIFRP VEFMICoqOiAgICAgIDEuMDc4eCBhcyBmYXN0ICAgIDEyNDczLjdtcyArLy0gMC42JSAgIDExNTY5 LjdtcyArLy0gMC40JSAgICAgc2lnbmlmaWNhbnQKCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CgogIHY4 OiAgICAgICAgICAgICAxLjA3OHggYXMgZmFzdCAgICAxMjQ3My43bXMgKy8tIDAuNiUgICAxMTU2 OS43bXMgKy8tIDAuNCUgICAgIHNpZ25pZmljYW50CiAgICBjcnlwdG86ICAgICAgIDEuMzd4IGFz IGZhc3QgICAgICAzMTAzLjFtcyArLy0gMC4zJSAgICAyMjY3LjhtcyArLy0gMC4yJSAgICAgc2ln bmlmaWNhbnQKICAgIGRlbHRhYmx1ZTogICAgLSAgICAgICAgICAgICAgICAgIDI4NTkuMm1zICsv LSAxLjclICAgIDI4MTYuMG1zICsvLSAwLjUlIAogICAgZWFybGV5LWJveWVyOiAtICAgICAgICAg ICAgICAgICAgMTExMS4zbXMgKy8tIDAuOCUgICAgMTEwOC41bXMgKy8tIDEuMSUgCiAgICByYXl0 cmFjZTogICAgIDEuMDE3eCBhcyBmYXN0ICAgICAyNDE1LjVtcyArLy0gMS4xJSAgICAyMzc1LjRt cyArLy0gMS4zJSAgICAgc2lnbmlmaWNhbnQKICAgIHJpY2hhcmRzOiAgICAgPz8gICAgICAgICAg ICAgICAgIDI5ODQuNm1zICsvLSAxLjElICAgIDMwMDIuMG1zICsvLSAwLjQlICAgICBub3QgY29u Y2x1c2l2ZTogbWlnaHQgYmUgKjEuMDA2eCBhcyBzbG93Kgo= 23846 2008-09-26 03:52:11 -0700 2008-10-15 02:13:30 -0700 int32 multiplication on op_mul (v2) op_mul_int32.patch text/plain 1570 loki SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2OTUxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDktMjYgIEdhYm9yIExv a2kgIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwOTEyPgorICAgICAgICBVc2Ugc2ltcGxlIHVpbnQzMl90IG11bHRpcGxpY2F0aW9uIG9u IG9wX211bCBpZiBib3RoIG9wZXJhbmRzIGFyZQorICAgICAgICBpbW1lZGlhdGUgbnVtYmVyIGFu ZCB0aGV5IGFyZSBiZXR3ZWVuIHplcm8gYW5kIDB4N0ZGRi4KKworICAgICAgICAqIFZNL01hY2hp bmUuY3BwOgorICAgICAgICAoSlNDOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6CisKIDIwMDgt MDktMjQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL1ZNL01hY2hp bmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL1ZNL01hY2hpbmUuY3BwCShyZXZp c2lvbiAzNjk0NikKKysrIEphdmFTY3JpcHRDb3JlL1ZNL01hY2hpbmUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xODU0LDYgKzE4NTQsMTYgQEAKICAgICAgICAgSlNWYWx1ZSogc3JjMiA9IHJbKCsr dlBDKS0+dS5vcGVyYW5kXS5qc1ZhbHVlKGV4ZWMpOwogICAgICAgICBkb3VibGUgbGVmdDsKICAg ICAgICAgZG91YmxlIHJpZ2h0OworICAgICAgICBpZiAoSlNJbW1lZGlhdGU6OmFyZUJvdGhJbW1l ZGlhdGVOdW1iZXJzKHNyYzEsIHNyYzIpKSB7CisgICAgICAgICAgICBpbnQzMl90IGxlZnQgPSBK U0ltbWVkaWF0ZTo6Z2V0VHJ1bmNhdGVkSW50MzIoc3JjMSk7CisgICAgICAgICAgICBpbnQzMl90 IHJpZ2h0ID0gSlNJbW1lZGlhdGU6OmdldFRydW5jYXRlZEludDMyKHNyYzIpOworICAgICAgICAg ICAgaWYgKChsZWZ0IHwgcmlnaHQpID4+IDE1ID09IDApCisgICAgICAgICAgICAgICAgcltkc3Rd ID0ganNOdW1iZXIoZXhlYywgbGVmdCAqIHJpZ2h0KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICByW2RzdF0gPSBqc051bWJlcihleGVjLCAoZG91YmxlKWxlZnQgKiAoZG91Ymxl KXJpZ2h0KTsKKyAgICAgICAgICAgICsrdlBDOworICAgICAgICAgICAgTkVYVF9PUENPREU7Cisg ICAgICAgIH0KICAgICAgICAgaWYgKGZhc3RJc051bWJlcihzcmMxLCBsZWZ0KSAmJiBmYXN0SXNO dW1iZXIoc3JjMiwgcmlnaHQpKQogICAgICAgICAgICAgcltkc3RdID0ganNOdW1iZXIoZXhlYywg bGVmdCAqIHJpZ2h0KTsKICAgICAgICAgZWxzZSB7Cg== 24354 2008-10-15 02:13:30 -0700 2008-10-15 02:24:21 -0700 int32 multiplication on op_mul (v3) int32_mul.patch text/plain 1766 loki SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3NjAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMTUgIEdhYm9yIExv a2kgIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwOTEyPgorICAgICAgICBVc2Ugc2ltcGxlIHVpbnQzMl90IG11bHRpcGxpY2F0aW9uIG9u IG9wX211bCBpZiBib3RoIG9wZXJhbmRzIGFyZQorICAgICAgICBpbW1lZGlhdGUgbnVtYmVyIGFu ZCB0aGV5IGFyZSBiZXR3ZWVuIHplcm8gYW5kIDB4N0ZGRi4KKworICAgICAgICAqIFZNL01hY2hp bmUuY3BwOgorICAgICAgICAoSlNDOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6CisKIDIwMDgt MTAtMDkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogSmF2YVNjcmlwdENvcmUvVk0vTWFjaGluZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvVk0vTWFjaGluZS5jcHAJKHJldmlzaW9uIDM3 NjAxKQorKysgSmF2YVNjcmlwdENvcmUvVk0vTWFjaGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE4NjQsNyArMTg2NCwxNCBAQAogICAgICAgICBKU1ZhbHVlKiBzcmMyID0gY2FsbEZyYW1lWygr K3ZQQyktPnUub3BlcmFuZF0uanNWYWx1ZShjYWxsRnJhbWUpOwogICAgICAgICBkb3VibGUgbGVm dDsKICAgICAgICAgZG91YmxlIHJpZ2h0OwotICAgICAgICBpZiAoZmFzdElzTnVtYmVyKHNyYzEs IGxlZnQpICYmIGZhc3RJc051bWJlcihzcmMyLCByaWdodCkpCisgICAgICAgIGlmIChKU0ltbWVk aWF0ZTo6YXJlQm90aEltbWVkaWF0ZU51bWJlcnMoc3JjMSwgc3JjMikpIHsKKyAgICAgICAgICAg IGludDMyX3QgbGVmdCA9IEpTSW1tZWRpYXRlOjpnZXRUcnVuY2F0ZWRJbnQzMihzcmMxKTsKKyAg ICAgICAgICAgIGludDMyX3QgcmlnaHQgPSBKU0ltbWVkaWF0ZTo6Z2V0VHJ1bmNhdGVkSW50MzIo c3JjMik7CisgICAgICAgICAgICBpZiAoKGxlZnQgfCByaWdodCkgPj4gMTUgPT0gMCkKKyAgICAg ICAgICAgICAgICBjYWxsRnJhbWVbZHN0XSA9IGpzTnVtYmVyKGNhbGxGcmFtZSwgbGVmdCAqIHJp Z2h0KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBjYWxsRnJhbWVbZHN0XSA9 IGpzTnVtYmVyKGNhbGxGcmFtZSwgc3RhdGljX2Nhc3Q8ZG91YmxlPihsZWZ0KSAqIHN0YXRpY19j YXN0PGRvdWJsZT4ocmlnaHQpKTsKKyAgICAgICAgfSBlbHNlIGlmIChmYXN0SXNOdW1iZXIoc3Jj MSwgbGVmdCkgJiYgZmFzdElzTnVtYmVyKHNyYzIsIHJpZ2h0KSkKICAgICAgICAgICAgIGNhbGxG cmFtZVtkc3RdID0ganNOdW1iZXIoY2FsbEZyYW1lLCBsZWZ0ICogcmlnaHQpOwogICAgICAgICBl bHNlIHsKICAgICAgICAgICAgIEpTVmFsdWUqIHJlc3VsdCA9IGpzTnVtYmVyKGNhbGxGcmFtZSwg c3JjMS0+dG9OdW1iZXIoY2FsbEZyYW1lKSAqIHNyYzItPnRvTnVtYmVyKGNhbGxGcmFtZSkpOwo= 24355 2008-10-15 02:15:48 -0700 2008-10-15 02:15:48 -0700 SunSpider, V8 results (rev 37601) SunSpider-int32-mul.txt text/plain 4492 loki VEVTVCAgICAgICAgICAgICAgICAgICBDT01QQVJJU09OICAgICAgICAgICAgRlJPTSAgICAgICAg ICAgICAgICAgVE8gICAgICAgICAgICAgREVUQUlMUwoKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KCioq IFRPVEFMICoqOiAgICAgICAgICAgMS4wMzF4IGFzIGZhc3QgICAgMjUwMi43bXMgKy8tIDAuNiUg ICAyNDI3LjVtcyArLy0gMC42JSAgICAgc2lnbmlmaWNhbnQKCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 CgogIDNkOiAgICAgICAgICAgICAgICAgIDEuMDYxeCBhcyBmYXN0ICAgICA0MjQuNm1zICsvLSAw LjglICAgIDQwMC4ybXMgKy8tIDAuNyUgICAgIHNpZ25pZmljYW50CiAgICBjdWJlOiAgICAgICAg ICAgICAgMS4wMjN4IGFzIGZhc3QgICAgIDEzNy43bXMgKy8tIDAuNCUgICAgMTM0LjZtcyArLy0g MC42JSAgICAgc2lnbmlmaWNhbnQKICAgIG1vcnBoOiAgICAgICAgICAgICAxLjEyOXggYXMgZmFz dCAgICAgMTY3LjhtcyArLy0gMS43JSAgICAxNDguNm1zICsvLSAxLjklICAgICBzaWduaWZpY2Fu dAogICAgcmF5dHJhY2U6ICAgICAgICAgIDEuMDE4eCBhcyBmYXN0ICAgICAxMTkuMW1zICsvLSAw LjUlICAgIDExNy4wbXMgKy8tIDAuNCUgICAgIHNpZ25pZmljYW50CgogIGFjY2VzczogICAgICAg ICAgICAgIDEuMDQxeCBhcyBmYXN0ICAgICAzNTkuNW1zICsvLSAwLjMlICAgIDM0NS40bXMgKy8t IDAuNCUgICAgIHNpZ25pZmljYW50CiAgICBiaW5hcnktdHJlZXM6ICAgICAgMS4wNjV4IGFzIGZh c3QgICAgICAzMi43bXMgKy8tIDEuMSUgICAgIDMwLjdtcyArLy0gMS42JSAgICAgc2lnbmlmaWNh bnQKICAgIGZhbm5rdWNoOiAgICAgICAgICAxLjA0M3ggYXMgZmFzdCAgICAgMTMxLjRtcyArLy0g MC41JSAgICAxMjYuMG1zICsvLSAwLjMlICAgICBzaWduaWZpY2FudAogICAgbmJvZHk6ICAgICAg ICAgICAgIDEuMDMxeCBhcyBmYXN0ICAgICAxNTkuNm1zICsvLSAwLjIlICAgIDE1NC44bXMgKy8t IDAuNyUgICAgIHNpZ25pZmljYW50CiAgICBuc2lldmU6ICAgICAgICAgICAgMS4wNTZ4IGFzIGZh c3QgICAgICAzNS44bXMgKy8tIDEuMyUgICAgIDMzLjltcyArLy0gMC43JSAgICAgc2lnbmlmaWNh bnQKCiAgYml0b3BzOiAgICAgICAgICAgICAgMS4wNDR4IGFzIGZhc3QgICAgIDIxNi4zbXMgKy8t IDAuNSUgICAgMjA3LjFtcyArLy0gMC40JSAgICAgc2lnbmlmaWNhbnQKICAgIDNiaXQtYml0cy1p bi1ieXRlOiAxLjA2MXggYXMgZmFzdCAgICAgIDM4LjRtcyArLy0gMS4wJSAgICAgMzYuMm1zICsv LSAwLjglICAgICBzaWduaWZpY2FudAogICAgYml0cy1pbi1ieXRlOiAgICAgIDEuMDUxeCBhcyBm YXN0ICAgICAgNDcuM21zICsvLSAwLjclICAgICA0NS4wbXMgKy8tIDAuNyUgICAgIHNpZ25pZmlj YW50CiAgICBiaXR3aXNlLWFuZDogICAgICAgKjEuMDQyeCBhcyBzbG93KiAgICA0MC44bXMgKy8t IDEuMSUgICAgIDQyLjVtcyArLy0gMS42JSAgICAgc2lnbmlmaWNhbnQKICAgIG5zaWV2ZS1iaXRz OiAgICAgICAxLjA3N3ggYXMgZmFzdCAgICAgIDg5LjhtcyArLy0gMC42JSAgICAgODMuNG1zICsv LSAwLjQlICAgICBzaWduaWZpY2FudAoKICBjb250cm9sZmxvdzogICAgICAgICAtICAgICAgICAg ICAgICAgICAgIDI1LjltcyArLy0gMC45JSAgICAgMjUuNm1zICsvLSAxLjQlIAogICAgcmVjdXJz aXZlOiAgICAgICAgIC0gICAgICAgICAgICAgICAgICAgMjUuOW1zICsvLSAwLjklICAgICAyNS42 bXMgKy8tIDEuNCUgCgogIGNyeXB0bzogICAgICAgICAgICAgIDEuMDQxeCBhcyBmYXN0ICAgICAx NjQuNG1zICsvLSAwLjQlICAgIDE1OC4wbXMgKy8tIDAuNCUgICAgIHNpZ25pZmljYW50CiAgICBh ZXM6ICAgICAgICAgICAgICAgMS4wNTR4IGFzIGZhc3QgICAgICA1OC4xbXMgKy8tIDAuNCUgICAg IDU1LjFtcyArLy0gMC40JSAgICAgc2lnbmlmaWNhbnQKICAgIG1kNTogICAgICAgICAgICAgICAx LjAyOXggYXMgZmFzdCAgICAgIDUzLjBtcyArLy0gMC45JSAgICAgNTEuNW1zICsvLSAwLjclICAg ICBzaWduaWZpY2FudAogICAgc2hhMTogICAgICAgICAgICAgIDEuMDM3eCBhcyBmYXN0ICAgICAg NTMuM21zICsvLSAwLjYlICAgICA1MS40bXMgKy8tIDAuNyUgICAgIHNpZ25pZmljYW50CgogIGRh dGU6ICAgICAgICAgICAgICAgIC0gICAgICAgICAgICAgICAgICAxNjUuMm1zICsvLSAwLjklICAg IDE2NC4ybXMgKy8tIDEuMSUgCiAgICBmb3JtYXQtdG9mdGU6ICAgICAgMS4wMjR4IGFzIGZhc3Qg ICAgICA3MS41bXMgKy8tIDAuOCUgICAgIDY5LjhtcyArLy0gMC42JSAgICAgc2lnbmlmaWNhbnQK ICAgIGZvcm1hdC14cGFyYjogICAgICA/PyAgICAgICAgICAgICAgICAgIDkzLjdtcyArLy0gMS4w JSAgICAgOTQuNG1zICsvLSAxLjYlICAgICBub3QgY29uY2x1c2l2ZTogbWlnaHQgYmUgKjEuMDA3 eCBhcyBzbG93KgoKICBtYXRoOiAgICAgICAgICAgICAgICAxLjA0MnggYXMgZmFzdCAgICAgMzM0 LjltcyArLy0gMC40JSAgICAzMjEuM21zICsvLSAwLjQlICAgICBzaWduaWZpY2FudAogICAgY29y ZGljOiAgICAgICAgICAgIDEuMDI1eCBhcyBmYXN0ICAgICAxMjMuOG1zICsvLSAwLjclICAgIDEy MC44bXMgKy8tIDAuNSUgICAgIHNpZ25pZmljYW50CiAgICBwYXJ0aWFsLXN1bXM6ICAgICAgMS4w MzF4IGFzIGZhc3QgICAgIDEzNC4zbXMgKy8tIDAuOCUgICAgMTMwLjNtcyArLy0gMC41JSAgICAg c2lnbmlmaWNhbnQKICAgIHNwZWN0cmFsLW5vcm06ICAgICAxLjA5NHggYXMgZmFzdCAgICAgIDc2 LjhtcyArLy0gMC45JSAgICAgNzAuMm1zICsvLSAwLjQlICAgICBzaWduaWZpY2FudAoKICByZWdl eHA6ICAgICAgICAgICAgICAtICAgICAgICAgICAgICAgICAgMzA0LjhtcyArLy0gMC42JSAgICAz MDQuOG1zICsvLSAwLjYlIAogICAgZG5hOiAgICAgICAgICAgICAgIC0gICAgICAgICAgICAgICAg ICAzMDQuOG1zICsvLSAwLjYlICAgIDMwNC44bXMgKy8tIDAuNiUgCgogIHN0cmluZzogICAgICAg ICAgICAgIC0gICAgICAgICAgICAgICAgICA1MDcuMW1zICsvLSAxLjclICAgIDUwMC45bXMgKy8t IDEuNiUgCiAgICBiYXNlNjQ6ICAgICAgICAgICAgLSAgICAgICAgICAgICAgICAgICA1MS41bXMg Ky8tIDEuMyUgICAgIDUwLjdtcyArLy0gMS44JSAKICAgIGZhc3RhOiAgICAgICAgICAgICAxLjA1 NnggYXMgZmFzdCAgICAgIDg4LjdtcyArLy0gMS4zJSAgICAgODQuMG1zICsvLSAxLjElICAgICBz aWduaWZpY2FudAogICAgdGFnY2xvdWQ6ICAgICAgICAgIC0gICAgICAgICAgICAgICAgICAxNjEu Nm1zICsvLSAyLjYlICAgIDE2MS41bXMgKy8tIDIuNSUgCiAgICB1bnBhY2stY29kZTogICAgICAg Pz8gICAgICAgICAgICAgICAgIDEyNi40bXMgKy8tIDEuMCUgICAgMTI2LjdtcyArLy0gMS4zJSAg ICAgbm90IGNvbmNsdXNpdmU6IG1pZ2h0IGJlICoxLjAwMnggYXMgc2xvdyoKICAgIHZhbGlkYXRl LWlucHV0OiAgICAtICAgICAgICAgICAgICAgICAgIDc4LjltcyArLy0gMi43JSAgICAgNzguMG1z ICsvLSAyLjYlIAoKClRFU1QgICAgICAgICAgICAgIENPTVBBUklTT04gICAgICAgICAgICBGUk9N ICAgICAgICAgICAgICAgICBUTyAgICAgICAgICAgICBERVRBSUxTCgo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQoKKiogVE9UQUwgKio6ICAgICAgMS4xMDZ4IGFzIGZhc3QgICAgMTIyNjMuNG1zICsvLSAw LjUlICAgMTEwODQuOG1zICsvLSAwLjUlICAgICBzaWduaWZpY2FudAoKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KCiAgdjg6ICAgICAgICAgICAgIDEuMTA2eCBhcyBmYXN0ICAgIDEyMjYzLjRtcyArLy0g MC41JSAgIDExMDg0LjhtcyArLy0gMC41JSAgICAgc2lnbmlmaWNhbnQKICAgIGNyeXB0bzogICAg ICAgMS4zMXggYXMgZmFzdCAgICAgIDM5NTEuOG1zICsvLSAwLjMlICAgIDMwMjIuNG1zICsvLSAw LjIlICAgICBzaWduaWZpY2FudAogICAgZGVsdGFibHVlOiAgICAxLjAxNnggYXMgZmFzdCAgICAg MjkwNS45bXMgKy8tIDAuNSUgICAgMjg2MS41bXMgKy8tIDAuNiUgICAgIHNpZ25pZmljYW50CiAg ICBlYXJsZXktYm95ZXI6IDEuMDE5eCBhcyBmYXN0ICAgICAxMDc0LjZtcyArLy0gMS4wJSAgICAx MDU0LjJtcyArLy0gMi4yJSAgICAgc2lnbmlmaWNhbnQKICAgIHJheXRyYWNlOiAgICAgMS4wMzR4 IGFzIGZhc3QgICAgICA5NzQuNm1zICsvLSAyLjAlICAgICA5NDIuM21zICsvLSAyLjAlICAgICBz aWduaWZpY2FudAogICAgcmljaGFyZHM6ICAgICAxLjA0N3ggYXMgZmFzdCAgICAgMzM1Ni41bXMg Ky8tIDEuMCUgICAgMzIwNC40bXMgKy8tIDAuNSUgICAgIHNpZ25pZmljYW50Cg==