209071 2020-03-13 11:53:28 -0700 [GPU Process] GraphicsContextStateChange::apply() should process ShadowsIgnoreTransformsChange before processing ShadowChange 2020-03-13 18:29:14 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue darin dino mmaxfield simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1629745 0 sabouhallawa 2020-03-13 11:53:28 -0700 This because GraphicsContext::setPlatformShadow() checks the value of m_state.shadowsIgnoreTransforms. GraphicsContext::setPlatformShadow() is called from GraphicsContextStateChange::apply() via setLegacyShadow() or setShadow() when it detects a ShadowChange. 1629748 1 393512 sabouhallawa 2020-03-13 11:55:53 -0700 Created attachment 393512 Patch 1629755 2 393514 sabouhallawa 2020-03-13 11:58:36 -0700 Created attachment 393514 test case 1629759 3 sabouhallawa 2020-03-13 12:06:11 -0700 Repro steps: 1. Launch mini-browser 2. Enable "Settings/Internal Features/Render Canvas in GPU Process" or "Settings/Enable Display List Drawing". 3. Open the attached test case Result: the test case shows a 100x100 green rectangle Expected: the test case shows a 100x100 green rectangle with its shadow 100x100 red rectangle 1629763 4 sabouhallawa 2020-03-13 12:08:24 -0700 This patch fixes the following test cases when running "run-webkit-tests --internal-feature RenderCanvasInGPUProcessEnabled" fast/canvas/canvas-image-shadow.html fast/canvas/canvas-scale-drawImage-shadow.html fast/canvas/canvas-scale-fillPath-shadow.html fast/canvas/canvas-scale-fillRect-shadow.html fast/canvas/canvas-scale-shadowBlur.html fast/canvas/canvas-transforms-fillRect-shadow.html fast/canvas/fillText-shadow.html 1629768 5 darin 2020-03-13 12:24:58 -0700 (In reply to Said Abou-Hallawa from comment #4) > This patch fixes the following test cases when running "run-webkit-tests > --internal-feature RenderCanvasInGPUProcessEnabled" > > fast/canvas/canvas-image-shadow.html > fast/canvas/canvas-scale-drawImage-shadow.html > fast/canvas/canvas-scale-fillPath-shadow.html > fast/canvas/canvas-scale-fillRect-shadow.html > fast/canvas/canvas-scale-shadowBlur.html > fast/canvas/canvas-transforms-fillRect-shadow.html > fast/canvas/fillText-shadow.html Change log should mention this. 1629886 6 393540 sabouhallawa 2020-03-13 15:32:20 -0700 Created attachment 393540 Patch 1629974 7 393540 commit-queue 2020-03-13 18:28:03 -0700 Comment on attachment 393540 Patch Clearing flags on attachment: 393540 Committed r258454: <https://trac.webkit.org/changeset/258454> 1629975 8 commit-queue 2020-03-13 18:28:05 -0700 All reviewed patches have been landed. Closing bug. 1629976 9 webkit-bug-importer 2020-03-13 18:29:14 -0700 <rdar://problem/60442640> 393512 2020-03-13 11:55:53 -0700 2020-03-13 15:32:18 -0700 Patch bug-209071-20200313115553.patch text/plain 2413 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM5MWJmMmM1MTM1ZDkw MDdhZTQ0OThmMjBmNTU4NzJhNWQwNjg3MS4uMjAxZWFjMWMyMjI0OTliMzhhODNmZWMzZmUxOTVh YWJhNTUwNDEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTEzICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQ cm9jZXNzXSBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZTo6YXBwbHkoKSBzaG91bGQgcHJvY2Vz cyBTaGFkb3dzSWdub3JlVHJhbnNmb3Jtc0NoYW5nZSBiZWZvcmUgcHJvY2Vzc2luZyBTaGFkb3dD aGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTA3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVu c3VyZSBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZTo6YXBwbHkoKSBjYWxscyBzaGFkb3dzSWdu b3JlVHJhbnNmb3JtcygpCisgICAgICAgIGNhbGxpbmcgc2V0TGVnYWN5U2hhZG93KCkgb3Igc2V0 U2hhZG93KCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0U3RhdGVDaGFuZ2U6OmFwcGx5 IGNvbnN0KToKKwogMjAyMC0wMy0xMiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FA YXBwbGUuY29tPgogCiAgICAgICAgIFtHUFUgUHJvY2Vzc10gR3JhcGhpY3NDb250ZXh0U3RhdGVD aGFuZ2UgbXVzdCBhY2N1bXVsYXRlIGZpbGwgYW5kIHN0cm9rZSBmaWVsZHMgYXMgc2luZ2xlIHBy b3BlcnRpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc0NvbnRleHQuY3BwCmluZGV4IDU0MjViNDIyYjY5NzAwOTA3MWUyZWI1NDk2ZGM0MWQxNjk3 N2RlOWYuLjQ5Y2IzOWRiNTYxNTFjM2E1YWE0OGNhYmI1ZDcyY2Y4ZmViMmFiMGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNw cApAQCAtMjAwLDYgKzIwMCw5IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0U3RhdGVDaGFuZ2U6OmFw cGx5KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCkgY29uc3QKICAgICBpZiAobV9jaGFuZ2VGbGFn cy5jb250YWlucyhHcmFwaGljc0NvbnRleHRTdGF0ZTo6RmlsbFBhdHRlcm5DaGFuZ2UpKQogICAg ICAgICBjb250ZXh0LnNldEZpbGxQYXR0ZXJuKCptX3N0YXRlLmZpbGxQYXR0ZXJuKTsKIAorICAg IGlmIChtX2NoYW5nZUZsYWdzLmNvbnRhaW5zKEdyYXBoaWNzQ29udGV4dFN0YXRlOjpTaGFkb3dz SWdub3JlVHJhbnNmb3Jtc0NoYW5nZSkpCisgICAgICAgIGNvbnRleHQuc2V0U2hhZG93c0lnbm9y ZVRyYW5zZm9ybXMobV9zdGF0ZS5zaGFkb3dzSWdub3JlVHJhbnNmb3Jtcyk7CisKICAgICBpZiAo bV9jaGFuZ2VGbGFncy5jb250YWlucyhHcmFwaGljc0NvbnRleHRTdGF0ZTo6U2hhZG93Q2hhbmdl KSkgewogI2lmIFVTRShDRykKICAgICAgICAgaWYgKG1fc3RhdGUuc2hhZG93c1VzZUxlZ2FjeVJh ZGl1cykKQEAgLTI0Miw5ICsyNDUsNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dFN0YXRlQ2hhbmdl OjphcHBseShHcmFwaGljc0NvbnRleHQmIGNvbnRleHQpIGNvbnN0CiAgICAgaWYgKG1fY2hhbmdl RmxhZ3MuY29udGFpbnMoR3JhcGhpY3NDb250ZXh0U3RhdGU6OlNob3VsZFN1YnBpeGVsUXVhbnRp emVGb250c0NoYW5nZSkpCiAgICAgICAgIGNvbnRleHQuc2V0U2hvdWxkU3VicGl4ZWxRdWFudGl6 ZUZvbnRzKG1fc3RhdGUuc2hvdWxkU3VicGl4ZWxRdWFudGl6ZUZvbnRzKTsKIAotICAgIGlmICht X2NoYW5nZUZsYWdzLmNvbnRhaW5zKEdyYXBoaWNzQ29udGV4dFN0YXRlOjpTaGFkb3dzSWdub3Jl VHJhbnNmb3Jtc0NoYW5nZSkpCi0gICAgICAgIGNvbnRleHQuc2V0U2hhZG93c0lnbm9yZVRyYW5z Zm9ybXMobV9zdGF0ZS5zaGFkb3dzSWdub3JlVHJhbnNmb3Jtcyk7Ci0KICAgICBpZiAobV9jaGFu Z2VGbGFncy5jb250YWlucyhHcmFwaGljc0NvbnRleHRTdGF0ZTo6RHJhd0x1bWluYW5jZU1hc2tD aGFuZ2UpKQogICAgICAgICBjb250ZXh0LnNldERyYXdMdW1pbmFuY2VNYXNrKG1fc3RhdGUuZHJh d0x1bWluYW5jZU1hc2spOwogCg== 393514 2020-03-13 11:58:36 -0700 2020-03-13 11:58:36 -0700 test case canvas-004.html text/html 523 sabouhallawa PHN0eWxlPgogICBjYW52YXMgewogICAgICAgd2lkdGg6IDIwMHB4OwogICAgICAgaGVpZ2h0OiAy MDBweDsKICAgICAgIGJvcmRlcjogMXB4IHNvbGlkOwogICB9Cjwvc3R5bGU+Cjxib2R5PgogICAg PGNhbnZhcyBpZD0ibXlDYW52YXMiPjwvY2FudmFzPgogICAgPHNjcmlwdD4KICAgICAgICB2YXIg Y2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ215Q2FudmFzJyk7CiAgICAgICAgdmFy IGN0eCA9IGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpOwogICAgICAgIGN0eC5zaGFkb3dPZmZzZXRY ID0gY2FudmFzLndpZHRoIC8gMjsKICAgICAgICBjdHguc2hhZG93T2Zmc2V0WSA9IGNhbnZhcy5o ZWlnaHQgLyAyOwogICAgICAgIGN0eC5maWxsU3R5bGUgPSAiZ3JlZW4iOwogICAgICAgIGN0eC5z aGFkb3dDb2xvciA9ICdyZ2JhKDI1NSwgMCwgMCwgMS4wKSc7CiAgICAgICAgY3R4LmZpbGxSZWN0 KDAsIDAsIGNhbnZhcy53aWR0aCAvIDIsIGNhbnZhcy5oZWlnaHQgLyAyKTsKICAgIDwvc2NyaXB0 Pgo8L2JvZHk+Cg== 393540 2020-03-13 15:32:20 -0700 2020-03-13 18:28:03 -0700 Patch bug-209071-20200313153219.patch text/plain 2900 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDViOGY4ZjYwN2JjODMz NjZkNmY4NDc4NDY2ZWIzYjA2YzQ5NzI3OS4uOTZlNmM2YjhmNmE4MzU0ZTEzYzM0MGVkOTJhYzFj OTk3MmZmYzhiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTAzLTEzICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQ cm9jZXNzXSBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZTo6YXBwbHkoKSBzaG91bGQgcHJvY2Vz cyBTaGFkb3dzSWdub3JlVHJhbnNmb3Jtc0NoYW5nZSBiZWZvcmUgcHJvY2Vzc2luZyBTaGFkb3dD aGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTA3MQorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIEVuc3Vy ZSBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZTo6YXBwbHkoKSBjYWxscyBzaGFkb3dzSWdub3Jl VHJhbnNmb3JtcygpCisgICAgICAgIGJlZm9yZSBjYWxsaW5nIHNldExlZ2FjeVNoYWRvdygpIG9y IHNldFNoYWRvdygpLgorCisgICAgICAgIFRlc3Q6IFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGZvbGxv d2luZyB0ZXN0cyB3aGVuIHJ1bm5pbmc6CisgICAgICAgICJydW4td2Via2l0LXRlc3RzIC0taW50 ZXJuYWwtZmVhdHVyZSBSZW5kZXJDYW52YXNJbkdQVVByb2Nlc3NFbmFibGVkIgorICAgICAgICAg ICAgZmFzdC9jYW52YXMvY2FudmFzLWltYWdlLXNoYWRvdy5odG1sCisgICAgICAgICAgICBmYXN0 L2NhbnZhcy9jYW52YXMtc2NhbGUtZHJhd0ltYWdlLXNoYWRvdy5odG1sCisgICAgICAgICAgICBm YXN0L2NhbnZhcy9jYW52YXMtc2NhbGUtZmlsbFBhdGgtc2hhZG93Lmh0bWwKKyAgICAgICAgICAg IGZhc3QvY2FudmFzL2NhbnZhcy1zY2FsZS1maWxsUmVjdC1zaGFkb3cuaHRtbAorICAgICAgICAg ICAgZmFzdC9jYW52YXMvY2FudmFzLXNjYWxlLXNoYWRvd0JsdXIuaHRtbAorICAgICAgICAgICAg ZmFzdC9jYW52YXMvY2FudmFzLXRyYW5zZm9ybXMtZmlsbFJlY3Qtc2hhZG93Lmh0bWwKKyAgICAg ICAgICAgIGZhc3QvY2FudmFzL2ZpbGxUZXh0LXNoYWRvdy5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0U3RhdGVDaGFuZ2U6OmFwcGx5IGNvbnN0KToKKwogMjAyMC0wMy0xMyAgUGVu ZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIFNhZmFyaSBzb21ldGltZXMg Y3Jhc2hlcyB3aGVuIHN3aXRjaCB2aWRlbyBpbnRvIFBpUCBtb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcAppbmRleCA1NDI1 YjQyMmI2OTcwMDkwNzFlMmViNTQ5NmRjNDFkMTY5NzdkZTlmLi40OWNiMzlkYjU2MTUxYzNhNWFh NDhjYWJiNWQ3MmNmOGZlYjJhYjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAKQEAgLTIwMCw2ICsyMDAsOSBAQCB2b2lk IEdyYXBoaWNzQ29udGV4dFN0YXRlQ2hhbmdlOjphcHBseShHcmFwaGljc0NvbnRleHQmIGNvbnRl eHQpIGNvbnN0CiAgICAgaWYgKG1fY2hhbmdlRmxhZ3MuY29udGFpbnMoR3JhcGhpY3NDb250ZXh0 U3RhdGU6OkZpbGxQYXR0ZXJuQ2hhbmdlKSkKICAgICAgICAgY29udGV4dC5zZXRGaWxsUGF0dGVy bigqbV9zdGF0ZS5maWxsUGF0dGVybik7CiAKKyAgICBpZiAobV9jaGFuZ2VGbGFncy5jb250YWlu cyhHcmFwaGljc0NvbnRleHRTdGF0ZTo6U2hhZG93c0lnbm9yZVRyYW5zZm9ybXNDaGFuZ2UpKQor ICAgICAgICBjb250ZXh0LnNldFNoYWRvd3NJZ25vcmVUcmFuc2Zvcm1zKG1fc3RhdGUuc2hhZG93 c0lnbm9yZVRyYW5zZm9ybXMpOworCiAgICAgaWYgKG1fY2hhbmdlRmxhZ3MuY29udGFpbnMoR3Jh cGhpY3NDb250ZXh0U3RhdGU6OlNoYWRvd0NoYW5nZSkpIHsKICNpZiBVU0UoQ0cpCiAgICAgICAg IGlmIChtX3N0YXRlLnNoYWRvd3NVc2VMZWdhY3lSYWRpdXMpCkBAIC0yNDIsOSArMjQ1LDYgQEAg dm9pZCBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZTo6YXBwbHkoR3JhcGhpY3NDb250ZXh0JiBj b250ZXh0KSBjb25zdAogICAgIGlmIChtX2NoYW5nZUZsYWdzLmNvbnRhaW5zKEdyYXBoaWNzQ29u dGV4dFN0YXRlOjpTaG91bGRTdWJwaXhlbFF1YW50aXplRm9udHNDaGFuZ2UpKQogICAgICAgICBj b250ZXh0LnNldFNob3VsZFN1YnBpeGVsUXVhbnRpemVGb250cyhtX3N0YXRlLnNob3VsZFN1YnBp eGVsUXVhbnRpemVGb250cyk7CiAKLSAgICBpZiAobV9jaGFuZ2VGbGFncy5jb250YWlucyhHcmFw aGljc0NvbnRleHRTdGF0ZTo6U2hhZG93c0lnbm9yZVRyYW5zZm9ybXNDaGFuZ2UpKQotICAgICAg ICBjb250ZXh0LnNldFNoYWRvd3NJZ25vcmVUcmFuc2Zvcm1zKG1fc3RhdGUuc2hhZG93c0lnbm9y ZVRyYW5zZm9ybXMpOwotCiAgICAgaWYgKG1fY2hhbmdlRmxhZ3MuY29udGFpbnMoR3JhcGhpY3ND b250ZXh0U3RhdGU6OkRyYXdMdW1pbmFuY2VNYXNrQ2hhbmdlKSkKICAgICAgICAgY29udGV4dC5z ZXREcmF3THVtaW5hbmNlTWFzayhtX3N0YXRlLmRyYXdMdW1pbmFuY2VNYXNrKTsKIAo=