209060 2020-03-13 10:24:32 -0700 [ews] run FindModifiedChangeLogs early in the build 2020-03-15 11:05:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1629672 0 aakash_jain 2020-03-13 10:24:32 -0700 [ews] run FindModifiedChangeLogs build-step early in the build. This would reduce the duration between updating to ToT and committing the patch. 1629676 1 393498 aakash_jain 2020-03-13 10:27:17 -0700 Created attachment 393498 Patch 1629741 2 393498 jbedard 2020-03-13 11:51:30 -0700 Comment on attachment 393498 Patch Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating? 1629756 3 aakash_jain 2020-03-13 11:59:21 -0700 (In reply to Jonathan Bedard from comment #2) > Does it make sense to do this before compiling and testing? Or should we do it after compiling and testing, but before updating? Probably doesn't make much difference. Might be slightly better before compiling, just after applying the patch (since git status would be based on only patch contents). 1629772 4 393498 commit-queue 2020-03-13 12:33:43 -0700 Comment on attachment 393498 Patch Clearing flags on attachment: 393498 Committed r258420: <https://trac.webkit.org/changeset/258420> 1629773 5 commit-queue 2020-03-13 12:33:45 -0700 All reviewed patches have been landed. Closing bug. 1629774 6 webkit-bug-importer 2020-03-13 12:34:16 -0700 <rdar://problem/60428905> 1630186 7 aakash_jain 2020-03-15 11:05:46 -0700 This change should reduce the chances of issues like https://bugs.webkit.org/show_bug.cgi?id=209125 (where landing failed, because during the time repo was updated to ToT and patch was attempted to be landed, there was another commit which modified similar files). 393498 2020-03-13 10:27:17 -0700 2020-03-13 12:33:43 -0700 Patch bug-209060-20200313132716.patch text/plain 2895 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODQwNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAzLTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBydW4gRmluZE1vZGlmaWVkQ2hhbmdlTG9ncyBlYXJseSBpbiB0 aGUgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwOTA2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5OiBVcGRhdGVk IHVuaXQtdGVzdC4KKwogMjAyMC0wMy0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBDcmFzaCBpbiBUZXh0SXRlcmF0b3I6Om5vZGUgdmlhIFRleHRNYW5pcHVs YXRpb25Db250cm9sbGVyOjpyZXBsYWNlCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDI1ODQwNikKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHdvcmtpbmcgY29weSkKQEAg LTIwNiw2ICsyMDYsNyBAQCBjbGFzcyBDb21taXRRdWV1ZUZhY3RvcnkoZmFjdG9yeS5CdWlsZEZh CiAgICAgICAgIHNlbGYuYWRkU3RlcChVcGRhdGVXb3JraW5nRGlyZWN0b3J5KCkpCiAgICAgICAg IHNlbGYuYWRkU3RlcChBcHBseVBhdGNoKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChWYWxpZGF0 ZUNoYW5nZUxvZ0FuZFJldmlld2VyKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChGaW5kTW9kaWZp ZWRDaGFuZ2VMb2dzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChLaWxsT2xkUHJvY2Vzc2VzKCkp CiAgICAgICAgIHNlbGYuYWRkU3RlcChDb21waWxlV2ViS2l0KHNraXBVcGxvYWQ9VHJ1ZSkpCiAg ICAgICAgIHNlbGYuYWRkU3RlcChLaWxsT2xkUHJvY2Vzc2VzKCkpCkBAIC0yMTUsNyArMjE2LDYg QEAgY2xhc3MgQ29tbWl0UXVldWVGYWN0b3J5KGZhY3RvcnkuQnVpbGRGYQogICAgICAgICBzZWxm LmFkZFN0ZXAoQ2hlY2tPdXRTb3VyY2UoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFVwZGF0ZVdv cmtpbmdEaXJlY3RvcnkoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKEFwcGx5UGF0Y2goKSkKLSAg ICAgICAgc2VsZi5hZGRTdGVwKEZpbmRNb2RpZmllZENoYW5nZUxvZ3MoKSkKICAgICAgICAgc2Vs Zi5hZGRTdGVwKENyZWF0ZUxvY2FsR0lUQ29tbWl0KCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChQ dXNoQ29tbWl0VG9XZWJLaXRSZXBvKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChTZXRCdWlsZFN1 bW1hcnkoKSkKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3Jp ZXNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5weQkocmV2aXNpb24gMjU4NDA2KQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5weQkod29ya2lu ZyBjb3B5KQpAQCAtMTg2LDYgKzE4Niw3IEBAIGNsYXNzIFRlc3RDb21taXRRdWV1ZUZhY3Rvcnko VGVzdENhc2UpOgogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVXBkYXRlV29y a2luZ0RpcmVjdG9yeSksCiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5BcHBs eVBhdGNoKSwKICAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlZhbGlkYXRlQ2hh bmdlTG9nQW5kUmV2aWV3ZXIpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMu RmluZE1vZGlmaWVkQ2hhbmdlTG9ncyksCiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShz dGVwcy5LaWxsT2xkUHJvY2Vzc2VzKSwKICAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0 ZXBzLkNvbXBpbGVXZWJLaXQsIHNraXBVcGxvYWQ9VHJ1ZSksCiAgICAgICAgICAgICBfQnVpbGRT dGVwRmFjdG9yeShzdGVwcy5LaWxsT2xkUHJvY2Vzc2VzKSwKQEAgLTE5NSw3ICsxOTYsNiBAQCBj bGFzcyBUZXN0Q29tbWl0UXVldWVGYWN0b3J5KFRlc3RDYXNlKToKICAgICAgICAgICAgIF9CdWls ZFN0ZXBGYWN0b3J5KHN0ZXBzLkNoZWNrT3V0U291cmNlKSwKICAgICAgICAgICAgIF9CdWlsZFN0 ZXBGYWN0b3J5KHN0ZXBzLlVwZGF0ZVdvcmtpbmdEaXJlY3RvcnkpLAogICAgICAgICAgICAgX0J1 aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQXBwbHlQYXRjaCksCi0gICAgICAgICAgICBfQnVpbGRTdGVw RmFjdG9yeShzdGVwcy5GaW5kTW9kaWZpZWRDaGFuZ2VMb2dzKSwKICAgICAgICAgICAgIF9CdWls ZFN0ZXBGYWN0b3J5KHN0ZXBzLkNyZWF0ZUxvY2FsR0lUQ29tbWl0KSwKICAgICAgICAgICAgIF9C dWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlB1c2hDb21taXRUb1dlYktpdFJlcG8pLAogICAgICAgICAg ICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuU2V0QnVpbGRTdW1tYXJ5KSwK