209057 2020-03-13 09:31:51 -0700 Bound functions should pass correct NewTarget value 2020-03-13 10:52:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 ashvayka ashvayka commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1629646 0 ashvayka 2020-03-13 09:31:51 -0700 Test case: Reflect.construct(function() {}.bind(), [], Set) instanceof Set Expected: true Actual: false ECMA262: https://tc39.es/ecma262/#sec-bound-function-exotic-objects-construct-argumentslist-newtarget (steps 5-6) Test262: https://test262.report/browse/language/statements/class/subclass/bound-function.js 1629655 1 393493 ashvayka 2020-03-13 09:52:01 -0700 Created attachment 393493 Patch 1629663 2 393493 keith_miller 2020-03-13 10:07:02 -0700 Comment on attachment 393493 Patch r=me. Huh, I guess that makes sense 1629702 3 393493 commit-queue 2020-03-13 10:51:55 -0700 Comment on attachment 393493 Patch Clearing flags on attachment: 393493 Committed r258410: <https://trac.webkit.org/changeset/258410> 1629703 4 commit-queue 2020-03-13 10:51:57 -0700 All reviewed patches have been landed. Closing bug. 1629704 5 webkit-bug-importer 2020-03-13 10:52:17 -0700 <rdar://problem/60424235> 393493 2020-03-13 09:52:01 -0700 2020-03-13 10:51:55 -0700 Patch bug-209057-20200313185200.patch text/plain 5355 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZDk1MmMyZDIwZjM1OWFlZDU5NjU0ODYyNTQ5N2JhOGU1MDk2OGQyLi5iOWYxZmJiMzk1ODNmZDVl ZGI2MTRiZGE5NTI5NTgyYzBkYTg0MDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0wMy0xMyAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFp bC5jb20+CisKKyAgICAgICAgQm91bmQgZnVuY3Rpb25zIHNob3VsZCBwYXNzIGNvcnJlY3QgTmV3 VGFyZ2V0IHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDkwNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGNoYW5nZSBpbXBsZW1lbnRzIHN0ZXBzIDUtNiBvZiBib3VuZCBmdW5jdGlvbidz IFtbQ29uc3RydWN0XV0gbWV0aG9kIFsxXSwKKyAgICAgICAgZml4aW5nIGJvdW5kIGZ1bmN0aW9u IHN1YmNsYXNzZXMgYW5kIGFsaWduaW5nIEpTQyB3aXRoIFY4IGFuZCBTcGlkZXJNb25rZXkuCisK KyAgICAgICAgWzFdOiBodHRwczovL3RjMzkuZXMvZWNtYTI2Mi8jc2VjLWJvdW5kLWZ1bmN0aW9u LWV4b3RpYy1vYmplY3RzLWNvbnN0cnVjdC1hcmd1bWVudHNsaXN0LW5ld3RhcmdldAorCisgICAg ICAgICogcnVudGltZS9KU0JvdW5kRnVuY3Rpb24uY3BwOgorICAgICAgICAoSlNDOjpib3VuZFRo aXNOb0FyZ3NGdW5jdGlvbkNvbnN0cnVjdCk6CisgICAgICAgIChKU0M6OmJvdW5kRnVuY3Rpb25D b25zdHJ1Y3QpOgorCiAyMDIwLTAzLTEyICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBw bGUuY29tPgogCiAgICAgICAgIERGRyBub2RlcyB0aGF0IHRha2UgYSBUeXBlZEFycmF5J3Mgc3Rv cmFnZSBuZWVkIHRvIGtlZXBBbGl2ZSB0aGUgVHlwZWRBcnJheQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCb3VuZEZ1bmN0aW9uLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQm91bmRGdW5jdGlvbi5jcHAKaW5kZXggYTA2NmQ3MmRlYmUx OTk0ZjM5MzhmZWVmNGIwZTBmZDRkNTJiMDBmMC4uYzAxNmJiYWQwNTU3ZDAxNGIzNDllZDhlMWQ5 MjlmZTA0ZjNmMjM4ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNCb3VuZEZ1bmN0aW9uLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0JvdW5kRnVuY3Rpb24uY3BwCkBAIC0xMTEsNyArMTExLDExIEBAIEVuY29kZWRKU1ZhbHVlIEpT Q19IT1NUX0NBTEwgYm91bmRUaGlzTm9BcmdzRnVuY3Rpb25Db25zdHJ1Y3QoSlNHbG9iYWxPYmpl Y3QqIGdsCiAgICAgQ29uc3RydWN0RGF0YSBjb25zdHJ1Y3REYXRhOwogICAgIENvbnN0cnVjdFR5 cGUgY29uc3RydWN0VHlwZSA9IGdldENvbnN0cnVjdERhdGEoZ2xvYmFsT2JqZWN0LT52bSgpLCB0 YXJnZXRGdW5jdGlvbiwgY29uc3RydWN0RGF0YSk7CiAgICAgQVNTRVJUKGNvbnN0cnVjdFR5cGUg IT0gQ29uc3RydWN0VHlwZTo6Tm9uZSk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShjb25z dHJ1Y3QoZ2xvYmFsT2JqZWN0LCB0YXJnZXRGdW5jdGlvbiwgY29uc3RydWN0VHlwZSwgY29uc3Ry dWN0RGF0YSwgYXJncykpOworCisgICAgSlNWYWx1ZSBuZXdUYXJnZXQgPSBjYWxsRnJhbWUtPm5l d1RhcmdldCgpOworICAgIGlmIChuZXdUYXJnZXQgPT0gYm91bmRGdW5jdGlvbikKKyAgICAgICAg bmV3VGFyZ2V0ID0gdGFyZ2V0RnVuY3Rpb247CisgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShj b25zdHJ1Y3QoZ2xvYmFsT2JqZWN0LCB0YXJnZXRGdW5jdGlvbiwgY29uc3RydWN0VHlwZSwgY29u c3RydWN0RGF0YSwgYXJncywgbmV3VGFyZ2V0KSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgYm91bmRGdW5jdGlvbkNvbnN0cnVjdChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2Jq ZWN0LCBDYWxsRnJhbWUqIGNhbGxGcmFtZSkKQEAgLTEzOSw3ICsxNDMsMTEgQEAgRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBib3VuZEZ1bmN0aW9uQ29uc3RydWN0KEpTR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QKICAgICBDb25zdHJ1Y3REYXRhIGNvbnN0cnVjdERhdGE7CiAgICAgQ29u c3RydWN0VHlwZSBjb25zdHJ1Y3RUeXBlID0gZ2V0Q29uc3RydWN0RGF0YSh2bSwgdGFyZ2V0RnVu Y3Rpb24sIGNvbnN0cnVjdERhdGEpOwogICAgIEFTU0VSVChjb25zdHJ1Y3RUeXBlICE9IENvbnN0 cnVjdFR5cGU6Ok5vbmUpOwotICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgSlNWYWx1ZTo6 ZW5jb2RlKGNvbnN0cnVjdChnbG9iYWxPYmplY3QsIHRhcmdldEZ1bmN0aW9uLCBjb25zdHJ1Y3RU eXBlLCBjb25zdHJ1Y3REYXRhLCBhcmdzKSkpOworCisgICAgSlNWYWx1ZSBuZXdUYXJnZXQgPSBj YWxsRnJhbWUtPm5ld1RhcmdldCgpOworICAgIGlmIChuZXdUYXJnZXQgPT0gYm91bmRGdW5jdGlv bikKKyAgICAgICAgbmV3VGFyZ2V0ID0gdGFyZ2V0RnVuY3Rpb247CisgICAgUkVMRUFTRV9BTkRf UkVUVVJOKHNjb3BlLCBKU1ZhbHVlOjplbmNvZGUoY29uc3RydWN0KGdsb2JhbE9iamVjdCwgdGFy Z2V0RnVuY3Rpb24sIGNvbnN0cnVjdFR5cGUsIGNvbnN0cnVjdERhdGEsIGFyZ3MsIG5ld1Rhcmdl dCkpKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBpc0JvdW5kRnVuY3Rpb24o SlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ2FsbEZyYW1lKiBjYWxsRnJhbWUpCmRpZmYg LS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZiMzc1 YmZiNTJjOGJmNzRmZDM2ZmFmZWU3NjczODQ2MjljYzhkM2IuLmU3NDVkZDZlZGI1NGY2MTUzNTNk YzBiNjQzOTY5YTdjMzE1MmMxOTUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBi L0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDMtMTMgIEFsZXhleSBT aHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisgICAgICAgIEJvdW5kIGZ1bmN0aW9u cyBzaG91bGQgcGFzcyBjb3JyZWN0IE5ld1RhcmdldCB2YWx1ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MDU3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1s OiBNYXJrIDQgdGVzdCBjYXNlcyBhcyBwYXNzaW5nLgorCiAyMDIwLTAzLTExICBLZWl0aCBNaWxs ZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFRlc3QyNjItcnVubmVyIHNo b3VsZCBhbHdheXMgY29uc2lkZXIgY3Jhc2hlcyBhcyBuZXcgZmFpbHVyZXMKZGlmZiAtLWdpdCBh L0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbCBiL0pTVGVzdHMvdGVzdDI2Mi9leHBl Y3RhdGlvbnMueWFtbAppbmRleCA2MDk4MWIxNjQyYzNiNTk0MGU0YTQ1OGUzYWU2NDFjYTM1OWQx MWNmLi41OTg1ODA0MDZjMTdjNWFkZmUzYTM0MThjNWJkODE5Yzc1Yzg1Y2JhIDEwMDY0NAotLS0g YS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYy L2V4cGVjdGF0aW9ucy55YW1sCkBAIC05NDIsOSArOTQyLDYgQEAgdGVzdC9idWlsdC1pbnMvRnVu Y3Rpb24vcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgogdGVzdC9idWlsdC1pbnMvRnVuY3Rpb24v cHJvdG90eXBlL2JpbmQvbGVuZ3RoLWV4Y2VlZHMtaW50MzIuanM6CiAgIGRlZmF1bHQ6ICdUZXN0 MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCqzDCuywgwqsyMTQ3NDgzNjQ4wrspIHRvIGJl IHRydWUnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUo wqswwrssIMKrMjE0NzQ4MzY0OMK7KSB0byBiZSB0cnVlJwotdGVzdC9idWlsdC1pbnMvRnVuY3Rp b24vcHJvdG90eXBlL2JpbmQvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLmpzOgotICBkZWZhdWx0OiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqtbb2JqZWN0IE9iamVjdF3Cuywgwqtb b2JqZWN0IE9iamVjdF3CuykgdG8gYmUgdHJ1ZScKLSAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJy b3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCq1tvYmplY3QgT2JqZWN0XcK7LCDCq1tvYmplY3QgT2Jq ZWN0XcK7KSB0byBiZSB0cnVlJwogdGVzdC9idWlsdC1pbnMvRnVuY3Rpb24vcHJvdG90eXBlL3Rv U3RyaW5nL0FzeW5jRnVuY3Rpb24uanM6CiAgIGRlZmF1bHQ6ICJTeW50YXhFcnJvcjogVW5leHBl Y3RlZCB0b2tlbiAnOycuIEV4cGVjdGVkIGEgJyknIG9yIGEgJywnIGFmdGVyIGEgcGFyYW1ldGVy IGRlY2xhcmF0aW9uLiIKICAgc3RyaWN0IG1vZGU6ICJTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0 b2tlbiAnOycuIEV4cGVjdGVkIGEgJyknIG9yIGEgJywnIGFmdGVyIGEgcGFyYW1ldGVyIGRlY2xh cmF0aW9uLiIKQEAgLTMzMDYsOSArMzMwMyw2IEBAIHRlc3QvbGFuZ3VhZ2Uvc3RhdGVtZW50cy9j bGFzcy9pZGVudC1uYW1lLW1ldGhvZC1kZWYtd2l0aC1lc2NhcGVkLmpzOgogdGVzdC9sYW5ndWFn ZS9zdGF0ZW1lbnRzL2NsYXNzL3BvaXNvbmVkLXVuZGVyc2NvcmUtcHJvdG8uanM6CiAgIGRlZmF1 bHQ6ICdUZXN0MjYyRXJyb3I6IHNob3VsZCBub3QgYmUgY2FsbGVkJwogICBzdHJpY3QgbW9kZTog J1Rlc3QyNjJFcnJvcjogc2hvdWxkIG5vdCBiZSBjYWxsZWQnCi10ZXN0L2xhbmd1YWdlL3N0YXRl bWVudHMvY2xhc3Mvc3ViY2xhc3MvYm91bmQtZnVuY3Rpb24uanM6Ci0gIGRlZmF1bHQ6ICdUZXN0 MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjCq1tvYmplY3QgT2JqZWN0XcK7LCDCq1tvYmpl Y3QgT2JqZWN0XcK7KSB0byBiZSB0cnVlJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjog RXhwZWN0ZWQgU2FtZVZhbHVlKMKrW29iamVjdCBPYmplY3RdwrssIMKrW29iamVjdCBPYmplY3Rd wrspIHRvIGJlIHRydWUnCiB0ZXN0L2xhbmd1YWdlL3N0YXRlbWVudHMvY2xhc3Mvc3ViY2xhc3Mv YnVpbHRpbi1vYmplY3RzL0FycmF5QnVmZmVyL3JlZ3VsYXItc3ViY2xhc3NpbmcuanM6CiAgIGRl ZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIHRydWUgYnV0IGdvdCBmYWxzZScKICAgc3Ry aWN0IG1vZGU6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIHRydWUgYnV0IGdvdCBmYWxzZScK