<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>209038</bug_id>
          
          <creation_ts>2020-03-12 21:04:52 -0700</creation_ts>
          <short_desc>Pull in JS tests from &quot;Internal&quot; when there are &quot;Internal&quot; tests in an adjacent directory</short_desc>
          <delta_ts>2020-03-13 00:25:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1629482</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-03-12 21:04:52 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629492</commentid>
    <comment_count>1</comment_count>
      <attachid>393454</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-03-12 21:39:58 -0700</bug_when>
    <thetext>Created attachment 393454
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629493</commentid>
    <comment_count>2</comment_count>
      <attachid>393454</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2020-03-12 21:40:30 -0700</bug_when>
    <thetext>Comment on attachment 393454
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629494</commentid>
    <comment_count>3</comment_count>
      <attachid>393454</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-03-12 21:40:42 -0700</bug_when>
    <thetext>Comment on attachment 393454
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393454&amp;action=review

&gt; Tools/Scripts/run-javascriptcore-tests:684
&gt; +        @testList = ();

oops, will fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629495</commentid>
    <comment_count>4</comment_count>
      <attachid>393454</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2020-03-12 21:41:07 -0700</bug_when>
    <thetext>Comment on attachment 393454
patch

lol whoops! r+ for realz</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629496</commentid>
    <comment_count>5</comment_count>
      <attachid>393455</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-03-12 21:41:26 -0700</bug_when>
    <thetext>Created attachment 393455
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629498</commentid>
    <comment_count>6</comment_count>
      <attachid>393457</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2020-03-12 21:45:29 -0700</bug_when>
    <thetext>Created attachment 393457
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629515</commentid>
    <comment_count>7</comment_count>
      <attachid>393457</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-03-13 00:24:40 -0700</bug_when>
    <thetext>Comment on attachment 393457
patch for landing

Clearing flags on attachment: 393457

Committed r258385: &lt;https://trac.webkit.org/changeset/258385&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629516</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-03-13 00:24:42 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629517</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-03-13 00:25:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/60407614&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393454</attachid>
            <date>2020-03-12 21:39:58 -0700</date>
            <delta_ts>2020-03-12 21:41:26 -0700</delta_ts>
            <desc>patch</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>1545</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI1ODM4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDIwLTAzLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor
CisgICAgICAgIFB1bGwgaW4gSlMgdGVzdHMgZnJvbSAiSW50ZXJuYWwiIHdoZW4gdGhlcmUgYXJl
ICJJbnRlcm5hbCIgdGVzdHMgaW4gYW4gYWRqYWNlbnQgZGlyZWN0b3J5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkwMzgKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFsbG93cyB1cyB0byBhdXRv
bWF0aWNhbGx5IHB1bGwgaW4gc29tZSB0ZXN0cyB0aGF0IGFyZSBpbiBub24gb3BlbiBzb3VyY2Vk
IEFwcGxlCisgICAgICAgIGNoZWNrb3V0cy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFz
Y3JpcHRjb3JlLXRlc3RzOgorICAgICAgICAocnVuSlNDU3RyZXNzVGVzdHMpOgorCiAyMDIwLTAz
LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGlu
IFRleHRNYW5pcHVsYXRpb25Db250cm9sbGVyOjpyZXBsYWNlCkluZGV4OiBUb29scy9TY3JpcHRz
L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1
bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMjU4MzgwKQorKysgVG9vbHMvU2NyaXB0
cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTY4MSw2ICs2ODEs
MTQgQEAgc3ViIHJ1bkpTQ1N0cmVzc1Rlc3RzCiAgICAgICAgICAgICAiSlNUZXN0cy9jb21wbGV4
LnlhbWwiLAogICAgICAgICAgICAgIkpTVGVzdHMvQ2hha3JhQ29yZS55YW1sIiwKICAgICAgICAg
ICAgICJKU1Rlc3RzL3dhc20ueWFtbCIpOworICAgICAgICBAdGVzdExpc3QgPSAoKTsKKworICAg
ICAgICBteSAkaW50ZXJuYWxUZXN0c0RpciA9IEZpbGU6OlNwZWMtPmNhdGRpcihkaXJuYW1lKHNv
dXJjZURpcigpKSwgIkludGVybmFsIiwgIlRlc3RzIiwgIkludGVybmFsSlNUZXN0cyIpOworICAg
ICAgICBpZiAoLWUgJGludGVybmFsVGVzdHNEaXIgYW5kIC1kICRpbnRlcm5hbFRlc3RzRGlyKSB7
CisgICAgICAgICAgICBwdXNoKEB0ZXN0TGlzdCwgRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkaW50ZXJu
YWxUZXN0c0RpciwgImludGVybmFsLWpzLXRlc3RzLnlhbWwiKSk7CisgICAgICAgICAgICBwdXNo
KEB0ZXN0TGlzdCwgRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkaW50ZXJuYWxUZXN0c0RpciwgInJlZ3Jl
c3MueWFtbCIpKTsKKyAgICAgICAgfQorCiAgICAgICAgICRoYXNUZXN0c1RvUnVuID0gMTsKICAg
ICB9CiAK
</data>
<flag name="review"
          id="408845"
          type_id="1"
          status="+"
          setter="keith_miller"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393455</attachid>
            <date>2020-03-12 21:41:26 -0700</date>
            <delta_ts>2020-03-12 21:45:29 -0700</delta_ts>
            <desc>patch</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>1520</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI1ODM4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDIwLTAzLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor
CisgICAgICAgIFB1bGwgaW4gSlMgdGVzdHMgZnJvbSAiSW50ZXJuYWwiIHdoZW4gdGhlcmUgYXJl
ICJJbnRlcm5hbCIgdGVzdHMgaW4gYW4gYWRqYWNlbnQgZGlyZWN0b3J5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkwMzgKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFsbG93cyB1cyB0byBhdXRv
bWF0aWNhbGx5IHB1bGwgaW4gc29tZSB0ZXN0cyB0aGF0IGFyZSBpbiBub24gb3BlbiBzb3VyY2Vk
IEFwcGxlCisgICAgICAgIGNoZWNrb3V0cy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFz
Y3JpcHRjb3JlLXRlc3RzOgorICAgICAgICAocnVuSlNDU3RyZXNzVGVzdHMpOgorCiAyMDIwLTAz
LTEyICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGlu
IFRleHRNYW5pcHVsYXRpb25Db250cm9sbGVyOjpyZXBsYWNlCkluZGV4OiBUb29scy9TY3JpcHRz
L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1
bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMjU4MzgwKQorKysgVG9vbHMvU2NyaXB0
cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTY4MSw2ICs2ODEs
MTMgQEAgc3ViIHJ1bkpTQ1N0cmVzc1Rlc3RzCiAgICAgICAgICAgICAiSlNUZXN0cy9jb21wbGV4
LnlhbWwiLAogICAgICAgICAgICAgIkpTVGVzdHMvQ2hha3JhQ29yZS55YW1sIiwKICAgICAgICAg
ICAgICJKU1Rlc3RzL3dhc20ueWFtbCIpOworCisgICAgICAgIG15ICRpbnRlcm5hbFRlc3RzRGly
ID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGRpcm5hbWUoc291cmNlRGlyKCkpLCAiSW50ZXJuYWwiLCAi
VGVzdHMiLCAiSW50ZXJuYWxKU1Rlc3RzIik7CisgICAgICAgIGlmICgtZSAkaW50ZXJuYWxUZXN0
c0RpciBhbmQgLWQgJGludGVybmFsVGVzdHNEaXIpIHsKKyAgICAgICAgICAgIHB1c2goQHRlc3RM
aXN0LCBGaWxlOjpTcGVjLT5jYXRmaWxlKCRpbnRlcm5hbFRlc3RzRGlyLCAiaW50ZXJuYWwtanMt
dGVzdHMueWFtbCIpKTsKKyAgICAgICAgICAgIHB1c2goQHRlc3RMaXN0LCBGaWxlOjpTcGVjLT5j
YXRmaWxlKCRpbnRlcm5hbFRlc3RzRGlyLCAicmVncmVzcy55YW1sIikpOworICAgICAgICB9CisK
ICAgICAgICAgJGhhc1Rlc3RzVG9SdW4gPSAxOwogICAgIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393457</attachid>
            <date>2020-03-12 21:45:29 -0700</date>
            <delta_ts>2020-03-13 00:24:40 -0700</delta_ts>
            <desc>patch for landing</desc>
            <filename>b-backup.diff</filename>
            <type>text/plain</type>
            <size>1518</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI1ODM4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDIwLTAzLTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor
CisgICAgICAgIFB1bGwgaW4gSlMgdGVzdHMgZnJvbSAiSW50ZXJuYWwiIHdoZW4gdGhlcmUgYXJl
ICJJbnRlcm5hbCIgdGVzdHMgaW4gYW4gYWRqYWNlbnQgZGlyZWN0b3J5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkwMzgKKworICAgICAgICBSZXZp
ZXdlZCBieSBLZWl0aCBNaWxsZXIuCisKKyAgICAgICAgVGhpcyBhbGxvd3MgdXMgdG8gYXV0b21h
dGljYWxseSBwdWxsIGluIHNvbWUgdGVzdHMgdGhhdCBhcmUgaW4gbm9uIG9wZW4gc291cmNlZCBB
cHBsZQorICAgICAgICBjaGVja291dHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2Ny
aXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHJ1bkpTQ1N0cmVzc1Rlc3RzKToKKwogMjAyMC0wMy0x
MiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDcmFzaCBpbiBU
ZXh0TWFuaXB1bGF0aW9uQ29udHJvbGxlcjo6cmVwbGFjZQpJbmRleDogVG9vbHMvU2NyaXB0cy9y
dW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4t
amF2YXNjcmlwdGNvcmUtdGVzdHMJKHJldmlzaW9uIDI1ODM4MCkKKysrIFRvb2xzL1NjcmlwdHMv
cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC02ODEsNiArNjgxLDEz
IEBAIHN1YiBydW5KU0NTdHJlc3NUZXN0cwogICAgICAgICAgICAgIkpTVGVzdHMvY29tcGxleC55
YW1sIiwKICAgICAgICAgICAgICJKU1Rlc3RzL0NoYWtyYUNvcmUueWFtbCIsCiAgICAgICAgICAg
ICAiSlNUZXN0cy93YXNtLnlhbWwiKTsKKworICAgICAgICBteSAkaW50ZXJuYWxUZXN0c0RpciA9
IEZpbGU6OlNwZWMtPmNhdGRpcihkaXJuYW1lKHNvdXJjZURpcigpKSwgIkludGVybmFsIiwgIlRl
c3RzIiwgIkludGVybmFsSlNUZXN0cyIpOworICAgICAgICBpZiAoLWUgJGludGVybmFsVGVzdHNE
aXIgYW5kIC1kICRpbnRlcm5hbFRlc3RzRGlyKSB7CisgICAgICAgICAgICBwdXNoKEB0ZXN0TGlz
dCwgRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkaW50ZXJuYWxUZXN0c0RpciwgImludGVybmFsLWpzLXRl
c3RzLnlhbWwiKSk7CisgICAgICAgICAgICBwdXNoKEB0ZXN0TGlzdCwgRmlsZTo6U3BlYy0+Y2F0
ZmlsZSgkaW50ZXJuYWxUZXN0c0RpciwgInJlZ3Jlc3MueWFtbCIpKTsKKyAgICAgICAgfQorCiAg
ICAgICAgICRoYXNUZXN0c1RvUnVuID0gMTsKICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>